Compare commits

...

637 Commits

Author SHA1 Message Date
Joel Jeremy Marquez
2ededcd854 Implement saving 2025-11-04 11:17:23 -08:00
Joel Jeremy Marquez
fbc6a42662 Change amount input type to number 2025-11-03 14:52:32 -08:00
Joel Jeremy Marquez
247b0d970a Smaller amount input 2025-11-03 14:10:56 -08:00
Joel Jeremy Marquez
b29a12799c Style updates 2025-11-03 14:07:15 -08:00
Joel Jeremy Marquez
b3c62fd69d New mobile transaction page (partial) 2025-11-03 13:56:29 -08:00
Matt Fiddaman
cbac6116d4 fix rerender issue with formula card (#6058)
* fix infinite rerender

* note

* remove React import
2025-11-03 01:30:32 +00:00
Michael Clark
e83cfba357 Remove plugin worker temporarily (#6052)
* remove plugin worker temporarily

* releas enotes

* clarifying comment

* remove plugin worker temporarily

* releas enotes

* clarifying comment
2025-11-02 10:18:49 +00:00
Matiss Janis Aboltins
0cac66b203 Remove isGlobal preference functionality (#6049) 2025-11-01 14:18:08 +00:00
Michael Clark
7983ee45e1 :electron: New appx icons (#6043)
* new appx icons

* updates the windows store appx icons to the new style
2025-10-31 21:45:23 +00:00
Michael Clark
844cd3433a :electron: Flathub MetaInfo (#6033)
* updates to flathub metainfo

* update to summary

* release notes

* omit :light

* Update upcoming-release-notes/6033.md

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

* actual budget

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-10-30 17:15:47 +00:00
dbequeaith
ae6bea2b15 Import qfx safari mobile (#6020)
* Supports selecting qfx files on safari mobile

Fixes #4283

accept explicit MIME types associated with qfx files

* generated release notes

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-28 14:20:58 +00:00
Michael Clark
37481535e7 ☁️ Fix server sync file download when server-files are in .config (#6010)
* fix server sync file download when server-files are in .config directory on linux

* extra security

* release notes

* putting it back after testing

* also accounting for directories

* derp
2025-10-27 20:11:40 +00:00
Matiss Janis Aboltins
45a4f0a40d Add sort_by field to custom reports (#6005) 2025-10-27 19:59:53 +00:00
Matt Fiddaman
9a3e33c0d7 fix inconsistent widths of bank sync field mapping selects on mobile (#6007) 2025-10-27 11:56:38 +00:00
Matiss Janis Aboltins
25d072944e Refactor account header to use SpaceBetween component for spacing (#5994) 2025-10-24 20:52:59 +01:00
Joel Jeremy Marquez
cf8a4b6e6a Fix InitialFocus not working on some fields (#5987)
* Fix InitialFocus not working on some fields

* Fix typecheck and lint errors

* Fix lint error

* Add ref type

* Add types

* Update VRT screenshots

Auto-generated by VRT workflow

PR: #5987

* Revert vrt

* Update VRT screenshots

Auto-generated by VRT workflow

PR: #5987

* Cleanup

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-10-23 11:34:41 -07:00
David Genord II
55b1ed170b Bump Alpine docker image to 3.22 upgrading from node 18 to 22 (#5989) 2025-10-23 00:42:48 +01:00
Matt Fiddaman
b266ebf1ea 📱 add bank sync settings page to mobile (#5978) 2025-10-22 20:06:44 +01:00
Matiss Janis Aboltins
6826ca0e4b Add virtualizer to mobile transactions (#5921) 2025-10-22 18:07:29 +01:00
Matt Fiddaman
80aee4ee71 ⬆️ bump dependencies before 25.11 (#5983)
* bump dependencies

* note

* recharts differences
2025-10-22 17:28:11 +01:00
dependabot[bot]
ab4aa21343 Bump vite from 7.1.9 to 7.1.11 (#5982)
* Bump vite from 7.1.9 to 7.1.11

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.1.9 to 7.1.11.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v7.1.11/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 7.1.11
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* note

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-10-22 14:23:36 +01:00
Matt Fiddaman
9dd0284e31 fix report date dropdowns not including current period (#5981) 2025-10-22 13:44:19 +01:00
Matt Fiddaman
dcc879294c fix slow performance in import csv modal (#5980) 2025-10-22 13:43:56 +01:00
lelemm
002f74a8fa Feature: Formula card and Formula for rules (#5939)
* Formula card and Formula rules

* [autofix.ci] apply automated fixes

* File move fix

* [autofix.ci] apply automated fixes

* Update packages/desktop-client/src/components/formula/codeMirror-excelLanguage.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* code rabbit wrong commit suggestion fix

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-10-21 21:57:56 -03:00
guiza
b6f80c26e6 fix split transaction sort order when duplicating (#5911)
* Fixes #5715

* Release notes

* [autofix.ci] apply automated fixes

* Fix release notes PR number

* Shorten release notes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-10-22 01:32:00 +01:00
qunm
ee71130d56 Fixes #4333 Overlapping text on mobile (#5900)
* made Budgeted header to be multiline and increased font minimum font size

* added release note

* Update upcoming-release-notes/5900.md

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Quan Nguyen <quannm@Quans-MacBook-Pro.local>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-10-22 01:11:20 +01:00
Andrea Colombo
6ed18d8f8c Update link to documentation in docker-compose.yml (#5873)
* Update link to documentation in docker-compose.yml

* Add release notes
2025-10-21 18:35:55 +01:00
dependabot[bot]
1737674b9e Bump vite from 7.1.9 to 7.1.11 (#5972) 2025-10-21 17:24:56 +01:00
Matt Fiddaman
e4617e8cd4 fix GoCardless institutions with special continuous access EUA behaviour (#5967) 2025-10-21 17:24:05 +01:00
Matiss Janis Aboltins
57d01467ca Refactor test execution to use lage task runner (#5964) 2025-10-21 08:58:26 +02:00
Joel Jeremy Marquez
8019d9f61b Update react compiler to v1 (#5971)
* Update react compiler

* Update VRT screenshots

Auto-generated by VRT workflow

PR: #5971

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-10-20 16:14:30 -07:00
Matiss Janis Aboltins
ddbefc790e Fix date validation bug causing crashes with old dates (#5970) 2025-10-20 22:04:32 +01:00
Matiss Janis Aboltins
7eaf23eb7c Improve e2e test stability (#5966) 2025-10-20 19:21:54 +02:00
Michael Clark
8f284e7b60 :electron: New desktop app icons (#5965)
* add new desktop app icons for better display on linux, and to prepare us for mac liquid glass

* png for windows

* release notes

* put old icons in archived folder
2025-10-20 09:24:59 +01:00
lelemm
be35328e42 🐛 Fix to show the notification for updating service worker (#5963)
* Fix to show the notification for updating service worker

* cleanup

* Add release notes for PR #5963

* trigger pipeline

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-10-19 22:48:05 -03:00
Michael Clark
23f1b7d3c0 :electron: Change desktop app execution name (#5954)
* change entrypoint name

* release notes
2025-10-19 18:30:09 +01:00
Matiss Janis Aboltins
8b1aa6fb93 Adjust account panel borders and corners (#5958) 2025-10-19 15:51:44 +01:00
Matt Fiddaman
155558ee62 drop support for node 20 (#5937)
* node 24

* node types

* dockerfiles

* readme

* note
2025-10-18 23:58:27 +01:00
Stephen Brown II
94332016e8 Adds balance variable to rule templates (#5925)
* Adds balance variable to rule templates

Enables access to the account balance within rule templates. This allows for more complex rule creation based on the current account balance.

Calculates the account balance up to the transaction being processed, including transactions on the same date with lower sort order.

Handles cases where the balance is undefined gracefully, defaulting to 0 to prevent errors.

## AI disclaimer
This PR contains code that was partially or fully generated by AI and may contain errors. All suggestions for improvement are welcome.

* Add release notes

* indexed sql params not supported

* [autofix.ci] apply automated fixes

* Skip parent transactions of splits

* Uses aql for account balance

Updates transaction rule preparation to use aql instead of  sql calculating it from past transactions.

The balance is defaulted to 0 if no account is set.

Refactor account balance calculation to build a proper query with date and sort_order filters

* Add block scoping to switch cases and ensure correct fallthrough handling in Action type conversions

* Corrects transaction rule sorting order

Reverses the sort order comparison in transaction rules
to ensure correct identification of prior transactions with the same date.

This ensures that the correct balance is used when
calculating balance-based rule conditions.

fixup! Corrects transaction rule sorting order

* Improves transaction rule balance calculation

Uses a more efficient query for calculating the account balance
up to a transaction when applying rules, improving performance.
This change reduces the complexity of the balance calculation.

* Apply coderabbit lessons learned

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-18 08:22:55 -07:00
Matiss Janis Aboltins
0af2c6c2fb Update default dashboard (#5924) 2025-10-18 16:34:41 +02:00
Matiss Janis Aboltins
97482a082d fix: prevent sensitive data leakage in error logs (#5948) 2025-10-18 16:33:27 +02:00
Matiss Janis Aboltins
31a9ba629b Change "/update-vrt" workflow (#5952) 2025-10-18 11:46:52 +01:00
Matiss Janis Aboltins
7c19a6333c docs: add AGENTS.md guide for AI agents (#5942) 2025-10-18 00:29:12 +02:00
Matiss Janis Aboltins
2bce9d707c Improve file decryption modal and button labels (#5943) 2025-10-17 23:47:12 +02:00
Michael Clark
4e42cda29e :electron: Prep for flathub - arm64 support and metainfo (#5947)
* prep for flathub -arm64 build and metainfo

* release note

* spelling mistake

* whitespace removal

* arch build issues

* hmm

* removing arm64 from flatpak - that would get bundled by flathub anyway
2025-10-17 21:08:59 +01:00
Matiss Janis Aboltins
0ce07d7692 Align onboarding form element sizes (#5941) 2025-10-16 22:34:51 +01:00
Matiss Janis Aboltins
0e3415c145 Hide refresh button when not connected to sync server (#5940) 2025-10-16 22:31:53 +01:00
Michael Clark
19675a7de6 ⬆️ Update flatpak sdk and platform (#5935)
* update flatpak sdk and platform

* release notes

* flatpak version config

* going to 24.08 to support as many distros as possible

* remove unneded file
2025-10-16 18:59:19 +01:00
Matt Fiddaman
5a1ceed7d9 ⬆️ bump electron (#5936)
* electron 38.3.0

* electron/notarize 3.1.0

* note
2025-10-16 16:22:48 +01:00
andreparames
86c1c30c97 enhancement: fix Cetelem bank transations (#5914)
* enhancement: fix Cetelem bank transations

The amount coming from GoCardless has the opposite sign of what we expect.

* Cetelem bank: make code more future-proof

Change based on code review suggestion

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-10-16 01:34:27 +01:00
lelemm
96ac1292f9 🐛 Fix Service Worker: New hash every build (#5928)
* New hash every build

* Add release notes for PR #5928

* trigger actions

* Changed from TS to MTS

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-15 13:11:54 -03:00
Matiss Janis Aboltins
328dfae8bf Update DeleteFileModal to disable delete button when server is offline (#5926) 2025-10-14 23:58:12 +02:00
Michael Süssemilch
37247395e2 feat(currency): add currency display to schedules (#5907)
* feat(currency): add currency display to schedules

* refactor: useFormat directly in cell
2025-10-14 20:10:57 +01:00
Daniel Boles
02b0e24d6e budgetfilesSlice: Fix paste-o in fallback sorting by ID (#5918)
* budgetfilesSlice: Fix paste-o in fallback sorting by ID

* Create 5918.md

* 5918.md: Clarify

* 5918.md: Ah, those square brackets don't just indicate a placeholder
2025-10-13 18:57:53 +01:00
Matiss Janis Aboltins
dfaa75f1cf Create e2e tests for mobile payees page (#5905) 2025-10-13 19:42:40 +02:00
Matiss Janis Aboltins
adae3e4352 Virtualize mobile payees list (#5904) 2025-10-13 19:04:32 +02:00
Matiss Janis Aboltins
7a3794295f Enhance mobile rules with undo notifications for save and delete actions (#5906) 2025-10-13 19:02:46 +02:00
Julian Dominguez-Schatz
c1d97fcc75 Allow size-compare action to run immediately after artifact upload (#5912)
* Allow size-compare action to run immediately after artifact upload

* Add release notes
2025-10-13 09:20:18 -07:00
Matiss Janis Aboltins
3715f16888 Add virtualizer to mobile rules list (#5899) 2025-10-11 12:57:39 +02:00
lelemm
edad7ce0e3 New Rule delete transaction action (#4603)
* Delete transaction rule action

* md

* removed debugger

* fix rule execution on csv preview

* Update 4603.md

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-10-10 21:41:43 -03:00
Matt Fiddaman
737341ffb6 fix hotkey scope warning (#5901) 2025-10-10 19:59:20 +01:00
Matt Fiddaman
6147495003 ⬆️ upgrade recharts to v3 (#5903) 2025-10-10 19:58:59 +01:00
Matiss Janis Aboltins
614bedcfbf Trigger edge docker release on master push (#5897) 2025-10-10 09:37:54 +02:00
Matt Fiddaman
248b1034d7 fix api failing to import (#5896) 2025-10-09 22:55:48 +01:00
Claudio Spizzi
4f88afa266 Fix the Authentik external help URL for OIDC (#5891) 2025-10-08 21:41:16 -03:00
Matt Fiddaman
5c23aad3c2 ⬆️ bump yarn to 4.10.x (#5885)
* bump yarn to 4.10.3

* note

* fix flaky test
2025-10-08 23:21:37 +01:00
Michael Clark
5b9bcc94f6 ⬆️ Upgrade electron-builder (#5857)
* upgrade electron-builder

* no postinstall when yarn immutable

* downgrade to last version without the bug

* fix issue with wrappy

* release notes

* regen yarn lock

* react-sprint

* hmm

* update yarn manually...

* fixing spring?

* lock

* finally

* conflict

* put package back
2025-10-08 22:20:29 +01:00
Matt Fiddaman
87d54251cd ⬆️ bump loot-core dependencies (#5888)
* csv-stringify 6.6.0

* lru-cache 11.2.2

* ua-parser-js 2.0.5

* @reduxjs/toolkit 2.9.0

* jest-diff 30.2.0

* csv-parse 6.1.0

* yargs 18.0.0

* slash 5.1.0

* drop memfs

* peggy 5.0.6

* fast-check 4.3.0

* fake-indexeddb 6.2.2

* note
2025-10-08 21:16:34 +01:00
Matt Fiddaman
2e439aacba ⬆️ bump various dependencies (#5886)
* bump various dependencies

* note

* update playwright images

* globals 16.4.0

* react-router 7.9.4
2025-10-08 21:01:27 +01:00
gdufay
244140314c Enhancements: Use remark plugin in the report's Text widget (#5850)
* Add remark plugin to MarkdownCard

* Generate release note

* [autofix.ci] apply automated fixes

* Avoid duplicate css code

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-08 17:26:31 +01:00
Matiss Janis Aboltins
f7b40fca64 Add swipe to delete to mobile rules (#5871) 2025-10-07 20:33:46 +02:00
Stephen Brown II
dc811552be feat(currency): Currency-influenced initial number formats (#5797) 2025-10-07 19:05:16 +01:00
lelemm
295839ebbb 🐛 Fix for worker in dev mode (#5878)
* Fix for worker in dev mode

* Add release notes for PR #5878

* trigger actions

---------

Co-authored-by: Leandro Menezes <leandro.menezes@fusionflowsoftware.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-10-07 14:45:13 -03:00
Michael Süssemilch
99ca34458e feat(currency): add currency display to rules (#5639)
* feat(currency): add to rules

* doc: release notes

* feat: remove keydown from Input

* doc: release notes

* fix: make onEnter optional

* fix: ai remark

* refactor: remove onKeyDown from Input.tsx

* fix: handle Amount (inflow) and Amount (outflow) properly

* [autofix.ci] apply automated fixes

* fix: update AmountInput to sign and on outflow set +

* refactor: onSubmit handling of input value

* coderabbit suggestions

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-07 10:44:21 -07:00
lelemm
90ac8d8520 📚 More Translations (#5812)
* Translations

* linter

* Add release notes for PR #5812

* actions trigger

* md category change

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* typecheck fix

* linter

* more linter

* omg

* Fixes

* [autofix.ci] apply automated fixes

* Code review change

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Leandro Menezes <leandro.menezes@fusionflowsoftware.com>
2025-10-07 14:36:10 -03:00
Matt Fiddaman
52aeec2d59 ♻️ bump react dependencies (#5865) 2025-10-07 17:50:41 +01:00
lelemm
0c280d60f6 Frontend plugins Support [3/10]: System-Wide Feature Flag System + Frontend plugins feature flag (#5785)
Support for global feature flag and minimum custom theme prefs for plugins
2025-10-07 13:13:31 -03:00
Roque Alejandro Sosa
148ca92584 Added ARS currency (#5869)
* Added ARS currency

* Added correct release number

---------

Co-authored-by: Ras <git.boasting733@passinbox.com>
2025-10-07 08:28:38 -07:00
Ilyos Khurozov
90e848ebe8 Added support for Uzbek Soum (UZS) (#5876) 2025-10-07 08:16:43 -07:00
lelemm
b034d5039f Frontend plugins Support [2/10]: Plugin service worker (#5784)
* Plugin service worker
2025-10-07 12:14:32 -03:00
Matiss Janis Aboltins
5ac29473f2 Mobile payees - swipe to delete (#5824) 2025-10-06 19:23:52 +01:00
Matt Fiddaman
3b0db2bed7 ♻️ bump various build dependencies (#5864)
* vite 7.1.9

* typescript 5.9.3

* @types/node 22.18.8

* linting

* emscripten types

* note
2025-10-06 17:32:42 +01:00
Michael Clark
7a886810bc :electron: Hide the Electron menu (#5847)
* add retries to electron server import

* release notes

* get rid of this menu. If its an app functionality it should be available within the app

* hide the menu - update the ui

* fix function call

* Update VRT

* release notes

* spelling mistake

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-10-06 17:13:47 +01:00
Haritha Hasathcharu
8bf0997275 Add LKR and CRC currencies (#5848) 2025-10-06 08:41:59 -07:00
Matt Fiddaman
2f965266ab run schedule rules regardless of posted date (#5870)
* run schedule rules regardless of date

* note
2025-10-06 16:31:24 +01:00
Matt Fiddaman
499f24f7fd ♻️ bump non-react deps in desktop-client (#5858)
* patch/minor deps

* @vitejs/plugin-basic-ssl 2.1.0

* remove chokidar

* cross-env 10.1.0

* downshift 9.0.10

* remove focus-visible

* jsdom 27.0.0

* rollup-plugin-visualizer 6.0.4

* note
2025-10-06 16:28:04 +01:00
Matiss Janis Aboltins
4c5be62f56 Mobile payees - add loading indicator to rules count label (#5842) 2025-10-05 19:57:27 +01:00
Matiss Janis Aboltins
1446c7d93f Mobile rules - refactor to use react-aria GridList component (#5804) 2025-10-05 19:57:06 +01:00
Julian Dominguez-Schatz
ad9980307e Fix React compiler behaviour in dev mode (#5853)
* Fix React compiler behaviour in dev mode

* Add release notes

* Add comment
2025-10-05 07:14:03 -07:00
dependabot[bot]
d4ad31fb0c Bump tar-fs from 2.1.3 to 2.1.4 (#5796)
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.3 to 2.1.4.
- [Commits](https://github.com/mafintosh/tar-fs/compare/v2.1.3...v2.1.4)

---
updated-dependencies:
- dependency-name: tar-fs
  dependency-version: 2.1.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-10-05 14:51:07 +01:00
Matt Fiddaman
05355788e4 ♻️ bump sync-server dependencies (#5819)
* uuid 11.1.0 -> 13.0.0

* better-sqlite3 12.2.0 -> 12.4.1

* debug 4.4.1 -> 4.4.3

* express-rate-limit 8.0.1 -> 8.1.0

* pluggy-sdk 0.74.0 -> 0.77.0

* babel/core 7.28.0 -> 7.28.4

* note
2025-10-05 14:36:57 +01:00
Stephen Brown II
805e2b1807 Align amount conversion utilities between api and loot-core (#5747)
* Align amount conversion utilities between api and loot-core

Updates api amount conversion utilities to align with loot-core, improving consistency and maintainability across the project.

Uses decimal places as parameters in conversion functions.

* Moves amount conversion utils to core

Moves amount conversion utilities to the core library.

This change consolidates these utilities for better code reuse
and maintainability across different parts of the application.
It removes the duplicate definition from the API package and
imports it from the core library where it is shared.
2025-10-05 14:23:34 +01:00
Çağdaş Şenel
e54dc0c1ca fix losing transaction amount decimals on update (#5807) 2025-10-05 14:23:15 +01:00
Çağdaş Şenel
e1c2f0a181 feat: show full decimals while editing (#5808)
* show full decimals while editing

* add changes

* handle null
2025-10-05 14:23:04 +01:00
Matt Fiddaman
cc2e329e8e show empty data points on line graph reports (#5815)
* draw zero points

* note

* Update VRT

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-10-05 14:22:51 +01:00
Matt Fiddaman
71f849d1e1 ♻️ bump eslint-plugin-actual dependencies (#5818)
* eslint 9.27.0 -> 9.36.0

* eslint-plugin-eslint-plugin 6.4.0 -> 7.0.0

* eslint-vitest-rule-tester 2.2.0 -> 2.2.2

* note

* misc eslint deps
2025-10-05 14:22:42 +01:00
Matt Fiddaman
0ea8bc1fb4 expand eslint untranslated string rule (#5827)
* expand translation rule and abstract import fix implementation

* fixes

* note

* coderabbit
2025-10-05 14:22:14 +01:00
Matt Fiddaman
f0c7953c0b ♻️ refactor rules code (#5837)
* extract handlebars helpers

* extract condition types

* extract condition class

* extract action class

* extract rule class

* extract rule indexer

* extract rule utils

* update main index

* note

* enable strict where able

* generalise assert

* coderabbit

* move condition-types into condition, move helper functions into rule-utils
2025-10-05 14:22:02 +01:00
Matt Fiddaman
4cf5f9b183 add average per year calculation to the summary report (#5838)
* add average per year to summary report

* note

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-05 14:21:52 +01:00
Michael Clark
80fd997540 Reports - Add an option to trim the start & end intervals (#5641)
* initial test to trim the intervals

* bit more

* got the logic

* fix table data

* add migration for trim intervals

* release notes

* nice work rabbit

* small cleanup

* not sure how major that is but yeah why not
2025-10-05 10:48:35 +01:00
Michael Clark
da93ddf63b 🛠️ Add retries to electron loot-core import (#5843)
* add retries to electron server import

* release notes
2025-10-05 10:48:05 +01:00
github-actions[bot]
7846d2e787 🔖 (25.10.0) (#5834)
* 🔖 (25.10.0)

* Remove used release notes

* Remove used release notes

---------

Co-authored-by: matt-fidd <81489167+matt-fidd@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-10-02 11:55:47 +01:00
youngcw
ca6d80461a 🐛 fix limit checker (#5835) 2025-10-01 09:04:34 -07:00
Matt Fiddaman
fa14cbb697 fix decimal input in amount input boxes (#5831)
* preserve decimal seperators while typing in input boxes

* note
2025-10-01 16:27:51 +01:00
Matt Fiddaman
1210a74b4a fix error handling for simplefin batch sync (#5822)
* fix error handling for batch simplefin sync

* note
2025-09-30 23:51:17 +01:00
Matt Fiddaman
534c1e6680 fix crash when switching reports (#5823)
* fix report autocomplete

* note
2025-09-30 21:24:46 +01:00
Matt Fiddaman
14d436712a move balance history graph to live queries (#5821)
* move balance history graph to live queries

* note

* [autofix.ci] apply automated fixes

* coderabbit suggestion

* fix null starting balance

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-30 20:27:22 +01:00
Matt Fiddaman
e9f3925124 prevent the account balance graph from showing on small screen sizes (#5816)
* prevent account balance graph from showing on small screen sizes

* note

* lint
2025-09-30 00:46:26 +01:00
Matt Fiddaman
f28229be99 fix payee autocomplete hovering randomly (#5817)
* use correct index for payee autocomplete hover states

* note

* coderabbit
2025-09-30 00:46:07 +01:00
Matt Fiddaman
1fc922c672 skip running the schedule service if the database is not loaded (#5810) 2025-09-29 14:29:17 +01:00
Matiss Janis Aboltins
c712217a7c Update PayeesList component to use flex styling for improved layout consistency (#5803) 2025-09-28 06:31:30 +01:00
Matiss Janis Aboltins
3559b2df3a Mobile Payees - move to react-aria GridList to improve performance (#5802) 2025-09-27 21:54:16 +01:00
Matt Fiddaman
6365a8f4bb replace deprecated function in count points script (#5791)
* fix deprecated function call in count points script

* note
2025-09-25 21:03:44 +01:00
Matt Fiddaman
14426b64fd fix live report time ranges (#5790)
* fix live range

* note

* use latest of currentMonth/latestTransaction

* [autofix.ci] apply automated fixes

* standardise card code

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-25 19:16:40 +01:00
Matiss Janis Aboltins
65790d4b9c Fix token expiration parsing (#5782) 2025-09-25 18:07:26 +01:00
Michael Clark
9af4ba4d07 🔽 Downgrade Ubuntu image for more compatibility with older distros (#5788)
* downgrade ubuntu image for more compatibility with older distros

* release ntoes
2025-09-24 19:37:31 +01:00
Matiss Janis Aboltins
28caf8eaf9 Add data-1p-ignore to transaction amounts (#5783) 2025-09-24 17:15:16 +01:00
lelemm
81160256bc Frontend plugins Support [1/10]: CORS proxy (#5780)
* Frontend plugins Support [1/10]: Cors proxy

* Add release notes for PR #5780

* changed code as CodeQL suggested

* CodeQL improvement for ip validation to bypass dns changes

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Code Rabbit suggestion

* Update packages/sync-server/src/app-cors-proxy.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Added env var for cors proxy

* multiple changes

* missed updating yarn.lock

* making code rabbit happy

* Tests

* linter

* Code Rabbit changes

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* [autofix.ci] apply automated fixes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-24 08:13:24 -03:00
Joel Jeremy Marquez
ca5378c0e8 Optimize scroll provider and replace usage of debounce package with lodash's debounce (#5750)
* Optimize scroll provider and replace usage of debounce package with lodash's debounce

* Coderabbit suggestions
2025-09-23 15:59:55 -07:00
youngcw
08b5b7fdc7 add limit template type (#5775)
* add limit template

* use null to match other tempaltes

* add in directive

* handle no limit preset

* limit periods aren't optional

* make start field the right type

* fix test

* fix looping

* remove unneeded comment
2025-09-23 14:34:36 -07:00
Matiss Janis Aboltins
67c0b6911b Mobile payees: click handlers (#5776) 2025-09-23 22:18:37 +01:00
Matt Fiddaman
4e9e153989 ensure file upload size limits are respected when syncing files (#5779) 2025-09-23 18:06:45 +01:00
Matiss Janis Aboltins
b0321ee265 refactor: update table and import transactions modal components (#5770) 2025-09-23 16:49:03 +01:00
milanalexandre
753a105b3d [WIP] [FIX] Translate Schedule '(No payee)' (#5777) 2025-09-22 22:56:41 +01:00
Matiss Janis Aboltins
5a888d44b9 Create mobile payees list page (#5767) 2025-09-22 18:56:57 +01:00
thromer
7a4799de94 Avoid repeated calls to payee.find in useDisplayPayee.ts (#5761) 2025-09-22 16:26:14 +01:00
Amr Awad
4ad369cd8f add a 'dryRun' option to transactions import API (#5758) 2025-09-22 16:24:35 +01:00
Matt Fiddaman
2c9a66cec6 API quiet mode (#5762)
* initial implementation of api quiet mode

* note

* lint rule

* rollout logger to loot-core

* add group methods

* windows paths

* make fixer more robust

* appease linter

* add debug

* change option name quiet -> verbose
2025-09-22 12:54:08 +01:00
Matiss Janis Aboltins
6e96b81799 fix: add minimum width to value editor in ConditionEditor component (#5766) 2025-09-22 12:04:43 +01:00
milanalexandre
f89d4fd13d [FIX] Translate 'Off budget' and 'Transfer' (#5765)
* translate transaction edit modal (mobile)

* add relese note

* fix warn

---------

Co-authored-by: Alex <Alex>
2025-09-22 09:42:03 +01:00
Matt Fiddaman
cc0812113a improve cleanup when opening multiple budgets through the API (#5760) 2025-09-21 17:47:27 +01:00
Matt Fiddaman
59724d445f fix nuisance timestamp error in API (#5759) 2025-09-21 17:47:10 +01:00
Çağdaş Şenel
6b99497d5d feat(reports): extend report end date to the latest transaction date (#5753)
* add get-latest-transaction function to extend end dates beyond today

* add release notes

* yarn lint

* fix dateEnd and lint warnings

* change getFullRange to return all months

* Update upcoming-release-notes/5753.md

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-09-21 13:28:08 +01:00
Matt Fiddaman
5f5457b226 fix scrolling inside modal with an input that autofocuses (#5752) 2025-09-20 20:03:01 +01:00
dependabot[bot]
4bdcb27573 Bump @eslint/plugin-kit from 0.3.1 to 0.3.5 (#5749)
Bumps [@eslint/plugin-kit](https://github.com/eslint/rewrite/tree/HEAD/packages/plugin-kit) from 0.3.1 to 0.3.5.
- [Release notes](https://github.com/eslint/rewrite/releases)
- [Changelog](https://github.com/eslint/rewrite/blob/main/packages/plugin-kit/CHANGELOG.md)
- [Commits](https://github.com/eslint/rewrite/commits/plugin-kit-v0.3.5/packages/plugin-kit)

---
updated-dependencies:
- dependency-name: "@eslint/plugin-kit"
  dependency-version: 0.3.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-09-20 11:47:11 +01:00
Joel Jeremy Marquez
8ae070ab12 React Compiler (#5562)
* Highlight first suggestion when searching instead of the split option

* Fix error

* Try out react compiler

* Fix typecheck errors

* Increase --max-old-space-size

* Increate --max-old-space-size in package-browser

* Update config and versions

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Update versions

* Fix typecheck errors

* Revert some changes

* Implement react compiler to take advantage of some performance improvements

* Fixes

* Remove unused packages

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-19 14:28:16 -07:00
dependabot[bot]
0ca5bec094 Bump axios from 1.8.3 to 1.12.1 (#5719)
Bumps [axios](https://github.com/axios/axios) from 1.8.3 to 1.12.1.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](https://github.com/axios/axios/compare/v1.8.3...v1.12.1)

---
updated-dependencies:
- dependency-name: axios
  dependency-version: 1.12.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-09-19 17:32:06 +01:00
dirk-apers
988bc21818 enhancement: add BPER Italy bank parser (BPER_RETAIL_BPMOIT22) (#5741)
* Refine BPER retail parser with anonymized fixtures

* style: streamline bper parser comments

* chore: add release note for BPER Italy parser
2025-09-19 17:31:04 +01:00
Stephen Brown II
f4419b96de Dynamic currency display options (#5744) 2025-09-19 17:06:21 +01:00
passabilities.eth
e30a38ced8 [Feature] Account Net Worth Graph (#5037)
* show net worth graph for each account page

* add release notes

* hide filter button

* fix lint

* import ReactNode type

* find selected accounts based on accountId param

* remove breaks

* can toggle account page net worth graph

* Improves account balance history graph
Refactors the balance history graph to improve its data fetching and rendering.

Removes the `selectedAccounts` state and related logic from the Account component, simplifying its state management. The `accountId` is now passed directly to the BalanceHistoryGraph.

Moves the BalanceHistoryGraph component to the accounts directory and removes the redundant BalanceHistoryGraph in the sidebar.

Updates the queries to directly use the accountId for filtering transactions, leading to more efficient data retrieval.

* mv

* min width and height only for sidebar

* move toggle chart button to account menu

* add fill gradiant to chart

* fix maxWidth

* fix chart hover offset

* responsive graph aspect ratio

* auto hide chart on short view

* revert balance position

* auto hide chart on 15% height

* remove chart boolean from internal state

* Implement account-specific net worth chart preferences

Replaced global net worth chart visibility preference with account-specific preferences. Updated components to use the new dynamic preference keys and added a toggle option in the account menus for better user customization.

* lint

* fix account groups

* Update VRT

* bump

---------

Co-authored-by: youngcw <calebyoung94@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-09-18 13:32:21 -07:00
Michael Süssemilch
98b91cfb8d fix: make sure cumulative value can not be undefined (#5738)
* fix: make sure cumulative value can not be undefined, which results in NaN

* doc: add release notes
2025-09-18 08:20:57 -07:00
Josh Woodward
942d3ea4d5 Schedules with the same amount and date are now handled properly (#5414)
* minor typescript updates

* [autofix.ci] apply automated fixes

* more typescript changes

* [autofix.ci] apply automated fixes

* Another typescript

* fixes

* [autofix.ci] apply automated fixes

* fixed test

* [autofix.ci] apply automated fixes

* renaming a few things

* [autofix.ci] apply automated fixes

* a test

* test 2

* [autofix.ci] apply automated fixes

* test 3

* attempting to add a new test

* [autofix.ci] apply automated fixes

* test update

* additional typing.

* [autofix.ci] apply automated fixes

* Testing first item again

* [autofix.ci] apply automated fixes

* temporarily adding logging

* [autofix.ci] apply automated fixes

* only running rules within a schedule if exists

* swapping if

* removing unused import

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* fixing typecheck

* updated test

* [autofix.ci] apply automated fixes

* Updated screenshots

* further test fixing

* changing test order

* [autofix.ci] apply automated fixes

* Almost there

* new images

* tests may be flaky

* just one image

* 🙏

* 🙏 🙏

* removing all images

* Revert "removing all images"

This reverts commit 4492cb7080.

* small order change

* [autofix.ci] apply automated fixes

* Update VRT

* Update packages/desktop-client/e2e/schedules.test.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* reverting unrelated changes

* [autofix.ci] apply automated fixes

* Reverting one other typescript change

* testing completing 1 schedule

* Update VRT

* release wrote rewrite

* Making sure rule application is saved

* Cleaning up get function

* prettier and null catch

* Removed now unused schedule type

* Better falling back if rule / schedule no longer exists

* linting

* Better typing for db request

* camel case to make code rabbit happier

* slightly more accurate comment

* [autofix.ci] apply automated fixes

* Running other rules when linked rule runs

* lint / prettier

* one more lint

* Update 5414.md

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-09-16 20:12:31 -07:00
Matiss Janis Aboltins
3c9b70df79 Integrate responsive design for RecurringSchedulePicker component (#5733) 2025-09-16 21:33:30 +01:00
milanalexandre
5c18b53888 [fix] make the StatusLabel text appear on a single line (#5736)
* make the StatusLabel text appear on a single line

* add relese note

---------

Co-authored-by: Alex <Alex>
2025-09-16 13:30:39 -07:00
mgibson-scottlogic
413398531c Fix copy last month's budget including hidden categories (#5735)
* Add check that category is not hidden before copying last months budget

* Add release notes

* Add check that group is also not hidden

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-09-16 11:21:50 -07:00
jgeneaguilar
e4c3d4e12a Fix AccountMenu popover in Italian (#5734) 2025-09-16 16:54:35 +01:00
Michael Clark
91b838c539 🔔 Add setting to disable update notifications (#5725)
* add setting to disable update notifications

* release notes

* fix dependency array

* Update packages/loot-core/src/server/preferences/app.ts

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

* moving latest version info into app state to prevent needless calls to external api

* fix release note

* Update VRT

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-09-15 09:12:24 +01:00
Joel Jeremy Marquez
9eb0e04c6a [Maintenance] Remove raw variables in render (#5718)
* Remove usage of raw variables in renders

* Release notes

* Update status

* Fix typecheck error
2025-09-12 15:26:09 -07:00
Joel Jeremy Marquez
14bf3d611c [Maintenance] Remove usage of a raw variable in CategoryAutocomplete component (#5686)
* Remove usage of a raw variable in CategoryAutocomplete component

* Cleanup

* Fix typecheck error

* Fix typecheck error

* Highlight first suggestion when searching instead of the split option

* Fix error

* Fix special item highligted index
2025-09-12 15:25:52 -07:00
Joel Jeremy Marquez
34b6599da3 Re-design mobile accounts page to better match the transactions and budget tables/list + add all accounts page (#5610)
* Re-design mobile accounts page to better match the transactions and budget tables/list + add all accounts page

* [autofix.ci] apply automated fixes

* Update to "All accounts" to match desktop text

* Update prop

* Update VRT

* Increase height

* Update VRT

* Update UI

* Update VRT

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>
2025-09-11 09:17:07 -07:00
Evan Smith
bc1cd9023c Remove auto-scrolling behavior when editing split transactions on mobile (#5572)
* Remove behavior to auto scroll to transaction with 0 amount

* Add release notes
2025-09-11 16:26:21 +01:00
dependabot[bot]
5ae9176f5e Bump vite from 6.3.5 to 6.3.6 (#5707)
* Bump vite from 6.3.5 to 6.3.6

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.3.5 to 6.3.6.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v6.3.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v6.3.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 6.3.6
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* note

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-09-11 16:19:48 +01:00
Joel Jeremy Marquez
2ed908aff4 Remove usage of a raw variable in Account component (#5684) 2025-09-11 08:13:24 -07:00
Matt Fiddaman
3318dd56e9 remove BANKS_WITH_LIMITED_HISTORY override array for GoCardless (#5714)
* remove banks with limited history gocardless array

* note

* [autofix.ci] apply automated fixes

* set 89 in fallback

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-11 15:48:43 +01:00
Michael Clark
00ab11cc40 :electron: Update Electron to v38 (#5713)
* update electron to 38

* release notes
2025-09-11 15:40:40 +01:00
youngcw
25c83eb64d Add bank sync option to only import balance (#5711)
* add investment account setting

* note

* disable other options if enabled

* handle 0 balance

* Update packages/loot-core/src/server/accounts/sync.ts

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

* [autofix.ci] apply automated fixes

* dont exit early

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-11 07:15:57 -07:00
Mauro Artizzu
7a420b79f2 Handle detailedAccount null or undefined in gocardless service. Fixes #5664 (#5706)
* fix detailedAccount could be null or undefined

* add release notes
2025-09-11 14:45:43 +01:00
Nalin Gupta
d2cfedf5e4 Fixes #5674 mark transfer issue (#5696)
* Fixes #5674 mark transfer issue

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-09 20:32:55 -07:00
Shalan
00a4cfcabf feat: add EGP and SAR currencies to supported list (#5698)
* feat: add EGP and SAR currencies to supported list

* add release notes for currency support

* use yarn generate:release-notes to fix release notes

* Rename file with PR number 5698
2025-09-08 08:04:55 -07:00
Karim Kodera
a18a05f55a Introduction of APIs to handle Schedule + a bit more. (#5584)
* Introduction of APIs to handle Schedule + a bit more. Refer to updated API documentation PR2811 on documentation.

* Fixed lint Error

* Removed unused declarations

* Fixed Bug in Test module

* Avoiding type Coercion fixes and direct assignment on conditions array.

* Lint Error Fixes

* more issues fixed

* lint errors

* Remove with Mutation in Get function. Fixed quotes. updated getIDyName for error handling

* More lint errors

* Minor final fixes.

* One type coercion removed

* One type coercion removed

* Revert back to original working code

* Added Account testing for both get by ID and updating schedules

* [autofix.ci] apply automated fixes

* Added Payee tests as well

* Payee Tests

* [autofix.ci] apply automated fixes

* Optimized condition checking at the beginning of the code and avoid ambiguity in case of corrupt schedule

* Mode debug infor on error in testing

* better bug tracking

* //more trouble shooting

* Bug fixed

* [autofix.ci] apply automated fixes

* Minor mofication to satisfy code rabbit. We should be ready for review.

* [autofix.ci] apply automated fixes

* Removing type coercion from the model

* [autofix.ci] apply automated fixes

* fixed compilation error

* Fixed new bugs

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-08 09:03:11 +01:00
Matiss Janis Aboltins
b399f290a6 Add ErrorBoundary around Modals and updating FatalError modal behavior. (#5649)
Fix #4703
2025-09-07 19:14:31 +01:00
Matiss Janis Aboltins
7c07295448 Issues: add issue types (#5648) 2025-09-07 19:13:15 +01:00
Michael Clark
510dd31de6 🔧 Fix heap allocation error when building locally with docker (#5695)
* fix heap allocation error when building locally with docker

* release notes

* clarifying comment
2025-09-07 13:32:40 +01:00
Michael Sanford
8e5a88bc55 Add NO_COLOR standard environment flag to sync-server logging. (#5676)
* Add NO_COLOR standard environment flag to sync-server logging.

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-05 15:31:12 -07:00
Joel Jeremy Marquez
bbf91ccbca [Maintenance] Remove usage of a raw variable in PayeeAutocomplete component (#5687)
* Remove usage of a raw variable in PayeeAutocomplete component

* Add note on 100 payees limit
2025-09-05 12:26:44 -07:00
Joel Jeremy Marquez
58bc14e1b3 Optimize usage of useScrollListener and useTransactionsSearch (#5690) 2025-09-05 12:26:05 -07:00
Joel Jeremy Marquez
de2966a06c [Maintenance] Remove usage of a raw variable in AccountAutocomplete component (#5685)
* Remove usage of a raw variable in AccountAutocomplete component

* Remove usage of a raw variable in CategoryAutocomplete component

* Release notes

* Fix typecheck error

* Fix typecheck errors

* Remove CategoryAutocomplete changes
2025-09-05 11:21:59 -07:00
Michael Süssemilch
90b859fd74 feat(currency): add BRL, JMD, RSD, RUB, THB and UAH (#5653)
* feat: add BRL, JMD and THB currencies

* feat: add RSD, RUB and UAH
2025-09-05 10:57:29 -07:00
biolan
fafcee071d Add Romanian and Moldovan currency (#5688)
* * add Romanian Leu currency

* add Moldovan Leu currency

* Add release note

* * Add release note

* * one line release note

---------

Co-authored-by: biolan <admin@biolan.dev>
2025-09-05 07:05:56 -07:00
Bernardo Jordão
ed40901534 Fix range calculator on the MonthPicker component (#5622)
* fix month range

* release notes

* use floor() to match e2e tests
2025-09-05 06:41:23 -07:00
Julian Dominguez-Schatz
338093836b Add tools to migrate/un-migrate to/from UI automations (#5624)
* Add helper to render automations to template notes

* Add modal to un-migrate from the automations UI

* Add import warning to automations modal

* Add release notes

* Use CSSProperties type from React directly
2025-09-05 07:32:17 -04:00
Julian Dominguez-Schatz
4df05aa37c Fix version bump logic to work if the month has rolled over (#5662)
* Fix version bump logic to work if the month has rolled over

* Refactor script to be more testable

* Add tests for regression

* Move tests to dedicated package

* Add release notes

* Coderabbit
2025-09-05 07:31:53 -04:00
Julian Dominguez-Schatz
5459b8baca 🔖 (25.9.0) (#5663)
* 🔖 (25.9.0)

* Remove used release notes

* Empty commit to bump CI

* Add release notes for PR #5663

* Remove AI-generated release note

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-09-03 19:27:22 -04:00
Julian Dominguez-Schatz
073d91a7b7 Fix income modal balance not showing (#5659)
* Fix income modal balance not showing

* Add release notes
2025-09-02 10:02:44 -04:00
Gediminas Lelešius
58a638cee2 [fix] Support webRoot being in a hidden folder (e.g. .cache) (#5643)
Fixes #5642 and makes npx and pnpx work for @actual/sync-server
2025-08-29 15:52:29 -04:00
milanalexandre
23f1bae7db [fix] Adjust modal styles and text wrapping in TransactionError (#5634)
* adaptive size of the modal

* add relese note

---------

Co-authored-by: Alex <Alex>
2025-08-27 13:24:31 -04:00
Matt Fiddaman
57240284a3 fix health check script (#5631)
* fix health-check

* note
2025-08-26 16:10:45 -04:00
Matiss Janis Aboltins
6c6d8931bb Release Pluggy bank-sync integration (#5628) 2025-08-26 18:17:20 +01:00
Michael Clark
cae8fa4e6f :electron: Building bcrypt for correct architecture during packaging (#5623)
* rebuilding bcrypt

* release notes
2025-08-25 09:41:45 +01:00
Michael Süssemilch
48ae371ecc fix: crash on filtering by amount (#5608)
* fix: crash on filtering by amount

* doc: add release notes
2025-08-23 10:55:22 +01:00
Matiss Janis Aboltins
e8d93fb797 Implement responsive DateSelect component for mobile view (#5607) 2025-08-22 22:13:16 +01:00
Joel Jeremy Marquez
6790f99de2 [Mobile] Show uncategorized/overspending totals on budget banners (#5605)
* [Mobile] Show uncategorized/overspending totals on budget banners

* Cleanup

* Update VRT

* Coderabbit feedback

* Remove console.log

* Rename release notes

* Use Array.from

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-08-21 21:26:55 -07:00
Joel Jeremy Marquez
68f0b05aed [Redux] Rename queriesSlice to transactionsSlice (#5598)
* Move getAccountsById to accountsSlice

* [autofix.ci] apply automated fixes

* [Redux] Rename queriesSlice to transactionsSlice

* Fix import

* Release notes

* Remove nonexistent saved state

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-21 18:16:43 -07:00
Joel Jeremy Marquez
c954d3924e [Redux] Move tags states from queriesSlice to tagsSlice (#5597)
* Update packages/desktop-client/src/queries/queriesSlice.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* [autofix.ci] apply automated fixes

* Move getAccountsById to accountsSlice

* [autofix.ci] apply automated fixes

* [Redux] Move tags states from queriesSlice to tagsSlice

* Fix lint + release notes

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-21 15:31:06 -07:00
Joel Jeremy Marquez
adf4bd2d0f Enable Make Transfer menu for child transactions (#5604) 2025-08-21 15:24:16 -07:00
Matiss Janis Aboltins
102c6eaff6 Enhance responsiveness of GenericInput in RuleEditor component for mobile devices (#5601)
* Enhance responsiveness of GenericInput in RuleEditor component for mobile devices

* Refactor ActionEditor layout in RuleEditor component for improved responsiveness

- Adjusted styles for the View components to enhance layout flexibility.
- Ensured the GenericInput component maintains appropriate minimum width based on method type.
- Updated Stack component to prevent shrinking, improving overall UI consistency.
2025-08-21 22:17:17 +01:00
Joel Jeremy Marquez
21105fc25b [Redux] Move category states from queriesSlice to budgetSlice (#5593)
* Update packages/desktop-client/src/queries/queriesSlice.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* [autofix.ci] apply automated fixes

* Move getAccountsById to accountsSlice

* [autofix.ci] apply automated fixes

* Fix merge error

* [autofix.ci] apply automated fixes

* [Redux] Move category states from queriesSlice to budgetSlice

* Move getCategoriesById to budgetSlice + fix lint

* Fix lint

* [autofix.ci] apply automated fixes

* Fix typecheck

* Add new slices to boundActions

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-21 14:15:30 -07:00
Matiss Janis Aboltins
c69142f58e Refactor schedule handling in ManageRules component (#5600)
- Updated the ManageRules component to use ScheduleEntity type for schedules.
- Improved the describeSchedule function to include type annotations for better clarity.
- Added a conditional check to handle cases where the schedule may not exist, ensuring robust functionality.
2025-08-21 20:09:21 +01:00
Matiss Janis Aboltins
fe32bf14c6 Mobile rules - update default stage to be "default" instead of "pre" (#5587) 2025-08-21 19:24:52 +01:00
Joel Jeremy Marquez
92e43bc3b5 [Redux] Move payee states from queriesSlice to payeesSlice (#5592)
* Update packages/desktop-client/src/queries/queriesSlice.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* [autofix.ci] apply automated fixes

* Move getAccountsById to accountsSlice

* [autofix.ci] apply automated fixes

* [Redux] Move payee states from queriesSlice to payeesSlice

* Fix merge error

* Fix merge error

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Fix import

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-21 08:51:38 -07:00
Joel Jeremy Marquez
165be3d0df [Redux] Move account states from queriesSlice to accountsSlice (#5581)
* Add rejected reducers

* Add dirty states

* Update packages/desktop-client/src/queries/queriesSlice.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* [autofix.ci] apply automated fixes

* [Redux] Move account states from queriesSlice to accountsSlice

* Release notes

* Move getAccountsById to accountsSlice

* [autofix.ci] apply automated fixes

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-21 08:16:22 -07:00
youngcw
3dd22994b7 fix bug (#5594) 2025-08-21 07:56:09 -07:00
Michael Clark
96bfc69332 Command bar VRTs (#5591)
* command bar vrts

* release notes

* reduce flakiness

* oh

* add screenshots back in

* Update VRT

* trigger

* reducing screenshots

* Update VRT

* trigger

* jeez

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-08-21 09:08:46 +01:00
Joel Jeremy Marquez
284fc13161 [Mobile] Do not show transfer transactions on uncategorized transactions view/page (#5589)
* [Mobile] Do not show transfer transactions on uncategorized transactions view/page

* [autofix.ci] apply automated fixes

* Rename

* Add release notes for PR #5589

* Change release notes to bugfix

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-08-20 14:09:53 -07:00
Matiss Janis Aboltins
30102b1474 Revert "Dispatch github ci jobs after running update-vrt workflow (#5586)" (#5590)
This reverts commit 3a8eb96d76.
2025-08-20 21:28:27 +01:00
Matiss Janis Aboltins
3a8eb96d76 Dispatch github ci jobs after running update-vrt workflow (#5586)
* Enhance CI workflows to support repository dispatch events and improve branch handling

- Added support for `repository_dispatch` events in build, check, and codeql workflows.
- Updated concurrency group to include `client_payload.pr_number` for better context.
- Modified checkout steps to reference the correct branch from `client_payload` if available.

* Add release notes for PR #5586

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-08-20 21:12:16 +01:00
Joel Jeremy Marquez
91a8bc3ef1 Prevent unnecessary calls to DB if same redux action is already pending (#5579)
* Prevent unnecessary calls to DB if same redux action is already pending

* [autofix.ci] apply automated fixes

* Release notes

* Add rejected reducers

* Add dirty states

* Remove commented code

* Update packages/desktop-client/src/queries/queriesSlice.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update packages/desktop-client/src/queries/queriesSlice.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update packages/desktop-client/src/queries/queriesSlice.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update packages/desktop-client/src/queries/queriesSlice.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update packages/desktop-client/src/queries/queriesSlice.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* [autofix.ci] apply automated fixes

* Coderabbit feedback

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-08-19 19:42:15 -07:00
Julian Dominguez-Schatz
dc2ab4843f Connect automations UI to backend (#5533)
* Connect automations UI to backend

* Fix integer -> amount

* Add release notes

* Fix length check

* No layout shift

* Coderabbit: decimal places
2025-08-19 20:30:09 -04:00
Matt Fiddaman
89e5676cfb only show schedule name in notes for upcoming transactions (#5580) 2025-08-19 19:06:27 -04:00
POGMAN
645342d47d Compute color of tags text for dark mode (#5574) 2025-08-19 10:16:45 -07:00
Julian
116c695964 fix filter transactions by closed account transfer payee (#5438)
* fix filter transactions by closed account transfer payee

* apply equivalent ignore pattern to arguments as variables in eslint

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-19 08:14:40 -07:00
Joel Jeremy Marquez
a5d18929c8 Fix AutoTextSize warnings (#5576)
* Fix AutoTextSize warnings

* Release notes
2025-08-19 08:14:21 -07:00
Matt Fiddaman
989d332e1b fix rerender loop in calendar card (#5573) 2025-08-18 11:19:45 -04:00
Michael Clark
169d08e721 🗑️ Remove old sourcemap and process package (#5567)
* remove old sourcemap package and process package

* release notes

* Update 5567.md
2025-08-18 08:54:44 +01:00
milanalexandre
a74da11904 translate import transactions (#5565)
* translate import transactions

* translate import transactions headers

* add relese note

* feed back

Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>

---------

Co-authored-by: Alex <Alex>
Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>
2025-08-17 07:39:55 -07:00
Michael Clark
cccd66713d 🗑️ Remove unused package (reselect) (#5566)
* remove unused package

* release notes
2025-08-16 21:04:41 +01:00
Matiss Janis Aboltins
1ce53b2762 feat(mobile): ability to delete rules (#5556) 2025-08-16 17:56:22 +01:00
milanalexandre
d75f984186 Translate closing account and more (#5549)
* translate

* add relese note

* Update VRT

* feed back

* Update VRT

* revert vrt

* avoid duplicate translations

* translate rename save butons (reports custom)

---------

Co-authored-by: Alex <Alex>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-08-15 18:06:38 -07:00
Matiss Janis Aboltins
692ade7254 Extract mobile rules form to a new page (#5516) 2025-08-14 21:52:47 +01:00
dependabot[bot]
da0ac0b144 Bump tmp from 0.2.1 to 0.2.5 (#5551)
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.1 to 0.2.5.
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md)
- [Commits](https://github.com/raszi/node-tmp/compare/v0.2.1...v0.2.5)

---
updated-dependencies:
- dependency-name: tmp
  dependency-version: 0.2.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-13 22:07:53 +01:00
Michael Clark
be20f65b6e 🛠️ Moving loot-core to Vite (#5379)
* Moving loot core to Vite
2025-08-13 20:49:48 +01:00
Joel Jeremy Marquez
1067e32028 [Mobile] Fix preview transactions not loading in multi-account views and uncategorized splits not loading (#5072)
* Fix preview transactions not loading in multi-account views and uncategorized splits not loading

* Update release notes

* Fix typecheck error

* Coderabbit feedback

* Fix lint error

* Fix banners

* Fix uncategorized view to use new route

* Updates

* Update VRT

* Dummy commit

* Fix lint

* [autofix.ci] apply automated fixes

* Update loading

* Coderabbit feedback

* [autofix.ci] apply automated fixes

* Delete old snapshots

* Translate Closed

* Update Closed translation

* Update translation

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

* [autofix.ci] apply automated fixes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-08-13 11:05:05 -07:00
Johannes Maas
dcb1c69e67 Display absolute date of reconciliation (#5521) 2025-08-13 13:47:27 -04:00
Matiss Janis Aboltins
f084e28086 Added CODEOWNERS file (#5544) 2025-08-12 22:10:10 +01:00
Joel Jeremy Marquez
f54e459e03 Fix transaction hooks and improve transactions loading experience in mobile (#5415)
* Fix transaction hooks and improve transactions loading experience in mobile

* Allow skipping of running balance calculation on preview transactions + recalculate running balances if there are any inversed transaction amounts

* [autofix.ci] apply automated fixes

* Disable PullToRefresh when transaction list is in loading state (See #5080)

* Cleanup

* Add calculateRunningBalancesTopDown to calculate top down from starting balance

* update balance sheet value

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-12 13:57:17 -07:00
Matiss Janis Aboltins
ccdde60bfe TypeScript: convert edit rules modal (#5543) 2025-08-12 21:41:13 +01:00
Michael Süssemilch
712d315229 fix: hidden category selection and include hidden when they are shown on budget (#5526)
* fix: hidden category selection

* chore: add (hidden) to hidden categories and groups

* feat: add hidden category to filter

* feat: show hidden categories in mobile

* refactor: remove unused variable
2025-08-12 12:57:54 -07:00
milanalexandre
31c6362307 Fix SpendingCard crash (#5541) 2025-08-12 09:51:10 -04:00
CyberSardinha
d1519993d6 Add gocardless support for Stadtsparkasse München (#5383)
* Add files via upload

* added credits to the original author Nebukadneza

* [autofix.ci] apply automated fixes

* Create 5383.md

* Improve Stadtsparkasse München GoCardless transaction parsing

* Improve Stadtsparkasse München GoCardless transaction parsing

* Update 5383.md

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-12 01:18:55 -04:00
Julian Dominguez-Schatz
ebde78434a Add backend logic to support automations UI (#5532)
* Add backend logic to support automations UI

* Fix tests

* Add release notes

* PR feedback: default priority

* PR feedback: template_settings

* PR feedback: batch

* PR feedback: no remainder special-casing

* Simplify SQL

* Fix tests

* Coderabbit

* Schema default
2025-08-11 23:39:09 -04:00
Matiss Janis Aboltins
8fcaff8e3a Fix display of link schedules condition (#5529) 2025-08-09 16:34:02 +01:00
dependabot[bot]
13bc99738f Bump tmp from 0.2.1 to 0.2.4 (#5504)
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.1 to 0.2.4.
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md)
- [Commits](https://github.com/raszi/node-tmp/compare/v0.2.1...v0.2.4)

---
updated-dependencies:
- dependency-name: tmp
  dependency-version: 0.2.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-09 01:39:06 -04:00
Junyuan Zheng
959824d317 [BUG] Fix incorrect mathematic calculation in reconcile window (#5528)
* [Bug 5527] Fix incorrect mathmatic equation in resoncile window

* fix linter

* update

* add note

* [autofix.ci] apply automated fixes

* fix linter

* fix linter & type

* fix typing error

* fix lint and typing

* add test

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-09 01:26:06 -04:00
ShayanAraghi
2abc144b03 Add fix for unfocusing the date disabling all other buttons (#5519)
* Add fix for unfocusing the date disabling all other buttons

* Add Release notes
2025-08-08 11:41:12 -07:00
dgliwka
71250f5fb7 [WIP] add Polish Złoty currency (#5472)
* add Polish Złoty currency

* Add release note

* Add Polish Złoty currency

* Delete upcoming-release-notes/5672.md
2025-08-08 09:40:52 -07:00
Michael Süssemilch
c5f050f6f8 fix: negative numbers in summary report (#5520)
* fix: negative numbers in summary report

* doc: add release notes
2025-08-08 12:32:48 -04:00
r1ch
0d46e221f9 Fix missing space on MergeUnusedPayeesModal (#5523)
* Missing space MergeUnusedPayeesModal.tsx

Create PR branch

* Create 5523.md

* [autofix.ci] apply automated fixes

* Update MergeUnusedPayeesModal.tsx

* Add parent

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-08 09:31:55 -07:00
Matiss Janis Aboltins
6bf2f581a3 Extracted rule editor outside of the modal and into its own component (#5518) 2025-08-07 22:38:44 +01:00
POGMAN
3c34603111 Add 'Prior year to date' time range (#5419)
* add 'Last year to date' time range

* Rename 'Last YTD' to 'Prior YTD'

* Day accurate prevYear for Prior YTD

* Update VRT
2025-08-07 13:31:12 -07:00
milanalexandre
3e488ae8f7 Fix translate payees page (#5514)
* Payees page

* edit rule

format

* add relese note

* feed back

---------

Co-authored-by: Alex <Alex>
2025-08-07 15:51:25 -04:00
Emil George
bacf3091b6 [4036] - Fix Payee Name Overflow (#5489)
* fix: update payee name overflow styles

* chore: add release note

* fix: use text one line component
2025-08-07 10:16:05 -07:00
Emil George
ac77c0f360 Add Indian Rupee (INR) Currency (#5483) 2025-08-07 11:49:21 -04:00
r1ch
e21256e7a2 [WIP] Fix display of old payee name in MergeUnusedPayees modal (#5485) 2025-08-07 09:35:16 -04:00
Joel Jeremy Marquez
22237d11ca Add Philippine Peso currency (#5507) 2025-08-06 17:39:49 -07:00
milanalexandre
63604c1161 Fix translate custom report and rule (#5486)
* translate Allocation Methods

* fix translate Action

translate Split info

* translate date range

* translate monthly spending

* translate shorter filter

* translate date filter reports custom

* add relese note

---------

Co-authored-by: Alex <Alex>
2025-08-06 15:14:36 -07:00
Michael Süssemilch
74b95ca83e feat(currency): add to reports (#5283)
* feat(currency): add to networth report

* feat(currency): add to cashflow report

* feat(currency): add to spending report

* feat(currency): add to summary report

* feat(currency): add to calendar report

* feat(currency): add to custom report

* chore: add release note

* chore(rename): rename formatFunc to format

* fix: missing average rounding

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-08-06 18:05:37 -04:00
Matiss Janis Aboltins
6a9028464b Mobile rules page (#5390) 2025-08-06 23:00:08 +01:00
Matt Fiddaman
186d417c6e make bulk notes prepend/append behaviour consistent with rules (#5464) 2025-08-06 16:26:10 -04:00
Alex Camilleri
c898116412 Added Länsförsäkringar bank (#5479)
* Added Länsförsäkringar

* Release Notes

---------

Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
2025-08-06 21:21:27 +01:00
Matt Fiddaman
85bd6bfb81 hide hold for next month option when "to budget" is negative (#5496) 2025-08-06 13:12:58 -04:00
Matiss Janis Aboltins
72616376e2 Enhance Tooltip component with close delay functionality (#5475) 2025-08-06 08:49:20 +01:00
Matt Fiddaman
136ad055f7 ♻️ bump sync-server dependencies (#5497)
* bcrypt 5.0.2 -> 6.0.0

* supertest 6.3.4 -> 7.1.4

* pluggy-sdk 0.70.1 -> 0.74.0

* types

* better-sqlite3 11.10.0 -> 12.2.0

* express-rate-limit 7.5.0 -> 8.0.1

* babel/core 7.27.1 -> 7.28.0

* typescript 5.8.3 -> 5.9.2

* node types

* note

* typechecker
2025-08-06 02:00:04 -04:00
Matt Fiddaman
c621f68e0a fix live report date mode not supporting a 2 month window (#5495)
* allow live report date ranges 2 months wide

* note
2025-08-05 23:19:54 -04:00
Matt Fiddaman
4f611ca458 fix (#5493) 2025-08-05 22:12:11 -04:00
Matt Fiddaman
d98e8375a8 merge automatic package versioning GitHub workflows (#5480)
* merge bump-package-versions script with get-next-package-version

* note

* appease the rabbit

* add update flag to node script

* use update flag in workflow

* not much has changed but they live underwater
2025-08-05 22:06:37 -04:00
passabilities.eth
4f50c1a889 Display Schedule Name in Upcoming Tx Notes (#5482)
* show schedule name in notes for upcoming scheduled transactions

* release notes
2025-08-05 21:36:34 -04:00
Matiss Janis Aboltins
0fa582b3d3 feat: show/hide balance graph in side nav (#5452) 2025-08-05 21:35:33 +01:00
Matt Fiddaman
80cd2cf347 prevent closing an account into itself (#5462)
* prevent closing account into itself

* note

* prevent at API level too
2025-08-05 15:11:01 -04:00
milanalexandre
f328332ab2 fix translations on the "new transaction" and "list" page on mobile (#5471)
* fix 'frome'/'to' && 'Split'...

* add relese note

* fomat

---------

Co-authored-by: Alex <Alex>
2025-08-05 01:15:45 -04:00
Chai
7465bdb54d fix: missing table column on mobile devices (#5126)
* fix: missing table column

* chore: better releasenote

* chore: incorrect filename

* Update VRT

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-08-04 21:31:01 -04:00
milanalexandre
1ad3406e84 Fix/i18n translate status and date (#5411)
* add translations for StatusLabel

* add translations for BalanceHistoryGraph (date)

* add random translations

* Update setHoveredValue update to avoid a crash

format

* add relese note

* feed back

---------

Co-authored-by: Alex <Alex>
2025-08-04 20:48:41 -04:00
Matt Fiddaman
48166952ce add Qatari Riyal currency symbol (#5456)
* add Quatari Riyal currency symbol

* note
2025-08-04 20:43:03 -04:00
Matt Fiddaman
994b959050 parallelise contributor points calculations (#5465) 2025-08-04 18:46:33 -04:00
Çağdaş Şenel
7f4f5005a5 Add currencies SEK and TRY (#5477)
* Add SEK and TRY

* Add SEK and TRY to translations

* Add release notes
2025-08-04 20:09:29 +01:00
ShayanAraghi
1e05b169c8 Truncate multiple payee names with ellipsis to prevent layout overflow in the payee column. (#5418)
* Have the multiple payee text overflow with ellipsis

* [autofix.ci] apply automated fixes

* Add release notes

* add minWidth to the payee text

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-04 11:28:07 -07:00
POGMAN
c54a5b3405 Use null as tag color by default (fallback to theme color) and stricter tag validation (#5398)
* Use null as tag color by default (fallback to theme color) and stricter tag validation

* Set ColorPicker's defaultValue props

* Set default tag color in first position

* Make ColorSwatchPicker configurable

Easier to change colors and how they are presented
2025-08-04 11:27:44 -07:00
milanalexandre
5c11a0a51a Fix missing translations (#5396)
* add missing translations

* add relese note

* add missing translations (no note)

---------

Co-authored-by: Alex <Alex>
2025-08-04 11:26:17 -07:00
milanalexandre
8f69669cc6 Fix translate rule stages (#5421)
* add translation support for rule stages

* add relese note

* fix test

* feed back

---------

Co-authored-by: Alex <Alex>
2025-08-04 11:25:56 -07:00
Matt Fiddaman
9ebdba27fd import category notes from nYNAB (#5461)
* import category notes from nYNAB

* note

* typecheck

* add notes to test file
2025-08-04 14:24:42 -04:00
Jakub Kuczys
8df3d23e03 Allow Docker image build by workflow dispatch on forks (#5404)
* Allow Docker image build by workflow dispatch on forks

* Add release note
2025-08-04 14:23:59 -04:00
ShayanAraghi
5d238c238d fix: move add specific days onto the next row and dynamically increased the width of the numbered input (#5406)
* fix: Move Add Specific Days to next line and dynamically increase the width of the numbered input box

* [autofix.ci] apply automated fixes

* Add Release Notes

* Update the release notes summary

* Update width from px to ch

* Update schedule date modal to expand when repeat every number increases

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-04 14:23:37 -04:00
Julian
e69235a35b fix responsiveness of mobile navigation with longer translation strings (#5429)
* fix responsiveness of mobile navigation with longer translation strings

* [autofix.ci] apply automated fixes

* Update VRT

* Update VRT

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-08-04 14:23:26 -04:00
Matt Fiddaman
611f7b046a make payeeName fall back to default if the custom mapped bank sync field is missing (#5460)
* payeeName should fallback if custom mapped field is empty

* note
2025-08-04 14:23:14 -04:00
Matt Fiddaman
ee8f7453ba add tooltip for detailed last sync time on bank sync page (#5458) 2025-08-04 14:23:04 -04:00
Matt Fiddaman
380fae1ccd fix tag colors when using the light theme as system default (#5457)
* fix tag colouring on system default light theme

* note
2025-08-04 14:22:51 -04:00
Matt Fiddaman
8d84f16604 improvements to release PR points counting logic (#5450)
* do not credit reviewers of release PRs

* make release regex more flexible
2025-08-02 15:31:04 -04:00
Michael Clark
239a087542 🐛 Paginate the count points list files call (#5448)
* paginate the count points list files call

* fix tier assignment

* paginate the count points list files call

* fix tier assignment

* ensure utc dates and fix issue filtering to include issues updated in other months
2025-08-02 18:33:18 +01:00
github-actions[bot]
895d69f875 🔖 (25.8.0) (#5447)
* 🔖 (25.8.0)

* Remove used release notes

---------

Co-authored-by: matt-fidd <81489167+matt-fidd@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-08-02 11:39:18 -04:00
Matt Fiddaman
1cb5e97fab fix reconcile input being hidden when empty (#5446)
* fix bug when reconcile box is empty

* note
2025-08-01 22:00:02 -04:00
Matt Fiddaman
13bd08d243 clarify ai release note comment (#5440) 2025-08-01 17:03:20 -04:00
ShayanAraghi
d946852ee9 Clear active edit on mobile when clicking out of notes field (#5430)
* clear active edit on mobile when clicking out of notes field

* Add release notes
2025-08-01 00:19:52 -04:00
Julian
4cdff76547 fix crash when enter is used to submit empty date in date picker (#5423) 2025-07-31 20:19:54 -07:00
youngcw
1a1975b5ab fix auto hold on new categories (#5434) 2025-07-31 20:18:09 -07:00
youngcw
6e2154d401 Revert "Mobile running balance" because its causing extreme slowness in large accounts. (#5405)
* Revert "Mobile running balance (#5219)"

This reverts commit a20805bfae.

* Add release notes for PR #5405

* retain added translation

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-07-30 12:57:28 -07:00
POGMAN
45bfd23daa Do not search tags in deleted transactions (#5409) 2025-07-28 07:17:03 -07:00
POGMAN
c44b32805f fix tag matching of filter and make hasTags op case-sensitive (#5386)
Co-authored-by: youngcw <calebyoung94@gmail.com>
2025-07-26 09:03:48 -07:00
Matiss Janis Aboltins
45530638fe Fix potential undefined points issue in contributor points calculation (#5393) 2025-07-26 07:48:09 +01:00
youngcw
a15ff85c20 Fix tags not syncing properly (#5387)
* start

* migration

* don't show deleted tags in list

* tag updates (#5389)

* upsert tag to ensure uniqueness

and insert default-tag in migration

* remove ability to change default tag color

---------

Co-authored-by: pogman-code <adrian.maurin@gmail.com>

* tags fixes (#5391)

* better tag validation

* fix typecheck issues

* update note

---------

Co-authored-by: pogman-code <adrian.maurin@gmail.com>
2025-07-25 14:32:52 -07:00
Matiss Janis Aboltins
1861060bda Fix undefined points error in contributor points (#5392) 2025-07-25 21:14:29 +01:00
Koen van Staveren
9281acb819 fix: reconcile select number on click (#5373) 2025-07-23 14:50:17 -07:00
youngcw
dc86441809 Fix template priority sorting (#5380)
* fix

* lint
2025-07-23 14:48:32 -07:00
passabilities.eth
78bcac95ed [Enhancement] Disable Sidebar Tooltip on Touchscreen Device (#5362)
* check if device is not touchscreen to show account sidebar tooltip

* release notes
2025-07-23 18:34:34 +01:00
POGMAN
45610bae81 Add button to import existing tag from transactions notes (#5368)
* Add button to import existing tag from transactions notes

* fix ##non-tag matching

* 'find' tags instead of 'import' to avoid confusion

* add link to show transaction that have given tag

* use same style as PayeeTableRow's button
2025-07-23 09:57:43 -07:00
Christian Speich
f5a6700b21 Only use fund from local group during cleanup. (#5377)
When using local group cleanup, currently all funds available in To Budget are distributed into the sinks. This behaviour seems somwhat odd and also results in all later groups or the "global" cleanup run to possibly have no funds as they've been distributed before.

This patch now changes the group usage of cleanup, to only distribute funds made available by the group itself. If one also wants to sink money from To Budget into the category, a simple addtional `#cleanup sink`, will achieve this.

Fixes #5374

Signed-off-by: Christian Speich <christian@spei.ch>
2025-07-23 08:56:21 -07:00
Michael Clark
8cea059834 VRT's for Help menu (#5371)
* add some tests for help menu

* updating tests

* release notes

* fix lint

* Update VRT

* unneeded focus

* good wabbit

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-07-23 09:06:28 +01:00
dependabot[bot]
31b31f2edb bump form-data from 4.0.0 to 4.0.4 (#5365)
* Bump form-data from 4.0.0 to 4.0.4

Bumps [form-data](https://github.com/form-data/form-data) from 4.0.0 to 4.0.4.
- [Release notes](https://github.com/form-data/form-data/releases)
- [Changelog](https://github.com/form-data/form-data/blob/master/CHANGELOG.md)
- [Commits](https://github.com/form-data/form-data/compare/v4.0.0...v4.0.4)

---
updated-dependencies:
- dependency-name: form-data
  dependency-version: 4.0.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* note

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-07-22 16:07:36 -04:00
Michael Clark
4b56e0cb54 ⌨️ Enhanced keyboard shortcuts modal (#5340)
* start to an enhanced keyboard shortcuts modal

* shortcut start

* poc

* still rough but getting closer

* refactor a bit

* types

* bits

* renaming

* clarifying comment

* release notes

* suggestions

* adding initial focus state on the search

* fix lint
2025-07-22 18:48:16 +01:00
Matt Fiddaman
f8dd4897e7 fix datepicker month input validation to allow mm/yyyy on resubmission (#5356)
* fix datepicker month input validation

* note

* fix year too

* keep mm/yyyy format consistent

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-22 12:27:19 -04:00
Matt Fiddaman
526d7a9baa add options to post schedule today or the next scheduled date (#5359)
* add option to post transaction today

* note

* Update VRT

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: youngcw <calebyoung94@gmail.com>
2025-07-22 12:27:10 -04:00
Ciftci
af8f26f200 Fixes #5343: Color of the resize handle now adapts to color scheme (dark theme/midnight theme/light theme) (#5364)
* Added color variable pageTextLight to resizable handlers in overview.scss

* Generated release notes

* [autofix.ci] apply automated fixes

---------

Co-authored-by: seabeeberry <seri@Mac.fritz.box>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-21 22:32:24 -04:00
Elijah Olmos
548f36e8d6 feat(CommandBar): display account balances (#5355)
* feat(CommandBar): display account balances

* add release note

* rename release note
2025-07-21 12:36:05 -04:00
Matt Fiddaman
9aed1f400c fix crash when using bulk amount update (#5360) 2025-07-21 11:27:09 -04:00
Matt Fiddaman
59bcee9369 fix payee and transaction context menus when no items selected (#5358)
* fix context menus with no items selected

* note
2025-07-21 10:16:36 -04:00
Matt Fiddaman
ff7529f6e5 remove unused dependency express-response-size (#5361)
* remove unused dep

* note
2025-07-21 10:11:32 -04:00
Julian Dominguez-Schatz
77e99af297 Convert SelectLinkedAccountsModal to TypeScript (#5059)
* Convert `SelectLinkedAccountsModal` to TypeScript

* Add release notes

* Fix typo caught by Rabbit
2025-07-21 09:54:27 -04:00
POGMAN
82a3c97222 Add colors to ReportTable "Totals" row (#5104)
* add colors to ReportTable

* Update VRT

* use default color for zero values

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-07-21 02:23:30 -04:00
martijnhielema
cafcc823cb Add extra date format (#5353)
* Added dd-mm-yyyy date format for display.

* adding release note entry
2025-07-21 00:23:01 -04:00
passabilities.eth
582e27dbdb [Feature] Only Show Sidebar Tooltip on Desktop (#5352)
* only show sidebar tooltip on desktop

* release notes

* Update upcoming-release-notes/5352.md

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

* replace with media query checks

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-07-21 00:00:19 -04:00
Elijah Olmos
d747563915 feat(CommandBar): add aggregated acct views (#5348)
* feat(CommandBar): add aggregated acct views

* docs: generate release notes

* capitalize release note

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-07-19 18:14:06 -04:00
Ngoc Do
84dec137bb fix defaultCleared options not used when importTransactions (#5247) 2025-07-19 11:33:08 -04:00
Guillaume Taquet Gasperini
76de8bf67f Fix Boursorama GoCardless transaction ordering (#5344)
I wrongly thought that all the card transactions will always
have their first line with the `CARTE` identifier.
But as I have seen recently, it's not the case, and we shouldn't
rely on the ordering of the array returned by the Boursorama
GoCardless integration.

Thus, check for transaction patterns in all of the lines of the
unstructured array.

This addresses a true case (added in test) where the payee name
was wrongly extracted as being `110,04 Gbp / 1 Euro = 0,860763454`
2025-07-19 04:23:10 -04:00
passabilities.eth
5db7026435 fix: Save Account Notes (#5326)
* replace static function with useCallback

occasionally if you are editing the notes of an account and then open another account from the sidebar without first closing the popover, the note would be saved to both the current and previously opened account.

* reset tempNote on id change

* save notes only if changes are made

Previously, the notes were being saved unconditionally when closing the Notes modal. This update ensures that the save action is triggered only if the temporary notes differ from the existing note, reducing unnecessary events.
2025-07-18 19:00:26 +01:00
youngcw
e4a993ad67 🐛 improve budgeting of schedules templates (#5319)
* fix

* fix

* didn't need that

* prevent div by 0
2025-07-17 12:49:00 -07:00
Dreptschar
38ab63638a add action button to trigger applyBudgetTemplatesInGroup to mobile (#5293)
* add action button to trigger applyBudgetTemplatesInGroup

* add release note

* fix typos

* fix lint and typecheck findings

* [autofix.ci] apply automated fixes

* fix typecheck

---------

Co-authored-by: dreptschar <dreptschar@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: youngcw <calebyoung94@gmail.com>
2025-07-16 09:50:03 -07:00
POGMAN
4eea349966 fix pseudo-element quotes in ColorPicker (#5335)
* fix pseudo-element quotes in ColorPicker

* Update upcoming-release-notes/5335.md

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-07-16 10:53:19 -04:00
Michael Clark
f66baeabd3 Add command palette to shortcuts modal (#5334)
* add command bar to shortcuts modal

* release notes

* release note
2025-07-15 19:48:16 +01:00
Joshua Taillon
19180138bb Add keyboard shortcuts to duplicate transaction, edit amount, and edit date (#5330)
* add kb shortcuts for duplicate, edit date, and edit amount

* release notes

* only allow editing amount if we can't merge

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-14 21:37:47 +01:00
youngcw
7705a2df08 🐛 fix template priorities in the tracking budget when templating income (#5316) 2025-07-12 07:29:15 -07:00
Sai Pratyush Cherukuri
202af094af enhancement: add interval selector for net worth report (#5282)
* feat: add interval selector for net worth graph

* docs: add release notes

* chore: reformat code

* fix: resolve review comments

* Update VRT

* chore: dummy commit

* feat: handle intervals in net worth card

* fix: handle date ranges inclusively

* fix: enhance date formatting and normalise x-axis tick size

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Update VRT

* feat: move interval selector inline

* fix: change label to current interval

* Update VRT

* feat: header wrapping for networth, calendar, cashflow and summary

* Update VRT

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: youngcw <calebyoung94@gmail.com>
2025-07-11 12:28:34 -07:00
Margarida Reis
333e7ff7bc fix: apply context menu actions to all selected transactions and payees (#5269)
* fix: apply context menu actions to all selected transactions

when multiple transactions were selected and the user right-clicked on one transaction, context menu actions were only being applied to the right-clicked transaction instead of all selected transactions

* fix: apply context menu actions to all selected payees

when multiple payees were selected and the user right-clicked on one payee, context menu actions were only being applied to the right-clicked payee instead of all selected payees
2025-07-11 12:28:18 -07:00
Giorgio Grigolo
eb11e14e94 Added Bank of Valletta as a limited history bank (#5309) 2025-07-09 21:06:44 -04:00
youngcw
dbcfb63857 [Goals] limits for remainders (#5301)
* limits for remainders

* round if needed

* handle edge cases
2025-07-09 07:11:11 -07:00
youngcw
64f4d200dd Reword the overspending banner for tracking budget. (#5307)
* no hidden

* changes for tracking

* note and cleanup

* sentance case

* exclude income categories

* Update VRT

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-07-08 20:02:50 -07:00
Julian Dominguez-Schatz
4be7e03570 Fix a few typos mentioned on Weblate (#5211)
* Fix a few typos mentioned on Weblate

* Add release notes

* Update VRT

* Update VRT

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-07-08 21:05:00 -04:00
youngcw
ca969cc61b no hidden (#5305) 2025-07-08 10:29:19 -07:00
youngcw
682d439c34 [Goals] upgrade week template to be a periodic template (#5295)
* upgrade week template to periodic template

* note

* do it right

* tabs
2025-07-08 06:54:12 -07:00
youngcw
37d91a90f7 [Goals] Round template amounts if hide decimals is set (#5288)
* round amounts

* cleanup, handle not pref set

* move comment

* fix test

* bunny, add a test
2025-07-08 06:53:45 -07:00
Michael Clark
3a09d91399 :electron: Fix early server-started signification message (#5303)
* fix issue where server was telling parent process it was ready but was not finished listening

* release notes
2025-07-08 09:39:42 +01:00
POGMAN
405c8b986f Customize tags colors (#5032)
* add user defined tag colors

* use DB to store tag colors

* change specific tags_colors to generic tags

* move tag customization to its own page (pt. 1)

* move tag customization to its own page (pt. 2), edit description

* move tag customization to its own page (pt. 3), better default tag mgmt

* move tag customization to its own page (pt. 4), tag creation

* move tag customization to its own page (pt. 5), remove tags settings

* Update VRT

* nitpicking & code rabbit fixing

* remove spaces from tag and better partial Tag typing

* add tag similar to transaction add

* peer review updates (live preview)

* enable keyboard navigation

* fix lint errors

* live input for color picker

* disable 3 digit hex color live input

* add context menu

* add tags link to command bar

* Update VRT

* Update VRT

* fix lint issues

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: youngcw <calebyoung94@gmail.com>
2025-07-07 12:42:26 -07:00
Rapha149
bd9f0aec89 Run rules on transactions created by a transfer. (#5279)
* Run rules on transactions created by a transfer.

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-07 10:10:16 -07:00
spezzino
a4f0d5bca8 add notes to scheduled transactions table (#5290) 2025-07-07 10:10:01 -07:00
Michael Clark
0085c3b58a 💬 Added Discord link to the help menu for discoverability (#5286)
* adding our discord to the help menu so users can find community support

* better label

* derp

* release note

* derp
2025-07-04 21:48:02 +01:00
Ciftci
cfb0f51e36 Fixes #5278: Applied PrivacyFilter to balance graph display (and added conditionality whether user is hovering on the graph) (#5281)
* Apply PrivacyFilter to balance graph display

* Deleted empty line which was added by accident

* Added release note

* [autofix.ci] apply automated fixes

* isHovered state now conditionally deactivates PrivacyFilter if user hovers the graph

* [autofix.ci] apply automated fixes

---------

Co-authored-by: Seray Ciftci <seri@Mac.fritz.box>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-04 12:53:44 -07:00
Matt Fiddaman
2d95fe6d03 add some basic linting rules for translation consistency (#5212)
* lint rules

* trans rule

* migrate away from rulesDir config

* fixes

* prefer Trans to t()

* typechecker

* cleanup

* note

* typo

* extend regex to include punctuation

* extend fixer to handle imports

* autofixes from punctuation
2025-07-04 15:17:17 -04:00
Matiss Janis Aboltins
80bb4ab299 Update contributor points calculation logic (#5169) 2025-07-04 07:56:54 +01:00
Michael Süssemilch
2f71e007d6 feat(currency): add currency setting and format (#5167) 2025-07-04 07:56:23 +01:00
Julian Dominguez-Schatz
7b71374e79 Move remaining .d.ts files to .ts (#5208)
* Update CRDT protobuf generation to create a .ts file

* Move remaining .d.ts files to .ts

* Fix remaining type errors

* Ignore .d.ts files so we don't accidentally use them in the future

* Add release notes
2025-07-03 14:59:21 -04:00
Matt Fiddaman
c1d70722b8 use correct running balance when adding a new transaction (#5207) 2025-07-03 13:16:03 -04:00
POGMAN
2cd79960a9 Fix rule templating on date causing crash (#5259)
* fix rule templating on date causing crash

* apply coderabbit suggestion, more or less
2025-07-03 09:27:16 -07:00
Ciftci
9a6afda6de Fixes #5228 - has tag(s) filter now takes values when pressing Enter (#5263)
* Fixes #5228 - has tag(s) filter now takes values when typing quickly and pressing Enter

* Added release notes

* State of GenericInput now gets updated with every keystroke

---------

Co-authored-by: Seray Ciftci <seri@Mac.fritz.box>
2025-07-03 09:27:04 -07:00
lougeorge
979fa43c4a correctly ignore hidden categories when using "Set Average Budget" (#5239)
* fixed setAverage functions to ignore hidden categories

* Add logic to ignore hidden categories in budget actions

* Modify SQL statements in setAverage functions to also exclude categoryGroups and change DbViewCategory type definition to include hidden flag of the group a category belongs to

* [autofix.ci] apply automated fixes

* Revert setZero functionality to set all budget categories and category groups to zero, including hidden ones

* Add new type DbViewCategoryWithGroupHidden which includes a flag for whether the group a category belongs to is hidden or not, and have setAvg functions use that type instead

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-03 09:26:47 -07:00
youngcw
a20805bfae Mobile running balance (#5219)
* start

* small fix

* clean

* working for regular transactions

* working for schedules

* cleanup

* typing

* cleanup

* cleanup

* vrt

* bunny

* use pref

* use pref right, lint

* more lint

* vrt

* pass hasInitialBalances to isLoading

* remove comment

* Add option to calculate running balances in useTransactions hook

* Fix typecheck error

* Fix lint error

* use the updated hook

* typecheck

* simplify

* don't show balances when searching

* Add runningBalances to usePreviewTransactions and an option to set the starting balance to start running balance calculation from

* Add filter to usePreviewTransactions and set startingBalance to account and category preview transaction hooks

* use runningbalance from preview transactions hook

* lint

* lint;typecheck

* remove initial from preview balances

* remove unneeded type

* Apply suggestions from code review

Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>

* typecheck; align right; change color

* types

* add a menu item

* cleanup

* fix for loot-core migrated files

* lint;type

* fix import

* only schedules need fixed

* lint

* it works

* cleanup

* make lint happy

* [autofix.ci] apply automated fixes

* simplify a bit

* fix import

* feedback

* fixed regular transaction balance calculation

* fix numbers not showing

* fix schedule running balance

* note

* attempt to update properly

* type

* remove the useEffect that I don't think should be requred

* remove old note

* cleanup

* typeing

* I FINALLY FOUND THE PROBLEM

* cleaner balance calculation

* fixes

* fix zeros

---------

Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-03 09:26:28 -07:00
github-actions[bot]
485830c859 🔖 (25.7.1) (#5272)
* 🔖 (25.7.1)

* build

* Remove used release notes

---------

Co-authored-by: youngcw <28542559+youngcw@users.noreply.github.com>
Co-authored-by: youngcw <calebyoung94@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-07-02 17:07:15 -07:00
youngcw
4aea6f4898 fix (#5270) 2025-07-02 12:07:49 -07:00
github-actions[bot]
1f828b6562 🔖 (25.7.0) (#5260)
* 🔖 (25.7.0)

* Empty commit to bump ci

* Remove used release notes

* Empty commit to bump CI

---------

Co-authored-by: jfdoming <9922514+jfdoming@users.noreply.github.com>
Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-07-01 14:35:37 -04:00
Mauritz Schild
ad9a84ddf1 Fixes #5238 last synced button text not visible on light theme. (#5241)
* Changed the buttonMenuText color for the light theme so that text is visible on light background as well.

* Updated the release notes.

* Change file name of release notes

* Remove button varient from use last synced total and restore light theme
values to previous.
2025-06-30 07:40:12 -07:00
Matiss Janis Aboltins
d9a171b249 fix: Tracking budget income budget fields missing in mobile view (#5251) 2025-06-29 18:51:04 +01:00
Matiss Janis Aboltins
e5c84d4ae0 Fix switching budget type requiring hard reload to take effect (#5253)
Fixes #5252
2025-06-29 17:43:32 +01:00
An Hoang
94a76a008d fix: reapply thousand separators before passing input to appendDecimals (#5220)
* fix: reapply thousand separators before passing input to appendDecimals

This ensures that the input going into `appendDecimals` is not malformed when the  `hideFraction` option is On, otherwise when hitting delete on the text `"1,234,567"`, it will result in the text `"1,234,56"` which the formatter will parse as `1234.56`. This doesn't happen when `hideFraction` is off since hitting delete on the text `"12,345.67"` results in `"12,345.6"`, which `appendDecimals` will happily handle in a separate case to provide `"1234.56"` as the input into `currencyToAmount`.

* Handle edge cases for reapplyThousandSeparators

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* [autofix.ci] apply automated fixes

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: youngcw <calebyoung94@gmail.com>
2025-06-28 12:49:30 -07:00
Matiss Janis Aboltins
432c2b6165 Patch mobile issues - hold for next month, transfer (#5245) 2025-06-28 14:37:38 +01:00
0x4d4e
46eb2a7c38 Added a gocardless bank parser for Raiffeisen AT bank (#5244)
* Added a gocardless bank parser for Raiffeisen AT bank

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-06-28 09:13:45 -04:00
Jeevan Shikaram
3214d5dd53 Update links pointing to /budgeting/users/. (#5246)
* Update links pointing to /budgeting/users/.

* Add release notes.
2025-06-28 00:27:27 -04:00
youngcw
66d8f1a631 Speed up balance history graph (#5229)
* speedy

* bunny, fill in missing data

* small cleanup

* Update packages/desktop-client/src/components/sidebar/BalanceHistoryGraph.tsx

Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>

* handle some edge cases, fix the month check

* better date formatting

* one more edge case

* fix

---------

Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
2025-06-27 12:59:32 -07:00
youngcw
e3aa63d1fa don't import deleted split lines ynab4 (#5226)
* don't import deleted split lines

* Update upcoming-release-notes/5226.md

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-23 14:28:24 -07:00
Michael Clark
9478707ebb Prevent forks from running nightly worfkflows (#5213)
* dont run nightly worfkflow on forks

* dont run nightly worfkflow on forks

* release notes
2025-06-21 19:04:24 +01:00
Matt Fiddaman
9952412e1d [WIP] 🌍 Mark more files for translation (#5209)
* translate more files

* prefer Trans component in JSX where possible

* note

* [autofix.ci] apply automated fixes

* aria-label

* more...

* [autofix.ci] apply automated fixes

* review

* [autofix.ci] apply automated fixes

* more review

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-06-21 02:11:49 -04:00
Matt Fiddaman
8231bbbf5a 🌍 mark titlebar strings for translation (#5206)
* translate title bar

* note

* Update VRT

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-06-21 01:45:20 -04:00
Julian Dominguez-Schatz
eadd88ce31 Move more .d.ts files to .ts (#5204)
* Rename .d.ts files to .ts

* Fix type and lint errors

* Add release notes

* CodeRabbit feedback
2025-06-21 00:16:55 -04:00
youngcw
6c61cf6a8d Revert "Mobile running balance (#4809)" (#5205)
This reverts commit 2c87c44168.
2025-06-20 20:37:24 -07:00
Matt Fiddaman
0fb9c252ca improve compatibility with OFX/QFX files (#5203)
* support ofx files with space in opening tag

* note
2025-06-20 22:21:32 -04:00
Guillaume Taquet Gasperini
d73ead135e Improve Boursobank Gocardless transaction parsing (#5202)
* Fix Boursobank transfer parsing

As per the comments on https://github.com/actualbudget/actual/pull/4958#issuecomment-2988814739,
the Boursobank transfer parsing was not working correctly.

Indeed, the array returned by GoCardless for transfers is randomly
ordered. So we cannot rely on the first line to know its type.

To work around this, the code gets a bit more complex by:
- Checking the first line for known types (card, loan, atm withdrawal)
  and handling them accordingly.
- If it's not one of these, we iterate through all the lines by checking
  if the array contains a line with the transfer type.

* Add credit note type for BoursoBank

An `Avoir` is a refund made to the credit card.
Adds the proper payee / notes parsing for it.

* Improve Boursobank card transaction parsing

Some Boursobank transactions have an unknown number attached to the
payee name. Remove it from the payee name to ensure consistency across
transactions.

For instance, `CARTE 19/03/25 Github 4 CB*0494` (notice the `4`).

* Improve Boursobank payee name backslashes handling

After more testing, I found that the backslashes present are for the
pending transactions, and indicating the localization of the payment.

To keep the payee name consistent, remove what follows the backslashes.

For instance `PICARD SA 1234\\PARIS\\ FR` is for a pending transaction
whereas `PICARD SA 1234` is what we receive for a completed one.

* Set notes with date for Boursobank card transactions

@mistyque requested to see the data of the card transaction in this
comment: https://github.com/actualbudget/actual/pull/4958#issuecomment-2981459622

* Add 5202 release note

* [autofix.ci] apply automated fixes

* refactor loops and match

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-20 19:48:22 -04:00
youngcw
2c87c44168 Mobile running balance (#4809)
* start

* small fix

* clean

* working for regular transactions

* working for schedules

* cleanup

* typing

* cleanup

* cleanup

* vrt

* bunny

* use pref

* use pref right, lint

* more lint

* vrt

* pass hasInitialBalances to isLoading

* remove comment

* Add option to calculate running balances in useTransactions hook

* Fix typecheck error

* Fix lint error

* use the updated hook

* typecheck

* simplify

* don't show balances when searching

* Add runningBalances to usePreviewTransactions and an option to set the starting balance to start running balance calculation from

* Add filter to usePreviewTransactions and set startingBalance to account and category preview transaction hooks

* use runningbalance from preview transactions hook

* lint

* lint;typecheck

* remove initial from preview balances

* remove unneeded type

* Apply suggestions from code review

Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>

* typecheck; align right; change color

* types

* add a menu item

* cleanup

* fix for loot-core migrated files

* lint;type

* fix import

* only schedules need fixed

* lint

* it works

* cleanup

* make lint happy

* [autofix.ci] apply automated fixes

* simplify a bit

* fix import

* feedback

---------

Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-06-19 17:54:00 -07:00
lelemm
15beba2ca3 🐛 Fix to AI generated release note (#5200)
* AI Generated release notes

* lint

* removedverbose console.log

* wrong permission to PR's

* missing write to issues

* Add release notes for PR #5200

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-06-19 20:46:22 -03:00
Matt Fiddaman
667cc24fac ⬆️ bump react-i18next from 14.1.3 -> 15.5.3 (#5196)
* bump react-i18next from 14.1.3 -> 15.5.3

* note
2025-06-19 19:17:20 -04:00
Matt Fiddaman
4cc542a658 ⬆️ bump csv-parse and csv-stringify to latest (#5198)
* bump csv-parse and csv-stringify

* note

* fix imports

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-06-19 19:17:10 -04:00
lelemm
093d799ba0 Auto generate Release Notes (#5182)
* AI Generated release notes

* lint

* removedverbose console.log
2025-06-19 17:22:44 -03:00
Matt Fiddaman
68d10f6b29 ⬆️ bump vitest from 3.1.4 -> 3.2.4 (#5195)
* bump vitest from 3.1.4 -> 3.2.4

* note
2025-06-19 15:30:25 -04:00
Matt Fiddaman
252f04e02c ♻️ remove body-parser dependency (#5197)
* bodyParser

* note
2025-06-19 15:30:12 -04:00
wachkyri
13cb85835b fix: wrong payeeName for KBC Brussels (#5193) 2025-06-18 20:49:24 -04:00
wachkyri
39cf04c74d add Belfius and KBC to banks with limited history (#5183)
* add Belfius and KBC to banks with limited history

* Update upcoming-release-notes/5183.md

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-18 16:40:07 -04:00
Jeremy Tan
562b5e2afd [Feature] Store and use last synced account balances (#4799)
* Update `processBankSyncDownload` to store synced balance in `balance_current`

* Display last synced balance in `MoreBalances`

* Add "Use last synced balance" to reconcile

* Remove logs

* Release notes

* Fix lint

* Add missing useEffect dep

* Restore console.log and fix type for id

* Last synced total

* Fix lint

* lint

* Made requested changes from maintainers.

* Added my name to authors note and updated description of feature.

---------

Co-authored-by: Spencer Sawyer <spencer@spencersawyer.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: youngcw <calebyoung94@gmail.com>
2025-06-18 14:51:43 -04:00
Tim Nielens
4b4e32d0e2 add BNP_BE_GEBABEBB in gocardless bank-factory.js (#5187)
* add BNP_BE_GEBABEBB in gocardless bank-factory.js

* Create release note 5187.md

* Update 5187.md
2025-06-18 14:50:11 -04:00
Matt Farrell
d821f1cebc fix parsing schedule templates with brackets in the name (#5189) 2025-06-18 11:38:17 -07:00
Joel Jeremy Marquez
53e3694a38 Move spreadsheet bindings to spreadsheets feature folder and move hooks in src/components/spreadsheets to src/hooks (#5007)
* Move loot-core/client/modals code over to desktop-client package

* Fix lint error

* Move loot-core/client/data-hooks over to desktop-client package

* Fix typecheck and lint errors

* Fix lint error

* Fix typecheck error

* Fix test

* Move spreadsheet bindings to spreadsheets feature folder and move hooks from src/components/spreadsheets to src/hooks

* Move NamespaceContext to useSheetName

* Rename NamespaceContext to SheetNameContext and use SheetNameProvider

* Fix lint errors

* Fix import and provider

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-06-17 14:34:00 -07:00
Michael Clark
8647452ccc 🔧 Add reset passsword to cli tool (#5185)
* add reset passsword to cli tool

* release notes

* added the script properly
2025-06-17 22:05:45 +01:00
Julian Dominguez-Schatz
5a40b017f0 Move more .d.ts files to .ts (#5060)
* Move more .d.ts files to .ts

* Add release notes

* Some errors with templates snuck in

* Fix API build

* CodeRabbit feedback

* Move budget templates to new directory

* Fix type errors in library module
2025-06-16 21:05:36 -04:00
Matiss Janis Aboltins
8ccc1af77e Clean up configuration files (#5181) 2025-06-16 22:22:38 +01:00
Matiss Janis Aboltins
07904c209e Enhance PullToRefresh component to ensure full height usage on mobile devices (#5179) 2025-06-16 21:30:52 +01:00
Matiss Janis Aboltins
234f008dcf Update feature request management message to clarify voting system and community contributions (#5180) 2025-06-16 20:07:49 +01:00
Matiss Janis Aboltins
d130b427b3 Upgrade react router to v7 (#5172) 2025-06-16 18:23:26 +01:00
Matiss Janis Aboltins
39cd71aa48 Fix: display notifications below modal windows (#5165) 2025-06-15 16:44:03 +01:00
Matiss Janis Aboltins
100711ccfb Fix bottom navbar overlaying content in mobile (#5166) 2025-06-14 20:55:14 +01:00
Matiss Janis Aboltins
7c9f3f241d Added unit tests for CategorySelector and Change components (#5118) 2025-06-14 15:54:13 +01:00
Matiss Janis Aboltins
6509e80061 Update version notification message for Pikapods instances (#5146) 2025-06-14 14:54:46 +01:00
Matiss Janis Aboltins
fbd6989a18 Add GitHub workflow and script for counting monthly contributor points (#5147) 2025-06-14 13:18:40 +01:00
Rob Jackson
180431f9ed Fix account properties being overriden with empty values from metadata (#5115)
My Monzo bank appears to return 'name' through the GoCardless getDetails and getMetadata calls, but the value in the getMetadata response is an empty string! Merging metadata values over detail values therefore risks losing values, that are useful to have & to present to the user.

To solve this, we can make getDetailedAccount smarter about merging the two objects. We could swap the object splattening around so details has priority over metadata, but I'm not at all confident there won't be other banks doing strange things with additional properties that might suffer similar bugs in the reverse scenario.

Instead, we loop through all keys in both objects and construct a new merged object, continuing to prioritise metadata over details but changing it to a truthy-based comparison (with the `||` operator).

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-14 08:03:59 -04:00
Matiss Janis Aboltins
d27d62b5fc Add GitHub Actions workflow for automatic code formatting (#5157) 2025-06-14 11:34:08 +01:00
Matiss Janis Aboltins
b5f29ccb4a show account historical balance change in side-nav hover tooltip (#5085) 2025-06-13 20:07:16 +01:00
Matt Fiddaman
0a5acebeaf use fallback linking parameters if initial GoCardless linking process fails (#5150) 2025-06-13 12:19:59 -04:00
Leandro Menezes
fa544d9c08 removed wrong md from master 2025-06-13 12:41:01 -03:00
github-actions[bot]
8976a59c3a Add release notes for PR #5155 2025-06-13 12:34:15 -03:00
Elijah Olmos
9713d09603 feat: add command bar (#5076)
* deps(desktop-client): add cmdk

* feat(desktop-client): create and integrate CommandBar

* hover on selection

* Ctrl+K only opens, ESC closes

* add custom reports

* add navigation items to cmdk

* fix: mouse hovering can interfere with keyboard navigation

* reset search state when CommandBar closes

* revert import order changes

* deps(desktop-client): readd cmdk

* fix vite error

* add item icons

* move navigation items into their own section

* hide scrollbar and release notes

* style: run yarn lint:fix

* fix: infinite loop opening commandbar with active modal

* fix: infinite error loop bc focus conflicts

* fix: kebab case console warning

* chore: update yarn.lock

* refactor: use autoFocus prop

* feat: add i18next

* style: relocate eslint-disable comment
2025-06-13 09:41:16 +01:00
youngcw
814f4fe955 release context menus (#5142) 2025-06-11 14:59:24 -07:00
Michael Clark
dbe6b27d9f :octocat: Prevent nightly npm packages publishing on push (#5144)
* prevent nightly npm packages publishing on push

* release ntoes

* Update upcoming-release-notes/5144.md

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-11 22:54:18 +01:00
Michael Clark
31a7902a08 :octocat: Add workflow for publishing nightly npm packages (#5047)
* add workflow for publishing edge npm packages

* release notes

* alright mr rabbit

* never trust the wabbit

* changing tag to nightly as per maintainer feedback

* fix hotfix script version

* rename workflow

* wabbit

* exit process

* fix reference to package json

* variable scoping

* change nightly version number to yyyymmdd (#17)

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-11 21:37:54 +01:00
Matt Fiddaman
eb35b41c6d fix preview transactions not showing on multi-account views (#5135) 2025-06-11 10:46:40 -04:00
Danish Joseph
a025d2b621 fix: bottom UI overlap with iOS Home Indicator (#5121) 2025-06-11 09:08:01 +01:00
Olicorne
d72140b8b6 add LCL to the list of bank with only 90 days of sync (#5087)
* add LCL to the list of bank with only 90 days of sync

Signed-off-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>

* add missing release note

Signed-off-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>

* Update upcoming-release-notes/5087.md

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Signed-off-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-10 14:04:46 -04:00
Olivier Kamers
254059d4c8 fix: ensure correct PR number is used for release notes file (#5134) 2025-06-10 11:25:09 -04:00
Olivier Kamers
92bc1e8ec9 fix: add missing 'enabled' in sentence. (#5133) 2025-06-10 12:59:40 +01:00
Matiss Janis Aboltins
b211b67f5e Fix: Only sync off-budget accounts when syncing from off-budget page (#5124) 2025-06-08 19:30:06 +01:00
Olivier Kamers
a2abb2b2ae Fix net worth graph gradient conflict (#5129)
* Fix net worth graph gradient conflict

Ensures that the net worth graph's gradient ID is unique to prevent conflicts when multiple graphs are rendered on the same page.
Fixes #3965

* Apply review suggestion
2025-06-08 14:03:59 -04:00
Olivier Kamers
3fab1be737 chore: replace snapshot-diff and jest with jest-diff (#5127)
Unlike the name suggests, jest-diff does not have a dependency on jest.
2025-06-08 14:00:33 -04:00
youngcw
bf9fbc5137 🐛 fix goal type templates (#5120)
* fix

* note

* fix test
2025-06-08 07:38:06 -07:00
youngcw
52eced1f21 🐛 group template apply (#5112)
* fix

* Update upcoming-release-notes/5112.md

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-08 07:36:54 -07:00
Michael Clark
359af05cc4 🐳 Fix nightly Docker edge image (#5123)
* fix nightly docker edge test

* release notes
2025-06-07 15:54:52 +01:00
Matt Fiddaman
9f1a8f6d5c ⬆️ upgrade uuid from 9.0.1 -> 11.1.0 (#5048) 2025-06-07 01:02:35 -04:00
Matiss Janis Aboltins
b22d712b4f fix: add missing dependency array to useEffect in SaveReportChoose.tsx (#5044) (#5111) 2025-06-06 18:51:11 +01:00
Michael Clark
098cacd904 :electron: Guide user to the docs on the electron configure server page (#5107)
* add link to docs on configure server page

* release note

* release note

* bump

* Update VRT

* huh

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-06-06 10:48:01 +01:00
Matiss Janis Aboltins
127f114914 🔧 improving the needs-info stale issue management (#5110) 2025-06-05 23:08:51 +01:00
Matiss Janis Aboltins
b56e26ee56 🔧 auto close issues with inaactivity and 'needs info' label (#5109) 2025-06-05 22:45:20 +01:00
Matiss Janis Aboltins
cd6b141117 🔧 (eslint) patch no-restriced-imports rule (#5081) 2025-06-05 19:59:51 +01:00
Roger Goldfinger
cd15aded05 Add test that docker images are working (#4952)
* use build directory in dockerfiles

* add release notes

* add test

* Add test for cli, try to fix image test

* - fail

* try again

* try again to fail

* done testing

* Code review

* publish is unecessary
2025-06-05 10:31:56 -04:00
Baruch Odem (Rothkoff)
cac318255d [Proposal] Enhance transaction import functionality with new Transaction type and type annotations (#4720)
* Enhance transaction import functionality with new Transaction type and type annotations

* release notes

* fixes for PR

* move transaction type as requested by @MatissJanis

* type importTransaction return value

---------

Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
2025-06-05 10:31:29 -04:00
dependabot[bot]
6872dd235b bump tar-fs from 2.1.2 to 2.1.3 (#5084)
* Bump tar-fs from 2.1.2 to 2.1.3

Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.2 to 2.1.3.
- [Commits](https://github.com/mafintosh/tar-fs/commits)

---
updated-dependencies:
- dependency-name: tar-fs
  dependency-version: 2.1.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* note

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-05 10:30:09 -04:00
Will Garrison
649932b42f [bugfix] Include split transactions in select-all (#5086)
* Include parent transactions in select-all when all of their children are selected

* Added release notes

* Fix release notes file name

* Make function return type explicit
2025-06-05 10:29:54 -04:00
Albert Pedersen
d372b71f36 Trim EndToEndID from the Danish Danske Bank branch (#5101)
* Trim EndToEndID from the Danish Danske Bank

* Add release note for PR #5101

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-05 10:29:45 -04:00
youngcw
47cb5e1ecf Add ability to auto hold funds for future months (#4778)
* add spreadsheet logic

* separate to own cell

* add selection cell

* fix selection

* added button

* arrow

* switches between the two hold options gracefully

* reset manual hold on apply auto hold

* working?

* fix

* lint

* better to budget menu logic

* type

* typing

* missing function pass

* some cleanup

* typecheck

* translation

* closer to good arrow

* lint

* prevent rollover arrow from clipping

* move to a menu; position is broken

* lint

* fix location

* lint

* standardize verbage

* right case

* fix import

* cleanup

* start of a mobile menu

* slightly better

* some cleanup

* lint

* Update packages/desktop-client/src/components/modals/EnvelopeIncomeBalanceMenuModal.tsx

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

* fix styling

* types

* Update packages/desktop-client/src/components/budget/envelope/BalanceMenu.tsx

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

* Apply suggestions from code review

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-05 06:04:14 -07:00
github-actions[bot]
02c59d9a1c 🔖 (25.6.1) (#5099)
* 🔖 (25.6.1)

* Remove used release notes

---------

Co-authored-by: matt-fidd <81489167+matt-fidd@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-06-04 18:13:40 -04:00
Matt Fiddaman
f9f6917fcd update dockerfiles to use node 20 (#5091)
* update dockerfiles to use node 20

* note
2025-06-04 13:31:45 -04:00
Michael Clark
7441b5fa92 🐛 Fix server version on docker (#5093)
* fix server version on docker

* bit more safety

* fix lint

* release notes

* more error handling
2025-06-04 13:31:37 -04:00
Matt Fiddaman
bfb2d61286 fix crash when datepicker deselected with no date set (#5095)
* fix crash when datepicker not set

* note
2025-06-04 13:31:29 -04:00
github-actions[bot]
09b12b8218 🔖 (25.6.0) (#5083)
* 🔖 (25.6.0)

* Empty commit to bump CI

* Remove used release notes

* Empty commit to bump CI

---------

Co-authored-by: jfdoming <9922514+jfdoming@users.noreply.github.com>
Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-06-04 00:35:34 -04:00
Matiss Janis Aboltins
1c46655e30 🐛 (mobile) fix - show loading indicator if schedules not yet loaded (#5080) 2025-06-02 22:24:06 +01:00
dependabot[bot]
82329b7de2 Bump formidable from 2.1.2 to 2.1.5 (#5075)
* Bump formidable from 2.1.2 to 2.1.5

Bumps [formidable](https://github.com/node-formidable/formidable) from 2.1.2 to 2.1.5.
- [Release notes](https://github.com/node-formidable/formidable/releases)
- [Changelog](https://github.com/node-formidable/formidable/blob/master/CHANGELOG.md)
- [Commits](https://github.com/node-formidable/formidable/commits)

---
updated-dependencies:
- dependency-name: formidable
  dependency-version: 2.1.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* note

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-01 19:54:47 -04:00
Shimikito
a34c94d9fe Add ING PL (ING_PL_INGBPLPW) to banks with limited history (#5073)
* Update bank-factory.js 90 days bank history

Add ING PL (ING_PL_INGBPLPW) to banks with limited history

* Adding a bank with limited history - alphabetical fix

adding alphabetical sorting

* note

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-06-01 19:49:08 -04:00
Normen
ae6eed65f7 Add 'GLS Gemeinschaftsbank' to banks with limited history (#5052)
* chore: add GLS_GEMEINSCHAFTSBANK_GENODEM1GLS to BANKS_WITH_LIMITED_HISTORY

* chore: add release note
2025-06-01 19:48:14 -04:00
Matiss Janis Aboltins
53398624f3 🔧 added needs-triage label to all new bug issues (#5070) 2025-05-30 21:57:16 +01:00
Valentin Lorenzen
47ee6eeb51 enable GoCardless account selection if supported by the target institution (#5031)
* Update gocardless-service.js

* Allow account selection during requisition based on institution support

* lint

* note

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-05-27 16:32:25 -04:00
Michael Süssemilch
6e3a337945 fix: save category expansion state when value is 0 (#5069) 2025-05-27 12:33:37 -07:00
Shreyas
d2d8ce2353 Fix: restrict electron-embedded sync server to bind only to configured hostname for security (#5050)
* comment sync server

* Fix: ensure electron-embedded sync server binds to localhost to limit access

* lint and release notes

* rename

* remove hostname config and revert docker yaml
2025-05-27 16:57:06 +01:00
Johnn27
7d38f6934d 🐛 Fix goals tooltip obstructing cover spending context menu (#5051)
* 🐛 Fix goals tooltip obstructing cover spending context menu

* Update release note

* Fix lint format

---------

Co-authored-by: Johnn27 <>
2025-05-24 09:23:34 -07:00
Matt Fiddaman
d4b09ecb27 fix "delete x users" translation string (#5045) 2025-05-22 20:18:47 -04:00
Matt Fiddaman
a508a8705c ⬆️ upgrade express from 4.21.2 -> 5.1.0 (#5042)
* upgrade express from 4.21.2 -> 5.1.0

* fix tests

* note

* fix wildcard route

* fix access of req.body when undefined
2025-05-22 16:21:57 -04:00
Matt Fiddaman
f3b2507516 ⬆️ upgrade date-fns from v2.30.0 -> v4.1.0 (#5041) 2025-05-22 14:37:55 -04:00
Joel Jeremy Marquez
583ddab2ac Use @desktop-client alias in all of desktop-client package (#4960)
* Use @desktop-client alias in all of desktop-client package

* Run yarn lint:fix
2025-05-22 09:01:05 -07:00
Joel Jeremy Marquez
1876ba9fe7 Update @actual-app/components/input to be based on react-aria-components Input component (#4955)
* Update @actual-app/components/input to use react-aria-components Input component

* Cleanup

* Dummy commit

* Remove marginRight being magically added by Stack component

* Update 4955.md

* Update selection background color to match current color

* Update selection background color

* Dummy commit

* Fix ConfigServer styles

* Fix lint error

* re-add accidentally removed placeholder fix

* vrt

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-05-21 22:48:05 -07:00
Matt Fiddaman
4c15647f7f ⬆️ upgrade low risk dependencies to their newest minor version (#5025)
* vitest

* types

* eslint

* better-sqlite3

* pluggy-sdk

* globals

* google-protobuf

* fast-check

* chokidar

* i18next

* openid-client

* playwright

* lru-cache

* memfs

* redacted font

* sass

* @vitejs/plugin-basic-ssl

* re-resizable

* rollup-plugin-visualizer

* note

* update vrt screenshots

* vrt
2025-05-21 16:56:07 -04:00
Joel Jeremy Marquez
174e13b3fe Fix category schedule indicators not showing up in budget page (#5036)
* Fix category schedule indicators not showing up in budget page

* Update release notes
2025-05-21 09:30:36 -07:00
Stein Petter Tokvam
2e9a752baa if BankSyncError is caused by rate limit. display that in toast (#5038)
* if BankSyncError is caused by rate limit. display that in toast

* ran prettier
2025-05-21 12:08:22 -04:00
Joel Jeremy Marquez
83f6706020 Add types to budget template files and some cleanup (#4986)
* Add types to budget template files and some cleanup

* Rename test context

* Rename test name

* Rename goal-template to match other files

* Update imports

* Fix lint and typecheck errors

* Release notes

* Update release notes

* Rename templateContext

* Revert rename

* Redo rename

* Fix renamed file

* Fix null error

* Missed to ignore hidden categories

* Revert to forEach

* Fix priorities

* Update 4986.md

* Revert deleted file

* Coderabbit feedback
2025-05-21 08:54:38 -07:00
Matt Fiddaman
4dba95842a ⬆️ upgrade react dependencies to their newest minor version (#5027) 2025-05-20 13:46:20 -04:00
Matt Fiddaman
af499c6503 ⬆️ upgrade babel/webpack dependencies to their newest minor version (#5028) 2025-05-20 13:45:45 -04:00
Julian Dominguez-Schatz
913a2c9a68 Automatically upload to the MS store on release (#5034)
* Update electron-master GitHub action to also submit to the MS store

* Add release notes
2025-05-19 23:23:46 -04:00
Matt Fiddaman
a4b0c4a0be ⬆️ upgrade electron dependencies to their newest minor version (#5029) 2025-05-19 17:34:12 -04:00
Jared Tweed
32a04cbbcb Changed 'close file' to say 'switch file' so it is more clear that the … (#4872)
* Changed 'close file' to say 'exit file' so it is more clear that the file is not being deleted (#4852)

Resolved this issue here:

https://github.com/actualbudget/actual/issues/4852#issue-3006813465

* chore(release): add release note for PR #4872

* Update BudgetName.tsx "Close file" -> "Switch file"

* Update 4872.md

* Changed 'Close budget' to 'Switch file' on mobile

* Update VRT

---------

Co-authored-by: youngcw <calebyoung94@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-05-19 10:29:47 -04:00
Matt Fiddaman
e950bbb1df resolve loot-core peer dependency warnings (#5024)
* fix loot-core peer dependency issues

* note

* update @swc/core
2025-05-18 19:37:22 -04:00
Matt Fiddaman
188cd21cf1 ⬆️ bump adm zip to 0.5.16 (#5019)
* bump adm-zip to 0.5.16

* note

* move to native yarn patch
2025-05-18 18:29:56 -04:00
Matt Fiddaman
f7a45d2081 ⬆️ bump dependency patch versions (#5015)
* bump dependency patch versions

* note

* remove unused ts-expect-error directives

* downgrade adm-zip again
2025-05-18 16:50:32 -04:00
Matt Fiddaman
99768a9aae ⬆️ upgrade yarn from v4.7.0 to v4.9.1 (#5014)
* upgrade yarn from v4.7.0 to v4.9.1

* note
2025-05-18 14:22:37 -04:00
Matt Fiddaman
7dbb3404f1 ⬆️ bump jq (#5018)
* bump jq

* note
2025-05-18 14:22:33 -04:00
Matt Fiddaman
ca09bbb858 remove dependency on ip (#5017)
* remove transitive dependency on ip

* note
2025-05-18 14:22:18 -04:00
Roger Goldfinger
0dca8498fe Set yarn engine version (#5011)
* Set yarn engine version

* release notes

* more precise version
2025-05-18 00:34:01 -04:00
Joel Jeremy Marquez
b5ece8e221 Make InitialFocus component generic (#5008)
* Make InitialFocus component generic

* Fix lint error
2025-05-16 15:02:06 -07:00
Samuel Barnes
351e252129 Allow-return-to-trigger-default-actions (#4912)
* button being focused

* working

* tests

* text selection test

* allow for ref injection

* updated some of the usages

* release notes

* rename of prop

* docs

* fixed release note

* remove unnecessary test setup

* updated from comments

* removed selecttext references

* fix type error

* updated children type

* removed comment
2025-05-16 12:28:31 -07:00
Joel Jeremy Marquez
720d0fda6d [Final PR] Move remaining loot-core/client files to desktop-client feature folders (#4830)
* Move loot-core/client/modals code over to desktop-client package

* Fix lint error

* Move loot-core/client/data-hooks over to desktop-client package

* Fix typecheck and lint errors

* Fix lint error

* [Final PR] Move remaining loot-core/client files to desktop-client feature folders

* Fix tests

* Clear server on each run

* Fix lint errors

* Fix imports

* Fix typecheck error

* Fix lint errors

* Fix typecheck error

* Fix test

* Fix tests - unsubscribe test pending fix

* Fix lint errors

* Fix typecheck error

* Fix lint error

* Fix tests

* Fix lint error
2025-05-16 10:42:06 -07:00
Joel Jeremy Marquez
fdf213865d Move loot-core/client/data-hooks over to desktop-client package (#4828)
* Move loot-core/client/modals code over to desktop-client package

* Fix lint error

* Move loot-core/client/data-hooks over to desktop-client package

* Fix lint errors

* Fix typecheck error

* Fix typecheck and lint errors

* Fix typecheck error

* Fix lint error
2025-05-16 08:53:59 -07:00
Alec Bakholdin
b2ffa1d846 [WIP] Qif empty lines (#5002)
* fixed qif failing with empty lines

* release notes

---------

Co-authored-by: Alec Bakholdin <alecbakholdin@Alecs-Mac.local>
2025-05-16 11:45:46 -04:00
Alec Bakholdin
21fb090ddf ⚙️ Moving TransactionsTable and TransactionList over to Typescript (#4930)
* moved over some util functions

* moved over TransactionHeader

* Added the bulk of Transaction typing data

* moved PayeeCell into its own file

* moved StatusCell over

* added NotesCell file

* Moved over NewTransaction

* converted TransactionsTable

* Converted TransactionList to use new typed TransactionsTable

* Converted consumers of TransactionList to use TransactionList

* removed old TransactionsTable

* release notes

* fixed bug vrt found

* fixed one todo

* attempting to debug whatever is going on

* moved TransactionsTable tests up a directory and that fixes it for some reason

* removed type cast

* re-instated onScheduleAction types

* re-added old TransactionsTable.jsx file

* consolidated changes into just TransactionsTable

* deleted split files and finished moving over TransactionList

* typecheck

* typecheck

* yarn lint

* changed type casting to make it more specific

* changed warn to error

* added some todos to clean up type assumptions later

* yarn lint

---------

Co-authored-by: Alec Bakholdin <alecbakholdin@mac.myfiosgateway.com>
Co-authored-by: Alec Bakholdin <alecbakholdin@Alecs-Mac.local>
2025-05-16 06:15:07 -04:00
Joel Jeremy Marquez
c389c6c637 Move loot-core/client/store and loot-core/client/redux code over to desktop-client package (#4827)
* Move loot-core/client/modals code over to desktop-client package

* Fix lint error

* Move loot-core/client/store and loot-core/client/redux to desktop-client package

* Separate redux store into it's own file

* Import types from redux/store instead of redux
2025-05-15 13:09:10 -07:00
Joel Jeremy Marquez
7bb6aff756 Move loot-core/client/users code over to desktop-client package (#4823)
* Move loot-core/client/modals code over to desktop-client package

* Fix lint error

* Move loot-core/client/users code over to desktop-client package

* Fix lint errors
2025-05-15 12:45:20 -07:00
Joel Jeremy Marquez
3f4ddfdfe0 [Mobile] Fix category transactions screen not showing child transactions (#4998) 2025-05-15 11:38:50 -07:00
Joel Jeremy Marquez
7dd98c4f86 Add runningBalances to usePreviewTransactions and an option to set the starting balance to start running balance calculation from (#4994)
* Add runningBalances to usePreviewTransactions and an option to set the starting balance to start running balance calculation from

* Add filter to usePreviewTransactions and set startingBalance to account and category preview transaction hooks
2025-05-15 11:31:38 -07:00
Michael Clark
f3fc4b8d22 Remove duplicate import (#4997) 2025-05-15 19:22:31 +01:00
Joel Jeremy Marquez
644e8df3e1 Move loot-core/client/queries code over to desktop-client package (#4822)
* Move loot-core/client/modals code over to desktop-client package

* Fix lint error

* Move loot-core/client/queries code over to desktop-client package
2025-05-15 11:10:19 -07:00
Joel Jeremy Marquez
9dfbefa1d2 Fix prefsSlice import (#4995) 2025-05-15 11:09:54 -07:00
Michael Clark
516977f666 Fix pipeline build (#4996) 2025-05-15 19:06:59 +01:00
Michael Clark
70362f6801 :electron: Server config ui (#4870)
* server config ui 

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-05-15 18:52:46 +01:00
Eetu Mäenpää
d225e5d5e1 Update react-spring to v10.0.0 (#4992)
* feat: update react-spring to v10.0.0

* docs: add release notes
2025-05-15 11:34:40 -04:00
Joel Jeremy Marquez
ae00fa2841 Move loot-core/client/prefs code over to desktop-client package (#4821)
* Move loot-core/client/modals code over to desktop-client package

* Fix lint error

* Move loot-core/client/prefs code over to desktop-client package

* Dummy commit
2025-05-14 22:01:02 -07:00
musicaldesigner
b475951075 Update bank-factory.js, add DNB to list of banks with limited history (#4893) 2025-05-14 19:09:06 -07:00
Joel Jeremy Marquez
d9dd96d0de Add option to calculate running balances in useTransactions hook (#4987)
* Add option to calculate running balances in useTransactions hook

* Fix typecheck error

* Fix lint error

* Cleanup

* retrigger checks
2025-05-14 15:27:38 -07:00
Joel Jeremy Marquez
45ff94590b Move loot-core/client/notifications code over to desktop-client package (#4820)
* Move loot-core/client/modals code over to desktop-client package

* Fix lint error

* Move loot-core/client/notifications code over to desktop-client package
2025-05-14 13:25:09 -07:00
Joel Jeremy Marquez
466875a8dd Move loot-core/client/modals code over to desktop-client package (#4819)
* Move loot-core/client/modals code over to desktop-client package

* Fix lint error

* Fix imports

* Fix lint error

* Fix lint error
2025-05-14 12:09:25 -07:00
Alec Bakholdin
0431039eb6 Inconsistent date update mobile new transaction (#4910)
* converted onUpdate to onChange for better mobile ux

* release notes

---------

Co-authored-by: Alec Bakholdin <alecbakholdin@Alecs-Mac.local>
2025-05-13 10:33:05 -04:00
Alec Bakholdin
2215c131a5 Fix new transactions account notes not clearing (#4914)
* added history entry if history entry is null while entering Add Transaction widget

* release notes

* Update TransactionEdit.jsx

* Update TransactionEdit.jsx

* Update TransactionEdit.jsx

---------

Co-authored-by: Alec Bakholdin <alecbakholdin@Alecs-Mac.local>
2025-05-13 10:32:54 -04:00
Matt Fiddaman
4de5fb34b9 increase OpenID timeout (#4980)
* increase openid request timeout

* note
2025-05-13 00:20:59 -04:00
OhNoBigO
4f6b97ae4a [Mobile] 🐛 Fix viewing pie/donut charts on mobile (#4935)
* Fix viewing pie/donut charts on mobile

* Add release note

* Fix onMouseEnter firing on ios devices

* Change isTouchDevice to canDeviceHover

---------

Co-authored-by: Oli-vers <180103373+Oli-vers@users.noreply.github.com>
2025-05-12 13:57:52 -04:00
Matt Fiddaman
6d921a48b6 change minimum version of Node.js to version 20 (#4978)
* update workflows

* update supported engines in package.json

* .nvmrc

* base yarn cache on node version being used rather than .nvmrc

* note
2025-05-12 13:49:09 -04:00
Michael Clark
2d0716233f Replacing Actuator with our own implementation (#4897)
* actuator replacement experiment

* replacing actuator

* release notes

* description added

* version typo

* Update upcoming-release-notes/4897.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-05-12 18:40:15 +01:00
Joel Jeremy Marquez
6f3bfd2ad4 Move loot-core/client/budgets code over to desktop-client package (#4818)
* Move loot-core/client/budgets code over to desktop-client package

* Fix lint error

* Fix lint error
2025-05-12 09:46:33 -07:00
Joel Jeremy Marquez
10a143a3ae Add upcoming/missed/due schedules indicator on budget table (based on category schedule templates) (#4815)
* Add upcoming/missed/due schedules indicator on budget table (based on category schedule templates)

* Rename hook

* Fix typecheck error

* Update packages/desktop-client/src/components/budget/SidebarCategory.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Use category goal_def instead of reparsing notes

* Fix lint and typecheck error

* Fix lint error

* Update type

* Handle doal_def parse errors

* Only show schedule status on month of the schedule's next date

* Mobile - only show category schedule status on month's schedule

* Update tooltip wording

* Disable if goal templates feature is disabled

* Move schedule indicator to spent column

* Update colors

* Mobile - move indicator to spent

* Cleanup

* Cleanup

* Support multiple schedule templates

* Clearer error message

* Memo useCategoryScheduleGoalTemplates

* Fix lint and typecheck errors

* Category preview transactions for mobile

* Fix lint errors

* Fix calls to .some()

* Show most urgent schedules first

* Fix typecheck error

* Fix lint error

* Align all schedule indicators

* List all schedules in schedule indicator tooltip

* Fix typecheck error

* Fix lint errors

* Update SpentCell to show schedule indicator

* Fix lint error

* Update packages/desktop-client/src/hooks/useCategoryScheduleGoalTemplateIndicator.ts

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-05-12 09:46:20 -07:00
Joel Jeremy Marquez
82c469648e Split transactions repair tool to remove categories from parent transactions + prevent adding/updating parent transactions with categories (#4889)
* Add a functionality to split transactions repair tool to remove categories from parent transactions and prevent adding/update parent transactions with categories

* Fix lint error

* Remove console.log
2025-05-12 09:17:22 -07:00
Joel Jeremy Marquez
ab3088b6fa Update budgetType preference in DB from rollover/report to be envelope/tracking (#4879)
* Update budgetType preference from rollover/report to be envelope/tracking

* Release notes

* Fix default budgetType in BalanceCell
2025-05-12 08:27:50 -07:00
Joel Jeremy Marquez
582bb59097 Move loot-core/client/app code over to desktop-client package (#4817)
* Move loot-core/client/app code over to desktop-client package

* Fix lint

* Fix lint error
2025-05-12 08:21:06 -07:00
youngcw
01c68bcfc7 Tests for goal templates (#4882)
* start

* make week tests make sense

* fix

* copy

* average

* no call checks

* add rest.  Still need to vet runSpend, and runBy

* fix average

* tweak spend

* updates

* cleanup

* note

* add more up to tests

* previous percentage

* hitting limit tests

* remainder

* fixes

* more fixes

* fixes, and fix remainder return value

* fix amounts in limit tests

* e2e for a category

* skip checking schedules if not needed

* lost changes

* fix null

* add goal tests

* final fix?

* lint

* lint option 2
2025-05-12 06:25:01 -07:00
Johnn27
dd749483f5 [Mobile] 🐛 Fix widget order (#4949)
* Fix Dashboard Widgets Not Ordered on Mobile

* Update Release Notes

* Update formatting and comment

---------

Co-authored-by: Johnn27 <>
2025-05-12 08:56:35 -04:00
sergio10
11b86fc33c Add Abanca to the list of banks with limited history (#4970)
* Add Abanca to the list of banks with limited history

* add release notes

* change category release notes
2025-05-12 08:42:50 -04:00
Guillaume Taquet Gasperini
6e5f4bfb18 Add BoursoBank GoCardless Integration (#4958)
* Add BoursoBank GoCardless Integration

The default normalization was creating new payees for each
transaction per day, as there was no specific integration
for this bank.

e.g. `Carte dd/mm/yy Payee Name Cb*1234` was taken as payee
name.

There doesn't seem to be an easy catch-all syntax for
the BoursoBank transactions, but I have put all the
ones I could find from my transactions.

* Fix comment typo

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-05-12 08:42:30 -04:00
Vincent Giorgi
d87b78c02a invert most of seb kort credit card transactions (#4869)
* invert most of seb kort credit card transactions

* add release-notes

* revert package.json

---------

Co-authored-by: Vincent Giorgi <8283278+vincegio@users.noreply.github.com>
2025-05-12 07:55:19 -04:00
Alec Bakholdin
3cab9a374b 🐛 fixed scrollbar being impossible to grab (#4923)
* adjusted scrollbar width

* added icons to release note generator

* release notes
2025-05-11 13:23:29 -04:00
Julian Dominguez-Schatz
96949b701e Stabilize electron build directory paths (#4864)
* Stabilize electron build directory paths

* Add release notes
2025-05-11 07:39:05 -04:00
Michael Clark
0f55c67d3e 🐛 Fix sync server build not copying sql files over (#4968)
* fix sync server build not copying sql files over

* release notes

* copy-static-assets script
2025-05-10 13:17:34 +01:00
Michael Clark
b0adcb1333 🐛 Sync server - resolving the user-files and server-files to an absolute dir (#4954)
* resolving the user-files and server-files to an absolute dir

* safety

* release notes
2025-05-09 19:39:57 +01:00
Alec Bakholdin
04da20e34c Fix title first null undefined (#4908)
* added more null checks to titleFirst

* release notes

* fixed lint and typecheck

* Update packages/loot-core/src/shared/util.ts

Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>

* removed ts-ignore after changing titleFirst

---------

Co-authored-by: Alec Bakholdin <alecbakholdin@Alecs-Mac.local>
Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>
Co-authored-by: Alec Bakholdin <alecbakholdin@mac.myfiosgateway.com>
2025-05-08 12:11:27 -04:00
Alec Bakholdin
48715bf6b4 Ofx parsing dates incorrectly (#4911)
* added trim to ofx parsing

* release notes

* removed console.log
2025-05-08 12:11:19 -04:00
Alec Bakholdin
6c278a72a5 Fixed graphical bug in report (#4917)
Co-authored-by: Alec Bakholdin <alecbakholdin@Alecs-Mac.local>
2025-05-08 12:11:11 -04:00
Alec Bakholdin
17173d3ff0 New transaction text deselection on alt tab (#4921)
* changed default amount to come from amountToCurrency to handle localized values and maintain focus

* release notes

---------

Co-authored-by: Alec Bakholdin <alecbakholdin@Alecs-Mac.local>
2025-05-08 12:11:02 -04:00
Alec Bakholdin
64caf0f28b Last reconciled date not visible mobile (#4922)
* added last reconciled note to the reconciliation popup

* release notes

* Update packages/desktop-client/src/components/accounts/Reconcile.tsx

Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>

* bumped up padding

* yarn lint

---------

Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>
Co-authored-by: Alec Bakholdin <alecbakholdin@mac.myfiosgateway.com>
2025-05-08 11:42:27 -04:00
Joel Jeremy Marquez
0a8f820652 Use cx in Button className merging (#4956) 2025-05-07 08:12:57 -07:00
Michael Clark
e30735104e 🐛 Fix cli package json after ts build change (#4957)
* fix cli package json after ts build change

* release ntoes
2025-05-07 09:06:09 +01:00
Julian Dominguez-Schatz
8878f36eaf Add basic modal for budget automations (#4810)
* Add basic modal for budget automations

* Add release notes

* Exclude TODOs from this PR for now

* Fix some rebase errors

* CodeRabbit feedback

* PR feedback: reduce nesting in automation editor

* PR feedback: reduce nesting in automation read-only state

* PR feedback: make editors feel more like part of the read-only entry
2025-05-06 20:51:08 -04:00
Julian Dominguez-Schatz
9531a57f1c Deduplicate vite versions (#4943)
* Deduplicate vite versions

* Add release notes

* Ensure plugins are compatible with the latest vite

* yarn dedupe
2025-05-06 18:10:51 -04:00
Michael Clark
9d99fe2838 🐛 Fixing docker edge (#4953)
* instead of referencing the build dir directly reference using relative path

* release notes
2025-05-06 22:56:32 +01:00
Joel Jeremy Marquez
3a18718fa0 [Mobile] Show transactions upon clicking income categories (#4940)
* [Mobile] Show transactions upon clicking income categories

* Fix lint error
2025-05-06 14:09:40 -07:00
Roger Goldfinger
090345bd95 Enable Typescript in sync-server (#4887)
* attempt at running with typescript

* release notes

* working jest tests for TS files

* working docker image build

* remaining docker images

* cleanup

* ensure vitest is working

* get tests passing in ci

* less strict

* update release notes

* use tsc compiled assets in the published package

* scripts

* update yarn.lock

* Use build path for electron app

* PR feedback: move sync-server build out of bin/build-browser

* PR feedback: undo moduleResolution change

* extend main tsconfig and fix types

* PR feedback on scripts and when the sync-server build runs

* fix lint (unrelated change)

---------

Co-authored-by: alecbakholdin <alecbakholdin@gmail.com>
2025-05-05 23:45:49 -04:00
dependabot[bot]
4a7439da5e Bump vite from 5.4.18 to 5.4.19 (#4904)
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.18 to 5.4.19.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.19/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.19/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 5.4.19
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-05 20:29:16 -04:00
Joel Jeremy Marquez
a3c9525c83 Fix lint error accidentally pushed to master (#4942) 2025-05-05 14:28:30 -07:00
Alvaro Crespo
0d60da5ba9 Payees functional tests (#4766)
* add PayeesPage model for searching payees in e2e tests

* add navigation method to go to PayeesPage in e2e tests

* add e2e tests for Payees page

* update release notes

* Run prettier to fix lint

* clean imports

* fix imports

* Add snapshots for visual tests

* Remove unused import in payees test

* Update VRT

* Update 4766.md

Dummy commit

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>
2025-05-05 09:26:17 -07:00
Julian Dominguez-Schatz
388a9f6c86 Automatically generate GitHub release text (#4932)
* Automatically generate GitHub release text

* [TEMPORARY] Revert Electron signing changes to make this change testable

* Revert "[TEMPORARY] Revert Electron signing changes to make this change testable"

This reverts commit eeb5680b1a.

* Add release notes
2025-05-05 08:45:09 -04:00
Julian Dominguez-Schatz
cabb7149f0 Use the latest release tag instead of the latest tag for version checks (#4933)
* Use the latest release tag instead of the latest tag for version checks

* Add release notes
2025-05-05 08:44:31 -04:00
lelemm
3c47c1ca27 Promoting OpenId as default feature (#4903)
* Removed OpenId feature flag

* linter

* md

* wrong author
2025-05-05 08:21:47 -03:00
Joel Jeremy Marquez
cc204ba70e Use @desktop-client/hooks alias for cleaner imports (#4789)
* Use @hooks path alias for cleaner imports

* Fix line errors

* Update to @desktop-client
2025-05-04 22:30:10 -07:00
Joel Jeremy Marquez
7074b4dd82 Rename AQL module's runQuery function to aqlQuery to disambiguate with DB module's runQuery function + AQL types (#4787)
* Rename AQL module's runQuery function to aqlQuery to disambiguate with DB module runQuery function

* Release notes

* Update SqlPieces

* Fix lint

* Update SqlPieces.from

* Add types

* Type result as any for now

* Fix lint

* Add types

* Fix typo

* PR feedback

* Update comment

* Fix lint error

* Fix import
2025-05-04 22:29:23 -07:00
github-actions[bot]
c23cbb4b0e 🔖 (25.5.0) (#4916)
* 🔖 (25.5.0)

* Bump CI

* Remove used release notes

* Bump CI

---------

Co-authored-by: jfdoming <9922514+jfdoming@users.noreply.github.com>
Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-05-03 13:44:50 -04:00
lelemm
8da1c59362 🐛 Bug FIX: OpenID first login is not working properly when using config.json or ENV VARS (#4902)
* First login was not working properly

* md
2025-05-01 10:26:03 -03:00
youngcw
916a27a89a 🐛 fix schedule preview running balance of split schedules (#4881)
* fix blance math

* clean

* note

* lint

* typecheck
2025-04-25 13:11:49 -07:00
Joel Jeremy Marquez
97b99d1f16 [Mobile] Fix hidden category groups not being hidden (#4880)
* Fix hidden category groups not being hidden

* Update release note
2025-04-23 12:24:52 -07:00
Joel Jeremy Marquez
cf114ef69e [Mobile] Fix uncategorized banner + overspent banner showing previously active month's overspent categories (#4875)
* [Mobile] Fix overspent banner showing previously active month's overspent categories

* Update packages/desktop-client/src/hooks/useOverspentCategories.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Fix typecheck error

* Enable uncategorized banner and overspent banner for tracking budgets

* Fix lint error

* Update VRT

* Dummy commit

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-04-23 08:15:18 -07:00
Joel Jeremy Marquez
7064106748 Move loot-core/client codes over to desktop-client package (#4816) 2025-04-22 08:21:01 -07:00
Michael Süssemilch
b92a1cacf7 fix: commerzbank escape payee (#4845) 2025-04-21 13:28:27 +01:00
Michael Clark
f5c1879de1 :electron: Fix some menu links (#4860)
* fix some menu references not working

* release notes
2025-04-21 09:38:12 +01:00
Julian Dominguez-Schatz
92f444f548 Move some .d.ts files to .ts (#4862)
* Move loot-core types to `.ts`

* Add release notes

* PR feedback
2025-04-20 22:40:53 -04:00
Julian Dominguez-Schatz
94600731d9 Move loot-core to vitest (#4859)
* Update build + dependencies to work with vitest

* Update tests to use vitest

* Update snapshots to vitest format

* Update sql.js loading in tests to work with vitest

* Update crdt package loading to work with vitest

* Add release notes
2025-04-20 15:52:59 -04:00
Julian Dominguez-Schatz
5d59ecd72c Move remaining non-loot-core packages to latest vitest (#4856)
* Move remaining non-loot-core packages to vitest

* Add release notes
2025-04-20 15:17:07 -04:00
Michael Clark
54d9f0ff41 :electron: Fix Load Backup backup modal (#4853)
* fix backup screen

* release notes
2025-04-20 17:15:24 +01:00
Vincent Giorgi
eebdbdf34e invert Strawberry credit card transaction amounts (#4857)
* add Strawberry (nordic choice club) credit cards to SEB balance inversion

* add release-notes

---------

Co-authored-by: Vincent Giorgi <8283278+vincegio@users.noreply.github.com>
2025-04-20 11:54:13 -04:00
Julian Dominguez-Schatz
bddc372650 Move crdt to vitest (#4851)
* Move crdt to vitest

* Add release notes
2025-04-20 09:00:39 -04:00
Julian Dominguez-Schatz
d027adc734 Move sync-server to vitest (#4840)
* Move sync-server to vitest

* Add release notes

* Add comment

* Remove extraneous console.log

* Empty commit to bump CI
2025-04-19 23:43:25 -04:00
Michael Clark
e67c064d1f :electron: Prep for configure server page (#4847)
* prep work for configure server page

* release notes

* better log message
2025-04-19 18:34:13 +01:00
Roger Goldfinger
2f1ccad25a Restore"Reload on all redirects to handle Cloudflare Access auth expiration" (#4844) 2025-04-18 23:11:11 -04:00
Bhautik Savaliya
a2b9153d02 Fixes #4705: Scheduled transaction date when posting early. (#4719) 2025-04-18 10:33:39 -07:00
Julian Dominguez-Schatz
f1594e5bca Fix bug in ofx2json logic (#4838)
* Fix double unescape bug in ofx2json

* Add test

* Add release notes

* Update snapshot
2025-04-18 13:29:38 -04:00
dependabot[bot]
fed426d704 Bump nanoid from 3.3.7 to 3.3.11 (#4834)
* Bump nanoid from 3.3.7 to 3.3.11

Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.11.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ai/nanoid/compare/3.3.7...3.3.11)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-version: 3.3.11
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add release notes

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>
2025-04-18 13:25:24 -04:00
dependabot[bot]
aeb26b75af Bump vite from 5.4.8 to 5.4.18 (#4833)
* Bump vite from 5.4.8 to 5.4.18

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.8 to 5.4.18.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.18/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.18/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 5.4.18
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add release notes

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>
2025-04-18 13:23:50 -04:00
Michael Süssemilch
4b58335780 feat: expandable budget categories (#4807) 2025-04-18 05:35:08 -04:00
Michael Clark
153eaeecc5 🐛 CLI: Fix ACTUAL_DATA_DIR env variable not respected in some cases (#4825)
* fix issue with default data directory not respecting env variables
2025-04-18 10:11:34 +01:00
Margarida Reis
e28db52c70 fix: persist filters in custom report on interval or date range change (#4724)
ensure that modified filters are reapplied to the Custom Report when changing its interval or date range, rather than reverting to the last saved state, which could overwrite unsaved changes to the filters or their conditional operand
2025-04-17 22:13:04 -04:00
Grant
83f7a79c76 4571: Fix UI lockout when using In/Out mode with existing split columns (#4715)
* Fix catch 22 problem when using In/Out with split columns already enabled
- Also changed UI and transaction amount parsing behavior to accept all options combined
- Repositioned some amount options
- Adjusted the labels of a few options

* Fix amount options triggering state resets

* Update VRT

* Revert "Update VRT"

This reverts commit 0a4b70afad.

* Update VRT

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-04-17 22:03:09 -04:00
Alec Bakholdin
7e3ebb7e5f Global prefs undefined change (#4837)
* updated saveGlobalPrefs to handle falsy values better

* updated link which was no longer valid

* release notes

* Removed errant log

---------

Co-authored-by: Alec Bakholdin <alecbakholdin@Alecs-Mac.local>
2025-04-17 12:38:03 -07:00
lelemm
a8d41e88a5 🐛 Fix for returnUrl in OpenID auth (#4836)
* Fix for `returnUrl` in OpenID auth

* md

* change md number
2025-04-17 13:03:21 -03:00
Roger Goldfinger
62ab6a12e8 Revert "Reload on all redirects to handle Cloudflare Access auth expiration (…" (#4835) 2025-04-17 11:02:21 -04:00
Julian Dominguez-Schatz
d91fd2fb0e Slow improvements to Account.tsx (1/many) (#4824)
* Move Account EmptyMessage to a separate file

* Move a tiny bit of state out of Account.tsx

* Add release notes
2025-04-17 09:13:27 -04:00
Alec Bakholdin
4e9d51be1f [Feature] Manually merge transactions (#4739)
* added transactions-merge action

* mergeTransactions now returns kept id

* merge option only shows up when amount matches

* merge now handles more errors and merges from the dropped transaction if values are present

* modified merge logic slightly to avoid duplicating imported_id

* added reconciled and cleared to merge logic

* modified canMerge logic in SelectedTransactionsButton

* made merge undoable

* added onMerge to mobile menu

* release notes

* modified testing suite slightly

* added logic for detecting bank sync vs file import

* typecheck problem

* linting errors

* attempt to clean up tests better

---------

Co-authored-by: Alec Bakholdin <abakho@icims.com>
2025-04-16 20:11:36 -07:00
dependabot[bot]
1bc87fb35a Bump http-proxy-middleware from 3.0.3 to 3.0.5 (#4832)
* Bump http-proxy-middleware from 3.0.3 to 3.0.5

Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 3.0.3 to 3.0.5.
- [Release notes](https://github.com/chimurai/http-proxy-middleware/releases)
- [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/master/CHANGELOG.md)
- [Commits](https://github.com/chimurai/http-proxy-middleware/compare/v3.0.3...v3.0.5)

---
updated-dependencies:
- dependency-name: http-proxy-middleware
  dependency-version: 3.0.5
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add release notes

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>
2025-04-16 23:00:12 -04:00
Roger Goldfinger
2f5464c735 Reload on all redirects to handle Cloudflare Access auth expiration (#4706)
* Reload on all redirects

* Update index.ts

* Create release notes

* Update index.ts

* Update index.ts

* Update 4706.md

---------

Co-authored-by: Roger Goldfinger <roger@remind101.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-04-16 20:26:29 -04:00
Matt Fiddaman
c85769eb82 add support for longer running SimpleFIN transaction requests (#4780)
* SimpleFIN follow redirects

* release note
2025-04-16 19:17:27 -04:00
lelemm
a657021303 Do not count hidden categories in tracking budgets + cleanup table math (#4567)
* Alternative solution

* tests

* a bit better, but now categories can be weird

* working, I think

* almost there

* I was making it harder than it needed to be

* Update VRT

* note

* note

* Separating logic from envelope and report to keep envelope as it was

* Update VRT

* Removed checks for budgetType inside `envelope.ts` and `report.ts`

* changed code position in file

* linter

* handle initially hidden

* Fix for when tracking but is enabled

* total up everything

* Add tests for handling hidden categories and groups in budget totals

---------

Co-authored-by: youngcw <calebyoung94@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kevin Gatera <kevin@deployitwith.me>
2025-04-16 18:43:21 -03:00
Julian Dominguez-Schatz
523a62c8a0 Fix crash on transactions table with new transaction popup open (#4812)
* Fix crash on transactions table with new transaction popup open

* Add release notes
2025-04-15 18:27:37 -04:00
Joel Jeremy Marquez
925efc4cb6 [Mobile] Drag and drop expense category groups to re-order (#4599)
* Update to GridList

* VRT - minimal diff between 2 rows

* Implement a hidden drag button

* Revert VRT

* VRT

* [Mobile] Drag and drop income categories to re-order

* Update drag preview

* Release notes

* Fix drag preview

* Fix typecheck errors

* Fix group header margins

* Coderabbit suggestion

* Fix group

* Yarn lint fix
2025-04-15 14:13:44 -07:00
Michael Clark
31fe766a2b 🆕 Sync server as npm package (#4798)
* sync server as npm package

* yarn lock

* workflow

* fix yml

* fix script

* named job better

* imagine trusting an ai

* pack and publish separately

* v4 instead of v3 upload

* dependencies

* identifying the right package for uplaod

* updating references

* what

* i see

* here comes the glory

* aaaand here it comes

* perms

* hmm

* try changing scope

* owner is invalid for git so have to go to npm instead

* better names on workflow

* package the api too

* updates

* rename to play better with gitignore

* yarn

* better

* dont ignore me

* yarn

* readme

* readme

* release note

* typo

* updating to read package.json from fs rather than import to support more node versions

* more ai autocomplete more problems
2025-04-15 20:51:17 +01:00
Joel Jeremy Marquez
b9e7d7e9c2 [Mobile] Drag and drop expense categories to re-order (#4484)
* ExpenseGroup component

* Release notes

* Fix imports

* Fix typecheck errors

* Fix drag and drop indicator

* Fix drop indicator

* Update imports

* Cleanup

* Update to GridList

* Cleanup

* VRT - minimal diff between 2 rows

* Implement a hidden drag button

* Fix budgeted/spent toggle

* Update VRT

* Dummy commit

* Revert VRT

* VRT

* Update dependency props

* Update VRT

* CodeRabbit suggestions

* Fix rebase error

* Update VRT

* Dummy commit to re-run vrt

* Fix typecheck errors

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-04-14 13:55:17 -07:00
Josh Woodward
04aa086c9e Unlink account via bank sync page (#4714)
* adding unlink and account name to modal

* fixing dispatch and some style updates

* release notes

* catching a few missed "bank-sync" phrases

* linting

* Addressing comments

* Addressing comments

* Linting

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-04-13 09:41:25 -04:00
Matiss Janis Aboltins
cc02970a16 ⬆️ upgrade to React v19 (#4700) 2025-04-10 08:49:38 +01:00
Matiss Janis Aboltins
9489e2f3b4 🔧 added eslint auto-fix to the lint-staged step (#4757)
small DX improvement
2025-04-10 08:19:44 +01:00
Ian
608b4be765 Add option to control note imports during transaction import (#4593)
* Make note imports optional. Adds tests too

* add release notes

* Update VRT

* type getTransactions to resolve TS error

* remove CSV note import - already supported

* type and lint to make coderabbit happy

* conditional rendering of importNotes

* Update VRT

* update snapshot to account for serialization change

* use <Trans>

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

* Fix closing Trans

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

* address missing import

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: youngcw <calebyoung94@gmail.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-04-09 15:29:34 -07:00
Joel Jeremy Marquez
01f45d5072 Extract auth related server handlers from main.ts to server/auth/app.ts (#4660)
* Extract auth related server handlers from main.ts to server/auth/app.ts

* Release notes

* Update get-openid-config

* Fix typecheck error

* Fix lint and typecheck errors
2025-04-09 08:34:44 -07:00
alcroito
1b5be7f9d2 Show closed accounts on mobile UI (#4581) (#4584)
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-04-09 11:20:45 -04:00
Julian Dominguez-Schatz
e5d301c66b Fix bump versions script (#4740)
* Include sync-server in auto-bumped versions

* Fix version bump logic to work if the month has rolled over

* Add release notes
2025-04-08 18:34:31 -04:00
Matiss Janis Aboltins
fe3fe47b67 🐛 (bank-sync) improved error handling for initial gocardless account linking (#4756) 2025-04-08 18:50:02 +01:00
Joel Jeremy Marquez
b4ad639bb5 [Mobile] Fix income categories not changing colors based on active month (#4774)
* [Mobile] Fix income categories not changing colors based on active month

* Release notes
2025-04-08 09:30:40 -07:00
Joel Jeremy Marquez
c77168fa18 Extract encryption related server handlers from main.ts to server/encryption/app.ts (#4662)
* Extract encryption related server handlers from main.ts to server/encryption/app.ts

* Release notes
2025-04-08 09:12:11 -07:00
Joel Jeremy Marquez
6fb7fe1343 Replace category DB queries in server handlers with AQL queries + implement category_groups AQL executor (#4544)
* Implement category_groups AQL executor

* Fix category_groups table name

* Release notes

* Update category-update
2025-04-08 09:11:47 -07:00
Joel Jeremy Marquez
490ec22b8a Extract budget file related server handlers from main.ts to server/budgetfiles/app.ts (#4547)
* Extract budget file related server handlers from main.ts to server/budgetfiles/app.ts

* Fix lint error

* Release notes

* Fix typo

* Move backups to budgetfiles folder

* Move backup snapshot

* Fix lint

* Fix lint
2025-04-08 08:21:35 -07:00
ADRROE
0d420ab4d9 Add functionality to download custom reports as an image. (#4219)
* Add functionality to download custom reports as an image.

* Add functionality to download custom reports as an image.

* Switched from html2canvas to html-to-image due to size considerations.

* Snapshot filename

* Add functionality to download custom reports as an image.

* Add functionality to download custom reports as an image.

* Update ReportTopbar.tsx

Fixed mistake

* Use existing date function

* fix imports

* Update VRT

* move component out of common in aid of components lib migration

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-04-08 11:20:22 -04:00
youngcw
6b22e7422b [Goals]: fix remove goals bug (#4749)
* fix remove goals bug

* note

* Update upcoming-release-notes/4749.md

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-04-08 08:16:28 -07:00
lelemm
35a833ecba New OpenID first login UX (#4446)
* Fix for openid review parameters

* Refactor and bug fix of OpenId parameters on first login

* md

* change some design

* adjustments

* responsive login

* linter

* removed debugger

* Merge fixes

* removed debugger

* Merge fixes

* missing stuff

* linter

* linter after merge
2025-04-08 12:01:38 -03:00
Michael Clark
140039ea1f :electron: Fix loot-core resolution (#4767)
* fix loot-core resolution

* fix loot core resolution in dev mode for electron
2025-04-08 15:54:43 +01:00
lelemm
afab6ee773 OPENID: Added option to create users on login (#4421)
* Added option to create users on login (openid)

* md

* added default value

* linter

* added validation to ACTUAL_USER_CREATION_MODE

* Merge

* linter

* fixes

* removed enchancement

* linter
2025-04-08 11:18:47 -03:00
lelemm
cefc8da7bc 📚 Missing translations [rules and to budget] (#4770)
* Missing translations

* md

* wrong md name
2025-04-08 11:04:04 -03:00
Alec Bakholdin
91aa2ae47b 🐛 [Bug] Pinning sidebar doesn't persist on reload (#4733)
* Fixed pinning issue

* asyncStorage typing updates

* re-added awaits to savePreferences

* release notes

---------

Co-authored-by: Alec Bakholdin <abakho@icims.com>
2025-04-08 10:01:55 -04:00
Michael Süssemilch
a2878ff2a2 feat: add previous/next month navigation to the MonthPicker (#4692)
* feat: add previous/next month navigation to MonthPicker

* doc: add release note

* chore: update formatting

* test: update vrt snapshots
2025-04-08 09:59:17 -04:00
Alec Bakholdin
0dfa2910c7 🐛 [Bug]: Focused console warning (#4735)
* removed focused from getInputProps

* release notes

---------

Co-authored-by: Alec Bakholdin <abakho@icims.com>
2025-04-08 09:58:07 -04:00
Alec Bakholdin
4e0ab44e2f Fixed bug where closing account did not properly validate transfer or category (#4769)
Co-authored-by: Alec Bakholdin <abakho@icims.com>
2025-04-08 09:52:54 -04:00
Michael Clark
aba97e8b74 :electron: Remove ngrok from electron server embed (#4768)
* remove ngrok

* lock

* release notes
2025-04-07 22:19:10 +01:00
Michael Clark
1d6b70d160 :electron: Playwright test fixture (#4752)
* playwright test fixture

* release notes

* update snapshots

* test

* again

* same timeout as web client

* faster

* srsly

* Update VRT

* update test

* get rid of this test for now

* updating update-vrt

* speed it up a bit

* same timeout as desktop-client

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-04-06 18:56:08 +01:00
bddvlpr
a9047bfcd6 Add KBCBE (KBC_KREDBEBB) to banks with limited history (#4743) 2025-04-06 18:54:25 +01:00
Matiss Janis Aboltins
af03477d3a ♻️ (typescript) converted indexeddb to strict TS (#4672) 2025-04-06 15:09:37 +01:00
Matiss Janis Aboltins
c4b4108eca 🔧 improving typechecker and lint local performance (#4710) 2025-04-06 14:47:49 +01:00
Michael Clark
26ee3179e1 :electron: Playwright testing for electron (#4674)
* playwright testing for electron

* pipeline updates

* fix normal e2e scripts

* fix path to artifact

* listing out whats there

* attempt to fix ci

* umm

* again

* setting a viewport

* window size to be consistent across machine for tests

* now it work... Righhttt?

* hmm

* do it

* worflow

* will this work

* oops

* dont skip

* trust in the pipeline gods

* remove update snapshots, just do it in the pipeline

* change name of snapshot to account for os

* lint

* fix package script
2025-04-05 09:19:06 +01:00
github-actions[bot]
82b6589c37 🔖 (25.4.0) (#4728)
* 🔖 (25.4.0)

* Remove used release notes

* Remove used release notes

---------

Co-authored-by: matt-fidd <81489167+matt-fidd@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-04-04 23:49:46 -04:00
Matt Fiddaman
56f509dcda fix balance menu alignment (#4729)
* fix alignment

* note

* fix mobile

* Fix for width

---------

Co-authored-by: Leandro Menezes <lelemm@gmail.com>
2025-04-03 23:47:10 -04:00
dependabot[bot]
bbfa0093cd bump tar-fs from 2.1.1 to 2.1.2 (#4717) 2025-03-31 16:44:40 -04:00
Matiss Janis Aboltins
aef38f1679 🐛 fix menu not closing when menu item is clicked (#4716) 2025-03-31 18:15:17 +01:00
lelemm
e04ca554e2 🐛 Fix pluggy.ai foreigner currency transaction (#4712)
* Fix pluggy.ai foreigner currency transaction

* Trigger actions

* removed folder
2025-03-31 06:36:36 -03:00
lelemm
77949ad276 🐛 Fix Make Transfer closing the Popover when clicked (#4697)
* Fix `Make Transfer` closing the Popover

* MD

* MD

* linter

* trigger actions

* removed junk from PR

* changed solution

* using focused state
2025-03-28 10:40:56 -03:00
Saahil Jaffer
45f9cc3c1d Fix for iss parameter missing from openid response (#4626)
* fix: iss missing from the response

* add release notes

* add parameter validation check

* remove additional validation

---------

Co-authored-by: lelemm <lelemm@gmail.com>
2025-03-26 16:50:13 -03:00
Mario Lamacchia
31ed12832c Fix error spread in non-batch bank sync (#4689) 2025-03-26 09:12:54 -04:00
Margarida Reis
0f8a1aeb2b fix: apply filters in Reports dashboard for cash flow widget (#4683)
fix issue where filters set in the widget editor for the cash flow widget were not applied in the Reports dashboard
2025-03-26 00:16:23 -04:00
lelemm
161c0625b1 🐛 Fix for objects in config files (#4688)
* fix for objects in config

* md

* linter
2025-03-25 20:54:04 +00:00
Joel Jeremy Marquez
009a3dff4e Show hidden overspent categories (#4680) 2025-03-24 16:25:17 -07:00
Alec Bakholdin
5d01e109e6 🐛 [Bug] Cant edit template rules (#4686)
* Can now save template rules

* added release notes

---------

Co-authored-by: Alec Bakholdin <abakho@icims.com>
2025-03-24 17:54:39 -04:00
Michael Clark
b2287cded3 Local docker build fix (#4677)
* local docker build fix

* Create 4677

* Update sync-server.Dockerfile

* Rename 4677 to 4677.md
2025-03-22 16:25:50 +00:00
Alec Bakholdin
19dbfd0673 fixed can't rename notes (#4675) 2025-03-22 08:20:04 -07:00
Joel Jeremy Marquez
36c40d90d2 [Mobile] Add banners to alert users of recommended budget actions (#4643)
* Add banners to alert users of recommended budget actions

* Update wording for consistency

* Release notes

* Fix release notes

* Code review feedback

* Cleanup

* Extend playwright timeout

* Update Categorize button locator in test

* Update VRT

* Dummy commit

* Streamline cover spending flow

* VRT

* Remove category from modal when covered and close modal when all categories are covered

* Coderabbit suggestions

* Update translations

* VRT

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-03-21 17:19:09 -07:00
Alec Bakholdin
00ff2e2522 🐛 [Bug] fixed bug in Accounts.tsx for applying rules that split transactions (#4623)
* fixed bug in Accounts.tsx for applying rules that split transactions

* added release notes

* Update packages/desktop-client/src/components/accounts/Account.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: Alec Bakholdin <abakho@icims.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-03-21 16:12:29 -04:00
dependabot[bot]
1d074730f4 Bump axios from 1.7.9 to 1.8.3 (#4654)
* Bump axios from 1.7.9 to 1.8.3

Bumps [axios](https://github.com/axios/axios) from 1.7.9 to 1.8.3.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](https://github.com/axios/axios/compare/v1.7.9...v1.8.3)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* note

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
2025-03-21 13:11:29 -04:00
Joel Jeremy Marquez
1e685b993b Extract sync related server handlers from main.ts to server/sync/app.ts (#4661)
* Extract sync related server handlers from main.ts to server/sync/app.ts

* Release notes

* Revert async
2025-03-21 08:04:07 -07:00
Alec Bakholdin
6b2d2420a5 🐛 Fixed GoCardless SelectLinkedAccounts institution bug (#4667)
* Fixed GoCardless SelectLinkedAccounts institution bug

* Modified to guarantee string return type

* Update packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Formatting

* Fixed spread syntax

* consistency in method (probably redundant)

---------

Co-authored-by: Alec Bakholdin <abakho@icims.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-03-21 07:56:25 -07:00
Joel Jeremy Marquez
af09e5b1d5 Fix error on budget file selection page when using server (#4670)
* Fix error on budget file selection page when using server

* Release notes
2025-03-21 06:29:07 -07:00
Michael Clark
8f12893ff0 :electron: Fix electron loot core resolutions (#4668)
* fix electron resolutions

* temp fix

* dont include build-electron in the web bundle assuming its built

* lowering size of build

* removing exports

* release notes

* adding bits back

* remove bad config
2025-03-21 09:01:20 +00:00
Joel Jeremy Marquez
a85dc890e5 Fix nested button error in budget file selection page (#4625)
* Resolve nested button error by converting to GridList

* Release notes
2025-03-20 13:12:43 -07:00
Joel Jeremy Marquez
8180476531 Fix embedded autocomplete unexpectedly closing when an item is clicked (#4645)
* Fix autocomplete unexpectedly closing when an item is clicked on embedded setting

* Release notes
2025-03-20 13:11:13 -07:00
Matt Fiddaman
ad1df689d7 bump various dependencies (#4656) 2025-03-20 13:27:17 -04:00
Alec Bakholdin
d9716caf5d 🔧 Added release-notes-generator.ts under generate:release-notes (#4664) 2025-03-20 10:19:04 -04:00
Michael Clark
b2cca2337c 🐛 Allowing service worker to cache files up to 5mb - fixes edge & offline mode (#4665)
* allowing sw to cache files up to 5mb

* release notes
2025-03-19 23:14:58 +00:00
Joel Jeremy Marquez
e0bddaeb99 Extract spreadsheet related server handlers from main.ts to server/spreadsheet/app.ts (#4649)
* Extract spreadsheet related server handlers from main.ts to server/spreadsheet/app.ts

* Release notes

* Fix get-cell

* Update type of initServer
2025-03-19 11:14:46 -07:00
Alec Bakholdin
2c4c5014ea 🐛 fixed current month upcoming calculation (#4629)
* fixed current month upcoming calculation

* added release notes

* updated test to validate the new behavior of getUpcoming

* modified one month and added more tests for leap years and months with different dates

* Fixed odd error

---------

Co-authored-by: Alec Bakholdin <abakho@icims.com>
2025-03-19 08:20:42 -07:00
Matiss Janis Aboltins
c7f3dadc07 🐛 (mobile) fix for iOS - keyboard focus when editing budget (#4651) 2025-03-19 04:50:04 +00:00
Matiss Janis Aboltins
999010cca6 🐛 (reports) fix conditionsOp not applying for saved reports (#4652) 2025-03-19 04:49:29 +00:00
Martin Sebek
b9603d0e54 Added CZ AirBank to banks with only 90 days of history (#4595)
* Added CZ AirBank to banks with only 90 days of history

* Added release notes
2025-03-19 00:01:52 -04:00
Alec Bakholdin
0c85523037 Add org name to bank sync UI (#4646)
* Added institution name to the LinkModal

* Added release notes

* removed a stray import I did not mean to leave in

* updated release note number

* Separated institution into its own column and updated sorting to sort by institution -> name

* Added tooltips to allow users to hover over institution name and account name when linking bank accounts

---------

Co-authored-by: Alec Bakholdin <abakho@icims.com>
2025-03-18 19:55:53 -07:00
Alec Bakholdin
eb5944b353 Bank sync avoid reimporting deleted transactions (#4644)
* matchTransactions imported_id query checks for deleted transactions

* added release notes

* removed stray import

* Added configuration option to control reimporting deleted transactions

* Updated release notes

* Unused import

* Typo

* Linting errors

* Fixed Checkbox id to match what it's for

* Added tooltip for the checkbox

---------

Co-authored-by: Alec Bakholdin <abakho@icims.com>
2025-03-18 16:21:59 -07:00
Matiss Janis Aboltins
f35a850e3d ♻️ moved loot-core import resolution from TS to yarn workspaces (#4592) 2025-03-18 17:38:57 +00:00
Matt Fiddaman
3ca9f6ecbc Update README.md (#4648) 2025-03-18 14:44:32 +00:00
Joel Jeremy Marquez
602b84342b Update server handlers to use the implementation function type instead of duplicating the function arguments/return types (#4650)
* Update server handlers types to be more strict

* Release notes
2025-03-18 06:43:15 -07:00
Joel Jeremy Marquez
b5cbaa52b2 Simplify Modals component by destructuring modal.options instead of passing options one by one (#4647)
* Simplify Modals component

* Release notes
2025-03-18 06:43:01 -07:00
Matiss Janis Aboltins
5fdaa98249 ♻️ removal of '.testing.ts' file extensions in favour of mocks (#4632) 2025-03-18 06:13:11 +00:00
Joel Jeremy Marquez
c8813e9953 Extract budget category related server handlers from main.ts to server/budget/app.ts (#4442)
* Extract category related server handlers from main.ts to server/budget/app.ts

* Release notes

* On DB layer, replace Entity model usage with DB models

* Fix typecheck errors

* Fix type error

* Fix types

* Fix typecheck error

* Fix lint errors

* Fix test errors

* Fix model mapping
2025-03-17 21:39:10 -07:00
Matiss Janis Aboltins
074d5b76cf ⬆️ upgrade yarn from v4.3.1 to v4.7.0 (#4641) 2025-03-17 17:21:28 +00:00
Matiss Janis Aboltins
9f9f349cbf ♻️ (api) do not bundle test files in package output (#4640) 2025-03-17 17:21:09 +00:00
lelemm
78e763659e 📚 More translations for rules and fields (#4635)
* More translations

* md

* more places
2025-03-17 10:43:45 -03:00
Joel Jeremy Marquez
0cc817f2ef [Redux Toolkit Migration] usersSlice [Final PR] (#4128)
* Migrate to accountSlice

* Fix lint and typecheck errors

* Update types

* Fix lint

* Fix types

* Cleanup

* Rename file

* Rename state

* Cleanup

* Fix typecheck error

* Move createAppAsyncThunk

* Queries slice

* Budgets slice

* Fix lint errors

* Undo auto removal of import/no-unresolved

* Update index.ts

* Release notes

* usersSlice

* Delete actions folder

* Remove action imports

* Fix lint

* Delete constants

* Fix lint error

* Update thunk name

* Replace CLOSE_BUDGET with resetApp
2025-03-16 21:51:58 -07:00
Alec Bakholdin
f00484b17c 🐛 added null/undefined check for scheduleIsRecurring (#4627) 2025-03-15 20:23:31 +00:00
lelemm
0cdaac6944 🐛 Pluggy.ai credit card transactions were inverted (#4628)
* bugfix

* md
2025-03-15 00:08:40 -03:00
Matiss Janis Aboltins
864aaacd11 ♻️ (loot-core) unify some electron/web/api logic (#4610)
* ♻️ (loot-core) unify some electron/web/api logic

* Add missing mock
2025-03-14 22:46:11 +00:00
Michael Clark
bdf76f6c63 :electron: Embed the sync-server (experimental) (#4526)
* sync server embedded

* cleanup

* remove comment

* remove comment

* changing settings names

* release notes

* release notes

* making dev easier (and slower)

* updating reference to webroot

* using the workspace package yo

* coderabbit
2025-03-14 22:22:17 +00:00
Joel Jeremy Marquez
47c0d394ee [Redux Toolkit Migration] prefsSlice (#4127)
* Migrate to accountSlice

* Fix lint and typecheck errors

* Update types

* Fix lint

* Fix types

* Cleanup

* Rename file

* Rename state

* Cleanup

* Fix typecheck error

* Move createAppAsyncThunk

* Queries slice

* Budgets slice

* Fix lint errors

* Undo auto removal of import/no-unresolved

* Update index.ts

* Prefs slice

* Remove old prefs types

* Fix import

* Fix typecheck errors

* Release notes

* Add checks on prefs saving

* Update prefs checking

* Fix set-theme
2025-03-14 06:35:43 -07:00
lelemm
fdac2839c9 🔨 OPENID: Refactor mixed stuff (#4428)
* Refactor

* changed the variable name back to loginMethod

* md

* Update packages/sync-server/src/app.js

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-03-14 08:38:33 -03:00
Michael Clark
379a84d2e2 🐳 @actual-app/web workspace in sync-server (#4569)
* Workspace ref web client (#9)
---------

Co-authored-by: lelemm <lelemm@gmail.com>
2025-03-14 09:07:59 +00:00
Joel Jeremy Marquez
d16d022b50 Remove height transition animation from modals when adjusting to viewport height for smoother experience (#4620)
* Use dvh to determine height of modal based on dynamic visual viewport

* Apply to dialog instead of another div

* Remove modal transition

* Release notes
2025-03-13 10:49:58 -07:00
Joel Jeremy Marquez
606e39252f [Mobile] Click on income category balance to show transactions (#4621)
* [Mobile] Click on income category balance to show transactions

* Release notes
2025-03-13 10:49:14 -07:00
Margarida Reis
2523c091c3 improvement: enable collapse split transactions with searches or filters (#4600)
* improvement: enable collapse split transactions with searches or filters

enable the "Collapse|Expand split transactions" button with searches or filters

* Update VRT

* chore: trigger GitHub actions

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-03-13 10:36:01 -07:00
tempiz
d4b37baa4d Modified transaction edit button on mobile to display "Add New Split" (#4536)
* Created Add Split Button

* Create 4536.md

* Fix Lint Check Error

* Fix Release Note Category

* Added add split text to amount left/save button

Removed my add split button and instead added functionality for the button save/amount left button to display "Add New Split" when all amounts are entered.

* Fix Lint

* Update release notes

* Show remaining on add split button

* Fix lint

* Added requested changes

* Fix lint
2025-03-12 17:05:20 -07:00
Matiss Janis Aboltins
ed4ef5b30e ♻️ solve most peer dependency issues reported on install (#4613)
* ♻️ solve most peer dependency issues reported on install

* Release notes

* Patch unit tests
2025-03-12 17:13:35 +00:00
Matiss Janis Aboltins
baadafb15e ♻️ (loot-core) updated all data model imports to use barrel file (#4609) 2025-03-12 17:05:46 +00:00
James Skinner
346727a539 Mobile budget file switching logical error fix (#4596)
* Fix logical error to filter out just the current file from list of files, rather than excluding remote files.

* Add release note and update comment
2025-03-12 07:45:30 -07:00
Matiss Janis Aboltins
ddcd771488 ♻️ (sync-server) align dependency versions; cleanup lint & typecheck (#4605) 2025-03-12 14:03:23 +00:00
Joel Jeremy Marquez
3ecfb4be7e Swipe to dismiss notifications (#4606)
* Swipe to dismiss notifications

* Release notes

* Update VRT

* Dummy commit

* Make notification swipe a bit snappier

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-03-11 14:35:01 -07:00
Margarida Reis
bf154db3d6 fix: align action buttons in modal for confirming transaction edit (#4604)
align the "Cancel" and "Confirm" buttons in the modal for confirming a transaction edit to the right-hand side for consistency
2025-03-11 14:15:49 -07:00
Joel Jeremy Marquez
4b48f09112 [TypeScript] Make db.all generic to make it easy to type DB query results (#4542)
* [TypeScript] Make db.all generic to make it easy to type DB query results

* Release notes

* Fix type

* Update return type
2025-03-10 12:14:13 -07:00
Matiss Janis Aboltins
6c7df7c1f9 ♻️ (components) updated old import paths to use the new paths (#4591) 2025-03-10 18:11:30 +00:00
Matiss Janis Aboltins
0b9b440a7a ♻️ (components) remove InputWithContent component (#4566) 2025-03-10 17:21:00 +00:00
Matiss Janis Aboltins
ebb83aca51 ♻️ (components) refactor useResponsive and move to comp. lib (#4568) 2025-03-10 15:32:17 +00:00
Joel Jeremy Marquez
e5c2ef47ac [Mobile] Drag and drop income categories to re-order (#4482)
* [Mobile] Drag and drop income categories to re-order

* Fix category group ID

* Update borders

* Use list item value prop

* Cleanup

* useCallback

* Remvoe usage of useListData

* Fix typecheck error

* Release notes

* Fix import

* Update DropIndicator

* Update DropIndicator

* Fix drop indicator
2025-03-10 08:14:33 -07:00
Matiss Janis Aboltins
af068d1f89 🐛 fix rules page table incorrect row heights (#4586) 2025-03-10 12:11:09 +00:00
James Skinner
35fe969b1b Typo fix in OutOfSyncMigrationsModal (#4585)
* Fix typo in OutOfSyncMigrationsModal.tsx

* Add release note

* Rename release note file to be id of PR rather than issue
2025-03-09 22:50:37 +00:00
1705 changed files with 69720 additions and 39787 deletions

3
.cursor/worktrees.json Normal file
View File

@@ -0,0 +1,3 @@
{
"setup-worktree": ["yarn"]
}

View File

@@ -1,14 +1,11 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/docker-existing-docker-compose
{
"name": "Actual development",
"dockerComposeFile": [
"../docker-compose.yml",
"docker-compose.yml"
],
// Alternatively:
// "image": "mcr.microsoft.com/devcontainers/typescript-node:0-16",
"service": "actual-development",
"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
"postCreateCommand": "yarn install"
"name": "Actual development",
"dockerComposeFile": ["../docker-compose.yml", "docker-compose.yml"],
// Alternatively:
// "image": "mcr.microsoft.com/devcontainers/typescript-node:0-16",
"service": "actual-development",
"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
"postCreateCommand": "yarn install"
}

View File

@@ -1,15 +1,14 @@
name: Bug Report
description: File a bug report also known as an issue or problem.
title: '[Bug]: '
labels: ['bug']
labels: ['needs triage', 'bug']
type: Bug
body:
- type: markdown
id: intro-md
attributes:
value: |
Thanks for taking the time to fill out this bug report! Please ensure you provide as much information as possible to better assist in confirming and identifying a fix for the bug.
- type: markdown
id: intro-md
attributes:
value: |
**IMPORTANT:** we use GitHub Issues only for BUG REPORTS and FEATURE REQUESTS. If you are looking for help/support - please reach out to the [community on Discord](https://discord.gg/pRYNYr4W5A). All non-bug and non-feature-request issues will be closed.
@@ -23,8 +22,6 @@ body:
options:
- label: 'I have searched and found no existing issue'
required: true
validations:
required: true
- type: textarea
id: what-happened
attributes:
@@ -43,7 +40,6 @@ body:
validations:
required: true
- type: markdown
id: env-info
attributes:
value: '## Environment Details'
- type: dropdown

View File

@@ -2,9 +2,9 @@ name: Feature request
description: Request a missing feature
title: '[Feature] '
labels: ['feature']
type: Feature
body:
- type: markdown
id: intro-md
attributes:
value: |
Thanks for taking the time to fill out this feature request! Please ensure you provide as much information as possible so we can better understand what youre proposing so we can come up with the best solution for everyone.
@@ -16,8 +16,6 @@ body:
options:
- label: 'I have searched and found no existing issue'
required: true
validations:
required: true
- type: checkboxes
attributes:
label: '💻'

View File

@@ -1 +1 @@
<!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes -->
<!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. -->

View File

@@ -0,0 +1,75 @@
#!/usr/bin/env node
import { Octokit } from '@octokit/rest';
import fs from 'fs';
const token = process.env.GITHUB_TOKEN;
const repo = process.env.GITHUB_REPOSITORY;
const issueNumber = process.env.GITHUB_EVENT_ISSUE_NUMBER;
const commentId = process.env.GITHUB_EVENT_COMMENT_ID;
if (!token || !repo || !issueNumber || !commentId) {
console.log('Missing required environment variables');
process.exit(1);
}
const [owner, repoName] = repo.split('/');
const octokit = new Octokit({ auth: token });
function setOutput(name, value) {
fs.appendFileSync(process.env.GITHUB_OUTPUT, `${name}=${value}\n`);
}
async function checkFirstComment() {
try {
console.log('Fetching comments with Octokit...');
// Get all comments with automatic pagination
const comments = await octokit.paginate(octokit.rest.issues.listComments, {
owner,
repo: repoName,
issue_number: issueNumber,
});
console.log(`Total comments found: ${comments.length}`);
// Filter for CodeRabbit summary comments (containing the specific marker)
const coderabbitSummaryComments = comments.filter(comment => {
const isCodeRabbit = comment.user.login === 'coderabbitai[bot]';
const hasSummaryMarker = comment.body.includes(
'<!-- This is an auto-generated comment: summarize by coderabbit.ai -->',
);
if (isCodeRabbit) {
console.log(
`CodeRabbit comment found (ID: ${comment.id}), has summary marker: ${hasSummaryMarker}`,
);
}
return isCodeRabbit && hasSummaryMarker;
});
const isFirstSummaryComment =
coderabbitSummaryComments.length === 1 &&
coderabbitSummaryComments[0].id == commentId;
console.log(
`CodeRabbit summary comments found: ${coderabbitSummaryComments.length}`,
);
console.log(`Current comment ID: ${commentId}`);
console.log(`Is first summary comment: ${isFirstSummaryComment}`);
setOutput('result', isFirstSummaryComment);
} catch (error) {
console.log('Error checking CodeRabbit comment:', error.message);
console.log('Stack:', error.stack);
setOutput('result', 'false');
process.exit(1);
}
}
checkFirstComment().catch(error => {
console.log('Unhandled error:', error.message);
console.log('Stack:', error.stack);
setOutput('result', 'false');
process.exit(1);
});

View File

@@ -0,0 +1,76 @@
#!/usr/bin/env node
import { Octokit } from '@octokit/rest';
import fs from 'fs';
const token = process.env.GITHUB_TOKEN;
const repo = process.env.GITHUB_REPOSITORY;
const issueNumber = process.env.GITHUB_EVENT_ISSUE_NUMBER;
const prDetailsJson = process.env.PR_DETAILS;
if (!token || !repo || !issueNumber || !prDetailsJson) {
console.log('Missing required environment variables');
process.exit(1);
}
const [owner, repoName] = repo.split('/');
const octokit = new Octokit({ auth: token });
function setOutput(name, value) {
fs.appendFileSync(process.env.GITHUB_OUTPUT, `${name}=${value}\n`);
}
async function checkReleaseNotesExists() {
try {
const prDetails = JSON.parse(prDetailsJson);
if (!prDetails) {
console.log('No PR details available, skipping file check');
setOutput('result', 'false');
return;
}
const fileName = `upcoming-release-notes/${prDetails.number}.md`;
// Get PR info to get head SHA
const { data: pr } = await octokit.rest.pulls.get({
owner,
repo: repoName,
pull_number: issueNumber,
});
const prHeadSha = pr.head.sha;
console.log(
`Checking for file on PR branch: ${pr.head.ref} (${prHeadSha})`,
);
// Check if file exists
try {
await octokit.rest.repos.getContent({
owner,
repo: repoName,
path: fileName,
ref: prHeadSha,
});
console.log(
`Release notes file already exists on PR branch: ${fileName}`,
);
setOutput('result', 'true');
} catch (error) {
if (error.status === 404) {
console.log(
`No existing release notes file found on PR branch: ${fileName}`,
);
setOutput('result', 'false');
} else {
console.log('Error checking file existence:', error.message);
setOutput('result', 'false');
}
}
} catch (error) {
console.log('Error in file existence check:', error.message);
setOutput('result', 'false');
}
}
checkReleaseNotesExists();

View File

@@ -0,0 +1,77 @@
#!/usr/bin/env node
import { Octokit } from '@octokit/rest';
const token = process.env.GITHUB_TOKEN;
const repo = process.env.GITHUB_REPOSITORY;
const issueNumber = process.env.GITHUB_EVENT_ISSUE_NUMBER;
const summaryDataJson = process.env.SUMMARY_DATA;
const category = process.env.CATEGORY;
if (!token || !repo || !issueNumber || !summaryDataJson || !category) {
console.log('Missing required environment variables');
process.exit(1);
}
const [owner, repoName] = repo.split('/');
const octokit = new Octokit({ auth: token });
async function commentOnPR() {
try {
const summaryData = JSON.parse(summaryDataJson);
if (!summaryData) {
console.log('No summary data available, skipping comment');
return;
}
if (!category || category === 'null') {
console.log('No valid category available, skipping comment');
return;
}
// Clean category for display
const cleanCategory =
typeof category === 'string'
? category.replace(/^["']|["']$/g, '')
: category;
// Get PR info for the file URL
const { data: pr } = await octokit.rest.pulls.get({
owner,
repo: repoName,
pull_number: issueNumber,
});
const prBranch = pr.head.ref;
const headOwner = pr.head.repo.owner.login;
const headRepo = pr.head.repo.name;
const fileUrl = `https://github.com/${headOwner}/${headRepo}/blob/${prBranch}/upcoming-release-notes/${summaryData.prNumber}.md`;
const commentBody = [
'🤖 **Auto-generated Release Notes**',
'',
`Hey @${summaryData.author}! I've automatically created a release notes file based on CodeRabbit's analysis:`,
'',
`**Category:** ${cleanCategory}`,
`**Summary:** ${summaryData.summary}`,
`**File:** [upcoming-release-notes/${summaryData.prNumber}.md](${fileUrl})`,
'',
// 'The release notes file has been committed to the repository. You can edit it if needed before merging.',
"If you're happy with this release note, you can add it to your pull request. If not, you'll need to add your own before a maintainer can review your change.",
].join('\n');
await octokit.rest.issues.createComment({
owner,
repo: repoName,
issue_number: issueNumber,
body: commentBody,
});
console.log('✅ Successfully commented on PR');
} catch (error) {
console.log('Error commenting on PR:', error.message);
}
}
commentOnPR();

View File

@@ -0,0 +1,96 @@
#!/usr/bin/env node
import { Octokit } from '@octokit/rest';
const token = process.env.GITHUB_TOKEN;
const repo = process.env.GITHUB_REPOSITORY;
const issueNumber = process.env.GITHUB_EVENT_ISSUE_NUMBER;
const summaryDataJson = process.env.SUMMARY_DATA;
const category = process.env.CATEGORY;
if (!token || !repo || !issueNumber || !summaryDataJson || !category) {
console.log('Missing required environment variables');
process.exit(1);
}
const [owner, repoName] = repo.split('/');
const octokit = new Octokit({ auth: token });
async function createReleaseNotesFile() {
try {
const summaryData = JSON.parse(summaryDataJson);
console.log('Debug - Category value:', category);
console.log('Debug - Category type:', typeof category);
console.log('Debug - Category JSON stringified:', JSON.stringify(category));
if (!summaryData) {
console.log('No summary data available, cannot create file');
return;
}
if (!category || category === 'null') {
console.log('No valid category available, cannot create file');
return;
}
// Create file content - ensure category is not quoted
const cleanCategory =
typeof category === 'string'
? category.replace(/^["']|["']$/g, '')
: category;
console.log('Debug - Clean category:', cleanCategory);
const fileContent = `---
category: ${cleanCategory}
authors: [${summaryData.author}]
---
${summaryData.summary}`;
const fileName = `upcoming-release-notes/${summaryData.prNumber}.md`;
console.log(`Creating release notes file: ${fileName}`);
console.log('File content:');
console.log(fileContent);
// Get PR info
const { data: pr } = await octokit.rest.pulls.get({
owner,
repo: repoName,
pull_number: issueNumber,
});
const prBranch = pr.head.ref;
const headOwner = pr.head.repo.owner.login;
const headRepo = pr.head.repo.name;
console.log(
`Committing to PR branch: ${headOwner}/${headRepo}:${prBranch}`,
);
// Create the file via GitHub API on the PR branch
await octokit.rest.repos.createOrUpdateFileContents({
owner: headOwner,
repo: headRepo,
path: fileName,
message: `Add release notes for PR #${summaryData.prNumber}`,
content: Buffer.from(`${fileContent}\n\n`).toString('base64'),
branch: prBranch,
committer: {
name: 'github-actions[bot]',
email: 'github-actions[bot]@users.noreply.github.com',
},
author: {
name: 'github-actions[bot]',
email: 'github-actions[bot]@users.noreply.github.com',
},
});
console.log(`✅ Successfully created release notes file: ${fileName}`);
} catch (error) {
console.log('Error creating release notes file:', error.message);
}
}
createReleaseNotesFile();

View File

@@ -0,0 +1,118 @@
#!/usr/bin/env node
const https = require('https');
const fs = require('fs');
const commentBody = process.env.GITHUB_EVENT_COMMENT_BODY;
const prDetailsJson = process.env.PR_DETAILS;
const summaryDataJson = process.env.SUMMARY_DATA;
const openaiApiKey = process.env.OPENAI_API_KEY;
if (!commentBody || !prDetailsJson || !summaryDataJson || !openaiApiKey) {
console.log('Missing required environment variables');
process.exit(1);
}
function setOutput(name, value) {
fs.appendFileSync(process.env.GITHUB_OUTPUT, `${name}=${value}\n`);
}
try {
const prDetails = JSON.parse(prDetailsJson);
const summaryData = JSON.parse(summaryDataJson);
if (!summaryData || !prDetails) {
console.log('Missing data for categorization');
setOutput('result', 'null');
process.exit(0);
}
const data = JSON.stringify({
model: 'gpt-4o-mini',
messages: [
{
role: 'system',
content:
'You are categorizing pull requests for release notes. You must respond with exactly one of these categories: "Features", "Enhancements", "Bugfix", or "Maintenance". No other text or explanation.',
},
{
role: 'user',
content: `PR Title: ${prDetails.title}\n\nGenerated Summary: ${summaryData.summary}\n\nCodeRabbit Analysis:\n${commentBody}\n\nCategories:\n- Features: New functionality or capabilities\n- Bugfix: Fixes for broken or incorrect behavior\n- Enhancements: Improvements to existing functionality\n- Maintenance: Code cleanup, refactoring, dependencies, etc.\n\nWhat category does this PR belong to?`,
},
],
max_tokens: 10,
temperature: 0.1,
});
const options = {
hostname: 'api.openai.com',
path: '/v1/chat/completions',
method: 'POST',
headers: {
Authorization: `Bearer ${openaiApiKey}`,
'Content-Type': 'application/json',
},
};
const req = https.request(options, res => {
let responseData = '';
res.on('data', chunk => (responseData += chunk));
res.on('end', () => {
if (res.statusCode !== 200) {
console.log('OpenAI API error for categorization');
setOutput('result', 'null');
return;
}
try {
const response = JSON.parse(responseData);
console.log('OpenAI raw response:', JSON.stringify(response, null, 2));
const rawContent = response.choices[0].message.content.trim();
console.log('Raw content from OpenAI:', rawContent);
let category;
try {
category = JSON.parse(rawContent);
console.log('Parsed category:', category);
} catch (parseError) {
console.log(
'JSON parse error, using raw content:',
parseError.message,
);
category = rawContent;
}
// Validate the category response
const validCategories = [
'Features',
'Bugfix',
'Enhancements',
'Maintenance',
];
if (validCategories.includes(category)) {
console.log('OpenAI categorized as:', category);
setOutput('result', category);
} else {
console.log('Invalid category from OpenAI:', category);
console.log('Valid categories are:', validCategories);
setOutput('result', 'null');
}
} catch (error) {
console.log('Error parsing OpenAI response:', error.message);
setOutput('result', 'null');
}
});
});
req.on('error', error => {
console.log('Error in categorization:', error.message);
setOutput('result', 'null');
});
req.write(data);
req.end();
} catch (error) {
console.log('Error in categorization:', error.message);
setOutput('result', 'null');
}

View File

@@ -0,0 +1,97 @@
#!/usr/bin/env node
const https = require('https');
const fs = require('fs');
const commentBody = process.env.GITHUB_EVENT_COMMENT_BODY;
const prDetailsJson = process.env.PR_DETAILS;
const openaiApiKey = process.env.OPENAI_API_KEY;
if (!commentBody || !prDetailsJson || !openaiApiKey) {
console.log('Missing required environment variables');
process.exit(1);
}
function setOutput(name, value) {
fs.appendFileSync(process.env.GITHUB_OUTPUT, `${name}=${value}\n`);
}
try {
const prDetails = JSON.parse(prDetailsJson);
if (!prDetails) {
console.log('No PR details available, cannot generate summary');
setOutput('result', 'null');
process.exit(0);
}
console.log('CodeRabbit comment body:', commentBody);
const data = JSON.stringify({
model: 'gpt-4o-mini',
messages: [
{
role: 'system',
content:
'You are a technical writer helping to create concise release notes. Generate a maximum 15-word summary that describes what this PR does. Focus on the user-facing changes or bug fixes. Do not include "This PR" or similar phrases - just describe the change directly. Start with a base form verb (e.g., "Add" not "Adds", "Fix" not "Fixes", "Introduce" not "Introduces").',
},
{
role: 'user',
content: `PR Title: ${prDetails.title}\n\nCodeRabbit Analysis:\n${commentBody}\n\nPlease provide a concise summary (max 15 words) of what this PR accomplishes.`,
},
],
max_tokens: 50,
temperature: 0.3,
});
const options = {
hostname: 'api.openai.com',
path: '/v1/chat/completions',
method: 'POST',
headers: {
Authorization: `Bearer ${openaiApiKey}`,
'Content-Type': 'application/json',
},
};
const req = https.request(options, res => {
let responseData = '';
res.on('data', chunk => (responseData += chunk));
res.on('end', () => {
if (res.statusCode !== 200) {
console.log(`OpenAI API error: ${res.statusCode} ${res.statusMessage}`);
setOutput('result', 'null');
return;
}
try {
const response = JSON.parse(responseData);
const summary = response.choices[0].message.content.trim();
console.log('Generated summary:', summary);
const result = {
summary: summary,
prNumber: prDetails.number,
author: prDetails.author,
};
setOutput('result', JSON.stringify(result));
} catch (error) {
console.log('Error parsing OpenAI response:', error.message);
setOutput('result', 'null');
}
});
});
req.on('error', error => {
console.log('Error generating summary:', error.message);
setOutput('result', 'null');
});
req.write(data);
req.end();
} catch (error) {
console.log('Error generating summary:', error.message);
setOutput('result', 'null');
}

View File

@@ -0,0 +1,59 @@
#!/usr/bin/env node
import { Octokit } from '@octokit/rest';
import fs from 'fs';
const token = process.env.GITHUB_TOKEN;
const repo = process.env.GITHUB_REPOSITORY;
const issueNumber = process.env.GITHUB_EVENT_ISSUE_NUMBER;
if (!token || !repo || !issueNumber) {
console.log('Missing required environment variables');
process.exit(1);
}
const [owner, repoName] = repo.split('/');
const octokit = new Octokit({ auth: token });
function setOutput(name, value) {
fs.appendFileSync(process.env.GITHUB_OUTPUT, `${name}=${value}\n`);
}
async function getPRDetails() {
try {
console.log(
`Fetching PR details for ${owner}/${repoName}#${issueNumber}...`,
);
const { data: pr } = await octokit.rest.pulls.get({
owner,
repo: repoName,
pull_number: issueNumber,
});
console.log('PR details fetched successfully');
console.log('- PR Number:', pr.number);
console.log('- PR Author:', pr.user.login);
console.log('- PR Title:', pr.title);
const result = {
number: pr.number,
author: pr.user.login,
title: pr.title,
};
setOutput('result', JSON.stringify(result));
} catch (error) {
console.log('Error getting PR details:', error.message);
console.log('Stack:', error.stack);
setOutput('result', 'null');
process.exit(1);
}
}
getPRDetails().catch(error => {
console.log('Unhandled error:', error.message);
console.log('Stack:', error.stack);
setOutput('result', 'null');
process.exit(1);
});

View File

@@ -1,30 +0,0 @@
#!/bin/bash
set -euo pipefail
if [ "$#" -gt 0 ]; then
version="${1#v}"
else
version=""
fi
files_to_bump=(
packages/api/package.json
packages/desktop-client/package.json
packages/desktop-electron/package.json
)
for file in "${files_to_bump[@]}"; do
if [ -z "$version" ]; then
# version format: YY.MM.patch
# logic: if before the 25th, bump patch, else set minor/major to next month
version="$(jq -r .version "$file" | perl -e '($y,$m,$p)=split/\./,<>;$d=(localtime)[3];$d>25?($p=0,++$m,$m>12&&($m=1,++$y)):$p++;print"$y.$m.$p\n"')"
if [ -z "$version" ]; then
echo "Error: Failed to calculate new version" >&2
exit 1
fi
fi
echo "Bumping $file to version $version"
jq '.version = "'"$version"'"' "$file" > "$file.tmp"
mv "$file.tmp" "$file"
done

View File

@@ -1,4 +1,5 @@
name: Setup
description: Setup the environment for the project
inputs:
working-directory:
@@ -16,17 +17,31 @@ runs:
- name: Install node
uses: actions/setup-node@v4
with:
node-version: 18.16.0
node-version: 22
- name: Install yarn
run: npm install -g yarn
shell: bash
if: ${{ env.ACT }}
- name: Get Node version
id: get-node
run: echo "version=$(node -v)" >> "$GITHUB_OUTPUT"
shell: bash
- name: Cache
uses: actions/cache@v4
id: cache
with:
path: ${{ format('{0}/**/node_modules', inputs.working-directory) }}
key: yarn-v1-${{ runner.os }}-${{ hashFiles(format('{0}/.nvmrc', inputs.working-directory)) }}-${{ hashFiles(format('{0}/**/yarn.lock', inputs.working-directory)) }}
key: yarn-v1-${{ runner.os }}-${{ steps.get-node.outputs.version }}-${{ hashFiles(format('{0}/**/yarn.lock', inputs.working-directory)) }}
- name: Ensure Lage cache directory exists
run: mkdir -p ${{ format('{0}/.lage', inputs.working-directory) }}
shell: bash
- name: Cache Lage
uses: actions/cache@v4
with:
path: ${{ format('{0}/.lage', inputs.working-directory) }}
key: lage-${{ runner.os }}-${{ github.sha }}
restore-keys: |
lage-${{ runner.os }}-
- name: Install
working-directory: ${{ inputs.working-directory }}
run: yarn --immutable

363
.github/scripts/count-points.mjs vendored Normal file
View File

@@ -0,0 +1,363 @@
import { Octokit } from '@octokit/rest';
import { minimatch } from 'minimatch';
import pLimit from 'p-limit';
const limit = pLimit(50);
/** Repository-specific configuration for points calculation */
const REPOSITORY_CONFIG = new Map([
[
'actual',
{
POINTS_PER_ISSUE_TRIAGE_ACTION: 1,
POINTS_PER_ISSUE_CLOSING_ACTION: 1,
POINTS_PER_RELEASE_PR: 0,
PR_REVIEW_POINT_TIERS: [
{ minChanges: 500, points: 8 },
{ minChanges: 100, points: 6 },
{ minChanges: 10, points: 2 },
{ minChanges: 0, points: 1 },
],
EXCLUDED_FILES: [
'yarn.lock',
'.yarn/**/*',
'packages/component-library/src/icons/**/*',
'release-notes/**/*',
],
},
],
[
'docs',
{
POINTS_PER_ISSUE_TRIAGE_ACTION: 1,
POINTS_PER_ISSUE_CLOSING_ACTION: 1,
POINTS_PER_RELEASE_PR: 4,
PR_REVIEW_POINT_TIERS: [
{ minChanges: 2000, points: 6 },
{ minChanges: 200, points: 4 },
{ minChanges: 0, points: 2 },
],
EXCLUDED_FILES: ['yarn.lock', '.yarn/**/*'],
},
],
]);
/**
* Get the start and end dates for the last month.
* @returns {Object} An object containing the start and end dates.
*/
function getLastMonthDates() {
// Get data relating to the last month
const now = new Date();
// Always use UTC for calculations
const firstDayOfLastMonth = new Date(
Date.UTC(now.getUTCFullYear(), now.getUTCMonth() - 1, 1, 0, 0, 0, 0),
);
const since = process.env.START_DATE
? new Date(Date.parse(process.env.START_DATE))
: firstDayOfLastMonth;
// Calculate the end of the month for the since date in UTC
const until = new Date(
Date.UTC(
since.getUTCFullYear(),
since.getUTCMonth() + 1,
0,
23,
59,
59,
999,
),
);
return { since, until };
}
/**
* Used for calculating the monthly points each core contributor has earned.
* These are used for payouts depending.
* @param {string} repo - The repository to analyze ('actual' or 'docs')
* @returns {number} The total points earned for the repository
*/
async function countContributorPoints(repo) {
const octokit = new Octokit({
auth: process.env.GITHUB_TOKEN,
});
const owner = 'actualbudget';
const config = REPOSITORY_CONFIG.get(repo);
const { since, until } = getLastMonthDates();
// Get organization members
const { data: orgMembers } = await octokit.orgs.listMembers({
org: owner,
});
const orgMemberLogins = new Set(orgMembers.map(member => member.login));
// Initialize stats map with all org members
const stats = new Map(
Array.from(orgMemberLogins).map(login => [
login,
{
reviews: [], // Will store objects with PR number and points
labelRemovals: [],
issueClosings: [],
points: 0,
},
]),
);
// Helper function to print statistics
const printStats = (title, getValue, formatLine) => {
console.log(`\n${title}:`);
console.log('='.repeat(title.length + 1));
const entries = Array.from(stats.entries())
.map(([user, userStats]) => [user, getValue(userStats)])
.filter(([, count]) => count > 0)
.sort((a, b) => b[1] - a[1]);
if (entries.length === 0) {
console.log(`No ${title.toLowerCase()} found in the last month.`);
} else {
entries.forEach(([user, count]) => {
console.log(formatLine(user, count));
});
}
};
// Get all PRs using search
const searchQuery = `repo:${owner}/${repo} is:pr is:merged merged:${since.toISOString()}..${until.toISOString()}`;
const recentPRs = await octokit.paginate(
'GET /search/issues',
{
q: searchQuery,
per_page: 100,
advanced_search: true,
},
response => response.data.filter(pr => pr.number),
);
// Get reviews and PR details for each PR
await Promise.all(
recentPRs.map(pr =>
limit(async () => {
const [reviews, modifiedFiles] = await Promise.all([
octokit.pulls.listReviews({ owner, repo, pull_number: pr.number }),
octokit.paginate(
octokit.pulls.listFiles,
{
owner,
repo,
pull_number: pr.number,
per_page: 100,
},
res => res.data,
),
]);
const totalChanges = modifiedFiles
.filter(
file =>
!config.EXCLUDED_FILES.some(pattern =>
minimatch(file.filename, pattern),
),
)
.reduce((sum, file) => sum + file.additions + file.deletions, 0);
const isReleasePR = pr.title.match(/🔖.*\d+\.\d+\.\d+/);
const prPoints =
config.PR_REVIEW_POINT_TIERS.find(t => totalChanges >= t.minChanges)
?.points ?? 0;
if (isReleasePR) {
if (stats.has(pr.user.login)) {
const creatorStats = stats.get(pr.user.login);
creatorStats.reviews.push({
pr: pr.number.toString(),
points: config.POINTS_PER_RELEASE_PR,
isReleaseCreator: true,
});
creatorStats.points += config.POINTS_PER_RELEASE_PR;
}
} else {
const uniqueReviewers = new Set();
reviews.data
.filter(
review =>
stats.has(review.user?.login) &&
review.state === 'APPROVED' &&
!uniqueReviewers.has(review.user?.login),
)
.forEach(({ user: { login: reviewer } }) => {
uniqueReviewers.add(reviewer);
const userStats = stats.get(reviewer);
userStats.reviews.push({
pr: pr.number.toString(),
points: prPoints,
});
userStats.points += prPoints;
});
}
}),
),
);
// Get all issues with label events in the last month
const issues = await octokit.paginate(octokit.issues.listForRepo, {
owner,
repo,
state: 'all',
sort: 'updated',
direction: 'desc',
per_page: 100,
since: since.toISOString(),
});
// Get label events for each issue
await Promise.all(
issues.map(issue =>
limit(async () => {
const { data: events } = await octokit.issues.listEventsForTimeline({
owner,
repo,
issue_number: issue.number,
});
events
.filter(event => {
const createdAt = new Date(event.created_at);
return (
createdAt.getTime() > since.getTime() &&
createdAt.getTime() <= until.getTime() &&
stats.has(event.actor?.login)
);
})
.forEach(event => {
if (
event.event === 'unlabeled' &&
event.label?.name.toLowerCase() === 'needs triage'
) {
const remover = event.actor.login;
const userStats = stats.get(remover);
userStats.labelRemovals.push(issue.number.toString());
userStats.points += config.POINTS_PER_ISSUE_TRIAGE_ACTION;
}
if (
event.event === 'closed' &&
event.state_reason === 'not_planned'
) {
const closer = event.actor.login;
const userStats = stats.get(closer);
userStats.issueClosings.push(issue.number.toString());
userStats.points += config.POINTS_PER_ISSUE_CLOSING_ACTION;
}
});
}),
),
);
// Print all statistics
printStats(
`PR Review Statistics (${repo})`,
stats => stats.reviews.length,
(user, count) =>
`${user}: ${count} (PRs: ${stats
.get(user)
.reviews.map(r => {
if (r.isReleaseCreator) {
return `#${r.pr} (${r.points}pts - Release Creator)`;
}
return `#${r.pr} (${r.points}pts)`;
})
.join(', ')})`,
);
printStats(
`"Needs Triage" Label Removal Statistics (${repo})`,
stats => stats.labelRemovals.length,
(user, count) =>
`${user}: ${count} (Issues: ${stats.get(user).labelRemovals.join(', ')})`,
);
printStats(
`Issue Closing Statistics (${repo})`,
stats => stats.issueClosings.length,
(user, count) =>
`${user}: ${count} (Issues: ${stats.get(user).issueClosings.join(', ')})`,
);
// Print points summary
printStats(
`Points Summary (${repo})`,
stats => stats.points,
(user, userPoints) => `${user}: ${userPoints}`,
);
// Calculate and print total points
const totalPoints = Array.from(stats.values()).reduce(
(sum, userStats) => sum + userStats.points,
0,
);
console.log(`\nTotal points earned for ${repo}: ${totalPoints}`);
// Return the points
return new Map(
Array.from(stats.entries()).map(([login, userStats]) => [
login,
userStats.points,
]),
);
}
/**
* Calculate the points for both repositories and print cumulative results
*/
async function calculateCumulativePoints() {
// Get stats for each repository
const repoPointsResults = await Promise.all(
Array.from(REPOSITORY_CONFIG.keys()).map(countContributorPoints),
);
// Calculate cumulative stats
const cumulativeStats = new Map(repoPointsResults[0]);
// Combine stats from all repositories
for (let i = 1; i < repoPointsResults.length; i++) {
for (const [login, points] of repoPointsResults[i].entries()) {
if (!cumulativeStats.has(login)) {
cumulativeStats.set(login, 0);
}
cumulativeStats.set(login, cumulativeStats.get(login) + points);
}
}
// Print cumulative statistics
console.log('\n\nCUMULATIVE STATISTICS ACROSS ALL REPOSITORIES');
console.log('='.repeat(50));
console.log('\nCumulative Points Summary:');
console.log('='.repeat('Cumulative Points Summary'.length + 1));
const entries = Array.from(cumulativeStats.entries())
.filter(([, count]) => count > 0)
.sort((a, b) => b[1] - a[1]);
if (entries.length === 0) {
console.log('No cumulative points summary found.');
} else {
entries.forEach(([user, points]) => {
console.log(`${user}: ${points}`);
});
}
// Calculate and print total cumulative points
const totalCumulativePoints = Array.from(cumulativeStats.values()).reduce(
(sum, points) => sum + points,
0,
);
console.log('\nTotal cumulative points earned: ' + totalCumulativePoints);
}
// Run the calculations
calculateCumulativePoints().catch(console.error);

View File

@@ -0,0 +1,89 @@
name: Generate Release Notes from CodeRabbit summary
on:
issue_comment:
types: [created]
jobs:
generate-release-notes:
# Only run on PR comments from CodeRabbit bot
if: github.event.issue.pull_request && github.event.comment.user.login == 'coderabbitai[bot]'
runs-on: ubuntu-latest
timeout-minutes: 10
permissions:
contents: write
pull-requests: write
issues: write
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Check if this is CodeRabbit's first comment
id: check-first-comment
run: node .github/actions/ai-generated-release-notes/check-first-comment.js
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_REPOSITORY: ${{ github.repository }}
GITHUB_EVENT_ISSUE_NUMBER: ${{ github.event.issue.number }}
GITHUB_EVENT_COMMENT_ID: ${{ github.event.comment.id }}
- name: Get PR details
if: steps.check-first-comment.outputs.result == 'true'
id: pr-details
run: node .github/actions/ai-generated-release-notes/pr-details.js
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_REPOSITORY: ${{ github.repository }}
GITHUB_EVENT_ISSUE_NUMBER: ${{ github.event.issue.number }}
- name: Check if release notes file already exists
if: steps.check-first-comment.outputs.result == 'true' && steps.pr-details.outputs.result != 'null'
id: check-release-notes-exists
run: node .github/actions/ai-generated-release-notes/check-release-notes-exists.js
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_REPOSITORY: ${{ github.repository }}
GITHUB_EVENT_ISSUE_NUMBER: ${{ github.event.issue.number }}
PR_DETAILS: ${{ steps.pr-details.outputs.result }}
- name: Generate summary with OpenAI
if: steps.check-first-comment.outputs.result == 'true' && steps.check-release-notes-exists.outputs.result == 'false'
id: generate-summary
run: node .github/actions/ai-generated-release-notes/generate-summary.js
env:
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
GITHUB_EVENT_COMMENT_BODY: ${{ github.event.comment.body }}
PR_DETAILS: ${{ steps.pr-details.outputs.result }}
- name: Determine category with OpenAI
if: steps.check-first-comment.outputs.result == 'true' && steps.check-release-notes-exists.outputs.result == 'false' && steps.generate-summary.outputs.result != 'null'
id: determine-category
run: node .github/actions/ai-generated-release-notes/determine-category.js
env:
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
GITHUB_EVENT_COMMENT_BODY: ${{ github.event.comment.body }}
PR_DETAILS: ${{ steps.pr-details.outputs.result }}
SUMMARY_DATA: ${{ steps.generate-summary.outputs.result }}
- name: Create and commit release notes file via GitHub API
if: steps.check-first-comment.outputs.result == 'true' && steps.check-release-notes-exists.outputs.result == 'false' && steps.generate-summary.outputs.result != 'null' && steps.determine-category.outputs.result != 'null' && steps.determine-category.outputs.result != ''
run: node .github/actions/ai-generated-release-notes/create-release-notes-file.js
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_REPOSITORY: ${{ github.repository }}
GITHUB_EVENT_ISSUE_NUMBER: ${{ github.event.issue.number }}
SUMMARY_DATA: ${{ steps.generate-summary.outputs.result }}
CATEGORY: ${{ steps.determine-category.outputs.result }}
- name: Comment on PR
if: steps.check-first-comment.outputs.result == 'true' && steps.check-release-notes-exists.outputs.result == 'false' && steps.generate-summary.outputs.result != 'null' && steps.determine-category.outputs.result != 'null' && steps.determine-category.outputs.result != ''
run: node .github/actions/ai-generated-release-notes/comment-on-pr.js
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_REPOSITORY: ${{ github.repository }}
GITHUB_EVENT_ISSUE_NUMBER: ${{ github.event.issue.number }}
SUMMARY_DATA: ${{ steps.generate-summary.outputs.result }}
CATEGORY: ${{ steps.determine-category.outputs.result }}

23
.github/workflows/autofix.yml vendored Normal file
View File

@@ -0,0 +1,23 @@
name: autofix.ci
defaults:
run:
shell: bash
on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
permissions:
contents: read
jobs:
autofix:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Format code
run: yarn lint:fix
- uses: autofix-ci/action@635ffb0c9798bd160680f18fd73371e355b85f27

View File

@@ -24,6 +24,8 @@ jobs:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
with:
download-translations: 'false'
- name: Build API
run: cd packages/api && yarn build
- name: Create package tgz
@@ -40,6 +42,8 @@ jobs:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
with:
download-translations: 'false'
- name: Build CRDT
run: cd packages/crdt && yarn build
- name: Create package tgz
@@ -57,7 +61,7 @@ jobs:
- name: Set up environment
uses: ./.github/actions/setup
- name: Build Web
run: ./bin/package-browser
run: yarn build:browser
- name: Upload Build
uses: actions/upload-artifact@v4
with:
@@ -75,8 +79,10 @@ jobs:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
with:
download-translations: 'false'
- name: Build Server
run: cd packages/sync-server && yarn build
run: yarn workspace @actual-app/sync-server build
- name: Upload Build
uses: actions/upload-artifact@v4
with:

View File

@@ -17,6 +17,8 @@ jobs:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
with:
download-translations: 'false'
- name: Lint
run: yarn lint
typecheck:
@@ -25,14 +27,30 @@ jobs:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
with:
download-translations: 'false'
- name: Typecheck
run: yarn typecheck
validate-cli:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
with:
download-translations: 'false'
- name: Build Web
run: yarn build:server
- name: Check that the built CLI works
run: node packages/sync-server/build/bin/actual-server.js --version
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
with:
download-translations: 'false'
- name: Test
run: yarn test
@@ -43,6 +61,6 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '19'
node-version: 22
- name: Check migrations
run: node ./.github/actions/check-migrations.js

26
.github/workflows/count-points.yml vendored Normal file
View File

@@ -0,0 +1,26 @@
name: Count points
on:
schedule:
# Run at 00:00 on the first day of every month
- cron: '0 0 1 * *'
workflow_dispatch:
inputs:
startDate:
description: 'Start date for point counter (YYYY-MM-DD)'
required: true
type: string
jobs:
count-points:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Count points
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
START_DATE: ${{ inputs.startDate }}
run: node .github/scripts/count-points.mjs

View File

@@ -1,30 +1,25 @@
name: Build Edge Docker Image
# Edge Docker images are built for every commit, and daily
# Edge Docker images are built for every push to master
on:
push:
branches:
- master
paths:
- 'packages/sync-server/**'
pull_request:
branches:
- master
paths:
- 'packages/sync-server/**'
schedule:
- cron: '0 0 * * *'
workflow_dispatch:
concurrency:
group: docker-edge-build
cancel-in-progress: true
permissions:
contents: read
packages: write
env:
IMAGES: |
actualbudget/actual-server
ghcr.io/actualbudget/actual-server
ghcr.io/actualbudget/actual
${{ !github.event.repository.fork && 'actualbudget/actual-server' || '' }}
ghcr.io/${{ github.repository_owner }}/actual-server
ghcr.io/${{ github.repository_owner }}/actual
# Creates the following tags:
# - actual-server:edge
@@ -34,7 +29,7 @@ env:
jobs:
build:
if: ${{ github.event.repository.fork == false }}
if: github.event_name == 'workflow_dispatch' || !github.event.repository.fork
name: Build Docker image
runs-on: ubuntu-latest
strategy:
@@ -60,7 +55,7 @@ jobs:
- name: Login to Docker Hub
uses: docker/login-action@v3
if: github.event_name != 'pull_request'
if: github.event_name != 'pull_request' && !github.event.repository.fork
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
@@ -73,17 +68,36 @@ jobs:
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Download artifacts
run: ./packages/sync-server/docker/download-artifacts.sh
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Building outside of the docker image allows us to build once and push to multiple platforms
# This is faster and avoids yarn memory issues
- name: Set up environment
uses: ./.github/actions/setup
- name: Build Web
run: yarn build:server
- name: Build and push image
- name: Build image for testing
uses: docker/build-push-action@v5
with:
context: .
push: false
load: true
file: packages/sync-server/docker/${{ matrix.os }}.Dockerfile
tags: actualbudget/actual-server-testing
- name: Test that the docker image boots
run: |
docker run --detach --network=host actualbudget/actual-server-testing
sleep 5
curl --fail -sS -LI -w '%{http_code}\n' --retry 10 --retry-delay 1 --retry-connrefused localhost:5006
# This will use the cache from the earlier build step and not rebuild the image
# https://docs.docker.com/build/ci/github-actions/test-before-push/
- name: Build and push images
uses: docker/build-push-action@v5
with:
context: .
push: ${{ github.event_name != 'pull_request' }}
file: packages/sync-server/docker/edge-${{ matrix.os }}.Dockerfile
file: packages/sync-server/docker/${{ matrix.os }}.Dockerfile
platforms: linux/amd64,linux/arm64,linux/arm/v7${{ matrix.os == 'alpine' && ',linux/arm/v6' || '' }}
tags: ${{ steps.meta.outputs.tags }}
build-args: |

View File

@@ -70,12 +70,19 @@ jobs:
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
# Building outside of the docker image allows us to build once and push to multiple platforms
# This is faster and avoids yarn memory issues
- name: Set up environment
uses: ./.github/actions/setup
- name: Build Web
run: yarn build:server
- name: Build and push ubuntu image
uses: docker/build-push-action@v5
with:
context: .
push: true
file: packages/sync-server/docker/stable-ubuntu.Dockerfile
file: packages/sync-server/docker/ubuntu.Dockerfile
platforms: linux/amd64,linux/arm64,linux/arm/v7
tags: ${{ steps.meta.outputs.tags }}
@@ -84,6 +91,6 @@ jobs:
with:
context: .
push: true
file: packages/sync-server/docker/stable-alpine.Dockerfile
file: packages/sync-server/docker/alpine.Dockerfile
platforms: linux/amd64,linux/arm64,linux/arm/v7,linux/arm/v6
tags: ${{ steps.alpine-meta.outputs.tags }}

View File

@@ -32,11 +32,13 @@ jobs:
needs: netlify
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.41.1-jammy
image: mcr.microsoft.com/playwright:v1.56.0-jammy
steps:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Trust the repository directory
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Run E2E Tests on Netlify URL
run: yarn e2e
env:
@@ -48,12 +50,35 @@ jobs:
path: packages/desktop-client/test-results/
retention-days: 30
overwrite: true
functional-desktop-app:
name: Functional Desktop App
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.56.0-jammy
steps:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Trust the repository directory
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Run Desktop app E2E Tests
run: |
xvfb-run --auto-servernum --server-args="-screen 0 1920x1080x24" -- yarn e2e:desktop
- uses: actions/upload-artifact@v4
if: always()
with:
name: desktop-app-test-results
path: packages/desktop-electron/e2e/test-results/
retention-days: 30
overwrite: true
vrt:
name: Visual regression
needs: netlify
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.41.1-jammy
image: mcr.microsoft.com/playwright:v1.56.0-jammy
steps:
- uses: actions/checkout@v4
- name: Set up environment

View File

@@ -24,7 +24,7 @@ jobs:
strategy:
matrix:
os:
- ubuntu-latest
- ubuntu-22.04
- windows-latest
- macos-latest
runs-on: ${{ matrix.os }}
@@ -44,9 +44,9 @@ jobs:
sudo apt-get install flatpak -y
sudo apt-get install flatpak-builder -y
sudo flatpak remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo
sudo flatpak install org.freedesktop.Sdk/x86_64/23.08 -y
sudo flatpak install org.freedesktop.Platform/x86_64/23.08 -y
sudo flatpak install org.electronjs.Electron2.BaseApp/x86_64/23.08 -y
sudo flatpak install org.freedesktop.Sdk//24.08 -y
sudo flatpak install org.freedesktop.Platform//24.08 -y
sudo flatpak install org.electronjs.Electron2.BaseApp//24.08 -y
- name: Set up environment
uses: ./.github/actions/setup
- name: Build Electron for Mac
@@ -57,6 +57,7 @@ jobs:
CSC_LINK: ${{ secrets.CSC_LINK }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
- name: Build Electron
if: ${{ ! startsWith(matrix.os, 'macos') }}
run: ./bin/package-electron
@@ -77,13 +78,68 @@ jobs:
name: actual-electron-${{ matrix.os }}-appx
path: |
packages/desktop-electron/dist/*.appx
- name: Add to Release
- name: Process release version
id: process_version
run: |
echo "version=${GITHUB_REF_NAME#v}" >> "$GITHUB_OUTPUT"
- name: Add to new release
uses: softprops/action-gh-release@v2
with:
draft: true
body: |
:link: [View release notes](https://actualbudget.org/blog/release-${{ steps.process_version.outputs.version }})
## Desktop releases
Please note: Microsoft store updates can sometimes lag behind the main release by a couple of days while they verify the new version.
<a href="https://apps.microsoft.com/detail/9p2hmlhsdbrm?cid=Github+Releases&mode=direct">
<img src="https://get.microsoft.com/images/en-us%20dark.svg" width="200"/>
</a>
files: |
packages/desktop-electron/dist/*.dmg
packages/desktop-electron/dist/*.exe
!packages/desktop-electron/dist/Actual-windows.exe
packages/desktop-electron/dist/*.AppImage
packages/desktop-electron/dist/*.flatpak
publish-microsoft-store:
needs: build
runs-on: windows-latest
if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') }}
steps:
- name: Install StoreBroker
shell: powershell
run: |
Install-Module -Name StoreBroker -AcceptLicense -Force -Scope CurrentUser -Verbose
- name: Download Microsoft Store artifacts
uses: actions/download-artifact@v4
with:
name: actual-electron-windows-latest-appx
- name: Submit to Microsoft Store
shell: powershell
run: |
# Disable telemetry
$global:SBDisableTelemetry = $true
# Authenticate against the store
$pass = ConvertTo-SecureString -String '${{ secrets.MICROSOFT_STORE_CLIENT_SECRET }}' -AsPlainText -Force
$cred = New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList ${{ secrets.MICROSOFT_STORE_CLIENT_ID }},$pass
Set-StoreBrokerAuthentication -TenantId '${{ secrets.MICROSOFT_STORE_TENANT_ID }}' -Credential $cred
# Zip and create metadata files
$artifacts = Get-ChildItem -Path . -Filter *.appx | Select-Object -ExpandProperty FullName
New-StoreBrokerConfigFile -Path "$PWD/config.json" -AppId ${{ secrets.MICROSOFT_STORE_PRODUCT_ID }}
New-SubmissionPackage -ConfigPath "$PWD/config.json" -DisableAutoPackageNameFormatting -AppxPath $artifacts -OutPath "$PWD" -OutName submission
# Submit the app
# See https://github.com/microsoft/StoreBroker/blob/master/Documentation/USAGE.md#the-easy-way
Update-ApplicationSubmission `
-AppId ${{ secrets.MICROSOFT_STORE_PRODUCT_ID }} `
-SubmissionDataPath "submission.json" `
-PackagePath "submission.zip" `
-ReplacePackages `
-NoStatus `
-AutoCommit `
-Force

View File

@@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os:
- ubuntu-latest
- ubuntu-22.04
- windows-latest
- macos-latest
runs-on: ${{ matrix.os }}
@@ -39,9 +39,9 @@ jobs:
sudo apt-get install flatpak -y
sudo apt-get install flatpak-builder -y
sudo flatpak remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo
sudo flatpak install org.freedesktop.Sdk/x86_64/23.08 -y
sudo flatpak install org.freedesktop.Platform/x86_64/23.08 -y
sudo flatpak install org.electronjs.Electron2.BaseApp/x86_64/23.08 -y
sudo flatpak install org.freedesktop.Sdk//24.08 -y
sudo flatpak install org.freedesktop.Platform//24.08 -y
sudo flatpak install org.electronjs.Electron2.BaseApp//24.08 -y
- name: Set up environment
uses: ./.github/actions/setup
- name: Build Electron

View File

@@ -24,8 +24,29 @@ jobs:
id: bump_package_versions
shell: bash
run: |
.github/actions/bump-package-versions ${{ github.event.inputs.version }}
echo "version=$(jq -r .version packages/desktop-client/package.json)" > $GITHUB_OUTPUT
declare -A packages=(
[web]="desktop-client"
[electron]="desktop-electron"
[sync]="sync-server"
[api]="api"
)
for key in "${!packages[@]}"; do
pkg="${packages[$key]}"
if [[ -n "${{ github.event.inputs.version }}" ]]; then
version="${{ github.event.inputs.version }}"
else
version=$(node ./packages/ci-actions/bin/get-next-package-version.js \
--package-json "./packages/$pkg/package.json" \
--type auto \
--update)
fi
eval "NEW_${key^^}_VERSION=\"$version\""
done
echo "version=$NEW_WEB_VERSION" >> "$GITHUB_OUTPUT"
- name: Create PR
uses: peter-evans/create-pull-request@v7
with:

View File

@@ -3,7 +3,7 @@ name: Extract and upload i18n strings
on:
schedule:
# 4am UTC
- cron: "0 4 * * *"
- cron: '0 4 * * *'
workflow_dispatch:
jobs:
@@ -19,7 +19,7 @@ jobs:
uses: ./actual/.github/actions/setup
with:
working-directory: actual
download-translations: false # As we'll manually clone instead
download-translations: false # As we'll manually clone instead
- name: Configure Git config
run: |
git config --global user.name "github-actions[bot]"
@@ -78,7 +78,7 @@ jobs:
actualbudget/actual
- name: Unlock translations
if: always() # Clean up even on failure
if: always() # Clean up even on failure
run: |
wlc \
--url https://hosted.weblate.org/api/ \

View File

@@ -24,7 +24,7 @@ jobs:
body: |
:sparkles: Thanks for sharing your idea! :sparkles:
This repository uses lodash style issue management for enhancements. That means enhancement issues are automatically closed. This doesnt mean we dont accept feature requests, though! We will consider implementing ones that receive many upvotes, and we welcome contributions for any feature requests marked as needing votes (just post a comment first so we can help you make a successful contribution).
This repository uses a voting-based system for feature requests. While enhancement issues are automatically closed, we still welcome feature requests! The voting system helps us gauge community interest in potential features. We also encourage community contributions for any feature requests marked as needing votes (just post a comment first so we can help guide you toward a successful contribution).
The enhancement backlog can be found here: https://github.com/actualbudget/actual/issues?q=label%3A%22needs+votes%22+sort%3Areactions-%2B1-desc+

View File

@@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '19'
node-version: 22
- name: Handle feature requests
run: node .github/actions/handle-feature-requests.js
env:

View File

@@ -22,15 +22,15 @@ jobs:
steps:
- name: Repository Checkout
uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Install Netlify
run: npm install netlify-cli@17.10.1 -g
- name: Build Actual
run: ./bin/package-browser
run: yarn build:browser
- name: Deploy to Netlify
id: netlify_deploy
@@ -40,4 +40,4 @@ jobs:
--site ${{ secrets.NETLIFY_SITE_ID }} \
--auth ${{ secrets.NETLIFY_API_TOKEN }} \
--filter @actual-app/web \
--prod
--prod

View File

@@ -0,0 +1,95 @@
name: Publish nightly npm packages
# Nightly npm packages are built daily
on:
schedule:
- cron: '0 0 * * *'
workflow_dispatch:
jobs:
build-and-pack:
runs-on: ubuntu-latest
name: Build and pack npm packages
if: github.event.repository.fork == false
steps:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Update package versions
run: |
# Get new nightly versions
NEW_WEB_VERSION=$(node ./packages/ci-actions/bin/get-next-package-version.js --package-json ./packages/desktop-client/package.json --type nightly)
NEW_SYNC_VERSION=$(node ./packages/ci-actions/bin/get-next-package-version.js --package-json ./packages/sync-server/package.json --type nightly)
NEW_API_VERSION=$(node ./packages/ci-actions/bin/get-next-package-version.js --package-json ./packages/api/package.json --type nightly)
# Set package versions
npm version $NEW_WEB_VERSION --no-git-tag-version --workspace=@actual-app/web --no-workspaces-update
npm version $NEW_SYNC_VERSION --no-git-tag-version --workspace=@actual-app/sync-server --no-workspaces-update
npm version $NEW_API_VERSION --no-git-tag-version --workspace=@actual-app/api --no-workspaces-update
- name: Yarn install
run: |
yarn install
- name: Build Server & Web
run: yarn build:server
- name: Pack the web and server packages
run: |
yarn workspace @actual-app/web pack --filename @actual-app/web.tgz
yarn workspace @actual-app/sync-server pack --filename @actual-app/sync-server.tgz
- name: Build API
run: yarn build:api
- name: Pack the api package
run: |
yarn workspace @actual-app/api pack --filename @actual-app/api.tgz
- name: Upload package artifacts
uses: actions/upload-artifact@v4
with:
name: npm-packages
path: |
packages/desktop-client/@actual-app/web.tgz
packages/sync-server/@actual-app/sync-server.tgz
packages/api/@actual-app/api.tgz
publish:
runs-on: ubuntu-latest
name: Publish Nightly npm packages
needs: build-and-pack
permissions:
contents: read
packages: write
steps:
- name: Download the artifacts
uses: actions/download-artifact@v4
with:
name: npm-packages
- name: Setup node and npm registry
uses: actions/setup-node@v4
with:
node-version: 22
registry-url: 'https://registry.npmjs.org'
- name: Publish Web
run: |
npm publish desktop-client/@actual-app/web.tgz --access public --tag nightly
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Publish Sync-Server
run: |
npm publish sync-server/@actual-app/sync-server.tgz --access public --tag nightly
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Publish API
run: |
npm publish api/@actual-app/api.tgz --access public --tag nightly
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

View File

@@ -0,0 +1,78 @@
name: Publish npm packages
# # Npm packages are published for every new tag
on:
push:
tags:
- 'v*.*.*'
jobs:
build-and-pack:
runs-on: ubuntu-latest
name: Build and pack npm packages
steps:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Build Web
run: yarn build:server
- name: Pack the web and server packages
run: |
yarn workspace @actual-app/web pack --filename @actual-app/web.tgz
yarn workspace @actual-app/sync-server pack --filename @actual-app/sync-server.tgz
- name: Build API
run: yarn build:api
- name: Pack the api package
run: |
yarn workspace @actual-app/api pack --filename @actual-app/api.tgz
- name: Upload package artifacts
uses: actions/upload-artifact@v4
with:
name: npm-packages
path: |
packages/desktop-client/@actual-app/web.tgz
packages/sync-server/@actual-app/sync-server.tgz
packages/api/@actual-app/api.tgz
publish:
runs-on: ubuntu-latest
name: Publish npm packages
needs: build-and-pack
permissions:
contents: read
packages: write
steps:
- name: Download the artifacts
uses: actions/download-artifact@v4
with:
name: npm-packages
- name: Setup node and npm registry
uses: actions/setup-node@v4
with:
node-version: 22
registry-url: 'https://registry.npmjs.org'
- name: Publish Web
run: |
npm publish desktop-client/@actual-app/web.tgz --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Publish Sync-Server
run: |
npm publish sync-server/@actual-app/sync-server.tgz --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Publish API
run: |
npm publish api/@actual-app/api.tgz --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

View File

@@ -54,6 +54,7 @@ jobs:
with:
branch: ${{github.base_ref}}
workflow: build.yml
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
name: build-stats
path: base
@@ -62,6 +63,7 @@ jobs:
with:
pr: ${{github.event.pull_request.number}}
workflow: build.yml
workflow_conclusion: '' # ignore the conclusion of the workflow, since we already checked it
name: build-stats
path: head
allow_forks: true
@@ -81,7 +83,7 @@ jobs:
base-stats-json-path: ./base/web-stats.json
title: desktop-client
- uses: github/webpack-bundlesize-compare-action@v2.1.0
- uses: twk3/rollup-size-compare-action@v1.1.1
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
current-stats-json-path: ./head/loot-core-stats.json

View File

@@ -2,6 +2,7 @@ name: 'Close stale PRs'
on:
schedule:
- cron: '30 1 * * *'
workflow_dispatch: # Allow manual triggering
jobs:
stale:
@@ -24,3 +25,18 @@ jobs:
any-of-labels: ':construction: WIP'
days-before-close: -1
days-before-issue-stale: -1
stale-needs-info:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v9
with:
stale-issue-label: 'needs info'
days-before-stale: -1
days-before-close: 7
close-issue-message: 'This issue has been automatically closed because there have been no comments for 7 days after the "needs info" label was added. If you still need help, please feel free to reopen the issue with the requested information.'
remove-stale-when-updated: false
stale-pr-message: '' # Disable PR processing
close-pr-message: '' # Disable PR processing
days-before-pr-stale: -1 # Disable PR processing
days-before-pr-close: -1 # Disable PR processing

View File

@@ -1,115 +0,0 @@
name: /update-vrt
on:
issue_comment:
types: [ created ]
permissions:
pull-requests: read
contents: read
concurrency:
group: ${{ github.workflow }}-${{ github.event.issue.number }}-${{ contains(github.event.comment.body, '/update-vrt') }}
cancel-in-progress: true
jobs:
update-vrt:
name: Update VRT
runs-on: ubuntu-latest
if: |
github.event.issue.pull_request &&
contains(github.event.comment.body, '/update-vrt')
container:
image: mcr.microsoft.com/playwright:v1.41.1-jammy
steps:
- name: Get PR branch
# Until https://github.com/xt0rted/pull-request-comment-branch/issues/322 is resolved we use the forked version
uses: gotson/pull-request-comment-branch@head-repo-owner-dist
id: comment-branch
- uses: actions/checkout@v4
with:
repository: ${{ steps.comment-branch.outputs.head_owner }}/${{ steps.comment-branch.outputs.head_repo }}
ref: ${{ steps.comment-branch.outputs.head_ref }}
- name: Set up environment
uses: ./.github/actions/setup
- name: Wait for Netlify build to finish
id: netlify
env:
COMMIT_SHA: ${{ steps.comment-branch.outputs.head_sha }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: ./.github/actions/netlify-wait-for-build
- name: Run VRT Tests on Netlify URL
run: yarn vrt --update-snapshots
env:
E2E_START_URL: ${{ steps.netlify.outputs.url }}
- name: Create patch
run: |
git config --system --add safe.directory "*"
git config --global user.name "github-actions[bot]"
git config --global user.email "github-actions[bot]@users.noreply.github.com"
git reset
git add "**/*.png"
if git diff --staged --quiet; then
echo "No changes to commit"
exit 0
fi
git commit -m "Update VRT"
git format-patch -1 HEAD --stdout > Update-VRT.patch
- uses: actions/upload-artifact@v4
with:
name: patch
path: Update-VRT.patch
push-patch:
runs-on: ubuntu-latest
needs: update-vrt
permissions:
contents: write
pull-requests: write
steps:
- name: Get PR branch
# Until https://github.com/xt0rted/pull-request-comment-branch/issues/322 is resolved we use the forked version
uses: gotson/pull-request-comment-branch@head-repo-owner-dist
id: comment-branch
- uses: actions/checkout@v4
with:
repository: ${{ steps.comment-branch.outputs.head_owner }}/${{ steps.comment-branch.outputs.head_repo }}
ref: ${{ steps.comment-branch.outputs.head_ref }}
- uses: actions/download-artifact@v4
continue-on-error: true
with:
name: patch
- name: Apply patch and push
env:
BRANCH_NAME: ${{ steps.comment-branch.outputs.head_ref }}
run: |
git config --global user.name "github-actions[bot]"
git config --global user.email "github-actions[bot]@users.noreply.github.com"
git apply Update-VRT.patch
git add "**/*.png"
if git diff --staged --quiet; then
echo "No changes to commit"
exit 0
fi
git commit -m "Update VRT"
git push origin HEAD:${BRANCH_NAME}
- name: Add finished reaction
uses: dkershner6/reaction-action@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
commentId: ${{ github.event.comment.id }}
reaction: "rocket"
add-starting-reaction:
runs-on: ubuntu-latest
if: |
github.event.issue.pull_request &&
contains(github.event.comment.body, '/update-vrt')
permissions:
pull-requests: write
steps:
- name: React to comment
uses: dkershner6/reaction-action@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
commentId: ${{ github.event.comment.id }}
reaction: "+1"

156
.github/workflows/vrt-update-apply.yml vendored Normal file
View File

@@ -0,0 +1,156 @@
name: VRT Update - Apply
# SECURITY: This workflow runs in trusted base repo context.
# It treats the patch artifact as untrusted data, validates it contains only PNGs,
# and safely applies it to the contributor's fork branch.
on:
workflow_run:
workflows: ['VRT Update - Generate']
types:
- completed
permissions:
contents: write
pull-requests: write
jobs:
apply-vrt-updates:
name: Apply VRT Updates
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- name: Download patch artifact
uses: actions/download-artifact@v4
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
run-id: ${{ github.event.workflow_run.id }}
pattern: vrt-patch-*
path: /tmp/artifacts
- name: Download metadata artifact
uses: actions/download-artifact@v4
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
run-id: ${{ github.event.workflow_run.id }}
pattern: vrt-metadata-*
path: /tmp/metadata
- name: Extract metadata
id: metadata
run: |
# Find the metadata directory (will be vrt-metadata-{PR_NUMBER})
METADATA_DIR=$(find /tmp/metadata -mindepth 1 -maxdepth 1 -type d | head -n 1)
if [ -z "$METADATA_DIR" ]; then
echo "No metadata found, skipping..."
exit 0
fi
PR_NUMBER=$(cat "$METADATA_DIR/pr-number.txt")
HEAD_REF=$(cat "$METADATA_DIR/head-ref.txt")
HEAD_REPO=$(cat "$METADATA_DIR/head-repo.txt")
echo "pr_number=$PR_NUMBER" >> "$GITHUB_OUTPUT"
echo "head_ref=$HEAD_REF" >> "$GITHUB_OUTPUT"
echo "head_repo=$HEAD_REPO" >> "$GITHUB_OUTPUT"
echo "Found PR #$PR_NUMBER: $HEAD_REPO @ $HEAD_REF"
- name: Checkout fork branch
if: steps.metadata.outputs.pr_number != ''
uses: actions/checkout@v4
with:
repository: ${{ steps.metadata.outputs.head_repo }}
ref: ${{ steps.metadata.outputs.head_ref }}
token: ${{ secrets.GITHUB_TOKEN }}
fetch-depth: 0
- name: Validate and apply patch
if: steps.metadata.outputs.pr_number != ''
id: apply
run: |
# Find the patch file
PATCH_DIR=$(find /tmp/artifacts -mindepth 1 -maxdepth 1 -type d | head -n 1)
PATCH_FILE="$PATCH_DIR/vrt-update.patch"
if [ ! -f "$PATCH_FILE" ]; then
echo "No patch file found"
exit 0
fi
echo "Found patch file: $PATCH_FILE"
# Validate patch only contains PNG files
echo "Validating patch contains only PNG files..."
if grep -E '^(\+\+\+|---) [ab]/' "$PATCH_FILE" | grep -v '\.png$'; then
echo "ERROR: Patch contains non-PNG files! Rejecting for security."
echo "applied=false" >> "$GITHUB_OUTPUT"
echo "error=Patch validation failed: contains non-PNG files" >> "$GITHUB_OUTPUT"
exit 1
fi
# Extract file list for verification
FILES_CHANGED=$(grep -E '^\+\+\+ b/' "$PATCH_FILE" | sed 's/^+++ b\///' | wc -l)
echo "Patch modifies $FILES_CHANGED PNG file(s)"
# Configure git
git config --global user.name "github-actions[bot]"
git config --global user.email "github-actions[bot]@users.noreply.github.com"
# Apply patch
echo "Applying patch..."
if git apply --check "$PATCH_FILE" 2>&1; then
git apply "$PATCH_FILE"
# Stage only PNG files (extra safety)
git add "**/*.png"
if git diff --staged --quiet; then
echo "No changes after applying patch"
echo "applied=false" >> "$GITHUB_OUTPUT"
exit 0
fi
# Commit
git commit -m "Update VRT screenshots" -m "Auto-generated by VRT workflow" -m "PR: #${{ steps.metadata.outputs.pr_number }}"
echo "applied=true" >> "$GITHUB_OUTPUT"
else
echo "Patch could not be applied cleanly"
echo "applied=false" >> "$GITHUB_OUTPUT"
echo "error=Patch conflicts with current branch state" >> "$GITHUB_OUTPUT"
exit 1
fi
- name: Push changes
if: steps.apply.outputs.applied == 'true'
env:
HEAD_REF: ${{ steps.metadata.outputs.head_ref }}
HEAD_REPO: ${{ steps.metadata.outputs.head_repo }}
run: |
git push origin "HEAD:refs/heads/$HEAD_REF"
echo "Successfully pushed VRT updates to $HEAD_REPO@$HEAD_REF"
- name: Comment on PR - Success
if: steps.apply.outputs.applied == 'true'
uses: actions/github-script@v7
with:
script: |
await github.rest.issues.createComment({
issue_number: ${{ steps.metadata.outputs.pr_number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: '✅ VRT screenshots have been automatically updated.'
});
- name: Comment on PR - Failure
if: failure() && steps.metadata.outputs.pr_number != ''
uses: actions/github-script@v7
with:
script: |
const error = `${{ steps.apply.outputs.error }}` || 'Unknown error occurred';
await github.rest.issues.createComment({
issue_number: ${{ steps.metadata.outputs.pr_number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: `❌ Failed to apply VRT updates: ${error}\n\nPlease check the workflow logs for details.`
});

View File

@@ -0,0 +1,105 @@
name: VRT Update - Generate
# SECURITY: This workflow runs in untrusted fork context with no write permissions.
# It only generates VRT patch artifacts that are later applied by vrt-update-apply.yml
on:
pull_request:
types: [opened, synchronize, reopened]
paths:
- 'packages/**'
- '.github/workflows/vrt-update-generate.yml'
permissions:
contents: read
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
generate-vrt-updates:
name: Generate VRT Updates
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.56.0-jammy
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up environment
uses: ./.github/actions/setup
- name: Run VRT Tests on Desktop app
continue-on-error: true
run: |
xvfb-run --auto-servernum --server-args="-screen 0 1920x1080x24" -- yarn e2e:desktop --update-snapshots
- name: Wait for Netlify build to finish
id: netlify
env:
COMMIT_SHA: ${{ github.event.pull_request.head.sha }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: ./.github/actions/netlify-wait-for-build
- name: Run VRT Tests on Netlify URL
continue-on-error: true
run: yarn vrt --update-snapshots
env:
E2E_START_URL: ${{ steps.netlify.outputs.url }}
- name: Create patch with PNG changes only
id: create-patch
run: |
# Trust the repository directory (required for container environments)
git config --global --add safe.directory "$GITHUB_WORKSPACE"
git config --global user.name "github-actions[bot]"
git config --global user.email "github-actions[bot]@users.noreply.github.com"
# Stage only PNG files
git add "**/*.png"
# Check if there are any changes
if git diff --staged --quiet; then
echo "has_changes=false" >> "$GITHUB_OUTPUT"
echo "No VRT changes to commit"
exit 0
fi
echo "has_changes=true" >> "$GITHUB_OUTPUT"
# Create commit and patch
git commit -m "Update VRT screenshots"
git format-patch -1 HEAD --stdout > vrt-update.patch
# Validate patch only contains PNG files
if grep -E '^(\+\+\+|---) [ab]/' vrt-update.patch | grep -v '\.png$'; then
echo "ERROR: Patch contains non-PNG files!"
exit 1
fi
echo "Patch created successfully with PNG changes only"
- name: Upload patch artifact
if: steps.create-patch.outputs.has_changes == 'true'
uses: actions/upload-artifact@v4
with:
name: vrt-patch-${{ github.event.pull_request.number }}
path: vrt-update.patch
retention-days: 5
- name: Save PR metadata
if: steps.create-patch.outputs.has_changes == 'true'
run: |
mkdir -p pr-metadata
echo "${{ github.event.pull_request.number }}" > pr-metadata/pr-number.txt
echo "${{ github.event.pull_request.head.ref }}" > pr-metadata/head-ref.txt
echo "${{ github.event.pull_request.head.repo.full_name }}" > pr-metadata/head-repo.txt
- name: Upload PR metadata
if: steps.create-patch.outputs.has_changes == 'true'
uses: actions/upload-artifact@v4
with:
name: vrt-metadata-${{ github.event.pull_request.number }}
path: pr-metadata/
retention-days: 5

15
.gitignore vendored
View File

@@ -3,12 +3,10 @@
!data/.gitkeep
/data2
Actual-*
!actual-server.js
**/xcuserdata/*
export-2020-01-10.csv
# Secrets
.secret-tokens
# MacOS
.DS_Store
@@ -25,6 +23,8 @@ packages/desktop-electron/build
packages/desktop-electron/.electron-symbols
packages/desktop-electron/dist
packages/desktop-electron/loot-core
packages/desktop-client/service-worker
packages/plugins-service/dist
bundle.desktop.js
bundle.desktop.js.map
bundle.mobile.js
@@ -56,3 +56,12 @@ package.tgz
# Fly.io configuration
fly.toml
# TypeScript cache
build/
# .d.ts files aren't type-checked with skipLibCheck set to true
*.d.ts
# Lage cache
.lage/

2
.nvmrc
View File

@@ -1 +1 @@
v18.16.0
v22/*

View File

@@ -1 +1,30 @@
sync_pb.*
packages/api/app/bundle.api.js
packages/api/app/stats.json
packages/api/dist
packages/api/@types
packages/api/migrations
packages/crdt/dist
packages/component-library/src/icons/**/*
packages/desktop-client/bundle.browser.js
packages/desktop-client/stats.json
packages/desktop-client/.swc/
packages/desktop-client/build/
packages/desktop-client/locale/
packages/desktop-client/build-electron/
packages/desktop-client/build-stats/
packages/desktop-client/public/kcab/
packages/desktop-client/public/data/
packages/desktop-client/**/node_modules/*
packages/desktop-client/node_modules/
packages/desktop-client/test-results/
packages/desktop-client/playwright-report/
packages/desktop-electron/client-build/
packages/desktop-electron/build/
packages/desktop-electron/dist/
packages/loot-core/**/node_modules/*
packages/loot-core/**/lib-dist/*
packages/loot-core/**/proto/*
packages/sync-server/coverage/
.yarn/*
upcoming-release-notes/*

View File

@@ -1,2 +0,0 @@
export APPLE_ID=example@email.com
export APPLE_APP_SPECIFIC_PASSWORD=password

View File

@@ -0,0 +1,10 @@
diff --git a/methods/inflater.js b/methods/inflater.js
index 8769e66e82b25541aba80b1ac6429199c9a8179f..1d4402402f0e1aaf64062c1f004c3d6e6fe93e76 100644
--- a/methods/inflater.js
+++ b/methods/inflater.js
@@ -1,4 +1,4 @@
-const version = +(process.versions ? process.versions.node : "").split(".")[0] || 0;
+const version = +(process?.versions?.node ?? "").split(".")[0] || 0;
module.exports = function (/*Buffer*/ inbuf, /*number*/ expectedLength) {
var zlib = require("zlib");

942
.yarn/releases/yarn-4.10.3.cjs vendored Executable file

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

View File

@@ -6,4 +6,4 @@ enableTransparentWorkspaces: false
nodeLinker: node-modules
yarnPath: .yarn/releases/yarn-4.3.1.cjs
yarnPath: .yarn/releases/yarn-4.10.3.cjs

585
AGENTS.md Normal file
View File

@@ -0,0 +1,585 @@
# AGENTS.md - Guide for AI Agents Working with Actual Budget
This guide provides comprehensive information for AI agents (like Cursor) working with the Actual Budget codebase.
## Project Overview
**Actual Budget** is a local-first personal finance tool written in TypeScript/JavaScript. It's 100% free and open-source with synchronization capabilities across devices.
- **Repository**: https://github.com/actualbudget/actual
- **Community Docs**: https://github.com/actualbudget/docs or https://actualbudget.org/docs
- **License**: MIT
- **Primary Language**: TypeScript (with React)
- **Build System**: Yarn 4 workspaces (monorepo)
## Quick Start Commands
### Essential Commands (Run from Root)
```bash
# Type checking (ALWAYS run before committing)
yarn typecheck
# Linting and formatting (with auto-fix)
yarn lint:fix
# Run all tests
yarn test
# Start development server (browser)
yarn start
# Start with sync server
yarn start:server-dev
# Start desktop app development
yarn start:desktop
```
### Important Rules
- **ALWAYS run yarn commands from the root directory** - never run them in child workspaces
- Use `yarn workspace <workspace-name> run <command>` for workspace-specific tasks
- Tests run once and exit by default (using `vitest --run`)
### Task Orchestration with Lage
The project uses **[lage](https://microsoft.github.io/lage/)** (a task runner for JavaScript monorepos) to efficiently run tests and other tasks across multiple workspaces:
- **Parallel execution**: Runs tests in parallel across workspaces for faster feedback
- **Smart caching**: Caches test results to skip unchanged packages (cached in `.lage/` directory)
- **Dependency awareness**: Understands workspace dependencies and execution order
- **Continues on error**: Uses `--continue` flag to run all packages even if one fails
**Lage Commands:**
```bash
# Run all tests across all packages
yarn test # Equivalent to: lage test --continue
# Run tests without cache (for debugging/CI)
yarn test:debug # Equivalent to: lage test --no-cache --continue
```
Configuration is in `lage.config.js` at the project root.
## Architecture & Package Structure
### Core Packages
#### 1. **loot-core** (`packages/loot-core/`)
The core application logic that runs on any platform.
- Business logic, database operations, and calculations
- Platform-agnostic code
- Exports for both browser and node environments
- Test commands:
```bash
# Run all loot-core tests
yarn workspace loot-core run test
# Or run tests across all packages using lage
yarn test
```
#### 2. **desktop-client** (`packages/desktop-client/` - aliased as `@actual-app/web`)
The React-based UI for web and desktop.
- React components using functional programming patterns
- E2E tests using Playwright
- Vite for bundling
- Commands:
```bash
# Development
yarn workspace @actual-app/web start:browser
# Build
yarn workspace @actual-app/web build
# E2E tests
yarn workspace @actual-app/web e2e
# Visual regression tests
yarn workspace @actual-app/web vrt
```
#### 3. **desktop-electron** (`packages/desktop-electron/`)
Electron wrapper for the desktop application.
- Window management and native OS integration
- E2E tests for Electron-specific features
#### 4. **api** (`packages/api/` - aliased as `@actual-app/api`)
Public API for programmatic access to Actual.
- Node.js API
- Designed for integrations and automation
- Commands:
```bash
# Build
yarn workspace @actual-app/api build
# Run tests
yarn workspace @actual-app/api test
# Or use lage to run all tests
yarn test
```
#### 5. **sync-server** (`packages/sync-server/` - aliased as `@actual-app/sync-server`)
Synchronization server for multi-device support.
- Express-based server
- Currently transitioning to TypeScript (mostly JavaScript)
- Commands:
```bash
yarn workspace @actual-app/sync-server start
```
#### 6. **component-library** (`packages/component-library/` - aliased as `@actual-app/components`)
Reusable React UI components.
- Shared components like Button, Input, Menu, etc.
- Theme system and design tokens
- Icons (375+ icons in SVG/TSX format)
#### 7. **crdt** (`packages/crdt/` - aliased as `@actual-app/crdt`)
CRDT (Conflict-free Replicated Data Type) implementation for data synchronization.
- Protocol buffers for serialization
- Core sync logic
#### 8. **plugins-service** (`packages/plugins-service/`)
Service for handling plugins/extensions.
#### 9. **eslint-plugin-actual** (`packages/eslint-plugin-actual/`)
Custom ESLint rules specific to Actual.
- `no-untranslated-strings`: Enforces i18n usage
- `prefer-trans-over-t`: Prefers Trans component over t() function
- `prefer-logger-over-console`: Enforces using logger instead of console
- `typography`: Typography rules
- `prefer-if-statement`: Prefers explicit if statements
## Development Workflow
### 1. Making Changes
When implementing changes:
1. Read relevant files to understand current implementation
2. Make focused, incremental changes
3. Run type checking: `yarn typecheck`
4. Run linting: `yarn lint:fix`
5. Run relevant tests
6. Fix any linter errors that are introduced
### 2. Testing Strategy
**Unit Tests (Vitest)**
The project uses **lage** for running tests across all workspaces efficiently.
```bash
# Run all tests across all packages (using lage)
yarn test
# Run tests without cache (for debugging)
yarn test:debug
# Run tests for a specific package
yarn workspace loot-core run test
# Run a specific test file (watch mode)
yarn workspace loot-core run test path/to/test.test.ts
```
**E2E Tests (Playwright)**
```bash
# Run E2E tests for web
yarn e2e
# Desktop Electron E2E (includes full build)
yarn e2e:desktop
# Visual regression tests
yarn vrt
# Visual regression in Docker (consistent environment)
yarn vrt:docker
# Run E2E tests for a specific package
yarn workspace @actual-app/web e2e
```
**Testing Best Practices:**
- Minimize mocked dependencies - prefer real implementations
- Use descriptive test names
- Vitest globals are available: `describe`, `it`, `expect`, `beforeEach`, etc.
- For sync-server tests, globals are explicitly defined in config
### 3. Type Checking
TypeScript configuration uses:
- Incremental compilation
- Strict type checking with `typescript-strict-plugin`
- Platform-specific exports in `loot-core` (node vs browser)
Always run `yarn typecheck` before committing.
### 4. Internationalization (i18n)
- Use `Trans` component instead of `t()` function when possible
- All user-facing strings must be translated
- Generate i18n files: `yarn generate:i18n`
- Custom ESLint rules enforce translation usage
## Code Style & Conventions
### TypeScript Guidelines
**Type Usage:**
- Use TypeScript for all code
- Prefer `type` over `interface`
- Avoid `enum` - use objects or maps
- Avoid `any` or `unknown` unless absolutely necessary
- Look for existing type definitions in the codebase
- Avoid type assertions (`as`, `!`) - prefer `satisfies`
- Use inline type imports: `import { type MyType } from '...'`
**Naming:**
- Use descriptive variable names with auxiliary verbs (e.g., `isLoaded`, `hasError`)
- Named exports for components and utilities (avoid default exports except in specific cases)
**Code Structure:**
- Functional and declarative programming patterns - avoid classes
- Use the `function` keyword for pure functions
- Prefer iteration and modularization over code duplication
- Structure files: exported component/page, helpers, static content, types
- Create new components in their own files
**React Patterns:**
- Don't use `React.FunctionComponent` or `React.FC` - type props directly
- Don't use `React.*` patterns - use named imports instead
- Use `<Link>` instead of `<a>` tags
- Use custom hooks from `src/hooks` (not react-router directly):
- `useNavigate()` from `src/hooks` (not react-router)
- `useDispatch()`, `useSelector()`, `useStore()` from `src/redux` (not react-redux)
- Avoid unstable nested components
- Use `satisfies` for type narrowing
**JSX Style:**
- Declarative JSX, minimal and readable
- Avoid unnecessary curly braces in conditionals
- Use concise syntax for simple statements
- Prefer explicit expressions (`condition && <Component />`)
### Import Organization
Imports are automatically organized by ESLint with the following order:
1. React imports (first)
2. Built-in Node.js modules
3. External packages
4. Actual packages (`loot-core`, `@actual-app/components` - legacy pattern `loot-design` may appear in old code)
5. Parent imports
6. Sibling imports
7. Index imports
Always maintain newlines between import groups.
### Platform-Specific Code
- Don't directly reference platform-specific imports (`.api`, `.web`, `.electron`)
- Use conditional exports in `loot-core` for platform-specific code
- Platform resolution happens at build time via package.json exports
### Restricted Patterns
**Never:**
- Use `console.*` (use logger instead - enforced by ESLint)
- Import from `uuid` without destructuring: use `import { v4 as uuidv4 } from 'uuid'`
- Import colors directly - use theme instead
- Import `@actual-app/web/*` in `loot-core`
**Git Commands:**
- Never update git config
- Never run destructive git operations (force push, hard reset) unless explicitly requested
- Never skip hooks (--no-verify, --no-gpg-sign)
- Never force push to main/master
- Never commit unless explicitly asked
## File Structure Patterns
### Typical Component File
```typescript
import { type ComponentType } from 'react';
// ... other imports
type MyComponentProps = {
// Props definition
};
export function MyComponent({ prop1, prop2 }: MyComponentProps) {
// Component logic
return (
// JSX
);
}
```
### Test File
```typescript
import { describe, it, expect, beforeEach } from 'vitest';
// ... imports
describe('ComponentName', () => {
it('should behave as expected', () => {
// Test logic
expect(result).toBe(expected);
});
});
```
## Important Directories & Files
### Configuration Files
- `/package.json` - Root workspace configuration, scripts
- `/lage.config.js` - Lage task runner configuration
- `/eslint.config.mjs` - ESLint configuration (flat config format)
- `/tsconfig.json` - Root TypeScript configuration
- `/.cursorignore`, `/.gitignore` - Ignored files
- `/yarn.lock` - Dependency lockfile (Yarn 4)
### Documentation
- `/README.md` - Project overview
- `/CONTRIBUTING.md` - Points to community docs
- `/upcoming-release-notes/` - Release notes for next version
- `/CODEOWNERS` - Code ownership definitions
### Build Artifacts (Don't Edit)
- `packages/*/lib-dist/` - Built output
- `packages/*/dist/` - Built output
- `packages/*/build/` - Built output
- `packages/desktop-client/playwright-report/` - Test reports
- `packages/desktop-client/test-results/` - Test results
- `.lage/` - Lage task runner cache (improves test performance)
### Key Source Directories
- `packages/loot-core/src/client/` - Client-side core logic
- `packages/loot-core/src/server/` - Server-side core logic
- `packages/loot-core/src/shared/` - Shared utilities
- `packages/loot-core/src/types/` - Type definitions
- `packages/desktop-client/src/components/` - React components
- `packages/desktop-client/src/hooks/` - Custom React hooks
- `packages/desktop-client/e2e/` - End-to-end tests
- `packages/component-library/src/` - Reusable components
- `packages/component-library/src/icons/` - Icon components (auto-generated, don't edit)
## Common Development Tasks
### Running Specific Tests
```bash
# Run all tests across all packages (recommended)
yarn test
# Unit test for a specific file in loot-core (watch mode)
yarn workspace loot-core run test src/path/to/file.test.ts
# E2E test for a specific file
yarn workspace @actual-app/web run playwright test accounts.test.ts --browser=chromium
```
### Building for Production
```bash
# Browser build
yarn build:browser
# Desktop build
yarn build:desktop
# API build
yarn build:api
# Sync server build
yarn build:server
```
### Type Checking Specific Packages
TypeScript uses project references. Run `yarn typecheck` from root to check all packages.
### Debugging Tests
```bash
# Run tests in debug mode (without parallelization)
yarn test:debug
# Run specific E2E test with headed browser
yarn workspace @actual-app/web run playwright test --headed --debug accounts.test.ts
```
### Working with Icons
Icons in `packages/component-library/src/icons/` are auto-generated. Don't manually edit them.
## Troubleshooting
### Type Errors
1. Run `yarn typecheck` to see all type errors
2. Check if types are imported correctly
3. Look for existing type definitions in `packages/loot-core/src/types/`
4. Use `satisfies` instead of `as` for type narrowing
### Linter Errors
1. Run `yarn lint:fix` to auto-fix many issues
2. Check ESLint output for specific rule violations
3. Custom rules:
- `actual/no-untranslated-strings` - Add i18n
- `actual/prefer-trans-over-t` - Use Trans component
- `actual/prefer-logger-over-console` - Use logger
- Check `eslint.config.mjs` for complete rules
### Test Failures
1. Check if test is running in correct environment (node vs web)
2. For Vitest: check `vitest.config.ts` or `vitest.web.config.ts`
3. For Playwright: check `playwright.config.ts`
4. Ensure mock minimization - prefer real implementations
5. **Lage cache issues**: Clear cache with `rm -rf .lage` if tests behave unexpectedly
6. **Tests continue on error**: With `--continue` flag, all packages run even if one fails
### Import Resolution Issues
1. Check `tsconfig.json` for path mappings
2. Check package.json `exports` field (especially for loot-core)
3. Verify platform-specific imports (`.web`, `.electron`, `.api`)
4. Use absolute imports in `desktop-client` (enforced by ESLint)
### Build Failures
1. Clean build artifacts: `rm -rf packages/*/dist packages/*/lib-dist packages/*/build`
2. Reinstall dependencies: `yarn install`
3. Check Node.js version (requires >=20)
4. Check Yarn version (requires ^4.9.1)
## Testing Patterns
### Unit Tests
- Located alongside source files or in `__tests__` directories
- Use `.test.ts`, `.test.tsx`, `.spec.js` extensions
- Vitest is the test runner
- Minimize mocking - prefer real implementations
### E2E Tests
- Located in `packages/desktop-client/e2e/`
- Use Playwright test runner
- Visual regression snapshots in `*-snapshots/` directories
- Page models in `e2e/page-models/` for reusable page interactions
- Mobile tests have `.mobile.test.ts` suffix
### Visual Regression Tests (VRT)
- Snapshots stored per test file in `*-snapshots/` directories
- Use Docker for consistent environment: `yarn vrt:docker`
## Additional Resources
- **Community Documentation**: https://actualbudget.org/docs/contributing/
- **Discord Community**: https://discord.gg/pRYNYr4W5A
- **GitHub Issues**: https://github.com/actualbudget/actual/issues
- **Feature Requests**: Label "needs votes" sorted by reactions
## Code Quality Checklist
Before committing changes, ensure:
- [ ] `yarn typecheck` passes
- [ ] `yarn lint:fix` has been run
- [ ] Relevant tests pass
- [ ] No new console.\* usage (use logger)
- [ ] User-facing strings are translated
- [ ] Prefer `type` over `interface`
- [ ] Named exports used (not default exports)
- [ ] Imports are properly ordered
- [ ] Platform-specific code uses proper exports
- [ ] No unnecessary type assertions
## Pull Request Guidelines
When creating pull requests:
- **AI-Generated PRs**: If you create a PR using AI assistance, add the **"AI generated"** label to the pull request. This helps maintainers understand the nature of the contribution.
## Performance Considerations
- **Bundle Size**: Check with rollup-plugin-visualizer
- **Type Checking**: Uses incremental compilation
- **Testing**: Tests run in parallel by default
- **Linting**: ESLint caches results for faster subsequent runs
## Workspace Commands Reference
```bash
# List all workspaces
yarn workspaces list
# Run command in specific workspace
yarn workspace <workspace-name> run <command>
# Run command in all workspaces
yarn workspaces foreach --all run <command>
# Install production dependencies only (for server deployment)
yarn install:server
```
## Environment Requirements
- **Node.js**: >=20
- **Yarn**: ^4.9.1 (managed by packageManager field)
- **Browser Targets**: Electron >= 35.0, modern browsers (see browserslist)
## Migration Notes
The codebase is actively being migrated:
- **JavaScript → TypeScript**: sync-server is in progress
- **Classes → Functions**: Prefer functional patterns
- **React.\* → Named Imports**: Legacy React.\* patterns being removed
When working with older code, follow the newer patterns described in this guide.

10
CODEOWNERS Normal file
View File

@@ -0,0 +1,10 @@
# CODEOWNERS file for Actual Budget
# Please add your name to code-paths that you feel especially
# passionate about. You will be notified for any PRs there.
/packages/api/ @MatissJanis
/packages/component-library/ @MatissJanis
/packages/desktop-client/src/components/mobile @joel-jeremy
/packages/desktop-electron/ @MikesGlitch
/packages/loot-core/src/server/budget @youngcw
/packages/sync-server/ @matt-fidd

View File

@@ -5,7 +5,7 @@
# you are doing.
###################################################
FROM node:18-bullseye as dev
FROM node:22-bookworm as dev
RUN apt-get update -y && apt-get upgrade -y && apt-get install -y openssl
WORKDIR /app
CMD ["sh", "./bin/docker-start"]

View File

@@ -66,7 +66,11 @@ To add new feature requests, open a new Issue of the "Feature Request" type.
### Translation
Make Actual Budget accessible to more people by helping with the [Internationalization](https://actualbudget.org/docs/contributing/i18n/) of Actual. We are using a crowd sourcing tool to manage the translations, see our [Weblate Project](https://hosted.weblate.org/projects/actualbudget/). Weblate proudly supports open-source software projects through their [Libre plan](https://weblate.org/en/hosting/#libre).
Make Actual Budget accessible to more people by helping with the [Internationalization](https://actualbudget.org/docs/contributing/i18n/) of Actual. We are using a crowd sourcing tool to manage the translations, see our [Weblate Project](https://hosted.weblate.org/projects/actualbudget/). Weblate proudly supports open-source software projects through their [Libre plan](https://weblate.org/en/hosting/#libre).
<a href="https://hosted.weblate.org/engage/actualbudget/">
<img src="https://hosted.weblate.org/widget/actualbudget/actual/287x66-grey.png" alt="Translation status" />
</a>
## Repo Activity

View File

@@ -14,6 +14,9 @@ git pull
popd > /dev/null
packages/desktop-client/bin/remove-untranslated-languages
export NODE_OPTIONS="--max-old-space-size=4096"
yarn workspace plugins-service build
yarn workspace loot-core build:browser
yarn workspace @actual-app/web build:browser

View File

@@ -6,8 +6,8 @@ RELEASE=""
CI=${CI:-false}
cd "$ROOT/.."
POSITIONAL=()
SKIP_EXE_BUILD=false
while [[ $# -gt 0 ]]; do
key="$1"
@@ -16,53 +16,57 @@ while [[ $# -gt 0 ]]; do
RELEASE="production"
shift
;;
--skip-exe-build)
SKIP_EXE_BUILD=true
shift
;;
*)
POSITIONAL+=("$1")
shift
;;
esac
done
set -- "${POSITIONAL[@]}"
if [ "$OSTYPE" == "msys" ]; then
if [ $CI != true ]; then
read -s -p "Windows certificate password: " -r CSC_KEY_PASSWORD
export CSC_KEY_PASSWORD
elif [ -n "$CIRCLE_TAG" ]; then
# We only want to run this on CircleCI as Github doesn't have the CSC_KEY_PASSWORD secret set.
certutil -f -p ${CSC_KEY_PASSWORD} -importPfx ~/windows-shift-reset-llc.p12
fi
fi
yarn workspace loot-core build:node
# Get translations
echo "Updating translations..."
if ! [ -d packages/desktop-client/locale ]; then
git clone https://github.com/actualbudget/translations packages/desktop-client/locale
fi
pushd packages/desktop-client/locale > /dev/null
git checkout .
git pull
popd > /dev/null
packages/desktop-client/bin/remove-untranslated-languages
export NODE_OPTIONS="--max-old-space-size=4096"
yarn workspace plugins-service build
yarn workspace loot-core build:node
yarn workspace @actual-app/web build --mode=desktop # electron specific build
# required for running the sync-server server
yarn workspace loot-core build:browser
yarn workspace @actual-app/web build:browser
yarn workspace @actual-app/sync-server build
yarn workspace desktop-electron update-client
(
cd packages/desktop-electron;
yarn clean;
if [ "$RELEASE" == "production" ]; then
if [ -f ../../.secret-tokens ]; then
source ../../.secret-tokens
fi
yarn build
echo "\nCreated release"
if [ $SKIP_EXE_BUILD == true ]; then
echo "Building the dist"
yarn build:dist
echo "Skipping exe build"
else
SKIP_NOTARIZATION=true yarn build
if [ "$RELEASE" == "production" ]; then
yarn build
echo "Created release"
else
yarn build
fi
fi
)

View File

@@ -0,0 +1,182 @@
import { exec } from 'node:child_process';
import { existsSync, writeFile } from 'node:fs';
import { exit } from 'node:process';
import prompts from 'prompts';
async function run() {
const username = await execAsync(
// eslint-disable-next-line actual/typography
"gh api user --jq '.login'",
'To avoid having to enter your username, consider installing the official GitHub CLI (https://github.com/cli/cli) and logging in with `gh auth login`.',
);
const activePr = await getActivePr(username);
if (activePr) {
console.log(
`Found potentially matching PR ${activePr.number}: ${activePr.title}`,
);
}
const initialPrNumber = activePr?.number ?? (await getNextPrNumber());
const result = await prompts([
{
name: 'githubUsername',
message: 'Comma-separated GitHub username(s)',
type: 'text',
initial: username,
},
{
name: 'pullRequestNumber',
message: 'PR Number',
type: 'number',
initial: initialPrNumber,
},
{
name: 'releaseNoteType',
message: 'Release Note Type',
type: 'select',
choices: [
{ title: '✨ Features', value: 'Features' },
{ title: '👍 Enhancements', value: 'Enhancements' },
{ title: '🐛 Bugfix', value: 'Bugfix' },
{ title: '⚙️ Maintenance', value: 'Maintenance' },
],
},
{
name: 'oneLineSummary',
message: 'Brief Summary',
type: 'text',
initial: activePr?.title,
},
]);
if (
!result.githubUsername ||
!result.oneLineSummary ||
!result.releaseNoteType ||
!result.pullRequestNumber
) {
console.log('All questions must be answered. Exiting');
exit(1);
}
const fileContents = getFileContents(
result.releaseNoteType,
result.githubUsername,
result.oneLineSummary,
);
const prNumber = result.pullRequestNumber;
const filepath = `./upcoming-release-notes/${prNumber}.md`;
if (existsSync(filepath)) {
const { confirm } = await prompts({
name: 'confirm',
type: 'confirm',
message: `This will overwrite the existing release note ${filepath} Are you sure?`,
});
if (!confirm) {
console.log('Exiting');
exit(1);
}
}
writeFile(filepath, fileContents, err => {
if (err) {
console.error('Failed to write release note file:', err);
exit(1);
} else {
console.log(`Release note generated successfully: ${filepath}`);
}
});
}
// makes an attempt to find an existing open PR from <username>:<branch>
async function getActivePr(
username: string,
): Promise<{ number: number; title: string } | undefined> {
if (!username) {
return undefined;
}
const branchName = await execAsync('git rev-parse --abbrev-ref HEAD');
if (!branchName) {
return undefined;
}
const forkHead = `${username}:${branchName}`;
return getPrNumberFromHead(forkHead);
}
async function getPrNumberFromHead(
head: string,
): Promise<{ number: number; title: string } | undefined> {
try {
// head is a weird query parameter in this API call. If nothing matches, it
// will return as if the head query parameter doesn't exist. To get around
// this, we make the page size 2 and only return the number if the length.
const resp = await fetch(
'https://api.github.com/repos/actualbudget/actual/pulls?state=open&per_page=2&head=' +
head,
);
if (!resp.ok) {
console.warn('error fetching from github pulls api:', resp.status);
return undefined;
}
const ghResponse = await resp.json();
if (ghResponse?.length === 1) {
return ghResponse[0];
} else {
return undefined;
}
} catch (e) {
console.warn('error fetching from github pulls api:', e);
}
}
async function getNextPrNumber(): Promise<number> {
try {
const resp = await fetch(
'https://api.github.com/repos/actualbudget/actual/issues?state=all&per_page=1',
);
if (!resp.ok) {
throw new Error(`API responded with status: ${resp.status}`);
}
const ghResponse = await resp.json();
const latestPrNumber = ghResponse?.[0]?.number;
if (!latestPrNumber) {
console.error(
'Could not find latest issue number in GitHub API response',
ghResponse,
);
exit(1);
}
return latestPrNumber + 1;
} catch (error) {
console.error('Failed to fetch next PR number:', error);
exit(1);
}
}
function getFileContents(type: string, username: string, summary: string) {
return `---
category: ${type}
authors: [${username}]
---
${summary}
`;
}
// simple exec that fails silently and returns an empty string on failure
async function execAsync(cmd: string, errorLog?: string): Promise<string> {
return new Promise<string>(res => {
exec(cmd, (error, stdout) => {
if (error) {
console.log(errorLog);
res('');
} else {
res(stdout.trim());
}
});
});
}
run();

View File

@@ -28,5 +28,5 @@ echo "Running VRT tests with the following parameters:"
echo "E2E_START_URL: $E2E_START_URL"
echo "VRT_ARGS: $VRT_ARGS"
MSYS_NO_PATHCONV=1 docker run --rm --network host -v "$(pwd)":/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.41.1-jammy /bin/bash \
MSYS_NO_PATHCONV=1 docker run --rm --network host -v "$(pwd)":/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.56.0-jammy /bin/bash \
-c "E2E_START_URL=$E2E_START_URL yarn vrt $VRT_ARGS"

View File

@@ -15,4 +15,3 @@ services:
volumes:
- '.:/app'
restart: 'no'

View File

@@ -1,29 +1,16 @@
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import globals from 'globals';
import { defineConfig } from 'eslint/config';
import pluginImport from 'eslint-plugin-import';
import pluginJSXA11y from 'eslint-plugin-jsx-a11y';
import pluginPrettier from 'eslint-plugin-prettier/recommended';
import pluginReact from 'eslint-plugin-react';
import pluginReactHooks from 'eslint-plugin-react-hooks';
import pluginRulesDir from 'eslint-plugin-rulesdir';
import pluginTypescript from 'typescript-eslint';
import pluginTypescriptPaths from 'eslint-plugin-typescript-paths';
import pluginActual from './packages/eslint-plugin-actual/lib/index.js';
import tsParser from '@typescript-eslint/parser';
const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
pluginRulesDir.RULES_DIR = path.join(
__dirname,
'packages',
'eslint-plugin-actual',
'lib',
'rules',
);
const confusingBrowserGlobals = [
// https://github.com/facebook/create-react-app/tree/main/packages/confusing-browser-globals
'addEventListener',
@@ -85,11 +72,11 @@ const confusingBrowserGlobals = [
'top',
];
/** @type {import('eslint').Linter.Config[]} */
export default [
export default defineConfig(
{
ignores: [
'packages/api/app/bundle.api.js',
'packages/api/app/stats.json',
'packages/api/dist',
'packages/api/@types',
'packages/api/migrations',
@@ -97,6 +84,7 @@ export default [
'packages/component-library/src/icons/**/*',
'packages/desktop-client/bundle.browser.js',
'packages/desktop-client/build/',
'packages/desktop-client/service-worker/*',
'packages/desktop-client/build-electron/',
'packages/desktop-client/build-stats/',
'packages/desktop-client/public/kcab/',
@@ -108,15 +96,35 @@ export default [
'packages/desktop-electron/client-build/',
'packages/desktop-electron/build/',
'packages/desktop-electron/dist/',
'packages/import-ynab4/**/node_modules/*',
'packages/import-ynab5/**/node_modules/*',
'packages/loot-core/**/node_modules/*',
'packages/loot-core/**/lib-dist/*',
'packages/loot-core/**/proto/*',
'packages/sync-server/build/',
'packages/plugins-service/dist/',
'.yarn/*',
'.github/*',
],
},
{
// Temporary until the sync-server is migrated to TypeScript
files: [
'packages/sync-server/**/*.spec.{js,jsx}',
'packages/sync-server/**/*.test.{js,jsx}',
],
languageOptions: {
globals: {
vi: true,
describe: true,
expect: true,
it: true,
beforeAll: true,
beforeEach: true,
afterAll: true,
afterEach: true,
test: true,
},
},
},
{
linterOptions: {
reportUnusedDisableDirectives: true,
@@ -125,7 +133,6 @@ export default [
globals: {
...globals.browser,
...globals.commonjs,
...globals.jest,
...globals.node,
globalThis: false,
vi: true,
@@ -145,18 +152,23 @@ export default [
},
pluginReact.configs.flat.recommended,
pluginReact.configs.flat['jsx-runtime'],
pluginPrettier,
...pluginTypescript.configs.recommended,
pluginTypescript.configs.recommended,
pluginImport.flatConfigs.recommended,
{
plugins: {
'react-hooks': pluginReactHooks,
'jsx-a11y': pluginJSXA11y,
rulesdir: pluginRulesDir,
actual: pluginActual,
},
rules: {
'actual/no-untranslated-strings': 'error',
'actual/prefer-trans-over-t': 'error',
},
},
{
files: ['**/*.{js,ts,jsx,tsx}'],
plugins: {
'jsx-a11y': pluginJSXA11y,
'react-hooks': pluginReactHooks,
},
rules: {
// http://eslint.org/docs/rules/
'array-callback-return': 'warn',
@@ -440,8 +452,9 @@ export default [
},
],
'rulesdir/typography': 'warn',
'rulesdir/prefer-if-statement': 'warn',
'actual/typography': 'warn',
'actual/prefer-if-statement': 'warn',
'actual/prefer-logger-over-console': 'error',
// Note: base rule explicitly disabled in favor of the TS one
'no-unused-vars': 'off',
@@ -449,6 +462,7 @@ export default [
'warn',
{
varsIgnorePattern: '^(_|React)',
argsIgnorePattern: '^(_|React)',
ignoreRestSiblings: true,
caughtErrors: 'none',
},
@@ -485,6 +499,32 @@ export default [
'no-restricted-imports': [
'warn',
{
paths: [
{
name: 'react-router',
importNames: ['useNavigate'],
message:
"Please import Actual's useNavigate() hook from `src/hooks` instead.",
},
{
name: 'react-redux',
importNames: ['useDispatch'],
message:
"Please import Actual's useDispatch() hook from `src/redux` instead.",
},
{
name: 'react-redux',
importNames: ['useSelector'],
message:
"Please import Actual's useSelector() hook from `src/redux` instead.",
},
{
name: 'react-redux',
importNames: ['useStore'],
message:
"Please import Actual's useStore() hook from `src/redux` instead.",
},
],
patterns: [
{
group: ['*.api', '*.web', '*.electron'],
@@ -500,6 +540,10 @@ export default [
importNames: ['colors'],
message: 'Please use themes instead of colors',
},
{
group: ['@actual-app/web/*'],
message: 'Please do not import `@actual-app/web` in `loot-core`',
},
],
},
],
@@ -521,7 +565,7 @@ export default [
},
},
{
files: ['**/*.ts?(x)'],
files: ['**/*.{ts,tsx}'],
languageOptions: {
parser: tsParser,
@@ -529,7 +573,7 @@ export default [
sourceType: 'module',
parserOptions: {
project: [path.join(__dirname, './tsconfig.json')],
projectService: true,
ecmaFeatures: {
jsx: true,
},
@@ -549,6 +593,13 @@ export default [
// 'tsc' already handles this (https://github.com/typescript-eslint/typescript-eslint/issues/477)
'no-undef': 'off',
// TypeScript already handles these (https://typescript-eslint.io/troubleshooting/typed-linting/performance/#eslint-plugin-import)
'import/named': 'off',
'import/namespace': 'off',
'import/default': 'off',
'import/no-named-as-default-member': 'off',
'import/no-unresolved': 'off',
// Add TypeScript specific rules (and turn off ESLint equivalents)
'@typescript-eslint/consistent-type-assertions': 'warn',
'no-array-constructor': 'off',
@@ -582,6 +633,19 @@ export default [
'@typescript-eslint/no-useless-constructor': 'warn',
},
},
{
files: ['packages/desktop-client/**/*.{js,ts,jsx,tsx}'],
plugins: {
'typescript-paths': pluginTypescriptPaths,
},
rules: {
'typescript-paths/absolute-parent-import': [
'error',
{ preferPathOverBaseUrl: true },
],
'typescript-paths/absolute-import': ['error', { enableAlias: false }],
},
},
{
files: [
'packages/desktop-client/**/*.{ts,tsx}',
@@ -616,88 +680,6 @@ export default [
],
},
},
{
files: ['packages/desktop-client/**/*'],
ignores: ['packages/desktop-client/src/hooks/useNavigate.{ts,tsx}'],
rules: {
'no-restricted-imports': [
'warn',
{
paths: [
{
name: 'react-router-dom',
importNames: ['useNavigate'],
message:
"Please import Actual's useNavigate() hook from `src/hooks` instead.",
},
],
},
],
},
},
{
files: ['packages/desktop-client/**/*', 'packages/loot-core/**/*'],
ignores: ['packages/desktop-client/src/redux/index.{ts,tsx}'],
rules: {
'no-restricted-imports': [
'warn',
{
paths: [
{
name: 'react-redux',
importNames: ['useDispatch'],
message:
"Please import Actual's useDispatch() hook from `src/redux` instead.",
},
{
name: 'react-redux',
importNames: ['useSelector'],
message:
"Please import Actual's useSelector() hook from `src/redux` instead.",
},
{
name: 'react-redux',
importNames: ['useStore'],
message:
"Please import Actual's useStore() hook from `src/redux` instead.",
},
],
},
],
},
},
{
files: ['packages/loot-core/src/**/*'],
rules: {
'no-restricted-imports': [
'warn',
{
patterns: [
{
group: ['*.api', '*.web', '*.electron'],
message: "Don't directly reference imports from other platforms",
},
{
group: ['uuid'],
importNames: ['*'],
message: "Use `import { v4 as uuidv4 } from 'uuid'` instead",
},
{
group: ['loot-core/**'],
message:
'Please use relative imports in loot-core instead of importing from `loot-core/*`',
},
{
group: ['@actual-app/web/*'],
message: 'Please do not import `@actual-app/web` in `loot-core`',
},
],
},
],
},
},
{
files: [
'packages/loot-core/src/types/**/*',
@@ -712,27 +694,6 @@ export default [
'import/no-unused-modules': 'off',
},
},
{
files: [
'packages/desktop-client/src/style/index.*',
'packages/desktop-client/src/style/palette.*',
],
rules: {
'no-restricted-imports': [
'off',
{
patterns: [
{
group: ['**/style', '**/colors'],
importNames: ['colors'],
message: 'Please use themes instead of colors',
},
],
},
],
},
},
{
files: ['packages/api/migrations/*', 'packages/loot-core/migrations/*'],
@@ -746,6 +707,16 @@ export default [
'import/no-unresolved': 'off',
},
},
// Allow configuring vitest with default exports (recommended as per vitest docs)
{
files: ['**/vitest.config.ts', '**/vitest.web.config.ts'],
rules: {
'import/no-anonymous-default-export': 'off',
'import/no-default-export': 'off',
},
},
{},
{
// TODO: fix the issues in these files
@@ -806,7 +777,9 @@ export default [
],
rules: {
'rulesdir/typography': 'off',
'actual/typography': 'off',
'actual/no-untranslated-strings': 'off',
'actual/prefer-logger-over-console': 'off',
},
},
{
@@ -825,7 +798,7 @@ export default [
// TODO: fix the issues in these files
rules: {
'import/extensions': 'off',
'rulesdir/typography': 'off',
'actual/typography': 'off',
},
},
{
@@ -833,8 +806,6 @@ export default [
rules: {
'import/no-anonymous-default-export': 'off',
'import/no-default-export': 'off',
// can be re-enabled after https://github.com/actualbudget/actual/pull/4253
'@typescript-eslint/no-unused-vars': 'off',
},
},
];
);

30
lage.config.js Normal file
View File

@@ -0,0 +1,30 @@
/** @type {import('lage').ConfigOptions} */
module.exports = {
pipeline: {
test: {
type: 'npmScript',
options: {
outputGlob: [
'coverage/**',
'**/test-results/**',
'**/playwright-report/**',
],
},
},
build: {
type: 'npmScript',
cache: true,
options: {
outputGlob: ['lib-dist/**', 'dist/**', 'build/**'],
},
},
},
cacheOptions: {
cacheStorageConfig: {
provider: 'local',
outputGlob: ['lib-dist/**', 'dist/**', 'build/**'],
},
},
npmClient: 'yarn',
concurrency: 2,
};

View File

@@ -22,67 +22,88 @@
"start:server": "yarn workspace @actual-app/sync-server start",
"start:server-monitor": "yarn workspace @actual-app/sync-server start-monitor",
"start:server-dev": "NODE_ENV=development BROWSER_OPEN=localhost:5006 yarn npm-run-all --parallel 'start:server-monitor' 'start'",
"start:desktop": "yarn rebuild-electron && npm-run-all --parallel 'start:desktop-*'",
"start:desktop": "yarn desktop-dependencies && npm-run-all --parallel 'start:desktop-*'",
"desktop-dependencies": "npm-run-all --parallel rebuild-electron build:browser-backend build:plugins-service",
"start:desktop-node": "yarn workspace loot-core watch:node",
"start:desktop-client": "yarn workspace @actual-app/web watch",
"start:desktop-server-client": "yarn workspace @actual-app/web build:browser",
"start:desktop-electron": "yarn workspace desktop-electron watch",
"start:electron": "yarn start:desktop",
"start:browser": "npm-run-all --parallel 'start:browser-*'",
"start:browser": "yarn workspace plugins-service build-dev && npm-run-all --parallel 'start:browser-*'",
"start:service-plugins": "yarn workspace plugins-service watch",
"start:browser-backend": "yarn workspace loot-core watch:browser",
"start:browser-frontend": "yarn workspace @actual-app/web start:browser",
"build:browser-backend": "yarn workspace loot-core build:browser",
"build:server": "yarn build:browser && yarn workspace @actual-app/sync-server build",
"build:browser": "./bin/package-browser",
"build:desktop": "./bin/package-electron",
"build:plugins-service": "yarn workspace plugins-service build",
"build:api": "yarn workspace @actual-app/api build",
"generate:i18n": "yarn workspace @actual-app/web generate:i18n",
"test": "yarn workspaces foreach --all --parallel --verbose run test",
"test:debug": "yarn workspaces foreach --all --verbose run test",
"e2e": "yarn workspaces foreach --all --parallel --verbose run e2e",
"vrt": "yarn workspaces foreach --all --parallel --verbose run vrt",
"generate:release-notes": "ts-node ./bin/release-note-generator.ts",
"test": "lage test --continue",
"test:debug": "lage test --no-cache --continue",
"e2e": "yarn workspace @actual-app/web run e2e",
"e2e:desktop": "yarn build:desktop --skip-exe-build && yarn workspace desktop-electron e2e",
"playwright": "yarn workspace @actual-app/web run playwright",
"vrt": "yarn workspace @actual-app/web run vrt",
"vrt:docker": "./bin/run-vrt",
"rebuild-electron": "./node_modules/.bin/electron-rebuild -f -m ./packages/loot-core",
"rebuild-electron": "./node_modules/.bin/electron-rebuild -m ./packages/loot-core",
"rebuild-node": "yarn workspace loot-core rebuild",
"lint": "eslint . --max-warnings 0",
"lint:verbose": "DEBUG=eslint:cli-engine eslint . --max-warnings 0",
"lint": "prettier --check . && eslint . --max-warnings 0",
"lint:fix": "prettier --check --write . && eslint . --max-warnings 0 --fix",
"install:server": "yarn workspaces focus @actual-app/sync-server --production",
"typecheck": "yarn tsc && tsc-strict",
"typecheck": "yarn tsc --incremental && tsc-strict",
"jq": "./node_modules/node-jq/bin/jq",
"prepare": "husky"
},
"devDependencies": {
"@typescript-eslint/parser": "^8.18.1",
"cross-env": "^7.0.3",
"eslint": "^9.17.0",
"eslint-config-prettier": "^9.1.0",
"eslint-import-resolver-typescript": "^3.7.0",
"eslint-plugin-import": "^2.31.0",
"@octokit/rest": "^22.0.0",
"@types/node": "^22.18.11",
"@types/prompts": "^2.4.9",
"@typescript-eslint/parser": "^8.46.0",
"cross-env": "^10.1.0",
"eslint": "^9.37.0",
"eslint-config-prettier": "^10.1.8",
"eslint-import-resolver-typescript": "^4.4.4",
"eslint-plugin-import": "^2.32.0",
"eslint-plugin-jsx-a11y": "^6.10.2",
"eslint-plugin-prettier": "5.2.1",
"eslint-plugin-react": "^7.37.2",
"eslint-plugin-react-hooks": "^5.1.0",
"eslint-plugin-rulesdir": "^0.2.2",
"globals": "^15.13.0",
"husky": "^9.0.11",
"lint-staged": "^15.2.9",
"node-jq": "^4.0.1",
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-react-hooks": "^7.0.0",
"eslint-plugin-typescript-paths": "^0.0.33",
"globals": "^16.4.0",
"html-to-image": "^1.11.13",
"husky": "^9.1.7",
"lage": "^2.14.14",
"lint-staged": "^16.2.3",
"minimatch": "^10.0.3",
"node-jq": "^6.3.1",
"npm-run-all": "^4.1.5",
"prettier": "^3.4.2",
"p-limit": "^7.1.1",
"prettier": "^3.6.2",
"prompts": "^2.4.2",
"source-map-support": "^0.5.21",
"typescript": "^5.5.4",
"typescript-eslint": "^8.18.1",
"ts-node": "^10.9.2",
"typescript": "^5.9.3",
"typescript-eslint": "^8.46.0",
"typescript-strict-plugin": "^2.4.4"
},
"resolutions": {
"rollup": "4.9.4"
"rollup": "4.40.1",
"socks": ">=2.8.3"
},
"engines": {
"node": ">=18.0.0"
"node": ">=22",
"yarn": "^4.9.1"
},
"lint-staged": {
"*.{js,jsx,ts,tsx,md,json}": "prettier --write"
"*.{js,mjs,jsx,ts,tsx,md,json,yml}": [
"eslint --fix",
"prettier --write"
]
},
"packageManager": "yarn@4.3.1",
"packageManager": "yarn@4.10.3",
"browserslist": [
"electron 24.0",
"electron >= 35.0",
"defaults"
]
}

View File

@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
exports[`API setup and teardown successfully loads budget 1`] = `
Array [
exports[`API setup and teardown > successfully loads budget 1`] = `
[
"2016-10",
"2016-11",
"2016-12",

View File

@@ -42,7 +42,11 @@ export async function init(config: InitConfig = {}) {
export async function shutdown() {
if (actualApp) {
await actualApp.send('sync');
try {
await actualApp.send('sync');
} catch (e) {
// most likely that no budget is loaded, so the sync failed
}
await actualApp.send('close-budget');
actualApp = null;
}

View File

@@ -1,24 +0,0 @@
module.exports = {
moduleFileExtensions: [
'testing.js',
'testing.ts',
'api.js',
'api.ts',
'api.tsx',
'electron.js',
'electron.ts',
'mjs',
'js',
'ts',
'tsx',
'json',
],
testEnvironment: 'node',
testPathIgnorePatterns: ['/node_modules/'],
watchPathIgnorePatterns: ['<rootDir>/mocks/budgets/'],
setupFilesAfterEnv: ['<rootDir>/../loot-core/src/mocks/setup.ts'],
transformIgnorePatterns: ['/node_modules/'],
transform: {
'^.+\\.(t|j)sx?$': '@swc/jest',
},
};

View File

@@ -6,10 +6,9 @@ import * as api from './index';
const budgetName = 'test-budget';
beforeEach(async () => {
// we need real datetime if we are going to mix new timestamps with our mock data
global.restoreDateNow();
global.IS_TESTING = true;
beforeEach(async () => {
const budgetPath = path.join(__dirname, '/mocks/budgets/', budgetName);
await fs.rm(budgetPath, { force: true, recursive: true });
@@ -569,8 +568,20 @@ describe('API CRUD operations', () => {
const accountId = await api.createAccount({ name: 'test-account' }, 0);
let newTransaction = [
{ date: '2023-11-03', imported_id: '11', amount: 100, notes: 'notes' },
{ date: '2023-11-03', imported_id: '12', amount: 100, notes: '' },
{
account: accountId,
date: '2023-11-03',
imported_id: '11',
amount: 100,
notes: 'notes',
},
{
account: accountId,
date: '2023-11-03',
imported_id: '12',
amount: 100,
notes: '',
},
];
const addResult = await api.addTransactions(accountId, newTransaction, {
@@ -598,9 +609,27 @@ describe('API CRUD operations', () => {
expect(transactions).toHaveLength(2);
newTransaction = [
{ date: '2023-12-03', imported_id: '11', amount: 100, notes: 'notes' },
{ date: '2023-12-03', imported_id: '12', amount: 100, notes: 'notes' },
{ date: '2023-12-03', imported_id: '22', amount: 200, notes: '' },
{
account: accountId,
date: '2023-12-03',
imported_id: '11',
amount: 100,
notes: 'notes',
},
{
account: accountId,
date: '2023-12-03',
imported_id: '12',
amount: 100,
notes: 'notes',
},
{
account: accountId,
date: '2023-12-03',
imported_id: '22',
amount: 200,
notes: '',
},
];
const reconciled = await api.importTransactions(accountId, newTransaction);
@@ -654,4 +683,179 @@ describe('API CRUD operations', () => {
);
expect(transactions).toHaveLength(1);
});
test('Transactions: import notes are preserved when importing', async () => {
const accountId = await api.createAccount({ name: 'test-account' }, 0);
// Test with notes
const transactionsWithNotes = [
{
date: '2023-11-03',
imported_id: '11',
amount: 100,
notes: 'test note',
},
];
const addResultWithNotes = await api.addTransactions(
accountId,
transactionsWithNotes,
{
learnCategories: true,
runTransfers: true,
},
);
expect(addResultWithNotes).toBe('ok');
let transactions = await api.getTransactions(
accountId,
'2023-11-01',
'2023-11-30',
);
expect(transactions[0].notes).toBe('test note');
// Clear transactions
await api.deleteTransaction(transactions[0].id);
// Test without notes
const transactionsWithoutNotes = [
{ date: '2023-11-03', imported_id: '11', amount: 100, notes: null },
];
const addResultWithoutNotes = await api.addTransactions(
accountId,
transactionsWithoutNotes,
{
learnCategories: true,
runTransfers: true,
},
);
expect(addResultWithoutNotes).toBe('ok');
transactions = await api.getTransactions(
accountId,
'2023-11-01',
'2023-11-30',
);
expect(transactions[0].notes).toBeNull();
});
});
//apis: createSchedule, getSchedules, updateSchedule, deleteSchedule
test('Schedules: successfully complete schedules operations', async () => {
await api.loadBudget(budgetName);
//test a schedule with a recuring configuration
const ScheduleId1 = await api.createSchedule({
name: 'test-schedule 1',
posts_transaction: true,
// amount: -5000,
amountOp: 'is',
date: {
frequency: 'monthly',
interval: 1,
start: '2025-06-13',
patterns: [],
skipWeekend: false,
weekendSolveMode: 'after',
endMode: 'never',
},
});
//test the creation of non recurring schedule
const ScheduleId2 = await api.createSchedule({
name: 'test-schedule 2',
posts_transaction: false,
amount: 4000,
amountOp: 'is',
date: '2025-06-13',
});
let schedules = await api.getSchedules();
// Schedules successfully created
expect(schedules).toEqual(
expect.arrayContaining([
expect.objectContaining({
name: 'test-schedule 1',
posts_transaction: true,
// amount: -5000,
amountOp: 'is',
date: {
frequency: 'monthly',
interval: 1,
start: '2025-06-13',
patterns: [],
skipWeekend: false,
weekendSolveMode: 'after',
endMode: 'never',
},
}),
expect.objectContaining({
name: 'test-schedule 2',
posts_transaction: false,
amount: 4000,
amountOp: 'is',
date: '2025-06-13',
}),
]),
);
//check getIDByName works on schedules
expect(await api.getIDByName('schedules', 'test-schedule 1')).toEqual(
ScheduleId1,
);
expect(await api.getIDByName('schedules', 'test-schedule 2')).toEqual(
ScheduleId2,
);
//check getIDByName works on accounts
const schedAccountId1 = await api.createAccount(
{ name: 'sched-test-account1', offbudget: true },
1000,
);
expect(await api.getIDByName('accounts', 'sched-test-account1')).toEqual(
schedAccountId1,
);
//check getIDByName works on payees
const schedPayeeId1 = await api.createPayee({ name: 'sched-test-payee1' });
expect(await api.getIDByName('payees', 'sched-test-payee1')).toEqual(
schedPayeeId1,
);
await api.updateSchedule(ScheduleId1, {
amount: -10000,
account: schedAccountId1,
});
await api.deleteSchedule(ScheduleId2);
// schedules successfully updated, and one of them deleted
await api.updateSchedule(ScheduleId1, {
amount: -10000,
account: schedAccountId1,
payee: schedPayeeId1,
});
await api.deleteSchedule(ScheduleId2);
schedules = await api.getSchedules();
expect(schedules).toEqual(
expect.arrayContaining([
expect.objectContaining({
id: ScheduleId1,
posts_transaction: true,
amount: -10000,
account: schedAccountId1,
payee: schedPayeeId1,
amountOp: 'is',
date: {
frequency: 'monthly',
interval: 1,
start: '2025-06-13',
patterns: [],
skipWeekend: false,
weekendSolveMode: 'after',
endMode: 'never',
},
}),
expect.not.objectContaining({ id: ScheduleId2 }),
]),
);
});

View File

@@ -1,5 +1,6 @@
// @ts-strict-ignore
import type { Handlers } from 'loot-core/types/handlers';
import type { ImportTransactionEntity } from 'loot-core/types/models/import-transaction';
import * as injected from './injected';
@@ -52,10 +53,18 @@ export async function batchBudgetUpdates(func) {
}
}
/**
* @deprecated Please use `aqlQuery` instead.
* This function will be removed in a future release.
*/
export function runQuery(query) {
return send('api/query', { query: query.serialize() });
}
export function aqlQuery(query) {
return send('api/query', { query: query.serialize() });
}
export function getBudgetMonths() {
return send('api/budget-months');
}
@@ -87,18 +96,21 @@ export function addTransactions(
export interface ImportTransactionsOpts {
defaultCleared?: boolean;
dryRun?: boolean;
}
export function importTransactions(
accountId,
transactions,
accountId: string,
transactions: ImportTransactionEntity[],
opts: ImportTransactionsOpts = {
defaultCleared: true,
dryRun: false,
},
) {
return send('api/transactions-import', {
accountId,
transactions,
isPreview: opts.dryRun,
opts,
});
}
@@ -230,3 +242,31 @@ export function holdBudgetForNextMonth(month, amount) {
export function resetBudgetHold(month) {
return send('api/budget-reset-hold', { month });
}
export function createSchedule(schedule) {
return send('api/schedule-create', schedule);
}
export function updateSchedule(id, fields, resetNextDate?: boolean) {
return send('api/schedule-update', {
id,
fields,
resetNextDate,
});
}
export function deleteSchedule(scheduleId) {
return send('api/schedule-delete', scheduleId);
}
export function getSchedules() {
return send('api/schedules-get');
}
export function getIDByName(type, name) {
return send('api/get-id-by-name', { type, name });
}
export function getServerVersion() {
return send('api/get-server-version');
}

View File

@@ -1,10 +1,10 @@
{
"name": "@actual-app/api",
"version": "25.3.1",
"version": "25.10.0",
"license": "MIT",
"description": "An API for Actual",
"engines": {
"node": ">=18.12.0"
"node": ">=20"
},
"main": "dist/index.js",
"types": "@types/index.d.ts",
@@ -14,27 +14,24 @@
],
"scripts": {
"build:app": "yarn workspace loot-core build:api",
"build:crdt": "yarn workspace @actual-app/crdt build",
"build:node": "tsc --p tsconfig.dist.json && tsc-alias -p tsconfig.dist.json",
"build:migrations": "cp migrations/*.sql dist/migrations",
"build:default-db": "cp default-db.sqlite dist/",
"build": "yarn run clean && yarn run build:app && yarn run build:node && yarn run build:migrations && yarn run build:default-db",
"test": "yarn run build:app && jest -c jest.config.js",
"test": "yarn run build:app && yarn run build:crdt && vitest --run",
"clean": "rm -rf dist @types"
},
"dependencies": {
"@actual-app/crdt": "workspace:^",
"better-sqlite3": "^11.7.0",
"compare-versions": "^6.1.0",
"better-sqlite3": "^12.4.1",
"compare-versions": "^6.1.1",
"node-fetch": "^3.3.2",
"uuid": "^9.0.1"
"uuid": "^13.0.0"
},
"devDependencies": {
"@swc/core": "^1.5.3",
"@swc/jest": "^0.2.36",
"@types/jest": "^27.5.2",
"@types/uuid": "^9.0.2",
"jest": "^27.5.1",
"tsc-alias": "^1.8.8",
"typescript": "^5.5.4"
"tsc-alias": "^1.8.16",
"typescript": "^5.9.3",
"vitest": "^3.2.4"
}
}

View File

@@ -11,9 +11,9 @@
"outDir": "dist",
"declarationDir": "@types",
"paths": {
"loot-core/*": ["./@types/loot-core/*"]
"loot-core/*": ["./@types/loot-core/src/*"]
}
},
"include": ["."],
"exclude": ["**/node_modules/*", "dist", "@types"]
"exclude": ["**/node_modules/*", "dist", "@types", "*.test.ts"]
}

View File

@@ -1,7 +0,0 @@
export function amountToInteger(n) {
return Math.round(n * 100);
}
export function integerToAmount(n) {
return parseFloat((n / 100).toFixed(2));
}

6
packages/api/utils.ts Normal file
View File

@@ -0,0 +1,6 @@
// @ts-ignore: bundle not available until we build it
// eslint-disable-next-line import/extensions
import * as bundle from './app/bundle.api.js';
export const amountToInteger = bundle.lib.amountToInteger;
export const integerToAmount = bundle.lib.integerToAmount;

View File

@@ -0,0 +1,15 @@
export default {
test: {
globals: true,
onConsoleLog(log: string, type: 'stdout' | 'stderr'): boolean | void {
// print only console.error
return type === 'stderr';
},
poolOptions: {
threads: {
maxThreads: 2,
minThreads: 1,
},
},
},
};

View File

@@ -0,0 +1,73 @@
#!/usr/bin/env node
// This script is used in GitHub Actions to get the next version based on the current package.json version.
// It supports three types of versioning: nightly, hotfix, and monthly.
import fs from 'node:fs';
import { parseArgs } from 'node:util';
// eslint-disable-next-line import/extensions
import { getNextVersion } from '../src/versions/get-next-package-version.js';
const args = process.argv;
const options = {
'package-json': {
type: 'string',
short: 'p',
},
type: {
type: 'string', // nightly, hotfix, monthly, auto
short: 't',
},
update: {
type: 'boolean',
short: 'u',
default: false,
},
};
const { values } = parseArgs({
args,
options,
allowPositionals: true,
});
if (!values['package-json']) {
console.error(
'Please specify the path to package.json using --package-json or -p option.',
);
process.exit(1);
}
try {
const packageJsonPath = values['package-json'];
const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
const currentVersion = packageJson.version;
let newVersion;
try {
newVersion = getNextVersion({
currentVersion,
type: values.type,
currentDate: new Date(),
});
} catch (e) {
console.error(e.message);
process.exit(1);
}
process.stdout.write(newVersion);
if (values.update) {
packageJson.version = newVersion;
fs.writeFileSync(
packageJsonPath,
JSON.stringify(packageJson, null, 2) + '\n',
'utf8',
);
}
} catch (error) {
console.error('Error:', error.message);
process.exit(1);
}

View File

@@ -0,0 +1,11 @@
{
"name": "@actual-app/ci-actions",
"private": true,
"type": "module",
"devDependencies": {
"vitest": "^3.2.4"
},
"scripts": {
"test": "vitest --run"
}
}

View File

@@ -0,0 +1,72 @@
function parseVersion(version) {
const [y, m, p] = version.split('.');
return {
versionYear: parseInt(y, 10),
versionMonth: parseInt(m, 10),
versionHotfix: parseInt(p, 10),
};
}
function computeNextMonth(versionYear, versionMonth) {
// Create date and add 1 month
const versionDate = new Date(2000 + versionYear, versionMonth - 1, 1); // month is 0-indexed
const nextVersionMonthDate = new Date(
versionDate.getFullYear(),
versionDate.getMonth() + 1,
1,
);
// Format back to YY.M format
const fullYear = nextVersionMonthDate.getFullYear();
const nextVersionYear = fullYear.toString().slice(fullYear < 2100 ? -2 : -3);
const nextVersionMonth = nextVersionMonthDate.getMonth() + 1; // Convert back to 1-indexed
return { nextVersionYear, nextVersionMonth };
}
// Determine logical type from 'auto' based on the current date and version
function resolveType(type, currentDate, versionYear, versionMonth) {
if (type !== 'auto') return type;
const inPatchMonth =
currentDate.getFullYear() === 2000 + versionYear &&
currentDate.getMonth() + 1 === versionMonth;
if (inPatchMonth && currentDate.getDate() <= 25) return 'hotfix';
return 'monthly';
}
export function getNextVersion({
currentVersion,
type,
currentDate = new Date(),
}) {
const { versionYear, versionMonth, versionHotfix } =
parseVersion(currentVersion);
const { nextVersionYear, nextVersionMonth } = computeNextMonth(
versionYear,
versionMonth,
);
const resolvedType = resolveType(
type,
currentDate,
versionYear,
versionMonth,
);
// Format date stamp once for nightly
const currentDateString = currentDate
.toISOString()
.split('T')[0]
.replaceAll('-', '');
switch (resolvedType) {
case 'nightly':
return `${nextVersionYear}.${nextVersionMonth}.0-nightly.${currentDateString}`;
case 'hotfix':
return `${versionYear}.${versionMonth}.${versionHotfix + 1}`;
case 'monthly':
return `${nextVersionYear}.${nextVersionMonth}.0`;
default:
throw new Error(
'Invalid type specified. Use “auto”, “nightly”, “hotfix”, or “monthly”.',
);
}
}

View File

@@ -0,0 +1,85 @@
import { describe, it, expect } from 'vitest';
import { getNextVersion } from './get-next-package-version';
describe('getNextVersion (lib)', () => {
it('hotfix increments patch', () => {
expect(
getNextVersion({
currentVersion: '25.8.1',
type: 'hotfix',
currentDate: new Date('2025-08-10'),
}),
).toBe('25.8.2');
});
it('monthly advances month same year', () => {
expect(
getNextVersion({
currentVersion: '25.8.3',
type: 'monthly',
currentDate: new Date('2025-08-15'),
}),
).toBe('25.9.0');
});
it('monthly wraps year December -> January', () => {
expect(
getNextVersion({
currentVersion: '25.12.3',
type: 'monthly',
currentDate: new Date('2025-12-05'),
}),
).toBe('26.1.0');
});
it('nightly format with date stamp', () => {
expect(
getNextVersion({
currentVersion: '25.8.1',
type: 'nightly',
currentDate: new Date('2025-08-22'),
}),
).toBe('25.9.0-nightly.20250822');
});
it('auto before 25th -> hotfix', () => {
expect(
getNextVersion({
currentVersion: '25.8.4',
type: 'auto',
currentDate: new Date('2025-08-20'),
}),
).toBe('25.8.5');
});
it('auto after 25th (same month) -> monthly', () => {
expect(
getNextVersion({
currentVersion: '25.8.4',
type: 'auto',
currentDate: new Date('2025-08-27'),
}),
).toBe('25.9.0');
});
it('auto after 25th (next month) -> monthly', () => {
expect(
getNextVersion({
currentVersion: '25.8.4',
type: 'auto',
currentDate: new Date('2025-09-02'),
}),
).toBe('25.9.0');
});
it('invalid type throws', () => {
expect(() =>
getNextVersion({
currentVersion: '25.8.4',
type: 'unknown',
currentDate: new Date('2025-08-10'),
}),
).toThrow(/Invalid type/);
});
});

View File

@@ -0,0 +1,14 @@
import { defineConfig } from 'vitest/config';
export default defineConfig({
test: {
globals: true,
include: ['src/**/*.test.(js|jsx|ts|tsx)'],
environment: 'node',
poolOptions: {
threads: {
singleThread: true,
},
},
},
});

View File

@@ -3,18 +3,23 @@
"version": "0.0.1",
"license": "MIT",
"peerDependencies": {
"react": ">=18.2"
"react": ">=18.2",
"react-dom": ">=18.2"
},
"dependencies": {
"@emotion/css": "^11.13.4",
"react-aria-components": "^1.7.0"
"@emotion/css": "^11.13.5",
"react-aria-components": "^1.13.0",
"usehooks-ts": "^3.1.1"
},
"devDependencies": {
"@svgr/cli": "^8.1.0",
"@types/react": "^18.2.0",
"react": "18.2.0"
"@types/react": "^19.2.2",
"react": "19.2.0",
"react-dom": "19.2.0",
"vitest": "^3.2.4"
},
"exports": {
"./hooks/*": "./src/hooks/*.ts",
"./icons/logo": "./src/icons/logo/index.ts",
"./icons/v0": "./src/icons/v0/index.ts",
"./icons/v1": "./src/icons/v1/index.ts",
@@ -43,9 +48,12 @@
"./tokens": "./src/tokens.ts",
"./toggle": "./src/Toggle.tsx",
"./tooltip": "./src/Tooltip.tsx",
"./view": "./src/View.tsx"
"./view": "./src/View.tsx",
"./color-picker": "./src/ColorPicker.tsx"
},
"scripts": {
"generate:icons": "rm src/icons/*/*.tsx; cd src/icons && svgr --template template.ts --index-template index-template.ts --typescript --expand-props start -d . ."
"generate:icons": "rm src/icons/*/*.tsx; cd src/icons && svgr --template template.ts --index-template index-template.ts --typescript --expand-props start -d . .",
"test": "npm-run-all -cp 'test:*'",
"test:web": "ENV=web vitest --run -c vitest.web.config.ts"
}
}

View File

@@ -7,7 +7,7 @@ import React, {
} from 'react';
import { Button as ReactAriaButton } from 'react-aria-components';
import { css } from '@emotion/css';
import { css, cx } from '@emotion/css';
import { AnimatedLoading } from './icons/AnimatedLoading';
import { styles } from './styles';
@@ -145,26 +145,24 @@ export const Button = forwardRef<HTMLButtonElement, ButtonProps>(
const defaultButtonClassName: string = useMemo(
() =>
String(
css({
alignItems: 'center',
justifyContent: 'center',
flexShrink: 0,
padding: _getPadding(variant),
margin: 0,
overflow: 'hidden',
display: 'flex',
borderRadius: 4,
backgroundColor: backgroundColor[variantWithDisabled],
border: _getBorder(variant, variantWithDisabled),
color: textColor[variantWithDisabled],
transition: 'box-shadow .25s',
WebkitAppRegion: 'no-drag',
...styles.smallText,
'&[data-hovered]': _getHoveredStyles(variant),
'&[data-pressed]': _getActiveStyles(variant, bounce),
}),
),
css({
alignItems: 'center',
justifyContent: 'center',
flexShrink: 0,
padding: _getPadding(variant),
margin: 0,
overflow: 'hidden',
display: 'flex',
borderRadius: 4,
backgroundColor: backgroundColor[variantWithDisabled],
border: _getBorder(variant, variantWithDisabled),
color: textColor[variantWithDisabled],
transition: 'box-shadow .25s',
WebkitAppRegion: 'no-drag',
...styles.smallText,
'&[data-hovered]': _getHoveredStyles(variant),
'&[data-pressed]': _getActiveStyles(variant, bounce),
}),
[bounce, variant, variantWithDisabled],
);
@@ -176,9 +174,8 @@ export const Button = forwardRef<HTMLButtonElement, ButtonProps>(
{...restProps}
className={
typeof className === 'function'
? renderProps =>
`${defaultButtonClassName} ${className(renderProps)}`
: `${defaultButtonClassName} ${className || ''}`
? renderProps => cx(defaultButtonClassName, className(renderProps))
: cx(defaultButtonClassName, className)
}
>
{children}

View File

@@ -0,0 +1,180 @@
import { ChangeEvent, ReactNode } from 'react';
import {
ColorPicker as AriaColorPicker,
ColorPickerProps as AriaColorPickerProps,
Dialog,
DialogTrigger,
ColorSwatch as AriaColorSwatch,
ColorSwatchProps,
ColorSwatchPicker as AriaColorSwatchPicker,
ColorSwatchPickerItem,
ColorField,
parseColor,
} from 'react-aria-components';
import { css } from '@emotion/css';
import { Input } from './Input';
import { Popover } from './Popover';
function ColorSwatch(props: ColorSwatchProps) {
return (
<AriaColorSwatch
{...props}
style={({ color }) => ({
background: color.toString('hex'),
width: '32px',
height: '32px',
borderRadius: '4px',
boxShadow: 'inset 0 0 0 1px rgba(0, 0, 0, 0.1)',
})}
/>
);
}
// colors from https://materialui.co/colors
const DEFAULT_COLOR_SET = [
'#690CB0',
'#D32F2F',
'#C2185B',
'#7B1FA2',
'#512DA8',
'#303F9F',
'#1976D2',
'#0288D1',
'#0097A7',
'#00796B',
'#388E3C',
'#689F38',
'#AFB42B',
'#FBC02D',
'#FFA000',
'#F57C00',
'#E64A19',
'#5D4037',
'#616161',
'#455A64',
];
interface ColorSwatchPickerProps {
columns?: number;
colorset?: string[];
}
function ColorSwatchPicker({
columns = 5,
colorset = DEFAULT_COLOR_SET,
}: ColorSwatchPickerProps) {
const pickers = [];
for (let l = 0; l < colorset.length / columns; l++) {
const pickerItems = [];
for (let c = 0; c < columns; c++) {
const color = colorset[columns * l + c];
if (!color) {
break;
}
pickerItems.push(
<ColorSwatchPickerItem
key={color}
color={color}
className={css({
position: 'relative',
outline: 'none',
borderRadius: '4px',
width: 'fit-content',
forcedColorAdjust: 'none',
cursor: 'pointer',
'&[data-selected]::after': {
// eslint-disable-next-line actual/typography
content: '""',
position: 'absolute',
inset: 0,
border: '2px solid black',
outline: '2px solid white',
outlineOffset: '-4px',
borderRadius: 'inherit',
},
})}
>
<ColorSwatch />
</ColorSwatchPickerItem>,
);
}
pickers.push(
<AriaColorSwatchPicker
key={`colorset-${l}`}
style={{
display: 'flex',
gap: '8px',
flexWrap: 'wrap',
}}
>
{pickerItems}
</AriaColorSwatchPicker>,
);
}
return pickers;
}
const isColor = (value: string) => /^#[0-9a-fA-F]{6}$/.test(value);
interface ColorPickerProps extends AriaColorPickerProps {
children?: ReactNode;
columns?: number;
colorset?: string[];
}
export function ColorPicker({
children,
columns,
colorset,
...props
}: ColorPickerProps) {
const onInput = (value: string) => {
if (!isColor(value)) {
return;
}
const color = parseColor(value);
if (color) {
props.onChange?.(color);
}
};
return (
<AriaColorPicker defaultValue={props.defaultValue ?? '#690CB0'} {...props}>
<DialogTrigger>
{children}
<Popover>
<Dialog
style={{
outline: 'none',
padding: '15px',
display: 'flex',
flexDirection: 'column',
gap: '8px',
minWidth: '192px',
maxHeight: 'inherit',
boxSizing: 'border-box',
overflow: 'auto',
}}
>
<ColorSwatchPicker columns={columns} colorset={colorset} />
<ColorField
onInput={({ target: { value } }: ChangeEvent<HTMLInputElement>) =>
onInput(value)
}
>
<Input placeholder="#RRGGBB" style={{ width: '100px' }} />
</ColorField>
</Dialog>
</Popover>
</DialogTrigger>
</AriaColorPicker>
);
}

View File

@@ -1,36 +1,65 @@
import {
type ReactElement,
type Ref,
Children,
cloneElement,
isValidElement,
type ReactElement,
Ref,
RefObject,
useEffect,
useRef,
} from 'react';
type InitialFocusProps = {
type InitialFocusProps<T extends HTMLElement> = {
/**
* The child element to focus when the component mounts. This can be either a single React element or a function that returns a React element.
* The child element should have a `ref` prop for this to work. For child components which receives a ref via another prop
* e.g. `inputRef`, use a function as child and pass the ref to the appropriate prop.
*/
children:
| ReactElement<{ inputRef: Ref<HTMLInputElement> }>
| ((node: Ref<HTMLInputElement>) => ReactElement);
| ReactElement<{ ref: Ref<T> }>
| ((ref: RefObject<T | null>) => ReactElement);
};
export function InitialFocus({ children }: InitialFocusProps) {
const node = useRef<HTMLInputElement>(null);
/**
* InitialFocus sets focus on its child element
* when it mounts.
* @param {ReactElement | function} children - A single React element or a function that returns a React element.
* The child element should have a `ref` prop for this to work. For child components which receives a ref via another prop
* e.g. `inputRef`, use a function as child and pass the ref to the appropriate prop.
*/
export function InitialFocus<T extends HTMLElement = HTMLElement>({
children,
}: InitialFocusProps<T>) {
const ref = useRef<T | null>(null);
useEffect(() => {
if (node.current) {
if (ref.current) {
// This is needed to avoid a strange interaction with
// `ScopeTab`, which doesn't allow it to be focused at first for
// some reason. Need to look into it.
setTimeout(() => {
if (node.current) {
node.current.focus();
node.current.setSelectionRange(0, 10000);
if (ref.current) {
ref.current.focus();
if (
ref.current instanceof HTMLInputElement ||
ref.current instanceof HTMLTextAreaElement
) {
ref.current.setSelectionRange(0, 10000);
}
}
}, 0);
}
}, []);
if (typeof children === 'function') {
return children(node);
return children(ref);
}
return cloneElement(children, { inputRef: node });
const child = Children.only(children);
if (isValidElement(child)) {
return cloneElement(child, { ref });
}
throw new Error(
'InitialFocus expects a single valid React element as its child.',
);
}

View File

@@ -0,0 +1,117 @@
import * as React from 'react';
import { forwardRef, Ref } from 'react';
import { render } from '@testing-library/react';
import { InitialFocus } from './InitialFocus';
import { View } from './View';
describe('InitialFocus', () => {
it('should focus a text input', async () => {
const component = render(
<View>
<InitialFocus>
<input type="text" title="focused" />
</InitialFocus>
<input type="text" title="unfocused" />
</View>,
);
// This is needed bc of the `setTimeout` in the `InitialFocus` component.
await new Promise(resolve => setTimeout(resolve, 0));
const input = component.getByTitle('focused') as HTMLInputElement;
const unfocusedInput = component.getByTitle(
'unfocused',
) as HTMLInputElement;
expect(document.activeElement).toBe(input);
expect(document.activeElement).not.toBe(unfocusedInput);
});
it('should focus a textarea', async () => {
const component = render(
<View>
<InitialFocus>
<textarea title="focused" />
</InitialFocus>
<textarea title="unfocused" />
</View>,
);
// This is needed bc of the `setTimeout` in the `InitialFocus` component.
await new Promise(resolve => setTimeout(resolve, 0));
const textarea = component.getByTitle('focused') as HTMLTextAreaElement;
const unfocusedTextarea = component.getByTitle(
'unfocused',
) as HTMLTextAreaElement;
expect(document.activeElement).toBe(textarea);
expect(document.activeElement).not.toBe(unfocusedTextarea);
});
it('should select text in an input', async () => {
const component = render(
<View>
<InitialFocus>
<input type="text" title="focused" defaultValue="Hello World" />
</InitialFocus>
<input type="text" title="unfocused" />
</View>,
);
// This is needed bc of the `setTimeout` in the `InitialFocus` component.
await new Promise(resolve => setTimeout(resolve, 0));
const input = component.getByTitle('focused') as HTMLInputElement;
expect(document.activeElement).toBe(input);
expect(input.selectionStart).toBe(0);
expect(input.selectionEnd).toBe(11); // Length of "Hello World"
});
it('should focus a button', async () => {
const component = render(
<View>
<InitialFocus>
<button title="focused">Click me</button>
</InitialFocus>
<button title="unfocused">Do not click me</button>
</View>,
);
// This is needed bc of the `setTimeout` in the `InitialFocus` component.
await new Promise(resolve => setTimeout(resolve, 0));
const button = component.getByTitle('focused') as HTMLButtonElement;
const unfocusedButton = component.getByTitle(
'unfocused',
) as HTMLButtonElement;
expect(document.activeElement).toBe(button);
expect(document.activeElement).not.toBe(unfocusedButton);
});
it('should focus a custom component with ref forwarding', async () => {
const CustomInput = forwardRef<HTMLInputElement>((props, ref) => (
<input type="text" ref={ref} {...props} title="focused" />
));
CustomInput.displayName = 'CustomInput';
const component = render(
<View>
<InitialFocus>
{node => <CustomInput ref={node as Ref<HTMLInputElement>} />}
</InitialFocus>
<input type="text" title="unfocused" />
</View>,
);
// This is needed bc of the `setTimeout` in the `InitialFocus` component.
await new Promise(resolve => setTimeout(resolve, 0));
const input = component.getByTitle('focused') as HTMLInputElement;
const unfocusedInput = component.getByTitle(
'unfocused',
) as HTMLInputElement;
expect(document.activeElement).toBe(input);
expect(document.activeElement).not.toBe(unfocusedInput);
});
});

View File

@@ -1,15 +1,18 @@
import React, {
type InputHTMLAttributes,
ChangeEvent,
ComponentPropsWithRef,
type KeyboardEvent,
type Ref,
type FocusEvent,
} from 'react';
import { Input as ReactAriaInput } from 'react-aria-components';
import { css, cx } from '@emotion/css';
import { styles, type CSSProperties } from './styles';
import { useResponsive } from './hooks/useResponsive';
import { styles } from './styles';
import { theme } from './theme';
export const defaultInputStyle = {
export const baseInputStyle = {
outline: 0,
backgroundColor: theme.tableBackground,
color: theme.formInputText,
@@ -19,85 +22,97 @@ export const defaultInputStyle = {
border: '1px solid ' + theme.formInputBorder,
};
type InputProps = InputHTMLAttributes<HTMLInputElement> & {
style?: CSSProperties;
inputRef?: Ref<HTMLInputElement>;
onEnter?: (event: KeyboardEvent<HTMLInputElement>) => void;
onEscape?: (event: KeyboardEvent<HTMLInputElement>) => void;
onChangeValue?: (newValue: string) => void;
onUpdate?: (newValue: string) => void;
const defaultInputClassName = css({
...baseInputStyle,
color: theme.formInputText,
whiteSpace: 'nowrap',
overflow: 'hidden',
flexShrink: 0,
'&[data-focused]': {
border: '1px solid ' + theme.formInputBorderSelected,
boxShadow: '0 1px 1px ' + theme.formInputShadowSelected,
},
'&[data-disabled]': {
color: theme.formInputTextPlaceholder,
},
'::placeholder': { color: theme.formInputTextPlaceholder },
...styles.smallText,
});
export type InputProps = ComponentPropsWithRef<typeof ReactAriaInput> & {
onEnter?: (value: string, event: KeyboardEvent<HTMLInputElement>) => void;
onEscape?: (value: string, event: KeyboardEvent<HTMLInputElement>) => void;
onChangeValue?: (
newValue: string,
event: ChangeEvent<HTMLInputElement>,
) => void;
onUpdate?: (newValue: string, event: FocusEvent<HTMLInputElement>) => void;
};
export function Input({
style,
inputRef,
ref,
onEnter,
onEscape,
onChangeValue,
onUpdate,
className,
...nativeProps
...props
}: InputProps) {
return (
<input
ref={inputRef}
className={cx(
css(
defaultInputStyle,
{
color: nativeProps.disabled
? theme.formInputTextPlaceholder
: theme.formInputText,
whiteSpace: 'nowrap',
overflow: 'hidden',
flexShrink: 0,
':focus': {
border: '1px solid ' + theme.formInputBorderSelected,
boxShadow: '0 1px 1px ' + theme.formInputShadowSelected,
},
'::placeholder': { color: theme.formInputTextPlaceholder },
},
styles.smallText,
style,
),
className,
)}
{...nativeProps}
onKeyDown={e => {
nativeProps.onKeyDown?.(e);
<ReactAriaInput
ref={ref}
className={
typeof className === 'function'
? renderProps => cx(defaultInputClassName, className(renderProps))
: cx(defaultInputClassName, className)
}
{...props}
onKeyUp={e => {
props.onKeyUp?.(e);
if (e.key === 'Enter' && onEnter) {
onEnter(e);
onEnter(e.currentTarget.value, e);
}
if (e.key === 'Escape' && onEscape) {
onEscape(e);
onEscape(e.currentTarget.value, e);
}
}}
onBlur={e => {
onUpdate?.(e.target.value);
nativeProps.onBlur?.(e);
onUpdate?.(e.currentTarget.value, e);
props.onBlur?.(e);
}}
onChange={e => {
onChangeValue?.(e.target.value);
nativeProps.onChange?.(e);
onChangeValue?.(e.currentTarget.value, e);
props.onChange?.(e);
}}
/>
);
}
export function BigInput(props: InputProps) {
const defaultBigInputClassName = css({
padding: 10,
fontSize: 15,
border: 'none',
...styles.shadow,
'&[data-focused]': { border: 'none', ...styles.shadow },
});
export function BigInput({ className, ...props }: InputProps) {
return (
<Input
{...props}
style={{
padding: 10,
fontSize: 15,
border: 'none',
...styles.shadow,
':focus': { border: 'none', ...styles.shadow },
...props.style,
}}
className={
typeof className === 'function'
? renderProps => cx(defaultBigInputClassName, className(renderProps))
: cx(defaultBigInputClassName, className)
}
/>
);
}
export function ResponsiveInput(props: InputProps) {
const { isNarrowWidth } = useResponsive();
return isNarrowWidth ? <BigInput {...props} /> : <Input {...props} />;
}

View File

@@ -3,11 +3,13 @@ import {
useEffect,
useRef,
useState,
type ComponentProps,
type ComponentType,
type SVGProps,
type CSSProperties,
} from 'react';
import { Button } from './Button';
import { Text } from './Text';
import { theme } from './theme';
import { Toggle } from './Toggle';
@@ -61,6 +63,7 @@ type MenuProps<NameType> = {
style?: CSSProperties;
className?: string;
getItemStyle?: (item: MenuItemObject<NameType>) => CSSProperties;
slot?: ComponentProps<typeof Button>['slot'];
};
export function Menu<const NameType = string>({
@@ -71,6 +74,7 @@ export function Menu<const NameType = string>({
style,
className,
getItemStyle,
slot,
}: MenuProps<NameType>) {
const elRef = useRef<HTMLDivElement>(null);
const items = allItems.filter(x => x);
@@ -161,9 +165,10 @@ export function Menu<const NameType = string>({
const Icon = item.icon;
return (
<View
role="button"
<Button
key={String(item.name)}
variant="bare"
slot={slot}
style={{
cursor: 'default',
padding: 10,
@@ -179,11 +184,9 @@ export function Menu<const NameType = string>({
}),
...(!isLabel(item) && getItemStyle?.(item)),
}}
onPointerEnter={() => setHoveredIndex(idx)}
onPointerLeave={() => setHoveredIndex(null)}
onPointerUp={e => {
e.stopPropagation();
onHoverStart={() => setHoveredIndex(idx)}
onHoverEnd={() => setHoveredIndex(null)}
onPress={() => {
if (
!item.disabled &&
item.toggle === undefined &&
@@ -232,7 +235,7 @@ export function Menu<const NameType = string>({
</View>
)}
{item.key && <Keybinding keyName={item.key} />}
</View>
</Button>
);
})}
{footer}

View File

@@ -1,5 +1,6 @@
import React, { type CSSProperties, type ReactNode } from 'react';
import React, { type ReactNode } from 'react';
import { type CSSProperties } from './styles';
import { View } from './View';
type SpaceBetweenProps = {

View File

@@ -21,7 +21,14 @@ function getChildren(key, children) {
'type' in child &&
child.type === Fragment
) {
return list.concat(getChildren(child.key, child.props.children));
return list.concat(
getChildren(
child.key,
typeof child.props === 'object' && 'children' in child.props
? child.props.children
: [],
),
);
}
list.push({ key: key + child['key'], child });
return list;

View File

@@ -62,7 +62,7 @@ export const Toggle = ({
data-on={isOn}
className={css(
{
// eslint-disable-next-line rulesdir/typography
// eslint-disable-next-line actual/typography
content: '" "',
position: 'absolute',
top: '2px',

View File

@@ -26,9 +26,14 @@ export const Tooltip = ({
const triggerRef = useRef(null);
const [isHovered, setIsHover] = useState(false);
const hoverTimeoutRef = useRef<ReturnType<typeof setTimeout>>();
const hoverTimeoutRef = useRef<ReturnType<typeof setTimeout>>(null);
const closeTimeoutRef = useRef<ReturnType<typeof setTimeout>>(null);
const handlePointerEnter = useCallback(() => {
if (closeTimeoutRef.current) {
clearTimeout(closeTimeoutRef.current);
}
const timeout = setTimeout(() => {
setIsHover(true);
}, triggerProps.delay ?? 300);
@@ -41,8 +46,10 @@ export const Tooltip = ({
clearTimeout(hoverTimeoutRef.current);
}
setIsHover(false);
}, []);
closeTimeoutRef.current = setTimeout(() => {
setIsHover(false);
}, triggerProps.closeDelay ?? 0);
}, [triggerProps.closeDelay]);
// Force closing the tooltip whenever the disablement state changes
useEffect(() => {

View File

@@ -23,7 +23,11 @@ export const View = forwardRef<HTMLDivElement, ViewProps>((props, ref) => {
{...restProps}
ref={innerRef ?? ref}
style={nativeStyle}
className={cx('view', className, css(style))}
className={cx(
'view',
className,
style && Object.keys(style).length > 0 ? css(style) : undefined,
)}
/>
);
});

View File

@@ -0,0 +1,23 @@
import { useWindowSize } from 'usehooks-ts';
import { breakpoints } from '../tokens';
export function useResponsive() {
const { height, width } = useWindowSize({
debounceDelay: 250,
});
// Possible view modes: narrow, small, medium, wide
// To check if we're at least small width, check !isNarrowWidth
return {
// atLeastMediumWidth is provided to avoid checking (isMediumWidth || isWideWidth)
atLeastMediumWidth: width >= breakpoints.medium,
isNarrowWidth: width < breakpoints.small,
isSmallWidth: width >= breakpoints.small && width < breakpoints.medium,
isMediumWidth: width >= breakpoints.medium && width < breakpoints.wide,
// No atLeastWideWidth because that's identical to isWideWidth
isWideWidth: width >= breakpoints.wide,
height,
width,
};
}

View File

@@ -0,0 +1,18 @@
import * as React from 'react';
import type { SVGProps } from 'react';
export const SvgArrowButtonSingleLeft1 = (props: SVGProps<SVGSVGElement>) => (
<svg
{...props}
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 24 24"
style={{
color: 'inherit',
...props.style,
}}
>
<path
d="M.25 12a2.643 2.643 0 0 1 .775-1.875L10.566.584a1.768 1.768 0 0 1 2.5 2.5l-8.739 8.739a.25.25 0 0 0 0 .354l8.739 8.739a1.768 1.768 0 0 1-2.5 2.5l-9.541-9.541A2.643 2.643 0 0 1 .25 12Z"
fill="currentColor"
/>
</svg>
);

View File

@@ -0,0 +1 @@
<svg id="Bold" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><title>arrow-button-single-left-1</title><path d="M.25,12a2.643,2.643,0,0,1,.775-1.875L10.566.584a1.768,1.768,0,0,1,2.5,2.5L4.327,11.823a.25.25,0,0,0,0,.354l8.739,8.739a1.768,1.768,0,0,1-2.5,2.5L1.025,13.875A2.643,2.643,0,0,1,.25,12Z"/></svg>

After

Width:  |  Height:  |  Size: 312 B

View File

@@ -2,6 +2,7 @@ export { SvgAlertTriangle } from './AlertTriangle';
export { SvgArrowButtonDown1 } from './ArrowButtonDown1';
export { SvgArrowButtonLeft1 } from './ArrowButtonLeft1';
export { SvgArrowButtonRight1 } from './ArrowButtonRight1';
export { SvgArrowButtonSingleLeft1 } from './ArrowButtonSingleLeft1';
export { SvgArrowButtonUp1 } from './ArrowButtonUp1';
export { SvgArrowsExpand3 } from './ArrowsExpand3';
export { SvgArrowsShrink3 } from './ArrowsShrink3';

View File

@@ -91,7 +91,7 @@ export const styles: Record<string, any> = {
},
shadowLarge,
tnum: {
// eslint-disable-next-line rulesdir/typography
// eslint-disable-next-line actual/typography
fontFeatureSettings: '"tnum"',
},
notFixed: { fontFeatureSettings: '' },
@@ -154,4 +154,10 @@ export const styles: Record<string, any> = {
borderRadius: 4,
padding: '3px 5px',
},
mobileListItem: {
borderBottom: `1px solid ${theme.tableBorder}`,
backgroundColor: theme.tableBackground,
padding: 16,
cursor: 'pointer',
},
};

View File

@@ -188,6 +188,7 @@ export const theme = {
reportsInnerLabel: 'var(--color-reportsInnerLabel)',
noteTagBackground: 'var(--color-noteTagBackground)',
noteTagBackgroundHover: 'var(--color-noteTagBackgroundHover)',
noteTagDefault: 'var(--color-noteTagDefault)',
noteTagText: 'var(--color-noteTagText)',
budgetOtherMonth: 'var(--color-budgetOtherMonth)',
budgetCurrentMonth: 'var(--color-budgetCurrentMonth)',

View File

@@ -0,0 +1,41 @@
import path from 'path';
import peggyLoader from 'vite-plugin-peggy-loader';
import { defineConfig } from 'vitest/config';
const resolveExtensions = [
'.testing.ts',
'.web.ts',
'.mjs',
'.js',
'.mts',
'.ts',
'.jsx',
'.tsx',
'.json',
'.wasm',
];
export default defineConfig({
test: {
environment: 'jsdom',
globals: true,
include: ['src/**/*.web.test.(js|jsx|ts|tsx)'],
poolOptions: {
threads: {
maxThreads: 2,
minThreads: 1,
},
},
},
resolve: {
alias: [
{
find: /^@actual-app\/crdt(\/.*)?$/,
replacement: path.resolve('../../../crdt/src$1'),
},
],
extensions: resolveExtensions,
},
plugins: [peggyLoader()],
});

View File

@@ -18,4 +18,9 @@ protoc --plugin="protoc-gen-ts=../../node_modules/.bin/protoc-gen-ts" \
../../node_modules/.bin/prettier --write src/proto/*.d.ts
for file in src/proto/*.d.ts; do
{ echo "/* eslint-disable @typescript-eslint/no-namespace */"; sed 's/export class/export declare class/g' "$file"; } > "${file%.d.ts}.ts"
rm "$file"
done
echo 'One more step! Find the `var global = ...` declaration in src/proto/sync_pb.js and change it to `var global = globalThis;`'

View File

@@ -1 +1 @@
export * from './src/main';
export * from './src';

View File

@@ -1,6 +0,0 @@
module.exports = {
testEnvironment: 'node',
transform: {
'^.+\\.(t|j)sx?$': '@swc/jest',
},
};

View File

@@ -11,21 +11,19 @@
"scripts": {
"build:node": "tsc --p tsconfig.dist.json",
"proto:generate": "./bin/generate-proto",
"build": "rm -rf dist && yarn run build:node && cp src/proto/sync_pb.d.ts dist/src/proto/",
"test": "jest -c jest.config.js"
"build": "rm -rf dist && yarn run build:node",
"test": "vitest --run --globals"
},
"dependencies": {
"google-protobuf": "^3.12.0-rc.1",
"google-protobuf": "^3.21.4",
"murmurhash": "^2.0.1",
"uuid": "^9.0.1"
"uuid": "^13.0.0"
},
"devDependencies": {
"@swc/core": "^1.5.3",
"@swc/jest": "^0.2.36",
"@types/jest": "^27.5.2",
"@types/uuid": "^9.0.2",
"jest": "^27.5.1",
"@types/google-protobuf": "^3.15.12",
"protoc-gen-js": "^3.21.4-4",
"ts-protoc-gen": "^0.15.0",
"typescript": "^5.5.4"
"typescript": "^5.9.3",
"vitest": "^3.2.4"
}
}

View File

@@ -1,23 +1,23 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
exports[`merkle trie adding an item works 1`] = `
Object {
"1": Object {
"2": Object {
"1": Object {
"0": Object {
"1": Object {
"0": Object {
"0": Object {
"2": Object {
"0": Object {
"1": Object {
"1": Object {
"0": Object {
"2": Object {
"2": Object {
"0": Object {
"0": Object {
exports[`merkle trie > adding an item works 1`] = `
{
"1": {
"2": {
"1": {
"0": {
"1": {
"0": {
"0": {
"2": {
"0": {
"1": {
"1": {
"0": {
"2": {
"2": {
"0": {
"0": {
"hash": 1983295247,
},
"hash": 1983295247,
@@ -34,14 +34,14 @@ Object {
},
"hash": 1983295247,
},
"1": Object {
"0": Object {
"1": Object {
"0": Object {
"2": Object {
"0": Object {
"0": Object {
"0": Object {
"1": {
"0": {
"1": {
"0": {
"2": {
"0": {
"0": {
"0": {
"hash": 1469038940,
},
"hash": 1469038940,
@@ -78,33 +78,33 @@ Object {
}
`;
exports[`merkle trie pruning works and keeps correct hashes 1`] = `
Object {
"1": Object {
"2": Object {
"1": Object {
"0": Object {
"0": Object {
"2": Object {
"2": Object {
"2": Object {
"1": Object {
"2": Object {
"2": Object {
"0": Object {
"0": Object {
"1": Object {
"2": Object {
"0": Object {
exports[`merkle trie > pruning works and keeps correct hashes 1`] = `
{
"1": {
"2": {
"1": {
"0": {
"0": {
"2": {
"2": {
"2": {
"1": {
"2": {
"2": {
"0": {
"0": {
"1": {
"2": {
"0": {
"hash": 1000,
},
"hash": 1000,
},
"hash": 1000,
},
"2": Object {
"2": Object {
"0": Object {
"2": {
"2": {
"0": {
"hash": 1100,
},
"hash": 1100,
@@ -113,28 +113,28 @@ Object {
},
"hash": 1956,
},
"1": Object {
"0": Object {
"2": Object {
"0": Object {
"1": {
"0": {
"2": {
"0": {
"hash": 1200,
},
"hash": 1200,
},
"hash": 1200,
},
"1": Object {
"2": Object {
"0": Object {
"1": {
"2": {
"0": {
"hash": 1300,
},
"hash": 1300,
},
"hash": 1300,
},
"2": Object {
"2": Object {
"0": Object {
"2": {
"2": {
"0": {
"hash": 1400,
},
"hash": 1400,
@@ -143,28 +143,28 @@ Object {
},
"hash": 1244,
},
"2": Object {
"0": Object {
"2": Object {
"0": Object {
"2": {
"0": {
"2": {
"0": {
"hash": 1500,
},
"hash": 1500,
},
"hash": 1500,
},
"1": Object {
"2": Object {
"0": Object {
"1": {
"2": {
"0": {
"hash": 1600,
},
"hash": 1600,
},
"hash": 1600,
},
"2": Object {
"2": Object {
"0": Object {
"2": {
"2": {
"0": {
"hash": 1700,
},
"hash": 1700,
@@ -175,29 +175,29 @@ Object {
},
"hash": 1600,
},
"1": Object {
"0": Object {
"0": Object {
"1": Object {
"1": Object {
"1": {
"0": {
"0": {
"1": {
"1": {
"hash": 1800,
},
"hash": 1800,
},
"hash": 1800,
},
"1": Object {
"1": Object {
"1": Object {
"1": {
"1": {
"1": {
"hash": 1900,
},
"hash": 1900,
},
"hash": 1900,
},
"2": Object {
"1": Object {
"1": Object {
"2": {
"1": {
"1": {
"hash": 2000,
},
"hash": 2000,
@@ -206,10 +206,10 @@ Object {
},
"hash": 1972,
},
"1": Object {
"0": Object {
"1": Object {
"1": Object {
"1": {
"0": {
"1": {
"1": {
"hash": 2100,
},
"hash": 2100,
@@ -246,33 +246,33 @@ Object {
}
`;
exports[`merkle trie pruning works and keeps correct hashes 2`] = `
Object {
"1": Object {
"2": Object {
"1": Object {
"0": Object {
"0": Object {
"2": Object {
"2": Object {
"2": Object {
"1": Object {
"2": Object {
"2": Object {
"0": Object {
"1": Object {
"1": Object {
"2": Object {
"0": Object {
exports[`merkle trie > pruning works and keeps correct hashes 2`] = `
{
"1": {
"2": {
"1": {
"0": {
"0": {
"2": {
"2": {
"2": {
"1": {
"2": {
"2": {
"0": {
"1": {
"1": {
"2": {
"0": {
"hash": 1300,
},
"hash": 1300,
},
"hash": 1300,
},
"2": Object {
"2": Object {
"0": Object {
"2": {
"2": {
"0": {
"hash": 1400,
},
"hash": 1400,
@@ -281,19 +281,19 @@ Object {
},
"hash": 1244,
},
"2": Object {
"1": Object {
"2": Object {
"0": Object {
"2": {
"1": {
"2": {
"0": {
"hash": 1600,
},
"hash": 1600,
},
"hash": 1600,
},
"2": Object {
"2": Object {
"0": Object {
"2": {
"2": {
"0": {
"hash": 1700,
},
"hash": 1700,
@@ -304,20 +304,20 @@ Object {
},
"hash": 1600,
},
"1": Object {
"0": Object {
"1": Object {
"1": Object {
"1": Object {
"1": {
"0": {
"1": {
"1": {
"1": {
"hash": 1900,
},
"hash": 1900,
},
"hash": 1900,
},
"2": Object {
"1": Object {
"1": Object {
"2": {
"1": {
"1": {
"hash": 2000,
},
"hash": 2000,
@@ -326,10 +326,10 @@ Object {
},
"hash": 1972,
},
"1": Object {
"0": Object {
"1": Object {
"1": Object {
"1": {
"0": {
"1": {
"1": {
"hash": 2100,
},
"hash": 2100,

View File

@@ -0,0 +1,23 @@
/* eslint-disable @typescript-eslint/no-explicit-any */
import './proto/sync_pb.js'; // Import for side effects
export {
merkle,
getClock,
setClock,
makeClock,
makeClientId,
serializeClock,
deserializeClock,
type Clock,
Timestamp,
} from './crdt';
// Access global proto namespace
export const SyncRequest = (globalThis as any).proto.SyncRequest;
export const SyncResponse = (globalThis as any).proto.SyncResponse;
export const Message = (globalThis as any).proto.Message;
export const MessageEnvelope = (globalThis as any).proto.MessageEnvelope;
export const EncryptedData = (globalThis as any).proto.EncryptedData;
export const SyncProtoBuf = (globalThis as any).proto;

View File

@@ -1,14 +0,0 @@
import * as SyncPb from './proto/sync_pb';
export {
merkle,
getClock,
setClock,
makeClock,
makeClientId,
serializeClock,
deserializeClock,
type Clock,
Timestamp,
} from './crdt';
export const SyncProtoBuf = SyncPb;

View File

@@ -157,9 +157,9 @@ proto.EncryptedData.prototype.toObject = function(opt_includeInstance) {
*/
proto.EncryptedData.toObject = function(includeInstance, msg) {
var f, obj = {
iv: msg.getIv_asB64(),
authtag: msg.getAuthtag_asB64(),
data: msg.getData_asB64()
iv: msg.getIv_asB64(),
authtag: msg.getAuthtag_asB64(),
data: msg.getData_asB64()
};
if (includeInstance) {
@@ -419,10 +419,10 @@ proto.Message.prototype.toObject = function(opt_includeInstance) {
*/
proto.Message.toObject = function(includeInstance, msg) {
var f, obj = {
dataset: jspb.Message.getFieldWithDefault(msg, 1, ""),
row: jspb.Message.getFieldWithDefault(msg, 2, ""),
column: jspb.Message.getFieldWithDefault(msg, 3, ""),
value: jspb.Message.getFieldWithDefault(msg, 4, "")
dataset: jspb.Message.getFieldWithDefault(msg, 1, ""),
row: jspb.Message.getFieldWithDefault(msg, 2, ""),
column: jspb.Message.getFieldWithDefault(msg, 3, ""),
value: jspb.Message.getFieldWithDefault(msg, 4, "")
};
if (includeInstance) {
@@ -639,9 +639,9 @@ proto.MessageEnvelope.prototype.toObject = function(opt_includeInstance) {
*/
proto.MessageEnvelope.toObject = function(includeInstance, msg) {
var f, obj = {
timestamp: jspb.Message.getFieldWithDefault(msg, 1, ""),
isencrypted: jspb.Message.getBooleanFieldWithDefault(msg, 2, false),
content: msg.getContent_asB64()
timestamp: jspb.Message.getFieldWithDefault(msg, 1, ""),
isencrypted: jspb.Message.getBooleanFieldWithDefault(msg, 2, false),
content: msg.getContent_asB64()
};
if (includeInstance) {
@@ -860,12 +860,12 @@ proto.SyncRequest.prototype.toObject = function(opt_includeInstance) {
*/
proto.SyncRequest.toObject = function(includeInstance, msg) {
var f, obj = {
messagesList: jspb.Message.toObjectList(msg.getMessagesList(),
messagesList: jspb.Message.toObjectList(msg.getMessagesList(),
proto.MessageEnvelope.toObject, includeInstance),
fileid: jspb.Message.getFieldWithDefault(msg, 2, ""),
groupid: jspb.Message.getFieldWithDefault(msg, 3, ""),
keyid: jspb.Message.getFieldWithDefault(msg, 5, ""),
since: jspb.Message.getFieldWithDefault(msg, 6, "")
fileid: jspb.Message.getFieldWithDefault(msg, 2, ""),
groupid: jspb.Message.getFieldWithDefault(msg, 3, ""),
keyid: jspb.Message.getFieldWithDefault(msg, 5, ""),
since: jspb.Message.getFieldWithDefault(msg, 6, "")
};
if (includeInstance) {
@@ -1140,9 +1140,9 @@ proto.SyncResponse.prototype.toObject = function(opt_includeInstance) {
*/
proto.SyncResponse.toObject = function(includeInstance, msg) {
var f, obj = {
messagesList: jspb.Message.toObjectList(msg.getMessagesList(),
messagesList: jspb.Message.toObjectList(msg.getMessagesList(),
proto.MessageEnvelope.toObject, includeInstance),
merkle: jspb.Message.getFieldWithDefault(msg, 2, "")
merkle: jspb.Message.getFieldWithDefault(msg, 2, "")
};
if (includeInstance) {

View File

@@ -1,9 +1,10 @@
/* eslint-disable @typescript-eslint/no-namespace */
// package:
// file: sync.proto
import * as jspb from 'google-protobuf';
export class EncryptedData extends jspb.Message {
export declare class EncryptedData extends jspb.Message {
getIv(): Uint8Array | string;
getIv_asU8(): Uint8Array;
getIv_asB64(): string;
@@ -48,7 +49,7 @@ export namespace EncryptedData {
};
}
export class Message extends jspb.Message {
export declare class Message extends jspb.Message {
getDataset(): string;
setDataset(value: string): void;
@@ -88,7 +89,7 @@ export namespace Message {
};
}
export class MessageEnvelope extends jspb.Message {
export declare class MessageEnvelope extends jspb.Message {
getTimestamp(): string;
setTimestamp(value: string): void;
@@ -129,7 +130,7 @@ export namespace MessageEnvelope {
};
}
export class SyncRequest extends jspb.Message {
export declare class SyncRequest extends jspb.Message {
clearMessagesList(): void;
getMessagesList(): Array<MessageEnvelope>;
setMessagesList(value: Array<MessageEnvelope>): void;
@@ -178,7 +179,7 @@ export namespace SyncRequest {
};
}
export class SyncResponse extends jspb.Message {
export declare class SyncResponse extends jspb.Message {
clearMessagesList(): void;
getMessagesList(): Array<MessageEnvelope>;
setMessagesList(value: Array<MessageEnvelope>): void;

Some files were not shown because too many files have changed in this diff Show More