github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4682] [CLOSED] ✨ [Feature]: Added autocomplete for tags #5532

New Issue
Closed
opened 2026-02-28 21:13:57 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:13:57 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4682
Author: @alecbakholdin
Created: 3/23/2025
Status: ❌ Closed

Base: master ← Head: tag-autocomplete

📝 Commits (10+)

  • 72b6c38 Started implementing tag autocomplete
  • 935437a Added basic UI functionality
  • 2fa061c Made actual tags work
  • 7ddc985 Fixed some small UX things with the autocomplete
  • 2ba8e25 typo
  • ed87cf2 added release notes
  • da47012 Limit the number of tags visible in autocomplete at once
  • 2968f74 annoying changes that I thought I had fixed
  • 7f4e429 Added proper escape functionality
  • ae50960 Fixed some test errors

📊 Changes

16 files changed (+306 additions, -29 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.tsx (+6 -0)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+16 -8)
📝 packages/desktop-client/src/components/reports/reports/Calendar.tsx (+3 -0)
📝 packages/desktop-client/src/components/table.tsx (+6 -0)
📝 packages/desktop-client/src/components/transactions/TransactionList.jsx (+2 -0)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.jsx (+166 -14)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx (+0 -5)
➕ packages/desktop-client/src/hooks/useTags.ts (+31 -0)
📝 packages/loot-core/src/client/queries/queriesSlice.ts (+14 -0)
📝 packages/loot-core/src/client/query-hooks.ts (+1 -0)
📝 packages/loot-core/src/client/shared-listeners.ts (+10 -1)
📝 packages/loot-core/src/server/db/index.ts (+26 -0)
📝 packages/loot-core/src/server/main.ts (+2 -0)
➕ packages/loot-core/src/server/tags/app.ts (+14 -0)
📝 packages/loot-core/src/types/handlers.d.ts (+3 -1)
➕ upcoming-release-notes/4682.md (+6 -0)

📄 Description

I have a lot of tags, and sometimes I forget exactly how they're spelled. In this PR, I've created an autocomplete field in the notes column of the TransactionsTable that makes adding tags easier. I've made it as unobtrusive as possible, and it still supports adding multiple tags per note. To accomplish this, I had to modify the Autocomplete.tsx file. It turns out, this is the only SingleAutocomplete that I could find that is using strict={false}, which made modifying things fairly safe. Let me know what you think.

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4682 **Author:** [@alecbakholdin](https://github.com/alecbakholdin) **Created:** 3/23/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `tag-autocomplete` --- ### 📝 Commits (10+) - [`72b6c38`](https://github.com/actualbudget/actual/commit/72b6c38ee42a1ad5fc571ddcba3dcee9e16275c9) Started implementing tag autocomplete - [`935437a`](https://github.com/actualbudget/actual/commit/935437ad2222f2223d5ed7c3bebff5041dcc92a6) Added basic UI functionality - [`2fa061c`](https://github.com/actualbudget/actual/commit/2fa061cc60283abac88dcd9c7889d3afd34205fc) Made actual tags work - [`7ddc985`](https://github.com/actualbudget/actual/commit/7ddc985b3a1a2b8da703d510c9651437d12597c8) Fixed some small UX things with the autocomplete - [`2ba8e25`](https://github.com/actualbudget/actual/commit/2ba8e2576b578e3c7670c0f434fb462b24f8fc72) typo - [`ed87cf2`](https://github.com/actualbudget/actual/commit/ed87cf2dc3504f538c8e6266dc27ed55d1e0aa35) added release notes - [`da47012`](https://github.com/actualbudget/actual/commit/da4701231120beb4ca78344064d1034d43f290e1) Limit the number of tags visible in autocomplete at once - [`2968f74`](https://github.com/actualbudget/actual/commit/2968f74c1a638c5b2a3bae9e249a678c373e4303) annoying changes that I thought I had fixed - [`7f4e429`](https://github.com/actualbudget/actual/commit/7f4e4299136a675117347fc72a3c506e0f3bbf05) Added proper escape functionality - [`ae50960`](https://github.com/actualbudget/actual/commit/ae50960d3868dcacb3ba8b58426f29960ca3cb03) Fixed some test errors ### 📊 Changes **16 files changed** (+306 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+6 -0) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+16 -8) 📝 `packages/desktop-client/src/components/reports/reports/Calendar.tsx` (+3 -0) 📝 `packages/desktop-client/src/components/table.tsx` (+6 -0) 📝 `packages/desktop-client/src/components/transactions/TransactionList.jsx` (+2 -0) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.jsx` (+166 -14) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx` (+0 -5) ➕ `packages/desktop-client/src/hooks/useTags.ts` (+31 -0) 📝 `packages/loot-core/src/client/queries/queriesSlice.ts` (+14 -0) 📝 `packages/loot-core/src/client/query-hooks.ts` (+1 -0) 📝 `packages/loot-core/src/client/shared-listeners.ts` (+10 -1) 📝 `packages/loot-core/src/server/db/index.ts` (+26 -0) 📝 `packages/loot-core/src/server/main.ts` (+2 -0) ➕ `packages/loot-core/src/server/tags/app.ts` (+14 -0) 📝 `packages/loot-core/src/types/handlers.d.ts` (+3 -1) ➕ `upcoming-release-notes/4682.md` (+6 -0) </details> ### 📄 Description I have a lot of tags, and sometimes I forget exactly how they're spelled. In this PR, I've created an autocomplete field in the notes column of the TransactionsTable that makes adding tags easier. I've made it as unobtrusive as possible, and it still supports adding multiple tags per note. To accomplish this, I had to modify the Autocomplete.tsx file. It turns out, this is the only SingleAutocomplete that I could find that is using strict={false}, which made modifying things fairly safe. Let me know what you think. <img width="497" alt="image" src="https://github.com/user-attachments/assets/243e78a6-e115-402d-8bbb-d7625520dd30" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:13:57 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5532
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?