github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2991] [MERGED] fix(#2562): Prevent transaction deduplication for imported transactions #4626

New Issue
Closed
opened 2026-02-28 20:58:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:58:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2991
Author: @pmoon00
Created: 7/6/2024
Status: ✅ Merged
Merged: 8/9/2024
Merged by: @matt-fidd

Base: master ← Head: fix-trans-dedupe-import

📝 Commits (10+)

  • 6f97f85 fix(#2562): Prevent transaction deduplication for imported transactions (#2770)
  • 3c7726b Add Handling For goCardless Fuzzy Search
  • 75955a9 Rename Release Note File
  • 4fd9655 Rename Release Notes File
  • ece1b75 Merge branch 'master' into fix-trans-dedupe-import
  • 8c0d020 Merge branch 'master' into fix-trans-dedupe-import
  • e31bbb4 Merge branch 'master' into fix-trans-dedupe-import
  • f0fb2d4 Fix UseFuzzySearchV2 After Merge Conflict
  • a56235c Update Fuzzy Search Query To Include New Columns
  • 72acad2 Update useFuzzyMatchV2 Variable To useStrictIdChecking

📊 Changes

3 files changed (+217 additions, -14 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/sync.test.ts (+157 -0)
📝 packages/loot-core/src/server/accounts/sync.ts (+54 -14)
➕ upcoming-release-notes/2991.md (+6 -0)

📄 Description

Resolves https://github.com/actualbudget/actual/issues/2562

Based on https://github.com/actualbudget/actual/pull/2618 , with comments by @MatissJanis and others applied

Resolves issues that caused a rollback described here

This resolves the goCardless fuzzy search predicament by having two types of fuzzy search behaviours. The default fuzzy search doesn't allow for transactions with different import IDs from being matched. The old fuzzy logic remains to handle goCardless's quirk.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2991 **Author:** [@pmoon00](https://github.com/pmoon00) **Created:** 7/6/2024 **Status:** ✅ Merged **Merged:** 8/9/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fix-trans-dedupe-import` --- ### 📝 Commits (10+) - [`6f97f85`](https://github.com/actualbudget/actual/commit/6f97f85f79fd3e9a201edc22d74e58310d7015f2) fix(#2562): Prevent transaction deduplication for imported transactions (#2770) - [`3c7726b`](https://github.com/actualbudget/actual/commit/3c7726b3a7ec84ee702c22954f7ab2ff348bfee3) Add Handling For goCardless Fuzzy Search - [`75955a9`](https://github.com/actualbudget/actual/commit/75955a91b2913f4ef91276322823b8a31af37f3f) Rename Release Note File - [`4fd9655`](https://github.com/actualbudget/actual/commit/4fd9655320c939a2cde3f0464f98a10cb131865f) Rename Release Notes File - [`ece1b75`](https://github.com/actualbudget/actual/commit/ece1b757777df5e10b02cfe46fee3496164ac47a) Merge branch 'master' into fix-trans-dedupe-import - [`8c0d020`](https://github.com/actualbudget/actual/commit/8c0d0208c5aee085e6c2b378ff1e7a045eda9749) Merge branch 'master' into fix-trans-dedupe-import - [`e31bbb4`](https://github.com/actualbudget/actual/commit/e31bbb46dc6454466b97989608f837c8301e91ea) Merge branch 'master' into fix-trans-dedupe-import - [`f0fb2d4`](https://github.com/actualbudget/actual/commit/f0fb2d414c06bbca84652240b54b6c18f428b85a) Fix UseFuzzySearchV2 After Merge Conflict - [`a56235c`](https://github.com/actualbudget/actual/commit/a56235c7ff0e5328197e3c1f8ca2d9a11f67ef64) Update Fuzzy Search Query To Include New Columns - [`72acad2`](https://github.com/actualbudget/actual/commit/72acad2ebeb4aa61ae97e60561e1f86d0caacd67) Update useFuzzyMatchV2 Variable To useStrictIdChecking ### 📊 Changes **3 files changed** (+217 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/sync.test.ts` (+157 -0) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+54 -14) ➕ `upcoming-release-notes/2991.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Resolves https://github.com/actualbudget/actual/issues/2562 Based on https://github.com/actualbudget/actual/pull/2618 , with comments by @MatissJanis and others applied Resolves issues that caused a rollback [described here](https://github.com/actualbudget/actual/issues/2877) This resolves the goCardless fuzzy search predicament by having two types of fuzzy search behaviours. The default fuzzy search doesn't allow for transactions with different import IDs from being matched. The old fuzzy logic remains to handle goCardless's quirk. ![](https://media0.giphy.com/media/dB1CUdNMPn4aVaISWe/giphy.gif?cid=5a38a5a2zay9bt6ut4y5hozliww4l4732c3wf9jf0cz7veor&ep=v1_gifs_search&rid=giphy.gif&ct=g) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:58:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4626
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?