[PR #5239] [MERGED] correctly ignore hidden categories when using "Set Average Budget" #5837

New Issue

GiteaMirror · 2026-02-28T21:19:33-06:00

GiteaMirror commented

2026-02-28 21:19:33 -06:00

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5239
Author: @lougeorge
Created: 6/26/2025
Status: ✅ Merged
Merged: 7/3/2025
Merged by: @youngcw

Base: master ← Head: fix_hidden_categories

📝 Commits (9)

b193923 fixed setAverage functions to ignore hidden categories
4bf2fa4 Add logic to ignore hidden categories in budget actions
3293a4b Modify SQL statements in setAverage functions to also exclude categoryGroups and change DbViewCategory type definition to include hidden flag of the group a category belongs to
09bd874 [autofix.ci] apply automated fixes
7eb757d Revert setZero functionality to set all budget categories and category groups to zero, including hidden ones
e879950 Merge branch 'master' into fix_hidden_categories
527c6d4 Add new type DbViewCategoryWithGroupHidden which includes a flag for whether the group a category belongs to is hidden or not, and have setAvg functions use that type instead
ba6fe3f Merge branch 'fix_hidden_categories' of https://github.com/lougeorge/actualbudget into fix_hidden_categories
4c04aa5 Merge branch 'master' into fix_hidden_categories

📊 Changes

3 files changed (+38 additions, -6 deletions)

View changed files

📝 packages/loot-core/src/server/budget/actions.ts (+21 -6)
📝 packages/loot-core/src/server/db/types/index.ts (+11 -0)
➕ upcoming-release-notes/5239.md (+6 -0)

📄 Description

Fixes #5128

Fix the functions to set budget targets based on past averages to correctly ignore hidden categories. Further work is required to handle hidden category groups, including potentially creating new views or migrations to expose relevant information to the target setting functions as the view these functions are pulling from has no knowledge of whether a category is in a hidden category group or not, and currently hiding a category group does not set the hidden flag of each category contained within.

Release Notes

category: Bugfix
authors: lougeorge
PR number: 5239
Summary: This PR adds logic to exclude hidden categories from functions to set budget targets based on past data

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5239 **Author:** [@lougeorge](https://github.com/lougeorge) **Created:** 6/26/2025 **Status:** ✅ Merged **Merged:** 7/3/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix_hidden_categories` --- ### 📝 Commits (9) - [`b193923`](https://github.com/actualbudget/actual/commit/b1939232a448cd4977772488561fd425b93d5512) fixed setAverage functions to ignore hidden categories - [`4bf2fa4`](https://github.com/actualbudget/actual/commit/4bf2fa4a8d9f2c62c0254b751bd239b23792c75f) Add logic to ignore hidden categories in budget actions - [`3293a4b`](https://github.com/actualbudget/actual/commit/3293a4b655103ea728cda57e90ef3e2d29ef4291) Modify SQL statements in setAverage functions to also exclude categoryGroups and change DbViewCategory type definition to include hidden flag of the group a category belongs to - [`09bd874`](https://github.com/actualbudget/actual/commit/09bd874dd6a6381fce148d2410087c1d9da822e9) [autofix.ci] apply automated fixes - [`7eb757d`](https://github.com/actualbudget/actual/commit/7eb757d51f41e582f11b0d0df2e9c3a7a8ad8f06) Revert setZero functionality to set all budget categories and category groups to zero, including hidden ones - [`e879950`](https://github.com/actualbudget/actual/commit/e8799507764e58ec8c2a93f82011daec887e5cc5) Merge branch 'master' into fix_hidden_categories - [`527c6d4`](https://github.com/actualbudget/actual/commit/527c6d44a5913c58006fff984b727b6f7f551a67) Add new type DbViewCategoryWithGroupHidden which includes a flag for whether the group a category belongs to is hidden or not, and have setAvg functions use that type instead - [`ba6fe3f`](https://github.com/actualbudget/actual/commit/ba6fe3f342b9f09222d3eb05913bff15666b7b9c) Merge branch 'fix_hidden_categories' of https://github.com/lougeorge/actualbudget into fix_hidden_categories - [`4c04aa5`](https://github.com/actualbudget/actual/commit/4c04aa58d1ab405ea370ca809858ee91af77ba87) Merge branch 'master' into fix_hidden_categories ### 📊 Changes **3 files changed** (+38 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/actions.ts` (+21 -6) 📝 `packages/loot-core/src/server/db/types/index.ts` (+11 -0) ➕ `upcoming-release-notes/5239.md` (+6 -0) </details> ### 📄 Description Fixes #5128 Fix the functions to set budget targets based on past averages to correctly ignore hidden categories. Further work is required to handle hidden category groups, including potentially creating new views or migrations to expose relevant information to the target setting functions as the view these functions are pulling from has no knowledge of whether a category is in a hidden category group or not, and currently hiding a category group does not set the hidden flag of each category contained within. ### Release Notes ### category: Bugfix authors: lougeorge PR number: 5239 Summary: This PR adds logic to exclude hidden categories from functions to set budget targets based on past data --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-02-28 21:19:33 -06:00

GiteaMirror closed this issue