github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5267] [CLOSED] [WIP] fix: filtering by Category/Contains in /accounts #5850

New Issue
Closed
opened 2026-02-28 21:19:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:19:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5267
Author: @mushrafmim
Created: 7/2/2025
Status: ❌ Closed

Base: master ← Head: fix-filtering-accounts

📝 Commits (3)

  • c8ff235 fix: filtering by Category/Contains in /accounts
  • 3d8885e Merge branch 'master' into fix-filtering-accounts
  • a84385f Merge branch 'master' into fix-filtering-accounts

📊 Changes

2 files changed (+9 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/util/GenericInput.jsx (+3 -0)
➕ upcoming-release-notes/5267.md (+6 -0)

📄 Description

This PR fixes #5261.

Cause of Issue: onChange function is passed as props to the Input in GenericInput component only to the functions onUpdate and onEnter where onUpdate only updates the current value when the onBlur event occurs and onEnter only updates the value on onKeyUp event.

Even though the behavior of onEnter is expected to happen, it doesn't because the UI is re rendered when onKeyUp is triggered in the packages/component-library/src/Input.tsx

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5267 **Author:** [@mushrafmim](https://github.com/mushrafmim) **Created:** 7/2/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-filtering-accounts` --- ### 📝 Commits (3) - [`c8ff235`](https://github.com/actualbudget/actual/commit/c8ff235074fe09d95284160a644fb7d534820eae) fix: filtering by `Category/Contains` in `/accounts` - [`3d8885e`](https://github.com/actualbudget/actual/commit/3d8885e77559d83bc62f6cccdf2fbaaa5ed580da) Merge branch 'master' into fix-filtering-accounts - [`a84385f`](https://github.com/actualbudget/actual/commit/a84385ffdf48a324731bd566740ea519bcea517f) Merge branch 'master' into fix-filtering-accounts ### 📊 Changes **2 files changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/util/GenericInput.jsx` (+3 -0) ➕ `upcoming-release-notes/5267.md` (+6 -0) </details> ### 📄 Description This PR fixes #5261. Cause of Issue: `onChange` function is passed as props to the `Input` in `GenericInput` component only to the functions `onUpdate` and `onEnter` where `onUpdate` only updates the current value when the `onBlur` event occurs and `onEnter` only updates the value on `onKeyUp` event. Even though the behavior of `onEnter` is expected to happen, it doesn't because the UI is re rendered when `onKeyUp` is triggered in the `packages/component-library/src/Input.tsx` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:19:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5850
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?