github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3027] [MERGED] :electron: Convert window-state.js ➡️ window-state.ts #4645

New Issue
Closed
opened 2026-02-28 20:59:01 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:59:01 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3027
Author: @MikesGlitch
Created: 7/10/2024
Status: ✅ Merged
Merged: 7/13/2024
Merged by: @MatissJanis

Base: master ← Head: ts/window-state-electron

📝 Commits (7)

  • fb166df moving electron window save state file to ts
  • ac85dd4 await the load
  • 36a507c explicit assign
  • 62a2ebd type
  • 5389efd release notes
  • bc71ff6 fix state bounds save when moving a maximized window
  • 62b569d Merge branch 'master' into ts/window-state-electron

📊 Changes

4 files changed (+45 additions, -25 deletions)

View changed files

📝 packages/desktop-electron/index.ts (+2 -1)
📝 packages/desktop-electron/modules.d.ts (+1 -0)
📝 packages/desktop-electron/window-state.ts (+36 -24)
➕ upcoming-release-notes/3027.md (+6 -0)

📄 Description

https://github.com/actualbudget/actual/issues/1483

  • Updated Electron window-state file to use typescript
  • Fixed a bug where the screen x/y values weren't being saved when the window was maximised
    • Caused the app to launch to the wrong display because it didn't know what display it belonged to

Tested on:

  • Windows
  • LInux

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3027 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 7/10/2024 **Status:** ✅ Merged **Merged:** 7/13/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `ts/window-state-electron` --- ### 📝 Commits (7) - [`fb166df`](https://github.com/actualbudget/actual/commit/fb166df946bbab42ae3d32f6989b996bb278ddd0) moving electron window save state file to ts - [`ac85dd4`](https://github.com/actualbudget/actual/commit/ac85dd40798e7e8d473828faac912dc8f10ba7b6) await the load - [`36a507c`](https://github.com/actualbudget/actual/commit/36a507ca7e2e10c33c744bdc7af2a3ca29e7cfb1) explicit assign - [`62a2ebd`](https://github.com/actualbudget/actual/commit/62a2ebdce56c8da5f06e9fc1f5d1538fdc59710e) type - [`5389efd`](https://github.com/actualbudget/actual/commit/5389efde6eab10e51d642ccf58aa323c69502b72) release notes - [`bc71ff6`](https://github.com/actualbudget/actual/commit/bc71ff6c908f09c3b7baee0ab96a0d3ba60dde40) fix state bounds save when moving a maximized window - [`62b569d`](https://github.com/actualbudget/actual/commit/62b569d61b43bff0a10af775484941e154648bab) Merge branch 'master' into ts/window-state-electron ### 📊 Changes **4 files changed** (+45 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-electron/index.ts` (+2 -1) 📝 `packages/desktop-electron/modules.d.ts` (+1 -0) 📝 `packages/desktop-electron/window-state.ts` (+36 -24) ➕ `upcoming-release-notes/3027.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> https://github.com/actualbudget/actual/issues/1483 - Updated Electron window-state file to use typescript - Fixed a bug where the screen x/y values weren't being saved when the window was maximised - Caused the app to launch to the wrong display because it didn't know what display it belonged to Tested on: - Windows - LInux --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:59:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4645
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?