[PR #3432] [MERGED] (dashboards) ability to save filters & timeframes on spending widgets #4851

Closed
opened 2026-02-28 21:02:15 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3432
Author: @MatissJanis
Created: 9/13/2024
Status: Merged
Merged: 9/24/2024
Merged by: @MatissJanis

Base: masterHead: matiss/dashboard-spending


📝 Commits (10+)

  • e335aad (dashboards) ability to save filters & timeframes on spending widgets
  • d4c3a2d Patches
  • 81b0135 Remove the label
  • 5e00187 Feedback: more optional chaining
  • 4f4efec Remove 'current month' in favour of live/static
  • 2b900f6 Feedback: date validation & style improvements
  • 78e21db Merge branch 'master' into matiss/dashboard-spending
  • 2771afc Revert the validateStart/end usage + rename start/end to compare/compareTo
  • 91fa431 Merge branch 'master' into matiss/dashboard-spending
  • 20622f1 Remove timeframe updates from live/paused button

📊 Changes

14 files changed (+412 additions, -320 deletions)

View changed files

📝 packages/desktop-client/src/components/common/Select.tsx (+3 -0)
📝 packages/desktop-client/src/components/reports/DateRange.tsx (+8 -1)
📝 packages/desktop-client/src/components/reports/Header.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/Overview.tsx (+1 -0)
📝 packages/desktop-client/src/components/reports/ReportRouter.tsx (+1 -0)
📝 packages/desktop-client/src/components/reports/graphs/SpendingGraph.tsx (+29 -23)
📝 packages/desktop-client/src/components/reports/reportRanges.ts (+42 -2)
📝 packages/desktop-client/src/components/reports/reports/Spending.tsx (+285 -238)
📝 packages/desktop-client/src/components/reports/reports/SpendingCard.tsx (+27 -43)
📝 packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts (+0 -3)
📝 packages/loot-core/src/types/models/dashboard.d.ts (+9 -1)
📝 packages/loot-core/src/types/models/reports.d.ts (+0 -2)
📝 packages/loot-core/src/types/prefs.d.ts (+0 -6)
upcoming-release-notes/3432.md (+6 -0)

📄 Description

Allowing to save spending widgets in dashboards. This required a bit of refactoring to move from LocalPrefs to widgets.

This is a breaking change sadly (i.e. the saved local-pref values will be lost). But IMO that's fine since this is an experimental feature that is expected to have breaking changes.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3432 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/13/2024 **Status:** ✅ Merged **Merged:** 9/24/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/dashboard-spending` --- ### 📝 Commits (10+) - [`e335aad`](https://github.com/actualbudget/actual/commit/e335aad4e567a0413eaa160f2e1e1324f65c5c0d) :sparkles: (dashboards) ability to save filters & timeframes on spending widgets - [`d4c3a2d`](https://github.com/actualbudget/actual/commit/d4c3a2d159d421d32dcbf39f33bebbc0146c5b4f) Patches - [`81b0135`](https://github.com/actualbudget/actual/commit/81b01358533c263fc53d2613d02c5a5fec26724c) Remove the label - [`5e00187`](https://github.com/actualbudget/actual/commit/5e001872b99a24dcb11805d18a15dd7f4c749fdc) Feedback: more optional chaining - [`4f4efec`](https://github.com/actualbudget/actual/commit/4f4efeccfce0029d12180ea90db78916a3219dcd) Remove 'current month' in favour of live/static - [`2b900f6`](https://github.com/actualbudget/actual/commit/2b900f6e0a21da1097a6a4f9e7e296fb2b8bcf59) Feedback: date validation & style improvements - [`78e21db`](https://github.com/actualbudget/actual/commit/78e21db65eef91c1248438690e0c18d194ceaec0) Merge branch 'master' into matiss/dashboard-spending - [`2771afc`](https://github.com/actualbudget/actual/commit/2771afcd97974ddae8c3c74d650261a9963ac657) Revert the validateStart/end usage + rename start/end to compare/compareTo - [`91fa431`](https://github.com/actualbudget/actual/commit/91fa43180428aa59393632e9942c7e843232a28f) Merge branch 'master' into matiss/dashboard-spending - [`20622f1`](https://github.com/actualbudget/actual/commit/20622f10c585088629ec0cd1cf34ef87d1cf7d2d) Remove timeframe updates from live/paused button ### 📊 Changes **14 files changed** (+412 additions, -320 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/common/Select.tsx` (+3 -0) 📝 `packages/desktop-client/src/components/reports/DateRange.tsx` (+8 -1) 📝 `packages/desktop-client/src/components/reports/Header.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/Overview.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/reports/ReportRouter.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/reports/graphs/SpendingGraph.tsx` (+29 -23) 📝 `packages/desktop-client/src/components/reports/reportRanges.ts` (+42 -2) 📝 `packages/desktop-client/src/components/reports/reports/Spending.tsx` (+285 -238) 📝 `packages/desktop-client/src/components/reports/reports/SpendingCard.tsx` (+27 -43) 📝 `packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts` (+0 -3) 📝 `packages/loot-core/src/types/models/dashboard.d.ts` (+9 -1) 📝 `packages/loot-core/src/types/models/reports.d.ts` (+0 -2) 📝 `packages/loot-core/src/types/prefs.d.ts` (+0 -6) ➕ `upcoming-release-notes/3432.md` (+6 -0) </details> ### 📄 Description Allowing to save spending widgets in dashboards. This required a bit of refactoring to move from `LocalPrefs` to widgets. This is a breaking change sadly (i.e. the saved local-pref values will be lost). But IMO that's fine since this is an **experimental** feature that is expected to have breaking changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:02:15 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4851