github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3515] [MERGED] fix: pushModal not dispatched in GoCardless linking #4902

New Issue
Closed
opened 2026-02-28 21:02:58 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:02:58 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3515
Author: @EtaoinWu
Created: 9/27/2024
Status: ✅ Merged
Merged: 9/28/2024
Merged by: @matt-fidd

Base: master ← Head: gocardless-link-dispatch-fix

📝 Commits (4)

  • ab78b1c fix: pushModal not dispatched in GoCardless linking
  • 4cffda3 chore: add PR release note
  • bbe42c0 Merge branch 'master' into gocardless-link-dispatch-fix
  • d781eea Merge branch 'master' into gocardless-link-dispatch-fix

📊 Changes

2 files changed (+14 additions, -6 deletions)

View changed files

📝 packages/desktop-client/src/gocardless.ts (+8 -6)
➕ upcoming-release-notes/3515.md (+6 -0)

📄 Description

Background

Multiple reports in Discord shows that the current master branch has issues with gocardless linking: mine, valerio's, aaarzan's, ROuGGy's among others. The symptom seems to be that, after a successful callback from GoCardless, Actual refuses to pop up the next step in the linking process, which is to select accounts to sync from. Server logs and browser console logs shows no anomaly.

Contribution

I tracked down the issue, and found that in gocardless.ts, the callback onSuccess only generates a pushModal action without sending it to dispatch:

_authorize(dispatch, upgradingAccountId, {
  onSuccess: async data => {
    pushModal('select-linked-accounts', {
      accounts: data.accounts,
      requisitionId: data.id,
      upgradingAccountId,
      syncSource: 'goCardless',
    });
  },
});

Therefore a SelectLinkedAccountsModal was never generated.

This was introduced in 420aad0 (#3413) two weeks ago. Latest release (v24.9.0) was not affected.

Next steps & help needed

I am unfortunately not a React dev, and lacks the environment or tool to build and test it. I hope that other contributors in this community can help verify my fix and resolve this issue.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3515 **Author:** [@EtaoinWu](https://github.com/EtaoinWu) **Created:** 9/27/2024 **Status:** ✅ Merged **Merged:** 9/28/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `gocardless-link-dispatch-fix` --- ### 📝 Commits (4) - [`ab78b1c`](https://github.com/actualbudget/actual/commit/ab78b1c4a208e47bd41daf5f11a2b5b90cc3f51c) fix: pushModal not dispatched in GoCardless linking - [`4cffda3`](https://github.com/actualbudget/actual/commit/4cffda3d2ea25568e29d4026826179517860e227) chore: add PR release note - [`bbe42c0`](https://github.com/actualbudget/actual/commit/bbe42c0b9987116a119619ce92f3144eab6a7c51) Merge branch 'master' into gocardless-link-dispatch-fix - [`d781eea`](https://github.com/actualbudget/actual/commit/d781eead9b42c6ccefc96d3e3b7a0b87de2a5e5f) Merge branch 'master' into gocardless-link-dispatch-fix ### 📊 Changes **2 files changed** (+14 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/gocardless.ts` (+8 -6) ➕ `upcoming-release-notes/3515.md` (+6 -0) </details> ### 📄 Description ### Background Multiple reports in Discord shows that the current master branch has issues with gocardless linking: [mine](https://discord.com/channels/937901803608096828/1288271251810422857), [valerio's](https://discord.com/channels/937901803608096828/1288418544739942452), [aaarzan's](https://discord.com/channels/937901803608096828/1285223872022712353), [ROuGGy's](https://discord.com/channels/937901803608096828/1286541192191938570) among others. The symptom seems to be that, after a successful callback from GoCardless, Actual refuses to pop up the next step in the linking process, which is to select accounts to sync from. Server logs and browser console logs shows no anomaly. ### Contribution I tracked down the issue, and found that in [gocardless.ts](https://github.com/actualbudget/actual/blob/686ce5b504e40646a0d7b92114ef4f07f1f8992a/packages/desktop-client/src/gocardless.ts#L47-L54), the callback `onSuccess` only generates a `pushModal` action without sending it to dispatch: ```typescript _authorize(dispatch, upgradingAccountId, { onSuccess: async data => { pushModal('select-linked-accounts', { accounts: data.accounts, requisitionId: data.id, upgradingAccountId, syncSource: 'goCardless', }); }, }); ``` Therefore a `SelectLinkedAccountsModal` was never generated. This was introduced in 420aad0 (#3413) two weeks ago. Latest release (v24.9.0) was not affected. ### Next steps & help needed I am unfortunately not a React dev, and lacks the environment or tool to build and test it. I hope that other contributors in this community can help verify my fix and resolve this issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:02:58 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4902
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?