github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4777] [CLOSED] 🔧 [Enhancement]: Added typings to the API #5580

New Issue
Closed
opened 2026-02-28 21:14:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:14:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4777
Author: @alecbakholdin
Created: 4/8/2025
Status: ❌ Closed

Base: master ← Head: schedule-actions-api

📝 Commits (10+)

  • 395e1ea added missing types to api-handlers.d.ts
  • 1f8b342 fixed export typing
  • 01dcbce final typecheck issues in api.ts
  • 1025508 added schedule entity
  • 5c96d21 finished adding schedule operations to API
  • 4035854 release notes
  • 8ec4564 separated oneOf, notOneOf, and inbetween into their own union types to make typescript lsp behave better
  • 19b5498 fixed typecheck and linting problems
  • 4e954d0 forgot to add the actual external facing API functions
  • 99013b9 added more types to external facing API functions

📊 Changes

17 files changed (+318 additions, -170 deletions)

View changed files

📝 packages/api/methods.test.ts (+5 -2)
📝 packages/api/methods.ts (+104 -38)
📝 packages/desktop-client/src/components/rules/ScheduleValue.tsx (+6 -3)
📝 packages/desktop-client/src/components/schedules/DiscoverSchedules.tsx (+1 -1)
📝 packages/desktop-client/src/components/schedules/ScheduleDetails.tsx (+4 -3)
📝 packages/loot-core/src/client/data-hooks/transactions.ts (+1 -1)
📝 packages/loot-core/src/server/api-models.ts (+49 -1)
📝 packages/loot-core/src/server/api.ts (+9 -10)
📝 packages/loot-core/src/server/importers/ynab4.ts (+0 -2)
📝 packages/loot-core/src/server/schedules/app.test.ts (+7 -3)
📝 packages/loot-core/src/server/schedules/app.ts (+11 -8)
📝 packages/loot-core/src/server/transactions/app.ts (+5 -10)
📝 packages/loot-core/src/server/transactions/export/export-to-csv.ts (+15 -5)
📝 packages/loot-core/src/shared/schedules.ts (+22 -14)
📝 packages/loot-core/src/types/api-handlers.d.ts (+58 -32)
📝 packages/loot-core/src/types/models/rule.d.ts (+15 -37)
➕ upcoming-release-notes/4777.md (+6 -0)

📄 Description

Added typings to the API

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4777 **Author:** [@alecbakholdin](https://github.com/alecbakholdin) **Created:** 4/8/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `schedule-actions-api` --- ### 📝 Commits (10+) - [`395e1ea`](https://github.com/actualbudget/actual/commit/395e1ea321fbd5438455b7f3036fe87bdb4642ca) added missing types to api-handlers.d.ts - [`1f8b342`](https://github.com/actualbudget/actual/commit/1f8b3424951a5af878b27bbc89249167f8aa3b07) fixed export typing - [`01dcbce`](https://github.com/actualbudget/actual/commit/01dcbce3e5038f126a43032331f20d85e605bcac) final typecheck issues in api.ts - [`1025508`](https://github.com/actualbudget/actual/commit/1025508cd63a863ef06b5991bd7aa95b8b9714d7) added schedule entity - [`5c96d21`](https://github.com/actualbudget/actual/commit/5c96d219acafb20ad8a033ddf569c618ede2efe8) finished adding schedule operations to API - [`4035854`](https://github.com/actualbudget/actual/commit/4035854d90597e1fae353dd09a1d5cf949feefa8) release notes - [`8ec4564`](https://github.com/actualbudget/actual/commit/8ec4564e766670e13728a1ae7bf349f3b4a9f550) separated oneOf, notOneOf, and inbetween into their own union types to make typescript lsp behave better - [`19b5498`](https://github.com/actualbudget/actual/commit/19b5498c446c6974353160eab696962aa6addad3) fixed typecheck and linting problems - [`4e954d0`](https://github.com/actualbudget/actual/commit/4e954d006e95933fca3f5dfaa8c865a8e3022082) forgot to add the actual external facing API functions - [`99013b9`](https://github.com/actualbudget/actual/commit/99013b9c2067c14bde7d6cff0cb13db8fbf3d55e) added more types to external facing API functions ### 📊 Changes **17 files changed** (+318 additions, -170 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/methods.test.ts` (+5 -2) 📝 `packages/api/methods.ts` (+104 -38) 📝 `packages/desktop-client/src/components/rules/ScheduleValue.tsx` (+6 -3) 📝 `packages/desktop-client/src/components/schedules/DiscoverSchedules.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/schedules/ScheduleDetails.tsx` (+4 -3) 📝 `packages/loot-core/src/client/data-hooks/transactions.ts` (+1 -1) 📝 `packages/loot-core/src/server/api-models.ts` (+49 -1) 📝 `packages/loot-core/src/server/api.ts` (+9 -10) 📝 `packages/loot-core/src/server/importers/ynab4.ts` (+0 -2) 📝 `packages/loot-core/src/server/schedules/app.test.ts` (+7 -3) 📝 `packages/loot-core/src/server/schedules/app.ts` (+11 -8) 📝 `packages/loot-core/src/server/transactions/app.ts` (+5 -10) 📝 `packages/loot-core/src/server/transactions/export/export-to-csv.ts` (+15 -5) 📝 `packages/loot-core/src/shared/schedules.ts` (+22 -14) 📝 `packages/loot-core/src/types/api-handlers.d.ts` (+58 -32) 📝 `packages/loot-core/src/types/models/rule.d.ts` (+15 -37) ➕ `upcoming-release-notes/4777.md` (+6 -0) </details> ### 📄 Description Added typings to the API --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:14:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5580
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?