github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5111] [MERGED] fix: add missing dependency array to useEffect in SaveReportChoose.tsx (#5044) #5762

New Issue
Closed
opened 2026-02-28 21:18:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:18:08 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5111
Author: @MatissJanis
Created: 6/5/2025
Status: ✅ Merged
Merged: 6/6/2025
Merged by: @MatissJanis

Base: master ← Head: fix/useeffect-deps-savereportchoose

📝 Commits (4)

  • 4d090ba fix: add missing dependency array to useEffect in SaveReportChoose.tsx (#5044)
  • 312a12d refactor: use useRef instead of createRef for inputRef in SaveReportChoose.tsx (fixes linter warning)
  • 9ee0ce2 chore: add release note for fix/useeffect-deps-savereportchoose (PR #5112)
  • d0c59d4 Rename 5112.md to 5111.md

📊 Changes

2 files changed (+9 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/SaveReportChoose.tsx (+3 -3)
➕ upcoming-release-notes/5111.md (+6 -0)

📄 Description

This PR fixes a small tech debt issue described in #5044 by adding a missing dependency array to the useEffect hook in SaveReportChoose.tsx. This ensures the effect only runs once on mount, preventing unnecessary re-renders and potential performance issues.

  • Added an empty dependency array to the useEffect hook that focuses the input on mount.

Closes #5044.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5111 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 6/5/2025 **Status:** ✅ Merged **Merged:** 6/6/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `fix/useeffect-deps-savereportchoose` --- ### 📝 Commits (4) - [`4d090ba`](https://github.com/actualbudget/actual/commit/4d090bac2c571baf9efcedc0b2b00b1d9e892804) fix: add missing dependency array to useEffect in SaveReportChoose.tsx (#5044) - [`312a12d`](https://github.com/actualbudget/actual/commit/312a12d4f94d789a081f150f91c233faf18c03a4) refactor: use useRef instead of createRef for inputRef in SaveReportChoose.tsx (fixes linter warning) - [`9ee0ce2`](https://github.com/actualbudget/actual/commit/9ee0ce2b89ae0a2ff31efb562a3425620dee04e2) chore: add release note for fix/useeffect-deps-savereportchoose (PR #5112) - [`d0c59d4`](https://github.com/actualbudget/actual/commit/d0c59d44a039ab90519a4c209d4fdf97d1839661) Rename 5112.md to 5111.md ### 📊 Changes **2 files changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/SaveReportChoose.tsx` (+3 -3) ➕ `upcoming-release-notes/5111.md` (+6 -0) </details> ### 📄 Description This PR fixes a small tech debt issue described in #5044 by adding a missing dependency array to the useEffect hook in SaveReportChoose.tsx. This ensures the effect only runs once on mount, preventing unnecessary re-renders and potential performance issues. - Added an empty dependency array to the useEffect hook that focuses the input on mount. Closes #5044. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:18:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5762
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?