github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3377] [MERGED] Privacy mode: instead of blurring, use an illegible font (#3376) #4820

New Issue
Closed
opened 2026-02-28 21:01:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:01:46 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3377
Author: @olets
Created: 9/6/2024
Status: ✅ Merged
Merged: 9/27/2024
Merged by: @joel-jeremy

Base: master ← Head: 3376-decrease-privacy-mode-legibility

📝 Commits (6)

  • 08314b9 Privacy mode: instead of blurring, use an illegible font (#3376)
  • 2e0cee8 Privacy mode: no layout shift when switching mode
  • 5ba91ab fix(Spending): update for latest PrivacyFilter
  • 6f0971a refactor(PrivacyFilter): use CSS :hover
  • a1d0dce chore(PrivacyFilter): no privacy mode BudgetCell height regression...
  • 134180d chore(GroupMonth): drop no-impact PrivacyFilter styles

📊 Changes

14 files changed (+85 additions, -68 deletions)

View changed files

📝 packages/desktop-client/package.json (+1 -0)
📝 packages/desktop-client/src/components/PrivacyFilter.tsx (+54 -32)
📝 packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx (+0 -10)
📝 packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudgetAmount.tsx (+5 -1)
📝 packages/desktop-client/src/components/budget/tracking/TrackingBudgetComponents.tsx (+0 -5)
📝 packages/desktop-client/src/components/budget/tracking/budgetsummary/Saved.tsx (+1 -3)
📝 packages/desktop-client/src/components/reports/ReportSummary.tsx (+2 -4)
📝 packages/desktop-client/src/components/reports/reports/CustomReport.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/reports/NetWorth.jsx (+1 -3)
📝 packages/desktop-client/src/components/reports/reports/Spending.tsx (+4 -4)
📝 packages/desktop-client/src/components/table.tsx (+0 -5)
📝 packages/desktop-client/src/fonts.scss (+2 -0)
➕ upcoming-release-notes/3377.md (+6 -0)
📝 yarn.lock (+8 -0)

📄 Description

Instead of blurring, uses the font Redacted Script https://github.com/christiannaths/redacted-font#redacted-script.

The good: much more private

Edit: the following limitation no longer applies (see https://github.com/actualbudget/actual/pull/3377#pullrequestreview-2287013488)

The touchy: this font's sizing isn't identical to the non-private font. In some cases there's a minor layout shift on hover, and/or when toggling between modes.

The implementation support per-element line-height customization, and could easily be extended to support per-element letter-spacing. I haven't gone deep down that rabbit hole, only customizing line height on the two large font size numbers, where the difference is more significant.

screenshotimage
screencap, updated

https://github.com/user-attachments/assets/0be1ffdb-4371-4994-b5f4-76374b39b3d3

OLD outdated screencapture, for posterity

https://github.com/user-attachments/assets/7752efe8-0f6b-4f65-9805-f1db82c56fdd

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3377 **Author:** [@olets](https://github.com/olets) **Created:** 9/6/2024 **Status:** ✅ Merged **Merged:** 9/27/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `3376-decrease-privacy-mode-legibility` --- ### 📝 Commits (6) - [`08314b9`](https://github.com/actualbudget/actual/commit/08314b9fa9ea1a682f06d51266ad4eedb673e697) Privacy mode: instead of blurring, use an illegible font (#3376) - [`2e0cee8`](https://github.com/actualbudget/actual/commit/2e0cee868d62f25664ecb78c5bda90d55724c143) Privacy mode: no layout shift when switching mode - [`5ba91ab`](https://github.com/actualbudget/actual/commit/5ba91abee32a286643c048256a517cd12195a96f) fix(Spending): update for latest PrivacyFilter - [`6f0971a`](https://github.com/actualbudget/actual/commit/6f0971a6d6a2b8f6fb780bdef66c808f0420eae4) refactor(PrivacyFilter): use CSS :hover - [`a1d0dce`](https://github.com/actualbudget/actual/commit/a1d0dcea74cf59044ce394ebb396bc025771156c) chore(PrivacyFilter): no privacy mode BudgetCell height regression... - [`134180d`](https://github.com/actualbudget/actual/commit/134180da29385f843e77824814bf1351351dd7f9) chore(GroupMonth): drop no-impact PrivacyFilter styles ### 📊 Changes **14 files changed** (+85 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+1 -0) 📝 `packages/desktop-client/src/components/PrivacyFilter.tsx` (+54 -32) 📝 `packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx` (+0 -10) 📝 `packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudgetAmount.tsx` (+5 -1) 📝 `packages/desktop-client/src/components/budget/tracking/TrackingBudgetComponents.tsx` (+0 -5) 📝 `packages/desktop-client/src/components/budget/tracking/budgetsummary/Saved.tsx` (+1 -3) 📝 `packages/desktop-client/src/components/reports/ReportSummary.tsx` (+2 -4) 📝 `packages/desktop-client/src/components/reports/reports/CustomReport.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/reports/NetWorth.jsx` (+1 -3) 📝 `packages/desktop-client/src/components/reports/reports/Spending.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/table.tsx` (+0 -5) 📝 `packages/desktop-client/src/fonts.scss` (+2 -0) ➕ `upcoming-release-notes/3377.md` (+6 -0) 📝 `yarn.lock` (+8 -0) </details> ### 📄 Description - For #3376 Instead of blurring, uses the font Redacted Script https://github.com/christiannaths/redacted-font#redacted-script. The good: much more private Edit: the following limitation no longer applies (see https://github.com/actualbudget/actual/pull/3377#pullrequestreview-2287013488) ~The touchy: this font's sizing isn't identical to the non-private font. In some cases there's a minor layout shift on hover, and/or when toggling between modes.~ ~The implementation support per-element `line-height` customization, and could easily be extended to support per-element `letter-spacing`. I haven't gone deep down that rabbit hole, only customizing line height on the two large font size numbers, where the difference is more significant.~ <details><summary>screenshot</summary><img width="1145" alt="image" src="https://github.com/user-attachments/assets/417e6046-c1dc-4a0c-8052-1be366b5bc84"> </details> <details><summary> screencap, updated</summary> https://github.com/user-attachments/assets/0be1ffdb-4371-4994-b5f4-76374b39b3d3 </details> <details><summary>OLD outdated screencapture, for posterity</summary> https://github.com/user-attachments/assets/7752efe8-0f6b-4f65-9805-f1db82c56fdd </details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:01:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4820
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?