github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4629] [MERGED] 🐛 fixed current month upcoming calculation #5496

New Issue
Closed
opened 2026-02-28 21:13:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:13:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4629
Author: @alecbakholdin
Created: 3/15/2025
Status: ✅ Merged
Merged: 3/19/2025
Merged by: @youngcw

Base: master ← Head: current-month-upcoming-schedule-bug

📝 Commits (6)

  • 1110fe1 fixed current month upcoming calculation
  • 600dce1 added release notes
  • 8bb1d29 updated test to validate the new behavior of getUpcoming
  • 55f25b0 modified one month and added more tests for leap years and months with different dates
  • 4947d1e Merge branch 'master' into current-month-upcoming-schedule-bug
  • e096dfa Fixed odd error

📊 Changes

4 files changed (+39 additions, -23 deletions)

View changed files

📝 packages/loot-core/src/client/data-hooks/transactions.ts (+3 -3)
📝 packages/loot-core/src/shared/schedules.test.ts (+22 -12)
📝 packages/loot-core/src/shared/schedules.ts (+8 -8)
➕ upcoming-release-notes/4629.md (+6 -0)

📄 Description

Resolves #4368

  1. Changes currentMonth and oneMonth logic to behave better.
  2. Added tests for the methods to validate leap year

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4629 **Author:** [@alecbakholdin](https://github.com/alecbakholdin) **Created:** 3/15/2025 **Status:** ✅ Merged **Merged:** 3/19/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `current-month-upcoming-schedule-bug` --- ### 📝 Commits (6) - [`1110fe1`](https://github.com/actualbudget/actual/commit/1110fe1a528cd01c4fe536e3dcfdaffb76f7a842) fixed current month upcoming calculation - [`600dce1`](https://github.com/actualbudget/actual/commit/600dce1ba02885a71233d20643e92cec545969ac) added release notes - [`8bb1d29`](https://github.com/actualbudget/actual/commit/8bb1d295dd151c93dd10cb5caad16c7054cc858f) updated test to validate the new behavior of getUpcoming - [`55f25b0`](https://github.com/actualbudget/actual/commit/55f25b0bbc47bf72495ea3fba04ddc8617482b3f) modified one month and added more tests for leap years and months with different dates - [`4947d1e`](https://github.com/actualbudget/actual/commit/4947d1e8967557a58695246c367acc2f2ad0a7f8) Merge branch 'master' into current-month-upcoming-schedule-bug - [`e096dfa`](https://github.com/actualbudget/actual/commit/e096dfa9a57da814c756e65fef9dd26415feda98) Fixed odd error ### 📊 Changes **4 files changed** (+39 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/client/data-hooks/transactions.ts` (+3 -3) 📝 `packages/loot-core/src/shared/schedules.test.ts` (+22 -12) 📝 `packages/loot-core/src/shared/schedules.ts` (+8 -8) ➕ `upcoming-release-notes/4629.md` (+6 -0) </details> ### 📄 Description Resolves #4368 1. Changes currentMonth and oneMonth logic to behave better. 2. Added tests for the methods to validate leap year --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:13:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5496
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?