mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-09 03:32:54 -05:00
[PR #5235] [CLOSED] feat: support _FILE variant for ACTUAL_OPENID_CLIENT_SECRET #5835
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#5835
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/5235
Author: @ghost
Created: 6/25/2025
Status: ❌ Closed
Base:
master← Head:add_secrets_file_support📝 Commits (9)
c3dbee2feat: support _FILE variant for ACTUAL_OPENID_CLIENT_SECRET87359f4Merge branch 'master' into add_secrets_file_support6e33ccfMerge branch 'master' into add_secrets_file_support980361eMerge branch 'master' into add_secrets_file_supportb7c2c91Merge branch 'master' into add_secrets_file_supporta8c01bbMerge branch 'master' into add_secrets_file_support9cb341cMerge branch 'master' into add_secrets_file_support0fe4839noted5d6fd1Merge branch 'master' into add_secrets_file_support📊 Changes
2 files changed (+24 additions, -0 deletions)
View changed files
📝
packages/sync-server/src/load-config.js(+18 -0)➕
upcoming-release-notes/5235.md(+6 -0)📄 Description
Fixes #5233
Adds support for a _FILE variant of ACTUAL_OPENID_CLIENT_SECRET for better Docker secret management. Reads secret value from file if the _FILE env var is set. This will overwrite other settings of the secret through config.json or the ACTUAL_OPENID_CLIENT_SECRET environment variable.
The function was written somewhat generically to allow further expansion, but as no other secrets are exposed through variables only ACTUAL_OPENID_CLIENT_SECRET was given a _FILE overwrite.
To test, simply append this line after the function is invoked.
console.log('[DEBUG] Loaded OIDC secret:', configSchema.get('openId.client_secret'));Output should be the contents of the file.
Release Notes
Type: Enhancements
Username(s): tim_connect
PR Number: #5235
Summary:
This PR adds support for reading the OpenID client secret from a file using the
ACTUAL_OPENID_CLIENT_SECRET_FILEenvironment variable. This enables better handling of secrets in Docker and Kubernetes environments.If both
ACTUAL_OPENID_CLIENT_SECRETandACTUAL_OPENID_CLIENT_SECRET_FILEare set, the_FILEvariant takes precedence.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.