github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3423] [MERGED] ♻️ (synced-prefs) moving the prefs from metadata.json to the db #4844

New Issue
Closed
opened 2026-02-28 21:02:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:02:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3423
Author: @MatissJanis
Created: 9/12/2024
Status: ✅ Merged
Merged: 9/17/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/synced-prefs-6

📝 Commits (8)

  • 59224da ♻️ (synced-prefs) moving the prefs from metadata.json to the db
  • 233dc57 Unit test fix
  • 1180c58 Different test patch
  • c4cfb1e Different test patch
  • 397d599 Feedback: delete metadata.json cleanup from migration
  • 10ef1b1 Merge branch 'master' into matiss/synced-prefs-6
  • 46b373e Feedback: update insertion statement
  • 2bae66f Merge branch 'matiss/synced-prefs-6' of github.com:actualbudget/actual into matiss/synced-prefs-6

📊 Changes

16 files changed (+202 additions, -50 deletions)

View changed files

📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx (+3 -0)
➖ packages/desktop-client/src/hooks/useLocalPrefs.ts (+0 -7)
📝 packages/desktop-client/src/hooks/useSyncedPref.ts (+22 -5)
📝 packages/desktop-client/src/hooks/useSyncedPrefs.ts (+30 -13)
➕ packages/loot-core/migrations/1723665565000_prefs.js (+59 -0)
📝 packages/loot-core/src/client/query-helpers.ts (+12 -4)
📝 packages/loot-core/src/client/query-hooks.tsx (+24 -3)
📝 packages/loot-core/src/server/aql/schema/index.ts (+4 -0)
📝 packages/loot-core/src/server/main.ts (+2 -0)
📝 packages/loot-core/src/server/migrate/migrations.ts (+7 -2)
➕ packages/loot-core/src/server/preferences/app.ts (+21 -0)
➕ packages/loot-core/src/server/preferences/types/handlers.d.ts (+8 -0)
📝 packages/loot-core/src/server/prefs.ts (+0 -13)
📝 packages/loot-core/src/types/handlers.d.ts (+2 -0)
📝 packages/loot-core/src/types/prefs.d.ts (+2 -3)
➕ upcoming-release-notes/3423.md (+6 -0)

📄 Description

Finally! Moving the synced preferences to the local database.

Looking for 2+ approvals.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3423 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/12/2024 **Status:** ✅ Merged **Merged:** 9/17/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/synced-prefs-6` --- ### 📝 Commits (8) - [`59224da`](https://github.com/actualbudget/actual/commit/59224dac0da8f711b596dfcee517b7166f68f1fd) :recycle: (synced-prefs) moving the prefs from metadata.json to the db - [`233dc57`](https://github.com/actualbudget/actual/commit/233dc5750bfd91659f2dc6f4d082750024b5928f) Unit test fix - [`1180c58`](https://github.com/actualbudget/actual/commit/1180c58d3fb95487998015b9ebb3739fe0c32bed) Different test patch - [`c4cfb1e`](https://github.com/actualbudget/actual/commit/c4cfb1e1b2dcf52e08cdf58bc2c882f2340de6eb) Different test patch - [`397d599`](https://github.com/actualbudget/actual/commit/397d5993cbad41526bddb11486aeaf5947333075) Feedback: delete metadata.json cleanup from migration - [`10ef1b1`](https://github.com/actualbudget/actual/commit/10ef1b1afef764550763d8d00afc4bff4eb466e8) Merge branch 'master' into matiss/synced-prefs-6 - [`46b373e`](https://github.com/actualbudget/actual/commit/46b373e6e3c13c358ddd317c88043143eef737e2) Feedback: update insertion statement - [`2bae66f`](https://github.com/actualbudget/actual/commit/2bae66f9b4e33e0cc2351510c8a79e4e154100e8) Merge branch 'matiss/synced-prefs-6' of github.com:actualbudget/actual into matiss/synced-prefs-6 ### 📊 Changes **16 files changed** (+202 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx` (+3 -0) ➖ `packages/desktop-client/src/hooks/useLocalPrefs.ts` (+0 -7) 📝 `packages/desktop-client/src/hooks/useSyncedPref.ts` (+22 -5) 📝 `packages/desktop-client/src/hooks/useSyncedPrefs.ts` (+30 -13) ➕ `packages/loot-core/migrations/1723665565000_prefs.js` (+59 -0) 📝 `packages/loot-core/src/client/query-helpers.ts` (+12 -4) 📝 `packages/loot-core/src/client/query-hooks.tsx` (+24 -3) 📝 `packages/loot-core/src/server/aql/schema/index.ts` (+4 -0) 📝 `packages/loot-core/src/server/main.ts` (+2 -0) 📝 `packages/loot-core/src/server/migrate/migrations.ts` (+7 -2) ➕ `packages/loot-core/src/server/preferences/app.ts` (+21 -0) ➕ `packages/loot-core/src/server/preferences/types/handlers.d.ts` (+8 -0) 📝 `packages/loot-core/src/server/prefs.ts` (+0 -13) 📝 `packages/loot-core/src/types/handlers.d.ts` (+2 -0) 📝 `packages/loot-core/src/types/prefs.d.ts` (+2 -3) ➕ `upcoming-release-notes/3423.md` (+6 -0) </details> ### 📄 Description Finally! Moving the synced preferences to the local database. Looking for 2+ approvals. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:02:07 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4844
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?