github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5377] [MERGED] Only use fund from local group during cleanup. #5903

New Issue
Closed
opened 2026-02-28 21:20:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:20:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5377
Author: @kleinweby
Created: 7/23/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @youngcw

Base: master ← Head: fix-cleanup-local

📝 Commits (1)

  • bf1af67 Only use fund from local group during cleanup.

📊 Changes

2 files changed (+20 additions, -8 deletions)

View changed files

📝 packages/loot-core/src/server/budget/cleanup-template.ts (+14 -8)
➕ upcoming-release-notes/5377.md (+6 -0)

📄 Description

When using local group cleanup, currently all funds available in To Budget are distributed into the sinks. This behaviour seems somwhat odd and also results in all later groups or the "global" cleanup run to possibly have no funds as they've been distributed before.

This patch now changes the group usage of cleanup, to only distribute funds made available by the group itself. If one also wants to sink money from To Budget into the category, a simple addtional #cleanup sink, will achieve this.

Fixes #5374

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5377 **Author:** [@kleinweby](https://github.com/kleinweby) **Created:** 7/23/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix-cleanup-local` --- ### 📝 Commits (1) - [`bf1af67`](https://github.com/actualbudget/actual/commit/bf1af67f58f42bda22c6f1a7e4ba37258d841e1d) Only use fund from local group during cleanup. ### 📊 Changes **2 files changed** (+20 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/cleanup-template.ts` (+14 -8) ➕ `upcoming-release-notes/5377.md` (+6 -0) </details> ### 📄 Description When using local group cleanup, currently all funds available in To Budget are distributed into the sinks. This behaviour seems somwhat odd and also results in all later groups or the "global" cleanup run to possibly have no funds as they've been distributed before. This patch now changes the group usage of cleanup, to only distribute funds made available by the group itself. If one also wants to sink money from To Budget into the category, a simple addtional `#cleanup sink`, will achieve this. Fixes #5374 <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:20:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5903
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?