github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4503] [MERGED] Fix number input on mobile with hidden decimals #5419

New Issue
Closed
opened 2026-02-28 21:12:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:12:08 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4503
Author: @jfdoming
Created: 3/2/2025
Status: ✅ Merged
Merged: 3/2/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/fix-number-parsing-mobile

📝 Commits (2)

  • 5730a3d Fix number input on mobile with hidden decimals
  • 7281f11 Add release notes

📊 Changes

3 files changed (+72 additions, -2 deletions)

View changed files

📝 packages/loot-core/src/shared/util.test.ts (+65 -1)
📝 packages/loot-core/src/shared/util.ts (+1 -1)
➕ upcoming-release-notes/4503.md (+6 -0)

📄 Description

Looking for help testing this for edge cases in the UI. The unit tests provide coverage based on how I think the function is used, and I've tested most format/fraction-hidden combinations in various places where that matters (reconciliation pop-up and mobile transaction input) but it would be good to get a second pair of eyes.

Fixes https://github.com/actualbudget/actual/issues/4494
Closes #4490

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4503 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 3/2/2025 **Status:** ✅ Merged **Merged:** 3/2/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/fix-number-parsing-mobile` --- ### 📝 Commits (2) - [`5730a3d`](https://github.com/actualbudget/actual/commit/5730a3d52de9142388962ed5709892bc268ef7a8) Fix number input on mobile with hidden decimals - [`7281f11`](https://github.com/actualbudget/actual/commit/7281f1158c94f1426ab0384e7a53e554bfa35991) Add release notes ### 📊 Changes **3 files changed** (+72 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/shared/util.test.ts` (+65 -1) 📝 `packages/loot-core/src/shared/util.ts` (+1 -1) ➕ `upcoming-release-notes/4503.md` (+6 -0) </details> ### 📄 Description Looking for help testing this for edge cases in the UI. The unit tests provide coverage based on how I think the function is used, and I've tested most format/fraction-hidden combinations in various places where that matters (reconciliation pop-up and mobile transaction input) but it would be good to get a second pair of eyes. Fixes https://github.com/actualbudget/actual/issues/4494 Closes #4490 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:12:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5419
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?