github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2923] [MERGED] Display splits in previews #4592

New Issue
Closed
opened 2026-02-28 20:58:10 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:58:10 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2923
Author: @jfdoming
Created: 6/23/2024
Status: ✅ Merged
Merged: 8/17/2024
Merged by: @jfdoming

Base: master ← Head: jfdoming/splits-in-previews

📝 Commits (10+)

  • 81d6636 Display splits in mobile previews
  • 125aefe Display splits in desktop previews
  • 198ea62 UI fix: hide checkboxes on preview child transactions
  • 8b25951 UI fix: show notes on preview transactions
  • 5f10f55 Add release notes
  • 55df37d Update vrt for mobile padding fix
  • 11711db Fix status display
  • b289f7d Collapse split previews by default
  • f1611c4 PR feedback: fix issues with split payee
  • cbcf4ec Update new VRT with spacing from this PR

📊 Changes

8 files changed (+148 additions, -82 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.jsx (+10 -4)
📝 packages/desktop-client/src/components/mobile/transactions/Transaction.jsx (+1 -2)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (+2 -2)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionList.jsx (+4 -0)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.jsx (+62 -54)
📝 packages/desktop-client/src/hooks/usePreviewTransactions.ts (+52 -20)
📝 packages/desktop-client/src/hooks/useSplitsExpanded.jsx (+11 -0)
➕ upcoming-release-notes/2923.md (+6 -0)

📄 Description

Following up on https://github.com/actualbudget/actual/issues/2379#issuecomment-2136242633.

There are some design decisions I'd like feedback on. In particular, Actual historically used the "category" column for the schedule status. That gets strange with splits because we also use that column for splits. I tentatively used the below UI:
image
image

We could also do something like this, although it looks a bit odd when the split is not hovered:
image
image

Open to suggestions or better alternatives.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2923 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 6/23/2024 **Status:** ✅ Merged **Merged:** 8/17/2024 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/splits-in-previews` --- ### 📝 Commits (10+) - [`81d6636`](https://github.com/actualbudget/actual/commit/81d6636d7110ce9c23b10edebbf59ffef009946a) Display splits in mobile previews - [`125aefe`](https://github.com/actualbudget/actual/commit/125aefe705d03017bc9726920e42c4c65dc904df) Display splits in desktop previews - [`198ea62`](https://github.com/actualbudget/actual/commit/198ea627872c484dd780564e2e14cd344d72bc4e) UI fix: hide checkboxes on preview child transactions - [`8b25951`](https://github.com/actualbudget/actual/commit/8b2595107cb495e65ceb70ffe64fc0861ee79425) UI fix: show notes on preview transactions - [`5f10f55`](https://github.com/actualbudget/actual/commit/5f10f55988f1d8e252952d5da1a8291f3e8d272b) Add release notes - [`55df37d`](https://github.com/actualbudget/actual/commit/55df37de8e3f5212d03780992e25f3d6984a01bb) Update vrt for mobile padding fix - [`11711db`](https://github.com/actualbudget/actual/commit/11711db86cb14d6002f875a53becc5c91079439a) Fix status display - [`b289f7d`](https://github.com/actualbudget/actual/commit/b289f7d438f9ee6ced73c753a7e21d17ef010b41) Collapse split previews by default - [`f1611c4`](https://github.com/actualbudget/actual/commit/f1611c4669236658a0f4f576c48163b66ba11c65) PR feedback: fix issues with split payee - [`cbcf4ec`](https://github.com/actualbudget/actual/commit/cbcf4ec8f5dca72e6899e5a01082f797fc9b71a1) Update new VRT with spacing from this PR ### 📊 Changes **8 files changed** (+148 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.jsx` (+10 -4) 📝 `packages/desktop-client/src/components/mobile/transactions/Transaction.jsx` (+1 -2) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx` (+2 -2) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionList.jsx` (+4 -0) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.jsx` (+62 -54) 📝 `packages/desktop-client/src/hooks/usePreviewTransactions.ts` (+52 -20) 📝 `packages/desktop-client/src/hooks/useSplitsExpanded.jsx` (+11 -0) ➕ `upcoming-release-notes/2923.md` (+6 -0) </details> ### 📄 Description Following up on https://github.com/actualbudget/actual/issues/2379#issuecomment-2136242633. There are some design decisions I'd like feedback on. In particular, Actual historically used the "category" column for the schedule status. That gets strange with splits because we also use that column for splits. I tentatively used the below UI: <img width="999" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/7e88fa36-cb7f-42ea-a2b7-610f1ea19af5"> <img width="802" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/f9471626-05fe-4bb4-89b3-b24d5429bd54"> We could also do something like this, although it looks a bit odd when the split is not hovered: <img width="846" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/fb01f187-2b2f-4ffe-91f6-6ecc528deb7f"> <img width="831" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/a841062a-2e6f-4070-989e-754a1556f51a"> Open to suggestions or better alternatives. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:58:10 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4592
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?