github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5241] [MERGED] Fixes #5238 last synced button text not visible on light theme. #5838

New Issue
Closed
opened 2026-02-28 21:19:34 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:19:34 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5241
Author: @mauschil
Created: 6/27/2025
Status: ✅ Merged
Merged: 6/30/2025
Merged by: @youngcw

Base: master ← Head: fix-last-sync-button-text-color-issue-on-light-theme

📝 Commits (5)

  • 090372a Changed the buttonMenuText color for the light theme so that text is visible on light background as well.
  • 745d131 Updated the release notes.
  • dfbd98f Change file name of release notes
  • ef5e83f Remove button varient from use last synced total and restore light theme
  • 5bfd254 Merge branch 'master' into fix-last-sync-button-text-color-issue-on-light-theme

📊 Changes

2 files changed (+6 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Reconcile.tsx (+0 -1)
➕ upcoming-release-notes/5241.md (+6 -0)

📄 Description

Related Issue

#5238

Release Notes

category: Bugfix
authors: [mauschil]

Change the buttonMenuText color for the light theme so that text is visible on light backgrounds as well.

Screenshots

Before
image
image

After
image
image

Additional Notes

In the light theme, the menus for any transaction menu (payee, category, date, etc) are still using a dark background. That means that buttonMenuText to has to be readable on both a dark and light background.

An alternative solution to this fix is to change the background color of the light transaction menus as well. Happy to do that, but since its my first PR, I'd leave the choice of whether to do it up to the maintainers.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5241 **Author:** [@mauschil](https://github.com/mauschil) **Created:** 6/27/2025 **Status:** ✅ Merged **Merged:** 6/30/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix-last-sync-button-text-color-issue-on-light-theme` --- ### 📝 Commits (5) - [`090372a`](https://github.com/actualbudget/actual/commit/090372ae28e6718faf4cf615c8aa3b95d3b2670f) Changed the buttonMenuText color for the light theme so that text is visible on light background as well. - [`745d131`](https://github.com/actualbudget/actual/commit/745d131f48e75d086b71a4ff53d6bc6ae1cab677) Updated the release notes. - [`dfbd98f`](https://github.com/actualbudget/actual/commit/dfbd98f5647e24a4a479259f51e4a8c6afc0a3e9) Change file name of release notes - [`ef5e83f`](https://github.com/actualbudget/actual/commit/ef5e83fdfde015bdd5bcc28eed7b5deca195f221) Remove button varient from use last synced total and restore light theme - [`5bfd254`](https://github.com/actualbudget/actual/commit/5bfd254e7c8693497edad694efe113265ec1556c) Merge branch 'master' into fix-last-sync-button-text-color-issue-on-light-theme ### 📊 Changes **2 files changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Reconcile.tsx` (+0 -1) ➕ `upcoming-release-notes/5241.md` (+6 -0) </details> ### 📄 Description ### Related Issue #5238 ### Release Notes category: Bugfix authors: [mauschil] Change the buttonMenuText color for the light theme so that text is visible on light backgrounds as well. ### Screenshots Before <img width="283" alt="image" src="https://github.com/user-attachments/assets/1fb97963-b2fb-4aea-a2ef-88b40d7c823e" /> <img width="364" alt="image" src="https://github.com/user-attachments/assets/72059d1b-3f31-41dd-b6e3-98964464cbd9" /> After <img width="284" alt="image" src="https://github.com/user-attachments/assets/c2bce846-cbd5-4f5e-bb3e-d8fc946c3eb0" /> <img width="365" alt="image" src="https://github.com/user-attachments/assets/0ff8c867-71e0-4b5e-8212-cd18f84b77cd" /> ### Additional Notes In the light theme, the menus for any transaction menu (payee, category, date, etc) are still using a dark background. That means that buttonMenuText to has to be readable on both a dark and light background. An alternative solution to this fix is to change the background color of the light transaction menus as well. Happy to do that, but since its my first PR, I'd leave the choice of whether to do it up to the maintainers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:19:34 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5838
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?