github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3761] [MERGED] Convert Mobile Transaction component to TransactionListItem + cleanup #5044

New Issue
Closed
opened 2026-02-28 21:05:05 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:05:05 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3761
Author: @joel-jeremy
Created: 10/31/2024
Status: ✅ Merged
Merged: 11/18/2024
Merged by: @joel-jeremy

Base: master ← Head: ts-migrate-mobile-Transaction-component

📝 Commits (7)

  • 2810b1a Migration mobile Transaction component to TransactionListItem + cleanup
  • d071718 Release notes + yarn install
  • e61ba6f Fix style
  • 3756d76 Padding changes + VRT
  • 73b5ded Update useScrollListener
  • 05d3430 Code rabbit feedback
  • ab7eee6 Do not show loading on preview transactions

📊 Changes

27 files changed (+1431 additions, -1490 deletions)

View changed files

📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-7-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-8-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-9-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Envelope-checks-that-clicking--c18ad-l-redirects-to-the-category-transactions-page-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Envelope-checks-that-clicking--e995e-l-redirects-to-the-category-transactions-page-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Envelope-checks-that-clicking--ff568-l-redirects-to-the-category-transactions-page-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Tracking-checks-that-clicking--11290-l-redirects-to-the-category-transactions-page-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Tracking-checks-that-clicking--57d88-l-redirects-to-the-category-transactions-page-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Tracking-checks-that-clicking--5d90c-l-redirects-to-the-category-transactions-page-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.mobile.test.js-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-7-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.mobile.test.js-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-8-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.mobile.test.js-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-9-chromium-linux.png (+0 -0)
📝 packages/desktop-client/package.json (+3 -3)
📝 packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx (+2 -3)
➖ packages/desktop-client/src/components/mobile/transactions/ListBox.jsx (+0 -41)
➖ packages/desktop-client/src/components/mobile/transactions/ListBoxSection.jsx (+0 -64)
➖ packages/desktop-client/src/components/mobile/transactions/Option.jsx (+0 -30)

...and 7 more files

📄 Description

Removed a bunch of files and replaced it with react-aria-component equivalent components

Did some minor adjustments to the horizontal paddings of transaction list items hence the VRT screenshot changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3761 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 10/31/2024 **Status:** ✅ Merged **Merged:** 11/18/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `ts-migrate-mobile-Transaction-component` --- ### 📝 Commits (7) - [`2810b1a`](https://github.com/actualbudget/actual/commit/2810b1a228aaad0ca5d0d35303ca1e8cbc459f8b) Migration mobile Transaction component to TransactionListItem + cleanup - [`d071718`](https://github.com/actualbudget/actual/commit/d071718855cdb8ebb5b4ab09ed616aa2be283faa) Release notes + yarn install - [`e61ba6f`](https://github.com/actualbudget/actual/commit/e61ba6f15ad5b22c8242e541706efc161c2b96ca) Fix style - [`3756d76`](https://github.com/actualbudget/actual/commit/3756d7608b61c28c105684092b63cd20fd4dd322) Padding changes + VRT - [`73b5ded`](https://github.com/actualbudget/actual/commit/73b5ded86e4c2e6665c6d26f6534e4e687b32dfa) Update useScrollListener - [`05d3430`](https://github.com/actualbudget/actual/commit/05d3430ba4b8aaf9a945cea4d43b880080d4ffef) Code rabbit feedback - [`ab7eee6`](https://github.com/actualbudget/actual/commit/ab7eee668d509fd6bfcb90dd00ed6ebc90833a9f) Do not show loading on preview transactions ### 📊 Changes **27 files changed** (+1431 additions, -1490 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-7-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-8-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-individual-account-page-and-checks-that-filtering-is-working-9-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Envelope-checks-that-clicking--c18ad-l-redirects-to-the-category-transactions-page-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Envelope-checks-that-clicking--e995e-l-redirects-to-the-category-transactions-page-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Envelope-checks-that-clicking--ff568-l-redirects-to-the-category-transactions-page-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Tracking-checks-that-clicking--11290-l-redirects-to-the-category-transactions-page-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Tracking-checks-that-clicking--57d88-l-redirects-to-the-category-transactions-page-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Tracking-checks-that-clicking--5d90c-l-redirects-to-the-category-transactions-page-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.mobile.test.js-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-7-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.mobile.test.js-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-8-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.mobile.test.js-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-9-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/package.json` (+3 -3) 📝 `packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx` (+2 -3) ➖ `packages/desktop-client/src/components/mobile/transactions/ListBox.jsx` (+0 -41) ➖ `packages/desktop-client/src/components/mobile/transactions/ListBoxSection.jsx` (+0 -64) ➖ `packages/desktop-client/src/components/mobile/transactions/Option.jsx` (+0 -30) _...and 7 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Removed a bunch of files and replaced it with react-aria-component equivalent components Did some minor adjustments to the horizontal paddings of transaction list items hence the VRT screenshot changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:05:05 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5044
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?