github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5124] [MERGED] Fix: Only sync off-budget accounts when syncing from off-budget page #5770

New Issue
Closed
opened 2026-02-28 21:18:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:18:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5124
Author: @MatissJanis
Created: 6/7/2025
Status: ✅ Merged
Merged: 6/8/2025
Merged by: @MatissJanis

Base: master ← Head: fix/offbudget-sync-only

📝 Commits (1)

  • 70713a5 Fix: Only sync off-budget accounts when syncing from off-budget page

📊 Changes

4 files changed (+46 additions, -20 deletions)

View changed files

📝 packages/desktop-client/src/accounts/accountsSlice.ts (+36 -18)
📝 packages/desktop-client/src/app/appSlice.ts (+3 -1)
📝 packages/desktop-client/src/components/accounts/Account.tsx (+1 -1)
➕ upcoming-release-notes/5124.md (+6 -0)

📄 Description

Summary

This PR fixes the bug where clicking "Bank Sync" on the off-budget page would sync all accounts instead of only off-budget accounts (issue #4209).

Changes

  • Refactored sync logic to use the accountId parameter for special cases:
    • If accountId is offbudget, only off-budget accounts are synced.
    • If accountId is onbudget, only on-budget accounts are synced.
    • If accountId is uncategorized, no accounts are synced.
    • Otherwise, sync the given account or all accounts as before.
  • No new flags or thunks were introduced; the logic is centralized in syncAccounts and triggered via syncAndDownload.

Testing

  • Sync from the off-budget page only syncs off-budget accounts.
  • Sync from the on-budget page only syncs on-budget accounts.
  • Sync from the uncategorized page does nothing.
  • Sync from an individual account or all accounts works as before.

Closes #4209.

Let me know if you need further changes or tests!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5124 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 6/7/2025 **Status:** ✅ Merged **Merged:** 6/8/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `fix/offbudget-sync-only` --- ### 📝 Commits (1) - [`70713a5`](https://github.com/actualbudget/actual/commit/70713a593453d3454645f48b6dc007319d451848) Fix: Only sync off-budget accounts when syncing from off-budget page ### 📊 Changes **4 files changed** (+46 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/accounts/accountsSlice.ts` (+36 -18) 📝 `packages/desktop-client/src/app/appSlice.ts` (+3 -1) 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+1 -1) ➕ `upcoming-release-notes/5124.md` (+6 -0) </details> ### 📄 Description ## Summary This PR fixes the bug where clicking "Bank Sync" on the off-budget page would sync all accounts instead of only off-budget accounts ([issue #4209](https://github.com/actualbudget/actual/issues/4209)). ## Changes - Refactored sync logic to use the `accountId` parameter for special cases: - If `accountId` is `offbudget`, only off-budget accounts are synced. - If `accountId` is `onbudget`, only on-budget accounts are synced. - If `accountId` is `uncategorized`, no accounts are synced. - Otherwise, sync the given account or all accounts as before. - No new flags or thunks were introduced; the logic is centralized in `syncAccounts` and triggered via `syncAndDownload`. ## Testing - Sync from the off-budget page only syncs off-budget accounts. - Sync from the on-budget page only syncs on-budget accounts. - Sync from the uncategorized page does nothing. - Sync from an individual account or all accounts works as before. Closes #4209. --- Let me know if you need further changes or tests! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:18:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?