github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3734] [MERGED] add buttons for combined-account transaction pages on mobile #5028

New Issue
Closed
opened 2026-02-28 21:04:52 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:04:52 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3734
Author: @gabeklavans
Created: 10/25/2024
Status: ✅ Merged
Merged: 1/7/2025
Merged by: @joel-jeremy

Base: master ← Head: mobile-multi-account-view

📝 Commits (6)

  • 9644c2e add buttons for combined-account transaction pages (#2333)
  • 1c6f887 add release note for #3734
  • 170796b add accessibility label to mobile combined-account header button
  • 243bf08 increase touch targets for combined-account buttons
  • 274b843 remove highlight color and add bounce to header buttons
  • 19d2487 update vrt screenshots for actualbudget#3734

📊 Changes

5 files changed (+49 additions, -9 deletions)

View changed files

📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/mobile/accounts/Accounts.tsx (+43 -9)
➕ upcoming-release-notes/3734.md (+6 -0)

📄 Description

I quickly threw together the actual styling of these buttons. I'm very much open to changing it up, but just wanted to start the functionality here.

I was pleasantly surprised to see that the combined accounts pages that work on desktop also seem to work fine on mobile. This just adds a way to navigate to those URLs on mobile.

resolves #2333

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3734 **Author:** [@gabeklavans](https://github.com/gabeklavans) **Created:** 10/25/2024 **Status:** ✅ Merged **Merged:** 1/7/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `mobile-multi-account-view` --- ### 📝 Commits (6) - [`9644c2e`](https://github.com/actualbudget/actual/commit/9644c2e20c84ca2df7428b0cb928425527e27d40) add buttons for combined-account transaction pages (#2333) - [`1c6f887`](https://github.com/actualbudget/actual/commit/1c6f887c54273889592c7118cb2b5c9f206c22df) add release note for #3734 - [`170796b`](https://github.com/actualbudget/actual/commit/170796b2dd5e1632a028b107b7f1f9ae1c164186) add accessibility label to mobile combined-account header button - [`243bf08`](https://github.com/actualbudget/actual/commit/243bf085b856a433909699aa3119cfc7265e2cb0) increase touch targets for combined-account buttons - [`274b843`](https://github.com/actualbudget/actual/commit/274b84313942a8bb6f26835aeb1d386ed7d80763) remove highlight color and add bounce to header buttons - [`19d2487`](https://github.com/actualbudget/actual/commit/19d24876e195ccda4c2facd5ddfb3cb568ef9b36) update vrt screenshots for actualbudget#3734 ### 📊 Changes **5 files changed** (+49 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/mobile/accounts/Accounts.tsx` (+43 -9) ➕ `upcoming-release-notes/3734.md` (+6 -0) </details> ### 📄 Description I quickly threw together the actual styling of these buttons. I'm very much open to changing it up, but just wanted to start the functionality here. I was pleasantly surprised to see that the combined accounts pages that work on desktop also seem to work fine on mobile. This just adds a way to navigate to those URLs on mobile. resolves #2333 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:04:52 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5028
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?