github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5054] [CLOSED] fix(auth): header loginMethod #5733

New Issue
Closed
opened 2026-02-28 21:17:34 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:17:34 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5054
Author: @pyrho
Created: 5/24/2025
Status: ❌ Closed

Base: master ← Head: fix/reverse-proxy-auth

📝 Commits (1)

  • 8588ed8 fix(auth): header loginMethod

📊 Changes

6 files changed (+34 additions, -23 deletions)

View changed files

📝 packages/desktop-client/src/components/ServerContext.tsx (+16 -13)
📝 packages/desktop-client/src/components/manager/subscribe/common.tsx (+8 -4)
📝 packages/loot-core/src/server/auth/app.ts (+2 -1)
📝 packages/sync-server/src/app-account.js (+1 -4)
📝 packages/sync-server/src/config-types.ts (+1 -1)
➕ upcoming-release-notes/5054.md (+6 -0)

📄 Description

The header loginMethod was never actually used, these changes aim to fix that.

Fixes #4488

edit: I have deployed this image and have been successfully logged in via header auth if i have ACTUAL_LOGIN_METHOD=header; and also checked that not setting this variable correctly defaults to the password method.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5054 **Author:** [@pyrho](https://github.com/pyrho) **Created:** 5/24/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/reverse-proxy-auth` --- ### 📝 Commits (1) - [`8588ed8`](https://github.com/actualbudget/actual/commit/8588ed8645c50bb1efa2b5a6beb87c988758c653) fix(auth): header loginMethod ### 📊 Changes **6 files changed** (+34 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ServerContext.tsx` (+16 -13) 📝 `packages/desktop-client/src/components/manager/subscribe/common.tsx` (+8 -4) 📝 `packages/loot-core/src/server/auth/app.ts` (+2 -1) 📝 `packages/sync-server/src/app-account.js` (+1 -4) 📝 `packages/sync-server/src/config-types.ts` (+1 -1) ➕ `upcoming-release-notes/5054.md` (+6 -0) </details> ### 📄 Description The header loginMethod was never actually used, these changes aim to fix that. Fixes #4488 edit: I have deployed this image and have been successfully logged in via header auth if i have `ACTUAL_LOGIN_METHOD=header`; and also checked that *not* setting this variable correctly defaults to the password method. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:17:34 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5733
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?