github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3674] [MERGED] Explicitly disable 1Password on table inputs #4997

New Issue
Closed
opened 2026-02-28 21:04:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:04:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3674
Author: @greggroth
Created: 10/15/2024
Status: ✅ Merged
Merged: 10/15/2024
Merged by: @youngcw

Base: master ← Head: 1password-ignore

📝 Commits (3)

  • ce89823 Explicitly disable 1Password on table inputs
  • 340a610 Add release notes
  • 924688a Update packages/desktop-client/src/components/autocomplete/Autocomplete.tsx

📊 Changes

2 files changed (+8 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+2 -1)
➕ upcoming-release-notes/3674.md (+6 -0)

📄 Description

When an account includes "Credit Card", 1Password really wants to suggest credit cards when you try to set the category or payee. This PR explicitly disables 1Password's autocomplete feature on table inputs to prevent these unwanted suggestions using the data-1p-ignore property.

Screenshot 2024-10-15 at 11 00 53 AM

I took a bit of a large-hammer/simpler approach and assumed there shouldn't be 1Password suggestions anywhere within Actual, so I added it to all input elements added by Autocomplete, but I can refactor it to push this into the properties if you'd prefer.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3674 **Author:** [@greggroth](https://github.com/greggroth) **Created:** 10/15/2024 **Status:** ✅ Merged **Merged:** 10/15/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `1password-ignore` --- ### 📝 Commits (3) - [`ce89823`](https://github.com/actualbudget/actual/commit/ce89823f758accba7ab973da5e3d8926d6165034) Explicitly disable 1Password on table inputs - [`340a610`](https://github.com/actualbudget/actual/commit/340a610b08216f121ed8a028f28b467c78ef9037) Add release notes - [`924688a`](https://github.com/actualbudget/actual/commit/924688a4f36b199554ce490dadf5a3cb003d5728) Update packages/desktop-client/src/components/autocomplete/Autocomplete.tsx ### 📊 Changes **2 files changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+2 -1) ➕ `upcoming-release-notes/3674.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> When an account includes "Credit Card", 1Password really wants to suggest credit cards when you try to set the category or payee. This PR explicitly disables 1Password's autocomplete feature on table inputs to prevent these unwanted suggestions [using the `data-1p-ignore` property](https://developer.1password.com/docs/web/compatible-website-design/). ![Screenshot 2024-10-15 at 11 00 53 AM](https://github.com/user-attachments/assets/f8bf0e62-e2b2-436e-a64a-be22af980bfa) I took a bit of a large-hammer/simpler approach and assumed there shouldn't be 1Password suggestions anywhere within Actual, so I added it to all `input` elements added by `Autocomplete`, but I can refactor it to push this into the properties if you'd prefer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:04:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4997
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?