github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 04:32:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3607] [MERGED] Fixes #3585 - Fixes Rule Conditions Removal #4953

New Issue
Closed
opened 2026-02-28 21:03:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:03:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3607
Author: @attyluccio
Created: 10/8/2024
Status: ✅ Merged
Merged: 10/12/2024
Merged by: @MatissJanis

Base: master ← Head: fix-3585

📝 Commits (9)

  • 8cbf6da Fixes #3585 - Fixes Rule Conditions Removal
  • 21fb643 Merge branch 'master' into fix-3585
  • 0231c8c Fixes #3585 - Fixes Rule Conditions Removal
  • d087c17 Merge branch 'fix-3585' of github.com:attyluccio/actual into fix-3585
  • e0dfe77 Merge branch 'master' into fix-3585
  • d55e2e2 Fixes #3585 - Fixes Rule Conditions Removal
  • 09e85f2 Merge branch 'master' into fix-3585
  • f26e594 fixed #3585 inputKey on ActionEditor
  • a2089be Merge branch 'fix-3585' of github.com:attyluccio/actual into fix-3585

📊 Changes

2 files changed (+23 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/EditRuleModal.jsx (+17 -4)
➕ upcoming-release-notes/3607.md (+6 -0)

📄 Description

Fixes the issue #3585

actually the removal worked correctly behind the scenes but was not rendered properly because the inputs did not have valid keys but the array index was used.

I fixed it by generating uuidv4s (instead of the previous Math.random() of the other inputs) and using them as the key

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3607 **Author:** [@attyluccio](https://github.com/attyluccio) **Created:** 10/8/2024 **Status:** ✅ Merged **Merged:** 10/12/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `fix-3585` --- ### 📝 Commits (9) - [`8cbf6da`](https://github.com/actualbudget/actual/commit/8cbf6da7156d146a0d3e6306cf5302587cd7da62) Fixes #3585 - Fixes Rule Conditions Removal - [`21fb643`](https://github.com/actualbudget/actual/commit/21fb6430fd37c31fc82d2dc2815867e709aa8a12) Merge branch 'master' into fix-3585 - [`0231c8c`](https://github.com/actualbudget/actual/commit/0231c8cc1b2a0385086b3458de6dc62d366386a0) Fixes #3585 - Fixes Rule Conditions Removal - [`d087c17`](https://github.com/actualbudget/actual/commit/d087c1715423b22c217a66bf7ec3e6ea23f53950) Merge branch 'fix-3585' of github.com:attyluccio/actual into fix-3585 - [`e0dfe77`](https://github.com/actualbudget/actual/commit/e0dfe778fdaa7060073f2b78c25a9f0cf140d3be) Merge branch 'master' into fix-3585 - [`d55e2e2`](https://github.com/actualbudget/actual/commit/d55e2e2ff3b752b353e3f5c07d158f93aa1ce362) Fixes #3585 - Fixes Rule Conditions Removal - [`09e85f2`](https://github.com/actualbudget/actual/commit/09e85f20388608510eb19a4142c415f58a07989e) Merge branch 'master' into fix-3585 - [`f26e594`](https://github.com/actualbudget/actual/commit/f26e594c1cabe893abca5d78cec575596a41f42e) fixed #3585 inputKey on ActionEditor - [`a2089be`](https://github.com/actualbudget/actual/commit/a2089be439e4c88de7602ff2ab3bdf68ed171128) Merge branch 'fix-3585' of github.com:attyluccio/actual into fix-3585 ### 📊 Changes **2 files changed** (+23 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/EditRuleModal.jsx` (+17 -4) ➕ `upcoming-release-notes/3607.md` (+6 -0) </details> ### 📄 Description Fixes the issue #3585 actually the removal worked correctly behind the scenes but was not rendered properly because the inputs did not have valid keys but the array index was used. I fixed it by generating uuidv4s (instead of the previous Math.random() of the other inputs) and using them as the key --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:03:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4953
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?