github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5301] [MERGED] [Goals] limits for remainders #5865

New Issue
Closed
opened 2026-02-28 21:20:05 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:20:05 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5301
Author: @youngcw
Created: 7/6/2025
Status: ✅ Merged
Merged: 7/9/2025
Merged by: @youngcw

Base: master ← Head: youngcw/remainder-limit

📝 Commits (4)

  • cab897a limits for remainders
  • 1985c42 Merge branch 'master' into youngcw/remainder-limit
  • 425ef83 round if needed
  • 2cdeaf3 handle edge cases

📊 Changes

3 files changed (+45 additions, -19 deletions)

View changed files

📝 packages/loot-core/src/server/budget/category-template-context.ts (+29 -15)
📝 packages/loot-core/src/server/budget/goal-template.ts (+10 -4)
➕ upcoming-release-notes/5301.md (+6 -0)

📄 Description

Make remainder templates respect category limits.

I don't know if the limit should only be for one passed in with a remainder template directly or if it should be like the other templates and any defined limit is respected. Currently any template in the category can define a limit and the remainder will respect it.

This works by looping over the remainder application until either there are no more categories that will accept funds, or the funds run out.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5301 **Author:** [@youngcw](https://github.com/youngcw) **Created:** 7/6/2025 **Status:** ✅ Merged **Merged:** 7/9/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `youngcw/remainder-limit` --- ### 📝 Commits (4) - [`cab897a`](https://github.com/actualbudget/actual/commit/cab897a43b19091d278742ff1e6ed0b39e192680) limits for remainders - [`1985c42`](https://github.com/actualbudget/actual/commit/1985c42bc8bf07cca28404f7f67371bdbdb6bfc5) Merge branch 'master' into youngcw/remainder-limit - [`425ef83`](https://github.com/actualbudget/actual/commit/425ef8380aeb78b225686164dbb507dbded24989) round if needed - [`2cdeaf3`](https://github.com/actualbudget/actual/commit/2cdeaf3ae97e21d7960cf3aec258d10335650533) handle edge cases ### 📊 Changes **3 files changed** (+45 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/category-template-context.ts` (+29 -15) 📝 `packages/loot-core/src/server/budget/goal-template.ts` (+10 -4) ➕ `upcoming-release-notes/5301.md` (+6 -0) </details> ### 📄 Description Make remainder templates respect category limits. I don't know if the limit should only be for one passed in with a remainder template directly or if it should be like the other templates and any defined limit is respected. Currently any template in the category can define a limit and the remainder will respect it. This works by looping over the remainder application until either there are no more categories that will accept funds, or the funds run out. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:20:05 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5865
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?