github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4070] [MERGED] Fix icon hover effect in transaction table #5172

New Issue
Closed
opened 2026-02-28 21:07:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:07:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4070
Author: @jfdoming
Created: 1/2/2025
Status: ✅ Merged
Merged: 1/2/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/fix-icon-hover

📝 Commits (3)

📊 Changes

12 files changed (+42 additions, -28 deletions)

View changed files

📝 packages/desktop-client/e2e/schedules.test.js (+4 -0)
📝 packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-13-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-14-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-15-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.jsx (+32 -28)
➕ upcoming-release-notes/4070.md (+6 -0)

📄 Description

Follow-up to #4056—that PR was almost the right fix but inadvertently caused a small regression with the hover effect on icons.

Edge:
image

This PR:
image

Also note that this still fixes the original issue, which specifically only reproed for imported payees.
Last release:
image

This PR:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4070 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 1/2/2025 **Status:** ✅ Merged **Merged:** 1/2/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/fix-icon-hover` --- ### 📝 Commits (3) - [`6372659`](https://github.com/actualbudget/actual/commit/6372659c0f5c30c6823f64c2209b428b7233a119) Fix icon hover effect in transaction table - [`913e5fa`](https://github.com/actualbudget/actual/commit/913e5fa6d7e66abb583af491d9a974ac70a70699) Add release notes - [`fcf112b`](https://github.com/actualbudget/actual/commit/fcf112b8fa90f56d69e411b7a86c5854bb6019d7) Add test ### 📊 Changes **12 files changed** (+42 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/schedules.test.js` (+4 -0) 📝 `packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-13-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-14-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-15-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.jsx` (+32 -28) ➕ `upcoming-release-notes/4070.md` (+6 -0) </details> ### 📄 Description Follow-up to #4056—that PR was almost the right fix but inadvertently caused a small regression with the hover effect on icons. Edge: <img width="198" alt="image" src="https://github.com/user-attachments/assets/d42aa616-3ed2-46ef-9f7f-4747ee51197a" /> This PR: <img width="80" alt="image" src="https://github.com/user-attachments/assets/d61194c8-44c9-48de-bb28-2078baa6ddc2" /> Also note that this still fixes the original issue, which specifically only reproed for imported payees. Last release: <img width="372" alt="image" src="https://github.com/user-attachments/assets/41f5b73e-f1f7-40f3-84b8-0ea7045c326b" /> This PR: <img width="356" alt="image" src="https://github.com/user-attachments/assets/00ed10c2-fc6b-4862-9cf9-1292e2d130b2" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:07:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5172
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?