[PR #4191] [MERGED] Use 'cimode' as default language in tests #5251

Closed
opened 2026-02-28 21:09:05 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4191
Author: @jfdoming
Created: 1/18/2025
Status: Merged
Merged: 1/19/2025
Merged by: @jfdoming

Base: masterHead: jfodming/cimode


📝 Commits (6)

📊 Changes

2 files changed (+11 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/i18n.ts (+5 -2)
upcoming-release-notes/4191.md (+6 -0)

📄 Description

As it says on the tin. This should hopefully prevent new strings/changed English strings from affecting visual regression tests.

After opening the PR, confirmed that (a) the deploy preview still pluralizes like normal, and (b) new strings appear in the VRT.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4191 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 1/18/2025 **Status:** ✅ Merged **Merged:** 1/19/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfodming/cimode` --- ### 📝 Commits (6) - [`0d863e5`](https://github.com/actualbudget/actual/commit/0d863e53619aba19a22750d857bfcde80f62a213) Use cimode as default language in tests - [`b26d7e3`](https://github.com/actualbudget/actual/commit/b26d7e3f8d6507b178f4e5fa9acf2c57967a8e54) Add release notes - [`8e4b83e`](https://github.com/actualbudget/actual/commit/8e4b83ee4fd4649c99f29cedfae0dfec55594560) Temp: testing VRT - [`1e8b65b`](https://github.com/actualbudget/actual/commit/1e8b65b90cd5aafbf9b58565a6fe42869f146ebd) Update VRT - [`9cb67e2`](https://github.com/actualbudget/actual/commit/9cb67e248b3f59f14eed0be9546ce08457e5d097) Revert test change - [`a7981cc`](https://github.com/actualbudget/actual/commit/a7981cc1ec1c264bc4e2a05de761070216ff3dd3) Update VRT ### 📊 Changes **2 files changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/i18n.ts` (+5 -2) ➕ `upcoming-release-notes/4191.md` (+6 -0) </details> ### 📄 Description As it says on the tin. This should hopefully prevent new strings/changed English strings from affecting visual regression tests. After opening the PR, confirmed that (a) the deploy preview still pluralizes like normal, and (b) new strings appear in the VRT. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:09:05 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5251