github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3458] [MERGED] ♻️ (synced-prefs) separate metadata and local prefs out #4864

New Issue
Closed
opened 2026-02-28 21:02:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:02:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3458
Author: @MatissJanis
Created: 9/17/2024
Status: ✅ Merged
Merged: 9/20/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/synced-prefs-8

📝 Commits (8)

  • 02f9e6a ♻️ (synced-prefs) separate metadata and local prefs out
  • 6392dce Feedback: coderabbit
  • c4b3960 Merge branch 'master' into matiss/synced-prefs-8
  • 0d04040 Feedback: initial value
  • e5da7aa Scoped local prefs
  • 0dd7850 Merge branch 'master' into matiss/synced-prefs-8
  • d6708a2 Feedback: remove setMetadataPref
  • ab6cbdf tMerge branch 'master' into matiss/synced-prefs-8

📊 Changes

10 files changed (+122 additions, -104 deletions)

View changed files

📝 packages/desktop-client/src/components/FinancesApp.tsx (+42 -8)
📝 packages/desktop-client/src/hooks/useLocalPref.ts (+28 -13)
📝 packages/desktop-client/src/hooks/useMetadataPref.ts (+17 -5)
📝 packages/loot-core/src/client/actions/prefs.ts (+3 -4)
📝 packages/loot-core/src/client/state-types/prefs.d.ts (+4 -4)
➖ packages/loot-core/src/client/update-notification.ts (+0 -45)
📝 packages/loot-core/src/server/sync/index.ts (+2 -2)
📝 packages/loot-core/src/types/prefs.d.ts (+18 -21)
📝 packages/loot-core/src/types/server-handlers.d.ts (+2 -2)
➕ upcoming-release-notes/3458.md (+6 -0)

📄 Description

This should be the last PR in the series.

Separating out MetadataPrefs (metadata.json) and LocalPrefs (local storage).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3458 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/17/2024 **Status:** ✅ Merged **Merged:** 9/20/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/synced-prefs-8` --- ### 📝 Commits (8) - [`02f9e6a`](https://github.com/actualbudget/actual/commit/02f9e6a874d0aa00fa0a24732b72bd4e1c09e014) :recycle: (synced-prefs) separate metadata and local prefs out - [`6392dce`](https://github.com/actualbudget/actual/commit/6392dcefb83fcd39ff87b7ebb7b4a6edbbc47e9b) Feedback: coderabbit - [`c4b3960`](https://github.com/actualbudget/actual/commit/c4b39602758bb180a9dcd34d308352a277c470ae) Merge branch 'master' into matiss/synced-prefs-8 - [`0d04040`](https://github.com/actualbudget/actual/commit/0d040406272eda366880905903ec0056ab25b348) Feedback: initial value - [`e5da7aa`](https://github.com/actualbudget/actual/commit/e5da7aa943804d09ed5fd95d43fcf2733f34df5e) Scoped local prefs - [`0dd7850`](https://github.com/actualbudget/actual/commit/0dd78502996b133e786cc80af263c060ad66db1b) Merge branch 'master' into matiss/synced-prefs-8 - [`d6708a2`](https://github.com/actualbudget/actual/commit/d6708a26596894453d1bb9460a35ee88b5296a4b) Feedback: remove setMetadataPref - [`ab6cbdf`](https://github.com/actualbudget/actual/commit/ab6cbdfc6f3cd66becdbdfe1877cc2a9a17255cb) tMerge branch 'master' into matiss/synced-prefs-8 ### 📊 Changes **10 files changed** (+122 additions, -104 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+42 -8) 📝 `packages/desktop-client/src/hooks/useLocalPref.ts` (+28 -13) 📝 `packages/desktop-client/src/hooks/useMetadataPref.ts` (+17 -5) 📝 `packages/loot-core/src/client/actions/prefs.ts` (+3 -4) 📝 `packages/loot-core/src/client/state-types/prefs.d.ts` (+4 -4) ➖ `packages/loot-core/src/client/update-notification.ts` (+0 -45) 📝 `packages/loot-core/src/server/sync/index.ts` (+2 -2) 📝 `packages/loot-core/src/types/prefs.d.ts` (+18 -21) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+2 -2) ➕ `upcoming-release-notes/3458.md` (+6 -0) </details> ### 📄 Description This should be the last PR in the series. Separating out `MetadataPrefs` (metadata.json) and `LocalPrefs` (local storage). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:02:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4864
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?