[PR #4002] [MERGED] Upload translations on builds of master #5147

Closed
opened 2026-02-28 21:06:45 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4002
Author: @jfdoming
Created: 12/18/2024
Status: Merged
Merged: 12/24/2024
Merged by: @jfdoming

Base: masterHead: jfdoming/translation-exports


📝 Commits (5)

  • bf7a400 fix: translations were not being loaded properly
  • 4ae4c8c fix: support running GitHub actions locally with act
  • a7e0875 feat: upload new strings on master build
  • 2e9a3df Add release notes
  • c68d90b PR feedback: security

📊 Changes

6 files changed (+58 additions, -2 deletions)

View changed files

📝 .github/actions/setup/action.yml (+4 -0)
.github/workflows/i18n-string-extract-master.yml (+36 -0)
📝 packages/desktop-client/.gitignore (+3 -0)
📝 packages/desktop-client/i18next-parser.config.js (+1 -1)
📝 packages/desktop-client/src/i18n.ts (+8 -1)
upcoming-release-notes/4002.md (+6 -0)

📄 Description

As it says on the tin. I also fixed some other issues with loading translations.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4002 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 12/18/2024 **Status:** ✅ Merged **Merged:** 12/24/2024 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/translation-exports` --- ### 📝 Commits (5) - [`bf7a400`](https://github.com/actualbudget/actual/commit/bf7a4003820fa3753ce13193292935686eff9936) fix: translations were not being loaded properly - [`4ae4c8c`](https://github.com/actualbudget/actual/commit/4ae4c8c75023e5ba2745551f023c8a094a0d39ec) fix: support running GitHub actions locally with `act` - [`a7e0875`](https://github.com/actualbudget/actual/commit/a7e087516d76cd659e7e6b71e4773f9c2ec717a9) feat: upload new strings on master build - [`2e9a3df`](https://github.com/actualbudget/actual/commit/2e9a3df12be51de6841ca7c2a994b54c0bf296a6) Add release notes - [`c68d90b`](https://github.com/actualbudget/actual/commit/c68d90b9e68d386673dc7161fcca93b00383cbc6) PR feedback: security ### 📊 Changes **6 files changed** (+58 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/setup/action.yml` (+4 -0) ➕ `.github/workflows/i18n-string-extract-master.yml` (+36 -0) 📝 `packages/desktop-client/.gitignore` (+3 -0) 📝 `packages/desktop-client/i18next-parser.config.js` (+1 -1) 📝 `packages/desktop-client/src/i18n.ts` (+8 -1) ➕ `upcoming-release-notes/4002.md` (+6 -0) </details> ### 📄 Description As it says on the tin. I also fixed some other issues with loading translations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:06:45 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5147