[PR #3936] [CLOSED] [WIP] adds more strings to be localized in groupByOptions description #5127

Closed
opened 2026-02-28 21:06:25 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3936
Author: @ammassey
Created: 12/6/2024
Status: Closed

Base: masterHead: report-options-i18n


📝 Commits (6)

  • 5b9e073 adds translatability groupByOptions description
  • eea413f release notes
  • be1574a Merge branch 'master' into report-options-i18n
  • 82af245 Merge branch 'master' into report-options-i18n
  • 8373a7c Merge branch 'master' into report-options-i18n
  • c931026 Merge branch 'master' into report-options-i18n

📊 Changes

2 files changed (+11 additions, -5 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/ReportOptions.ts (+5 -5)
upcoming-release-notes/3936.md (+6 -0)

📄 Description

Seeks to complete adding translatability to ReportOptions.ts. This was noted as not yet completed per the list of files requiring i18n support

In a previous PR (https://github.com/actualbudget/actual/pull/3548), it looks like this was mostly completed but I noticed there were some strings potentially missing.

Relevant issue: https://github.com/actualbudget/actual/issues/3329


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3936 **Author:** [@ammassey](https://github.com/ammassey) **Created:** 12/6/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `report-options-i18n` --- ### 📝 Commits (6) - [`5b9e073`](https://github.com/actualbudget/actual/commit/5b9e0736c0f0ea46ac10fc5cf5e8ea1a649cbaed) adds translatability groupByOptions description - [`eea413f`](https://github.com/actualbudget/actual/commit/eea413f47914180f7af5953f6ff5b5783d75bb44) release notes - [`be1574a`](https://github.com/actualbudget/actual/commit/be1574ae5577497c165fdf43832fa4b6f21d8fa4) Merge branch 'master' into report-options-i18n - [`82af245`](https://github.com/actualbudget/actual/commit/82af245e20e85775693fa7651ee64249b98894b5) Merge branch 'master' into report-options-i18n - [`8373a7c`](https://github.com/actualbudget/actual/commit/8373a7cd44077fb08e823825b4c7d4add1b94be4) Merge branch 'master' into report-options-i18n - [`c931026`](https://github.com/actualbudget/actual/commit/c9310265e4a397872c1387fbf93b36728bb4d36c) Merge branch 'master' into report-options-i18n ### 📊 Changes **2 files changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/ReportOptions.ts` (+5 -5) ➕ `upcoming-release-notes/3936.md` (+6 -0) </details> ### 📄 Description Seeks to complete adding translatability to ReportOptions.ts. This was noted as not yet completed per the [list of files requiring i18n support](https://docs.google.com/spreadsheets/d/1JuZ7-77vq5NXuARrvCF58ek5sHISMt9DonTZ8crGQRc/edit?gid=0#gid=0) In a previous PR (https://github.com/actualbudget/actual/pull/3548), it looks like this was mostly completed but I noticed there were some strings potentially missing. Relevant issue: https://github.com/actualbudget/actual/issues/3329 <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:06:25 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5127