github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #4399] [CLOSED] [WIP] - ✨ OPENID: Added ACTUAL_OPENID_AUTO_REDIRECT variable to automatically redirect to OpenID login #5360

New Issue
Closed
opened 2026-02-28 21:11:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:11:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4399
Author: @lelemm
Created: 2/18/2025
Status: ❌ Closed

Base: master ← Head: enhance/openid_01

📝 Commits (10+)

  • 4fc32f5 OpenID autologin
  • 9f4f7ef Merge branch 'master' into enhance/openid_01
  • 4d1f8f6 change variable name and location
  • d8cc6c4 updated md
  • 3368fa7 Merge remote-tracking branch 'org/master' into enhance/openid_01
  • 919fc73 Merge branch 'master' into enhance/openid_01
  • da341af Merge branch 'master' into enhance/openid_01
  • 8552a0a linter
  • 3fea350 Merge branch 'master' into enhance/openid_01
  • 9c36d19 Merge remote-tracking branch 'org/master' into enhance/openid_01

📊 Changes

26 files changed (+250 additions, -44 deletions)

View changed files

📝 packages/desktop-client/src/components/App.tsx (+5 -3)
📝 packages/desktop-client/src/components/LoggedInUser.tsx (+2 -2)
📝 packages/desktop-client/src/components/ServerContext.tsx (+11 -0)
📝 packages/desktop-client/src/components/admin/UserAccess/UserAccessRow.tsx (+1 -1)
📝 packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx (+1 -1)
📝 packages/desktop-client/src/components/manager/ConfigServer.tsx (+7 -2)
📝 packages/desktop-client/src/components/manager/subscribe/Login.tsx (+67 -17)
📝 packages/desktop-client/src/components/manager/subscribe/common.tsx (+4 -0)
📝 packages/desktop-client/src/components/modals/EditAccess.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/EditUser.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/OpenIDEnableModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/OutOfSyncMigrationsModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/PasswordEnableModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/index.tsx (+1 -1)
📝 packages/desktop-client/src/components/sidebar/BudgetName.tsx (+1 -1)
📝 packages/loot-core/src/client/budgets/budgetsSlice.ts (+29 -5)
📝 packages/loot-core/src/client/shared-listeners.ts (+2 -2)
📝 packages/loot-core/src/client/users/usersSlice.ts (+2 -2)
📝 packages/loot-core/src/server/main.ts (+29 -0)
📝 packages/loot-core/src/types/server-handlers.d.ts (+5 -0)

...and 6 more files

📄 Description

Based on user feedback, added this variable ACTUAL_OPENID_AUTO_REDIRECT, so when a user tries to open actual and openid is enable, the user gets redirected to the openid login.

I needed to introduce a logout flow for the openid provider. When you logout from actual, it will try to logout from the openid provider. I guess we need to test on multiple providers to ensure that its working properly.
I may add another variable enable/disable provider logout when logging out from actual

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4399 **Author:** [@lelemm](https://github.com/lelemm) **Created:** 2/18/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `enhance/openid_01` --- ### 📝 Commits (10+) - [`4fc32f5`](https://github.com/actualbudget/actual/commit/4fc32f5ea63196f7e1c042056eeda49e7a58e45f) OpenID autologin - [`9f4f7ef`](https://github.com/actualbudget/actual/commit/9f4f7efad254987cbc7c8d676e4fe5e38be7bd90) Merge branch 'master' into enhance/openid_01 - [`4d1f8f6`](https://github.com/actualbudget/actual/commit/4d1f8f60ab51a2529f702c6c5f47e2549c26bca1) change variable name and location - [`d8cc6c4`](https://github.com/actualbudget/actual/commit/d8cc6c4eacdc4ff2b9b041a19197fb0518258c2c) updated md - [`3368fa7`](https://github.com/actualbudget/actual/commit/3368fa75a33fef9a80400421e7683c6b522fe455) Merge remote-tracking branch 'org/master' into enhance/openid_01 - [`919fc73`](https://github.com/actualbudget/actual/commit/919fc73c1e8355beaef1a489d24a6a253521c7b9) Merge branch 'master' into enhance/openid_01 - [`da341af`](https://github.com/actualbudget/actual/commit/da341afd3f6649e1687c01f22e986da43f37e46f) Merge branch 'master' into enhance/openid_01 - [`8552a0a`](https://github.com/actualbudget/actual/commit/8552a0afa5a7a63406c276d6633c1e0d5b298a94) linter - [`3fea350`](https://github.com/actualbudget/actual/commit/3fea350d1ced30480f30dd837e5509cd1f86c745) Merge branch 'master' into enhance/openid_01 - [`9c36d19`](https://github.com/actualbudget/actual/commit/9c36d19a80cca59081e0be5c563c025b830b0018) Merge remote-tracking branch 'org/master' into enhance/openid_01 ### 📊 Changes **26 files changed** (+250 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/App.tsx` (+5 -3) 📝 `packages/desktop-client/src/components/LoggedInUser.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/ServerContext.tsx` (+11 -0) 📝 `packages/desktop-client/src/components/admin/UserAccess/UserAccessRow.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/manager/ConfigServer.tsx` (+7 -2) 📝 `packages/desktop-client/src/components/manager/subscribe/Login.tsx` (+67 -17) 📝 `packages/desktop-client/src/components/manager/subscribe/common.tsx` (+4 -0) 📝 `packages/desktop-client/src/components/modals/EditAccess.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/EditUser.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/OpenIDEnableModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/OutOfSyncMigrationsModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/PasswordEnableModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/index.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/sidebar/BudgetName.tsx` (+1 -1) 📝 `packages/loot-core/src/client/budgets/budgetsSlice.ts` (+29 -5) 📝 `packages/loot-core/src/client/shared-listeners.ts` (+2 -2) 📝 `packages/loot-core/src/client/users/usersSlice.ts` (+2 -2) 📝 `packages/loot-core/src/server/main.ts` (+29 -0) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+5 -0) _...and 6 more files_ </details> ### 📄 Description Based on user feedback, added this variable `ACTUAL_OPENID_AUTO_REDIRECT`, so when a user tries to open actual and openid is enable, the user gets redirected to the openid login. I needed to introduce a logout flow for the openid provider. When you logout from actual, it will try to logout from the openid provider. I guess we need to test on multiple providers to ensure that its working properly. I may add another variable enable/disable provider logout when logging out from actual --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:11:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5360
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?