github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3400] [MERGED] Update splash background to match theming #4834

New Issue
Closed
opened 2026-02-28 21:01:57 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:01:57 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3400
Author: @jfdoming
Created: 9/8/2024
Status: ✅ Merged
Merged: 9/9/2024
Merged by: @jfdoming

Base: master ← Head: jfdoming/better-splash-screen-color

📝 Commits (2)

  • 59f19ae Update splash background to match theming
  • 42c40c7 Add release notes

📊 Changes

2 files changed (+87 additions, -81 deletions)

View changed files

📝 packages/desktop-client/public/site.webmanifest (+81 -81)
➕ upcoming-release-notes/3400.md (+6 -0)

📄 Description

I noticed that (at least on Android) the PWA looks weird when launching: the background is fully white, which makes it look like we didn't bother to theme the app. This PR updates the background color to match the theme, which I think is reasonable (e.g., my bank's app has a splash-screen background color that matches the icon). I think we could still do better (e.g., having a higher-resolution image—the current icon looks a little blurry in the screenshot below) but IMO this is an improvement.

Thoughts? If this is something we want to add, having someone test on iOS would be great (I don't have a device handy).

Recommend reviewing with whitespace diff off (my editor auto-formatted 😞).

Before After
image image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3400 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 9/8/2024 **Status:** ✅ Merged **Merged:** 9/9/2024 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/better-splash-screen-color` --- ### 📝 Commits (2) - [`59f19ae`](https://github.com/actualbudget/actual/commit/59f19ae608e47bbdc9ce2938671a40ab88f69cb8) Update splash background to match theming - [`42c40c7`](https://github.com/actualbudget/actual/commit/42c40c776d2dd48c9cb53fd7474fc3e956050e62) Add release notes ### 📊 Changes **2 files changed** (+87 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/public/site.webmanifest` (+81 -81) ➕ `upcoming-release-notes/3400.md` (+6 -0) </details> ### 📄 Description I noticed that (at least on Android) the PWA looks weird when launching: the background is fully white, which makes it look like we didn't bother to theme the app. This PR updates the background color to match the theme, which I think is reasonable (e.g., my bank's app has a splash-screen background color that matches the icon). I think we could still do better (e.g., having a higher-resolution image—the current icon looks a little blurry in the screenshot below) but IMO this is an improvement. Thoughts? If this is something we want to add, having someone test on iOS would be great (I don't have a device handy). Recommend reviewing with whitespace diff off (my editor auto-formatted 😞). | Before | After | |--------|--------| | ![image](https://github.com/user-attachments/assets/8f864d9b-9447-4932-a492-254f70d1bd53) | ![image](https://github.com/user-attachments/assets/4b41cba2-10ec-419c-a996-3901235d55e5) | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:01:57 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4834
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?