github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4194] [MERGED] Spending Report: Fix budget category filtering #5252

New Issue
Closed
opened 2026-02-28 21:09:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:09:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4194
Author: @CertifiKate
Created: 1/19/2025
Status: ✅ Merged
Merged: 1/22/2025
Merged by: @UnderKoen

Base: master ← Head: Fix-Spending-Report-Budget-Filters

📝 Commits (5)

  • 3056c7c Spending: Fix budget comparison filters
  • 623df2b Add release notes
  • ba76d95 Spending Report: Fix linting, remove unused filters from budget filter options
  • 8a1ce45 Merge branch 'master' into Fix-Spending-Report-Budget-Filters
  • 68851dc enhance: add possibility for join between zero budget and category

📊 Changes

3 files changed (+18 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts (+11 -1)
📝 packages/loot-core/src/server/aql/schema/index.ts (+1 -1)
➕ upcoming-release-notes/4194.md (+6 -0)

📄 Description

Fixes up the Spending Report category filters when comparing to the budget. Previously only worked for the category is filter. Now added support for other category filters (one of, not in, etc.)

Note that this does not fix the filters for contains, matches, or does not contain since they seem to create incompatible joins on the zero_budgets table so I'm simply filtering these options out for now.

Fixes #4044

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4194 **Author:** [@CertifiKate](https://github.com/CertifiKate) **Created:** 1/19/2025 **Status:** ✅ Merged **Merged:** 1/22/2025 **Merged by:** [@UnderKoen](https://github.com/UnderKoen) **Base:** `master` ← **Head:** `Fix-Spending-Report-Budget-Filters` --- ### 📝 Commits (5) - [`3056c7c`](https://github.com/actualbudget/actual/commit/3056c7c9653d7a51b3592bb07d7f59c09c90432c) Spending: Fix budget comparison filters - [`623df2b`](https://github.com/actualbudget/actual/commit/623df2b95fb8eb32f43907006fced1ba21bb8b60) Add release notes - [`ba76d95`](https://github.com/actualbudget/actual/commit/ba76d957c2a6a6d9d6800329a0d24deae60a14b4) Spending Report: Fix linting, remove unused filters from budget filter options - [`8a1ce45`](https://github.com/actualbudget/actual/commit/8a1ce45ae8087f67c3e60113ec612fee0ce080af) Merge branch 'master' into Fix-Spending-Report-Budget-Filters - [`68851dc`](https://github.com/actualbudget/actual/commit/68851dc61da0ce153fa787547cc59ba4f0f34ebb) enhance: add possibility for join between zero budget and category ### 📊 Changes **3 files changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts` (+11 -1) 📝 `packages/loot-core/src/server/aql/schema/index.ts` (+1 -1) ➕ `upcoming-release-notes/4194.md` (+6 -0) </details> ### 📄 Description Fixes up the Spending Report category filters when comparing to the budget. Previously only worked for the category *is* filter. Now added support for other category filters (one of, not in, etc.) Note that this does not fix the filters for `contains`, `matches`, or `does not contain` since they seem to create incompatible joins on the zero_budgets table so I'm simply filtering these options out for now. Fixes #4044 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:09:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5252
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?