github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4145] [MERGED] Fix top-level types of send function #5211

New Issue
Closed
opened 2026-02-28 21:08:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:08:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4145
Author: @jfdoming
Created: 1/14/2025
Status: ✅ Merged
Merged: 2/19/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/fix-send-types

📝 Commits (7)

  • d5ea716 Add release notes
  • c17b83e Fix types of send function
  • 84fd2b8 Fix send types in a number of places
  • 30c2e28 PR feedback
  • 3102013 Merge branch 'master' into jfdoming/fix-send-types
  • eda6f09 Merge branch 'master' into jfdoming/fix-send-types
  • 94b0a0f Merge branch 'master' into jfdoming/fix-send-types

📊 Changes

5 files changed (+42 additions, -36 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/EditAccess.tsx (+14 -17)
📝 packages/loot-core/src/platform/client/fetch/index.browser.ts (+4 -6)
📝 packages/loot-core/src/platform/client/fetch/index.d.ts (+15 -9)
📝 packages/loot-core/src/platform/client/fetch/index.web.ts (+3 -4)
➕ upcoming-release-notes/4145.md (+6 -0)

📄 Description

In the course of fixing a bug in https://github.com/actualbudget/actual/pull/4112 I noticed that the send function always had a return type of any. Turns out the function was typed incorrectly and this wasn't caught due to having disabled checks of .d.ts files. I'll open a separate PR to test turning on that flag, but using this PR so I can iterate on how CI responds to having proper types for send.

Depends on https://github.com/actualbudget/actual/pull/4146 and https://github.com/actualbudget/actual/pull/4147

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4145 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 1/14/2025 **Status:** ✅ Merged **Merged:** 2/19/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/fix-send-types` --- ### 📝 Commits (7) - [`d5ea716`](https://github.com/actualbudget/actual/commit/d5ea716ba737d3525234ef6476bf9a8c448f21eb) Add release notes - [`c17b83e`](https://github.com/actualbudget/actual/commit/c17b83e94e1030e141f119bdf84093f9802288ab) Fix types of `send` function - [`84fd2b8`](https://github.com/actualbudget/actual/commit/84fd2b8f34b3c123a048f72a6ef1d592901e4e9a) Fix `send` types in a number of places - [`30c2e28`](https://github.com/actualbudget/actual/commit/30c2e28b2f68949c55f0b08ca6548db02b61cf9a) PR feedback - [`3102013`](https://github.com/actualbudget/actual/commit/31020139fcde044d2833f0971c605313f96d900c) Merge branch 'master' into jfdoming/fix-send-types - [`eda6f09`](https://github.com/actualbudget/actual/commit/eda6f090878f0ff3ccefc1e574608e06dba38662) Merge branch 'master' into jfdoming/fix-send-types - [`94b0a0f`](https://github.com/actualbudget/actual/commit/94b0a0ff523aaeba0747f64387f4dacaf1fe4a64) Merge branch 'master' into jfdoming/fix-send-types ### 📊 Changes **5 files changed** (+42 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/EditAccess.tsx` (+14 -17) 📝 `packages/loot-core/src/platform/client/fetch/index.browser.ts` (+4 -6) 📝 `packages/loot-core/src/platform/client/fetch/index.d.ts` (+15 -9) 📝 `packages/loot-core/src/platform/client/fetch/index.web.ts` (+3 -4) ➕ `upcoming-release-notes/4145.md` (+6 -0) </details> ### 📄 Description In the course of fixing a bug in https://github.com/actualbudget/actual/pull/4112 I noticed that the `send` function always had a return type of `any`. Turns out the function was typed incorrectly and this wasn't caught due to having disabled checks of `.d.ts` files. I'll open a separate PR to test turning on that flag, but using this PR so I can iterate on how CI responds to having proper types for `send`. Depends on https://github.com/actualbudget/actual/pull/4146 and https://github.com/actualbudget/actual/pull/4147 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:08:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5211
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?