github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3095] [MERGED] Support type-checking on spreadsheet fields (part 2) #4675

New Issue
Closed
opened 2026-02-28 20:59:29 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:59:29 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3095
Author: @jfdoming
Created: 7/18/2024
Status: ✅ Merged
Merged: 8/7/2024
Merged by: @jfdoming

Base: master ← Head: jfdoming/strict-binding-types-part-2

📝 Commits (6)

  • 923f647 Add rollover budget typing
  • 173d1ac Fix lint
  • 5913200 Add release notes
  • 68c91b9 Fix strict typechecking
  • fec4687 Merge branch 'master' into jfdoming/strict-binding-types-part-2
  • 50efacc Merge branch 'master' into jfdoming/strict-binding-types-part-2

📊 Changes

15 files changed (+147 additions, -58 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/rollover/BalanceMenu.tsx (+6 -3)
📝 packages/desktop-client/src/components/budget/rollover/BalanceMovementMenu.tsx (+4 -3)
📝 packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx (+41 -12)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx (+8 -3)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx (+12 -5)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetMenu.tsx (+3 -3)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/TotalsList.tsx (+7 -7)
📝 packages/desktop-client/src/components/modals/HoldBufferModal.tsx (+2 -2)
📝 packages/desktop-client/src/components/modals/RolloverBudgetMenuModal.tsx (+4 -2)
📝 packages/desktop-client/src/components/modals/RolloverBudgetSummaryModal.tsx (+2 -2)
📝 packages/desktop-client/src/components/spreadsheet/CellValue.tsx (+8 -4)
📝 packages/desktop-client/src/components/spreadsheet/index.ts (+26 -1)
📝 packages/desktop-client/src/components/table.tsx (+1 -1)
📝 packages/loot-core/src/client/queries.ts (+17 -10)
➕ upcoming-release-notes/3095.md (+6 -0)

📄 Description

Please see this link to view the diff of this PR excluding part 1.

This PR (along with the previous and subsequent ones, see PRs for parts 1 and 3) adds stricter types to the "spreadsheet" utilities used in the app. See part 1 for more context. This PR adds types for the rollover-budget spreadsheet.

Please see this link for a collapsed version of all the PRs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3095 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 7/18/2024 **Status:** ✅ Merged **Merged:** 8/7/2024 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/strict-binding-types-part-2` --- ### 📝 Commits (6) - [`923f647`](https://github.com/actualbudget/actual/commit/923f647c52686fa40af29bc4c4dff22137db9fb5) Add rollover budget typing - [`173d1ac`](https://github.com/actualbudget/actual/commit/173d1ac151d911cb0e4d5c7367978107f8cec64b) Fix lint - [`5913200`](https://github.com/actualbudget/actual/commit/591320023cdf1934fa08fb66cc0da354a5348f0e) Add release notes - [`68c91b9`](https://github.com/actualbudget/actual/commit/68c91b9456fac7bf3a364bc8b599a39329dd1d45) Fix strict typechecking - [`fec4687`](https://github.com/actualbudget/actual/commit/fec468752976671169593b76ab1b742d5d84b887) Merge branch 'master' into jfdoming/strict-binding-types-part-2 - [`50efacc`](https://github.com/actualbudget/actual/commit/50efacc352fb86255cec5c7d777a51544ebeae1d) Merge branch 'master' into jfdoming/strict-binding-types-part-2 ### 📊 Changes **15 files changed** (+147 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/rollover/BalanceMenu.tsx` (+6 -3) 📝 `packages/desktop-client/src/components/budget/rollover/BalanceMovementMenu.tsx` (+4 -3) 📝 `packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx` (+41 -12) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx` (+8 -3) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx` (+12 -5) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetMenu.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/TotalsList.tsx` (+7 -7) 📝 `packages/desktop-client/src/components/modals/HoldBufferModal.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/modals/RolloverBudgetMenuModal.tsx` (+4 -2) 📝 `packages/desktop-client/src/components/modals/RolloverBudgetSummaryModal.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/spreadsheet/CellValue.tsx` (+8 -4) 📝 `packages/desktop-client/src/components/spreadsheet/index.ts` (+26 -1) 📝 `packages/desktop-client/src/components/table.tsx` (+1 -1) 📝 `packages/loot-core/src/client/queries.ts` (+17 -10) ➕ `upcoming-release-notes/3095.md` (+6 -0) </details> ### 📄 Description ### Please see [this link](https://github.com/jfdoming/actual/compare/jfdoming/strict-binding-types-part-1...jfdoming:actual:jfdoming/strict-binding-types-part-2) to view the diff of this PR excluding part 1. This PR (along with the previous and subsequent ones, see PRs for parts [1](https://github.com/actualbudget/actual/pull/3093) and [3](https://github.com/actualbudget/actual/pull/3097)) adds stricter types to the "spreadsheet" utilities used in the app. See [part 1](https://github.com/actualbudget/actual/pull/3093) for more context. This PR adds types for the `rollover-budget` spreadsheet. Please see [this link](https://github.com/actualbudget/actual/compare/master...jfdoming:actual:jfdoming/strict-binding-types-demo) for a collapsed version of all the PRs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:59:29 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?