github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3708] [CLOSED] Migrate Account component to a functional component and use the new useTransactions hook #5014

New Issue
Closed
opened 2026-02-28 21:04:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:04:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3708
Author: @joel-jeremy
Created: 10/21/2024
Status: ❌ Closed

Base: master ← Head: accounts-function-component

📝 Commits (10+)

  • fbc2ccd useTransactions hook to load transactions
  • a7b90a0 Fx flaky test
  • b9a43b9 Fix tests
  • 60dac66 Apply coderabbit suggestions
  • b9c167d Update useTransactions
  • 89059bf Code rabbit suggestions
  • a7f6553 Coderabbit feedback + make useSchedules consistent with query pattern used in useTransactions
  • 0726760 Code review feedback and improve schedules loading
  • df61e42 Initial commit
  • ccff841 Fix preview transactions

📊 Changes

40 files changed (+2040 additions, -2074 deletions)

View changed files

📝 packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-7-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-8-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-9-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/accounts/Account.tsx (+1310 -1580)
📝 packages/desktop-client/src/components/accounts/Balance.tsx (+70 -56)
📝 packages/desktop-client/src/components/accounts/Header.tsx (+81 -67)
📝 packages/desktop-client/src/components/accounts/Reconcile.tsx (+6 -5)
📝 packages/desktop-client/src/components/filters/AppliedFilters.tsx (+8 -6)
📝 packages/desktop-client/src/components/filters/ConditionsOpMenu.tsx (+3 -3)
📝 packages/desktop-client/src/components/filters/FilterMenu.tsx (+18 -10)
📝 packages/desktop-client/src/components/filters/FiltersStack.tsx (+26 -22)
📝 packages/desktop-client/src/components/filters/SavedFilterMenuButton.tsx (+58 -62)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx (+8 -6)
📝 packages/desktop-client/src/components/reports/Header.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/reports/Calendar.tsx (+122 -135)
📝 packages/desktop-client/src/components/reports/spreadsheets/cash-flow-spreadsheet.tsx (+2 -2)
📝 packages/desktop-client/src/components/reports/spreadsheets/net-worth-spreadsheet.ts (+1 -1)
📝 packages/desktop-client/src/components/reports/spreadsheets/summary-spreadsheet.ts (+1 -1)
📝 packages/desktop-client/src/components/rules/Value.tsx (+2 -0)
📝 packages/desktop-client/src/components/schedules/ScheduleLink.tsx (+16 -15)

...and 20 more files

📄 Description

Follow up to https://github.com/actualbudget/actual/pull/3685 to simplify fetching transactions throughout the codebase.

This PR is migrating the desktop Account component/page to a functional component so that it can use the new useTransactions hook from https://github.com/actualbudget/actual/pull/3685

This is a major rewrite of the component so I would like to get 2-3 approvals for this before merging

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3708 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 10/21/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `accounts-function-component` --- ### 📝 Commits (10+) - [`fbc2ccd`](https://github.com/actualbudget/actual/commit/fbc2ccd2e73d54f5a0808683a59e0a2f3799cf13) useTransactions hook to load transactions - [`a7b90a0`](https://github.com/actualbudget/actual/commit/a7b90a0945f03e7c5c1b63ed050ebe3e5d8cd54f) Fx flaky test - [`b9a43b9`](https://github.com/actualbudget/actual/commit/b9a43b992a0ac37823b00afbf24f77b9da338d20) Fix tests - [`60dac66`](https://github.com/actualbudget/actual/commit/60dac668988eed763677e8ed08f2e37a444f80f4) Apply coderabbit suggestions - [`b9c167d`](https://github.com/actualbudget/actual/commit/b9c167d5d688db715c677d60d2ee9cc5c5e1ce3e) Update useTransactions - [`89059bf`](https://github.com/actualbudget/actual/commit/89059bf5dab1d66a3c1ba7de1e10436bb2924027) Code rabbit suggestions - [`a7f6553`](https://github.com/actualbudget/actual/commit/a7f65532fb4aeab8d2b0f23d739db68830b09417) Coderabbit feedback + make useSchedules consistent with query pattern used in useTransactions - [`0726760`](https://github.com/actualbudget/actual/commit/072676008478dc941230eb9d30a7fff6ee4777f6) Code review feedback and improve schedules loading - [`df61e42`](https://github.com/actualbudget/actual/commit/df61e42fda50ae08d75962ce251bd7baf85c286b) Initial commit - [`ccff841`](https://github.com/actualbudget/actual/commit/ccff8412d35802d566f633c89385cc9f45c855c3) Fix preview transactions ### 📊 Changes **40 files changed** (+2040 additions, -2074 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-7-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-8-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-9-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+1310 -1580) 📝 `packages/desktop-client/src/components/accounts/Balance.tsx` (+70 -56) 📝 `packages/desktop-client/src/components/accounts/Header.tsx` (+81 -67) 📝 `packages/desktop-client/src/components/accounts/Reconcile.tsx` (+6 -5) 📝 `packages/desktop-client/src/components/filters/AppliedFilters.tsx` (+8 -6) 📝 `packages/desktop-client/src/components/filters/ConditionsOpMenu.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/filters/FilterMenu.tsx` (+18 -10) 📝 `packages/desktop-client/src/components/filters/FiltersStack.tsx` (+26 -22) 📝 `packages/desktop-client/src/components/filters/SavedFilterMenuButton.tsx` (+58 -62) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx` (+8 -6) 📝 `packages/desktop-client/src/components/reports/Header.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/reports/Calendar.tsx` (+122 -135) 📝 `packages/desktop-client/src/components/reports/spreadsheets/cash-flow-spreadsheet.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/reports/spreadsheets/net-worth-spreadsheet.ts` (+1 -1) 📝 `packages/desktop-client/src/components/reports/spreadsheets/summary-spreadsheet.ts` (+1 -1) 📝 `packages/desktop-client/src/components/rules/Value.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/schedules/ScheduleLink.tsx` (+16 -15) _...and 20 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Follow up to https://github.com/actualbudget/actual/pull/3685 to simplify fetching transactions throughout the codebase. This PR is migrating the desktop `Account` component/page to a functional component so that it can use the new `useTransactions` hook from https://github.com/actualbudget/actual/pull/3685 This is a major rewrite of the component so I would like to get 2-3 approvals for this before merging --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:04:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5014
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?