[PR #3882] [MERGED] 🐛 Fix performance when navigating between budget/accounts #5109

Closed
opened 2026-02-28 21:06:08 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3882
Author: @MikesGlitch
Created: 11/23/2024
Status: Merged
Merged: 11/24/2024
Merged by: @MikesGlitch

Base: masterHead: perf/fix-slow-navigation-accounts-budget


📝 Commits (5)

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/spreadsheet/useSheetValue.ts (+1 -1)
upcoming-release-notes/3882.md (+6 -0)

📄 Description

https://github.com/actualbudget/actual/issues/3881

This is a bit heavy handed but it works - open to other ideas. We must be passing in a new object ref with the same contents for query, so even if it's the same data it thought it was different.

This is the only solution I can think of that doesn't involve lots of refactoring


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3882 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 11/23/2024 **Status:** ✅ Merged **Merged:** 11/24/2024 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `perf/fix-slow-navigation-accounts-budget` --- ### 📝 Commits (5) - [`4353b75`](https://github.com/actualbudget/actual/commit/4353b75ea136ac46fc7ff72ac5311b2fe80c38d5) memo the bindingobj - [`f3f51dc`](https://github.com/actualbudget/actual/commit/f3f51dccf42504772e6fb106b1bd096b0582980c) release notes - [`aa59fc9`](https://github.com/actualbudget/actual/commit/aa59fc9b88f1e3ec0de001ab1f080fbe049cde7a) fix - [`53fd326`](https://github.com/actualbudget/actual/commit/53fd326a6832b089445c6419f9a197f59fd48995) a bit heavy handed - [`bf7a266`](https://github.com/actualbudget/actual/commit/bf7a266a498573488f78b69ad31ab239ca95777f) lint ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/spreadsheet/useSheetValue.ts` (+1 -1) ➕ `upcoming-release-notes/3882.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> https://github.com/actualbudget/actual/issues/3881 This is a bit heavy handed but it works - open to other ideas. We must be passing in a new object ref with the same contents for query, so even if it's the same data it thought it was different. This is the only solution I can think of that doesn't involve lots of refactoring --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:06:08 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5109