[PR #3903] [MERGED] Consistent accounts terminology (For budget / Budgeted --> On budget) #5118

Closed
opened 2026-02-28 21:06:18 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3903
Author: @joel-jeremy
Created: 11/26/2024
Status: Merged
Merged: 12/10/2024
Merged by: @joel-jeremy

Base: masterHead: consistent-on-budget-accounts-terminology


📝 Commits (10+)

📊 Changes

168 files changed (+79 additions, -69 deletions)

View changed files

📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js (+3 -3)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Envelope-checks-that-clicking--321fd-ed-amount-opens-the-budget-summary-menu-modal-2-chromium-linux.png (+0 -0)

...and 80 more files

📄 Description

Accounts that are on budget are either referred to as For budget / Budgeted in the UI and the codebase. This PR aims to just refer to these accounts as on-budget for consistency.

Changes are also reflected in docs https://github.com/actualbudget/docs/pull/504


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3903 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 12/10/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `consistent-on-budget-accounts-terminology` --- ### 📝 Commits (10+) - [`9947cc0`](https://github.com/actualbudget/actual/commit/9947cc0e09a0c2f84044b9e087138d295bf6e42f) Change for budget and budgeted terms to on-budget - [`f47ca51`](https://github.com/actualbudget/actual/commit/f47ca51e0705597335d0f7e26f882bc04ecc219e) Release notes - [`d332cb4`](https://github.com/actualbudget/actual/commit/d332cb4d7e8c85f6ee33d369732b6ffd3e4e9ae7) Update mobile account header - [`ff8e6de`](https://github.com/actualbudget/actual/commit/ff8e6de2123d4c024a01412dcd3afe9258bd3897) Fix release notes - [`8ac00f9`](https://github.com/actualbudget/actual/commit/8ac00f93f8b9c2629f278a22af6987dd6e2305d7) Fix release note category - [`8b24e13`](https://github.com/actualbudget/actual/commit/8b24e1379dc037ab76d8a49d6b4495cb003c8e02) Update VRT - [`1d08477`](https://github.com/actualbudget/actual/commit/1d08477c13caea577c1a5b74e33ea3aec05db6ca) Rename variables - [`efe98eb`](https://github.com/actualbudget/actual/commit/efe98eb4386a68eb82194c8a335439aef4fa83d1) Remove hyphens - [`b7cc573`](https://github.com/actualbudget/actual/commit/b7cc573db1b912da22b10f7a845aab4051770118) Show off budget - [`991ab02`](https://github.com/actualbudget/actual/commit/991ab029449ed561ef5489537d0abcb565d2e586) Update VRT ### 📊 Changes **168 files changed** (+79 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.mobile.test.js-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js` (+3 -3) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.js-snapshots/Mobile-Budget-Envelope-checks-that-clicking--321fd-ed-amount-opens-the-budget-summary-menu-modal-2-chromium-linux.png` (+0 -0) _...and 80 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Accounts that are on budget are either referred to as `For budget` / `Budgeted` in the UI and the codebase. This PR aims to just refer to these accounts as `on-budget` for consistency. Changes are also reflected in docs https://github.com/actualbudget/docs/pull/504 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:06:18 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5118