github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2945] [CLOSED] [WIP] Openid #4605

New Issue
Closed
opened 2026-02-28 20:58:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:58:22 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2945
Author: @lelemm
Created: 6/26/2024
Status: ❌ Closed

Base: master ← Head: openid

📝 Commits (10+)

  • e3a1cd6 OpenId implementation
  • cb75f63 Fix bootstrap (doesn't include OpenID yet)
  • 03acb3b Add frontend for OpenID bootstrap
  • 2e13fed Address code review
  • 28c323e Fix typecheck and add release notes
  • e3ed86a Merge branch 'master' into openid
  • 8696956 Changing the autocomplete search to accept text without accents to match options with accents
  • 29bd12f lint fix
  • 0c35c91 Added upcoming-release-notes
  • 4fb4424 Release note authors should be a list.

📊 Changes

70 files changed (+4595 additions, -388 deletions)

View changed files

📝 packages/api/methods.ts (+4 -1)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/src/auth/AuthProvider.tsx (+45 -0)
➕ packages/desktop-client/src/auth/ProtectedRoute.tsx (+64 -0)
➕ packages/desktop-client/src/auth/types.ts (+3 -0)
📝 packages/desktop-client/src/components/App.tsx (+41 -1)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+30 -1)
📝 packages/desktop-client/src/components/LoggedInUser.tsx (+135 -34)
📝 packages/desktop-client/src/components/ManageRules.tsx (+1 -1)
📝 packages/desktop-client/src/components/Modals.tsx (+41 -0)
📝 packages/desktop-client/src/components/ServerContext.tsx (+73 -1)
➕ packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx (+345 -0)
➕ packages/desktop-client/src/components/admin/UserAccess/UserAccessHeader.tsx (+13 -0)
➕ packages/desktop-client/src/components/admin/UserAccess/UserAccessPage.tsx (+19 -0)
➕ packages/desktop-client/src/components/admin/UserAccess/UserAccessRow.tsx (+143 -0)
➕ packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx (+340 -0)
➕ packages/desktop-client/src/components/admin/UserDirectory/UserDirectoryHeader.tsx (+31 -0)
➕ packages/desktop-client/src/components/admin/UserDirectory/UserDirectoryPage.tsx (+46 -0)
➕ packages/desktop-client/src/components/admin/UserDirectory/UserDirectoryRow.tsx (+143 -0)

...and 50 more files

📄 Description

Following the PR #1164

Instruction on how to test this.

  • Clone actual server PR and this PR locally, at the server, in the packages.json, point the @actual/web to link to this PR clone (this is important because the pages will come from this package)
    This is how I do:
    image
    It's important to remember to BUILD the desktop-client package before starting the server.

  • I suggest to start testing this using a empty server instead of an server already configured.

  • Once you have actual server running, you can open the URL and start configuring it using this preview doc https://deploy-preview-447.www.actualbudget.org/docs/advanced/oauth-auth

  • I suggest start with configuring from bootstrap. Use passwordless.id for testing, probably the easiest way to test.

  • You can test the openid provider login now. But to test multiple users, you have to configure multiuser support

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2945 **Author:** [@lelemm](https://github.com/lelemm) **Created:** 6/26/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `openid` --- ### 📝 Commits (10+) - [`e3a1cd6`](https://github.com/actualbudget/actual/commit/e3a1cd63c439178fe84a5e7a6f8a44c2e1c8ad36) OpenId implementation - [`cb75f63`](https://github.com/actualbudget/actual/commit/cb75f63667aaa45906ec88b83f3d2cac68c031e8) Fix bootstrap (doesn't include OpenID yet) - [`03acb3b`](https://github.com/actualbudget/actual/commit/03acb3b8c5b812d7e0ae38de9c84c335f6cf337c) Add frontend for OpenID bootstrap - [`2e13fed`](https://github.com/actualbudget/actual/commit/2e13fede6accdb701a247a9b0597d91a199b8bf3) Address code review - [`28c323e`](https://github.com/actualbudget/actual/commit/28c323e4cf64cc6cb343996708b91a8f2e443656) Fix typecheck and add release notes - [`e3ed86a`](https://github.com/actualbudget/actual/commit/e3ed86a32dbbb92773fc9281f817156283dad4e8) Merge branch 'master' into openid - [`8696956`](https://github.com/actualbudget/actual/commit/8696956762eeb8efc3f4e5e2dae58bf35324755a) Changing the autocomplete search to accept text without accents to match options with accents - [`29bd12f`](https://github.com/actualbudget/actual/commit/29bd12f476d6ce9891c14bc931deaebb40523149) lint fix - [`0c35c91`](https://github.com/actualbudget/actual/commit/0c35c91d81f90f2ba3df532cd3a373558cc2ee53) Added upcoming-release-notes - [`4fb4424`](https://github.com/actualbudget/actual/commit/4fb44242b297387eca2f451ee85a076f377d5b82) Release note authors should be a list. ### 📊 Changes **70 files changed** (+4595 additions, -388 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/methods.ts` (+4 -1) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/src/auth/AuthProvider.tsx` (+45 -0) ➕ `packages/desktop-client/src/auth/ProtectedRoute.tsx` (+64 -0) ➕ `packages/desktop-client/src/auth/types.ts` (+3 -0) 📝 `packages/desktop-client/src/components/App.tsx` (+41 -1) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+30 -1) 📝 `packages/desktop-client/src/components/LoggedInUser.tsx` (+135 -34) 📝 `packages/desktop-client/src/components/ManageRules.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/Modals.tsx` (+41 -0) 📝 `packages/desktop-client/src/components/ServerContext.tsx` (+73 -1) ➕ `packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx` (+345 -0) ➕ `packages/desktop-client/src/components/admin/UserAccess/UserAccessHeader.tsx` (+13 -0) ➕ `packages/desktop-client/src/components/admin/UserAccess/UserAccessPage.tsx` (+19 -0) ➕ `packages/desktop-client/src/components/admin/UserAccess/UserAccessRow.tsx` (+143 -0) ➕ `packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx` (+340 -0) ➕ `packages/desktop-client/src/components/admin/UserDirectory/UserDirectoryHeader.tsx` (+31 -0) ➕ `packages/desktop-client/src/components/admin/UserDirectory/UserDirectoryPage.tsx` (+46 -0) ➕ `packages/desktop-client/src/components/admin/UserDirectory/UserDirectoryRow.tsx` (+143 -0) _...and 50 more files_ </details> ### 📄 Description Following the PR #1164 Instruction on how to test this. - Clone actual server PR and this PR locally, at the server, in the packages.json, point the @actual/web to link to this PR clone (this is important because the pages will come from this package) This is how I do: ![image](https://github.com/user-attachments/assets/0fc26e80-e4ba-45a9-8f55-8c9043342352) It's important to remember to BUILD the desktop-client package before starting the server. - I suggest to start testing this using a empty server instead of an server already configured. - Once you have actual server running, you can open the URL and start configuring it using this preview doc https://deploy-preview-447.www.actualbudget.org/docs/advanced/oauth-auth - I suggest start with [configuring from bootstrap](https://deploy-preview-447.www.actualbudget.org/docs/advanced/oauth-auth#configuration-from-bootstrap). Use passwordless.id for testing, probably the easiest way to test. - You can test the openid provider login now. But to test multiple users, you have to configure [multiuser support](https://deploy-preview-447.www.actualbudget.org/docs/advanced/multi-user) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:58:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4605
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?