github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4593] [MERGED] Add option to control note imports during transaction import #5471

New Issue
Closed
opened 2026-02-28 21:13:00 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:13:00 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4593
Author: @iaewing
Created: 3/10/2025
Status: ✅ Merged
Merged: 4/9/2025
Merged by: @youngcw

Base: master ← Head: Add-optional-note-import

📝 Commits (10+)

  • a8c9f15 Make note imports optional. Adds tests too
  • 1839cf4 add release notes
  • 486fe25 Update VRT
  • eb4e9f8 type getTransactions to resolve TS error
  • 6000286 remove CSV note import - already supported
  • 5fc0b26 type and lint to make coderabbit happy
  • f4f2384 conditional rendering of importNotes
  • 20c9950 Update VRT
  • 41aaff6 Merge branch 'master' into Add-optional-note-import
  • 1a6231d update snapshot to account for serialization change

📊 Changes

13 files changed (+472 additions, -16 deletions)

View changed files

📝 packages/api/methods.test.ts (+56 -0)
📝 packages/desktop-client/e2e/accounts.test.ts (+23 -0)
📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-import-csv-file-twice-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-import-csv-file-twice-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-import-csv-file-twice-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx (+44 -5)
📝 packages/loot-core/src/server/transactions/import/__snapshots__/parse-file.test.ts.snap (+265 -0)
📝 packages/loot-core/src/server/transactions/import/parse-file.test.ts (+58 -4)
📝 packages/loot-core/src/server/transactions/import/parse-file.ts (+20 -7)
➕ upcoming-release-notes/4593.md (+6 -0)

📄 Description

This PR adds the ability to control whether notes are imported during transaction imports. This gives users more control over their imported data by:

  1. Adding an importNotes option to the import configuration
  2. Supporting the option across all import types (OFX, QFX, QIF, CAMT)
  3. Persisting the user's preference per account/file type
  4. Adding comprehensive test coverage with snapshots

The feature allows users to choose whether they want notes included when importing transactions, which is particularly useful when notes contain unwanted or redundant information.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4593 **Author:** [@iaewing](https://github.com/iaewing) **Created:** 3/10/2025 **Status:** ✅ Merged **Merged:** 4/9/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `Add-optional-note-import` --- ### 📝 Commits (10+) - [`a8c9f15`](https://github.com/actualbudget/actual/commit/a8c9f1584669dbc249e0d2b680c10e9f5c8d7dfa) Make note imports optional. Adds tests too - [`1839cf4`](https://github.com/actualbudget/actual/commit/1839cf43ee4fb9216ce6fa3baaa9521066bed38f) add release notes - [`486fe25`](https://github.com/actualbudget/actual/commit/486fe2534d6c8b6e4f0620e6014ea99cc383a80f) Update VRT - [`eb4e9f8`](https://github.com/actualbudget/actual/commit/eb4e9f8f61b78a6d8d28258286944379f5804b50) type getTransactions to resolve TS error - [`6000286`](https://github.com/actualbudget/actual/commit/6000286a3df405dfab0cb03a14ce957915063b6e) remove CSV note import - already supported - [`5fc0b26`](https://github.com/actualbudget/actual/commit/5fc0b260493dc92e4181b107fcfc146adf2e8841) type and lint to make coderabbit happy - [`f4f2384`](https://github.com/actualbudget/actual/commit/f4f238406c2da9bb14396c781fc552741b69ca82) conditional rendering of importNotes - [`20c9950`](https://github.com/actualbudget/actual/commit/20c9950c92cf2535d304b505711f47359b301d80) Update VRT - [`41aaff6`](https://github.com/actualbudget/actual/commit/41aaff6db6f07180ee65d544c7062874a8cbbaab) Merge branch 'master' into Add-optional-note-import - [`1a6231d`](https://github.com/actualbudget/actual/commit/1a6231dd77e31c37eab6f426d6206b78c07082fd) update snapshot to account for serialization change ### 📊 Changes **13 files changed** (+472 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/methods.test.ts` (+56 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts` (+23 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-import-csv-file-twice-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-import-csv-file-twice-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-import-csv-file-twice-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx` (+44 -5) 📝 `packages/loot-core/src/server/transactions/import/__snapshots__/parse-file.test.ts.snap` (+265 -0) 📝 `packages/loot-core/src/server/transactions/import/parse-file.test.ts` (+58 -4) 📝 `packages/loot-core/src/server/transactions/import/parse-file.ts` (+20 -7) ➕ `upcoming-release-notes/4593.md` (+6 -0) </details> ### 📄 Description This PR adds the ability to control whether notes are imported during transaction imports. This gives users more control over their imported data by: 1. Adding an `importNotes` option to the import configuration 2. Supporting the option across all import types (OFX, QFX, QIF, CAMT) 3. Persisting the user's preference per account/file type 4. Adding comprehensive test coverage with snapshots The feature allows users to choose whether they want notes included when importing transactions, which is particularly useful when notes contain unwanted or redundant information. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:13:00 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5471
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?