github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4569] [MERGED] 🐳 @actual-app/web workspace in sync-server #5460

New Issue
Closed
opened 2026-02-28 21:12:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:12:50 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4569
Author: @MikesGlitch
Created: 3/7/2025
Status: ✅ Merged
Merged: 3/14/2025
Merged by: @MikesGlitch

Base: master ← Head: web-client-workspace-reference

📝 Commits (6)

📊 Changes

14 files changed (+292 additions, -176 deletions)

View changed files

📝 .github/workflows/docker-edge.yml (+7 -5)
📝 .github/workflows/docker-release.yml (+9 -2)
📝 package.json (+1 -0)
➕ packages/sync-server/docker/alpine.Dockerfile (+62 -0)
➖ packages/sync-server/docker/download-artifacts.sh (+0 -14)
➖ packages/sync-server/docker/edge-alpine.Dockerfile (+0 -37)
➖ packages/sync-server/docker/edge-ubuntu.Dockerfile (+0 -37)
➖ packages/sync-server/docker/stable-alpine.Dockerfile (+0 -27)
➖ packages/sync-server/docker/stable-ubuntu.Dockerfile (+0 -27)
➕ packages/sync-server/docker/ubuntu.Dockerfile (+63 -0)
📝 packages/sync-server/package.json (+1 -1)
📝 sync-server.Dockerfile (+50 -11)
➕ upcoming-release-notes/4569.md (+6 -0)
📝 yarn.lock (+93 -15)

📄 Description

Important

Users doing a local install will have to install all dependencies - this is because they need devDependencies to build the web project

Users running local installs will need to run this before starting their servers:

yarn build:server

I've updated the docs: https://github.com/actualbudget/docs/pull/661

I've tested all I can with this. There's one thing I could not test because I don't have a armv7 processor. Apparently they're quite old and I doubt anyone is using it so I don't think we'll be able to test it properly.

If you'd like to test the docker images you can get them here:

  • https://hub.docker.com/r/mclarkgb/test
  • Note that the sizes are smaller - it's partly because the old images were using the npm package AND copying in the edge build so it doubled up on the web client.

I've tested:

  • Ubuntu image
  • Alpine image
  • sync-server.Dockerfile

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4569 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 3/7/2025 **Status:** ✅ Merged **Merged:** 3/14/2025 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `web-client-workspace-reference` --- ### 📝 Commits (6) - [`bc9fadd`](https://github.com/actualbudget/actual/commit/bc9fadda464a5eb6605348574a9df582b8ef29d2) Workspace ref web client (#9) - [`1438fc5`](https://github.com/actualbudget/actual/commit/1438fc5c10e3ba75db6fb664391529b575bc8b21) updating release notes - [`cdc1ba6`](https://github.com/actualbudget/actual/commit/cdc1ba619217b15e7ccc61947fc717b08996360d) edge and stable are the same, consolidating them - [`0824cf4`](https://github.com/actualbudget/actual/commit/0824cf496c6a4047ce102ebbaf8f74c01d0c83da) rename dockerfiles - [`fbb6fe8`](https://github.com/actualbudget/actual/commit/fbb6fe8643f42e8d0ddf299ec4dfe3e3cf36d63e) Merge branch 'master' of https://github.com/MikesGlitch/actual into web-client-workspace-reference - [`b998ea5`](https://github.com/actualbudget/actual/commit/b998ea58d4d1c911517bce237de1de78b2754c69) merge ### 📊 Changes **14 files changed** (+292 additions, -176 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/docker-edge.yml` (+7 -5) 📝 `.github/workflows/docker-release.yml` (+9 -2) 📝 `package.json` (+1 -0) ➕ `packages/sync-server/docker/alpine.Dockerfile` (+62 -0) ➖ `packages/sync-server/docker/download-artifacts.sh` (+0 -14) ➖ `packages/sync-server/docker/edge-alpine.Dockerfile` (+0 -37) ➖ `packages/sync-server/docker/edge-ubuntu.Dockerfile` (+0 -37) ➖ `packages/sync-server/docker/stable-alpine.Dockerfile` (+0 -27) ➖ `packages/sync-server/docker/stable-ubuntu.Dockerfile` (+0 -27) ➕ `packages/sync-server/docker/ubuntu.Dockerfile` (+63 -0) 📝 `packages/sync-server/package.json` (+1 -1) 📝 `sync-server.Dockerfile` (+50 -11) ➕ `upcoming-release-notes/4569.md` (+6 -0) 📝 `yarn.lock` (+93 -15) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> > [!IMPORTANT] > Users doing a local install will have to install **all dependencies** - this is because they need devDependencies to build the web project Users running local installs will need to run this before starting their servers: ``` yarn build:server ``` **I've updated the docs**: https://github.com/actualbudget/docs/pull/661 I've tested all I can with this. There's one thing I could not test because I don't have a armv7 processor. Apparently they're quite old and I doubt anyone is using it so I don't think we'll be able to test it properly. If you'd like to test the docker images you can get them here: - https://hub.docker.com/r/mclarkgb/test - Note that the sizes are smaller - it's partly because the old images were using the npm package AND copying in the edge build so it doubled up on the web client. **I've tested:** - [x] Ubuntu image - [x] Alpine image - [x] sync-server.Dockerfile --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:12:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5460
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?