github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5229] [MERGED] ⚡ Speed up balance history graph #5834

New Issue
Closed
opened 2026-02-28 21:19:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:19:30 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5229
Author: @youngcw
Created: 6/23/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @youngcw

Base: master ← Head: youngcw/fast-graph

📝 Commits (8)

  • 5d44dc5 speedy
  • 6c26360 bunny, fill in missing data
  • 02455d0 small cleanup
  • 6e32642 Update packages/desktop-client/src/components/sidebar/BalanceHistoryGraph.tsx
  • d3a53a8 handle some edge cases, fix the month check
  • bf3fcbf better date formatting
  • 10d3f82 one more edge case
  • 9495950 fix

📊 Changes

2 files changed (+103 additions, -14 deletions)

View changed files

📝 packages/desktop-client/src/components/sidebar/BalanceHistoryGraph.tsx (+97 -14)
➕ upcoming-release-notes/5229.md (+6 -0)

📄 Description

For whatever reason, using the api call 'account-balance' is pretty slow. I pulled in the same aql used by the net worth graph and its faster now. Testing my budget the graph loads instantly where before it would take about 2 seconds for some accounts.

To test:

  1. upload a budget file with an account with many transactions
  2. hover the sidebar account name until the popover shows
  3. observer that its a lot faster than edge

Something else that Ive noticed is that the balance history graph is slowing down the account table loading. For some reason, if the balance history graph is triggered, the account table wont update until the graph has finished loading. This makes it seem like the account is frozen and isn't updating when moving between accounts or budget pages. So making the graph load instantly should fix this issue too

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5229 **Author:** [@youngcw](https://github.com/youngcw) **Created:** 6/23/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `youngcw/fast-graph` --- ### 📝 Commits (8) - [`5d44dc5`](https://github.com/actualbudget/actual/commit/5d44dc5e70c5e50e20f9b09574f54c2034c8785c) speedy - [`6c26360`](https://github.com/actualbudget/actual/commit/6c26360b197a3933ea0b6b24637c70911e78fea0) bunny, fill in missing data - [`02455d0`](https://github.com/actualbudget/actual/commit/02455d0140e94702cca69cc824aad32b2d62d786) small cleanup - [`6e32642`](https://github.com/actualbudget/actual/commit/6e326425868e2a2002ee924cfda92c5ead10c691) Update packages/desktop-client/src/components/sidebar/BalanceHistoryGraph.tsx - [`d3a53a8`](https://github.com/actualbudget/actual/commit/d3a53a812a79417429799ec2326b13541d5beb77) handle some edge cases, fix the month check - [`bf3fcbf`](https://github.com/actualbudget/actual/commit/bf3fcbf6567e96c1a9d6efe8784140c03a0427b8) better date formatting - [`10d3f82`](https://github.com/actualbudget/actual/commit/10d3f8296c002c5a401bf2c0b8cadc99c89eabb0) one more edge case - [`9495950`](https://github.com/actualbudget/actual/commit/9495950fa0224d7c564318ba577d2112bff8aa23) fix ### 📊 Changes **2 files changed** (+103 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/sidebar/BalanceHistoryGraph.tsx` (+97 -14) ➕ `upcoming-release-notes/5229.md` (+6 -0) </details> ### 📄 Description For whatever reason, using the api call 'account-balance' is pretty slow. I pulled in the same aql used by the net worth graph and its faster now. Testing my budget the graph loads instantly where before it would take about 2 seconds for some accounts. To test: 1. upload a budget file with an account with many transactions 2. hover the sidebar account name until the popover shows 3. observer that its a lot faster than edge Something else that Ive noticed is that the balance history graph is slowing down the account table loading. For some reason, if the balance history graph is triggered, the account table wont update until the graph has finished loading. This makes it seem like the account is frozen and isn't updating when moving between accounts or budget pages. So making the graph load instantly should fix this issue too --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:19:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5834
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?