github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5208] [MERGED] Move remaining .d.ts files to .ts #5821

New Issue
Closed
opened 2026-02-28 21:19:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:19:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5208
Author: @jfdoming
Created: 6/21/2025
Status: ✅ Merged
Merged: 7/3/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/move-d-ts-4

📝 Commits (6)

  • 80e11eb Update CRDT protobuf generation to create a .ts file
  • 33a9f01 Move remaining .d.ts files to .ts
  • b7cf5d5 Fix remaining type errors
  • 5e30cc9 Ignore .d.ts files so we don't accidentally use them in the future
  • 130d2dc Add release notes
  • 0073183 Merge branch 'master' into jfdoming/move-d-ts-4

📊 Changes

15 files changed (+121 additions, -80 deletions)

View changed files

📝 .gitignore (+3 -0)
📝 packages/crdt/bin/generate-proto (+5 -0)
📝 packages/crdt/package.json (+3 -1)
📝 packages/crdt/src/proto/sync_pb.js (+17 -17)
📝 packages/crdt/src/proto/sync_pb.ts (+6 -5)
➖ packages/desktop-client/globals.d.ts (+0 -19)
➕ packages/desktop-client/globals.ts (+16 -0)
📝 packages/desktop-electron/modules.ts (+0 -0)
📝 packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts (+1 -1)
➕ packages/loot-core/src/platform/server/asyncStorage/index-types.ts (+35 -0)
➖ packages/loot-core/src/platform/server/asyncStorage/index.d.ts (+0 -35)
📝 packages/loot-core/src/platform/server/asyncStorage/index.electron.ts (+1 -1)
📝 packages/loot-core/src/platform/server/asyncStorage/index.ts (+1 -1)
➕ upcoming-release-notes/5208.md (+6 -0)
📝 yarn.lock (+27 -0)

📄 Description

Last PR to complete the migration, follow-up to https://github.com/actualbudget/actual/pull/5204. The last change in this PR is to ratchet creation of .d.ts files—since there's not an easy way to add a test for it, I just ignored them instead and hopefully that will be enough of a deterrent.

Suggest reviewing by commit with whitespace changes off as the changes will make more sense that way.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5208 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 6/21/2025 **Status:** ✅ Merged **Merged:** 7/3/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/move-d-ts-4` --- ### 📝 Commits (6) - [`80e11eb`](https://github.com/actualbudget/actual/commit/80e11eb9b66c07097c37fe7032ed4c9077aa40f6) Update CRDT protobuf generation to create a .ts file - [`33a9f01`](https://github.com/actualbudget/actual/commit/33a9f01849dbc04569ba57fea4e60bdb6bdac6cc) Move remaining .d.ts files to .ts - [`b7cf5d5`](https://github.com/actualbudget/actual/commit/b7cf5d56115eaebaa80ec934a5ed3b42ef0bf38d) Fix remaining type errors - [`5e30cc9`](https://github.com/actualbudget/actual/commit/5e30cc9154b21bcb6e4fa97b67a4b28007665457) Ignore .d.ts files so we don't accidentally use them in the future - [`130d2dc`](https://github.com/actualbudget/actual/commit/130d2dcaa6559ab9dff894f6621cfaee09e81f59) Add release notes - [`0073183`](https://github.com/actualbudget/actual/commit/0073183c9215cab07ccd43bf9e8ec1207e078d4e) Merge branch 'master' into jfdoming/move-d-ts-4 ### 📊 Changes **15 files changed** (+121 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -0) 📝 `packages/crdt/bin/generate-proto` (+5 -0) 📝 `packages/crdt/package.json` (+3 -1) 📝 `packages/crdt/src/proto/sync_pb.js` (+17 -17) 📝 `packages/crdt/src/proto/sync_pb.ts` (+6 -5) ➖ `packages/desktop-client/globals.d.ts` (+0 -19) ➕ `packages/desktop-client/globals.ts` (+16 -0) 📝 `packages/desktop-electron/modules.ts` (+0 -0) 📝 `packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts` (+1 -1) ➕ `packages/loot-core/src/platform/server/asyncStorage/index-types.ts` (+35 -0) ➖ `packages/loot-core/src/platform/server/asyncStorage/index.d.ts` (+0 -35) 📝 `packages/loot-core/src/platform/server/asyncStorage/index.electron.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/asyncStorage/index.ts` (+1 -1) ➕ `upcoming-release-notes/5208.md` (+6 -0) 📝 `yarn.lock` (+27 -0) </details> ### 📄 Description Last PR to complete the migration, follow-up to https://github.com/actualbudget/actual/pull/5204. The last change in this PR is to ratchet creation of `.d.ts` files—since there's not an easy way to add a test for it, I just ignored them instead and hopefully that will be enough of a deterrent. Suggest [reviewing by commit](https://github.com/actualbudget/actual/pull/5208/commits/80e11eb9b66c07097c37fe7032ed4c9077aa40f6?diff=unified&w=1) with whitespace changes off as the changes will make more sense that way. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:19:15 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5821
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?