github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3499] [MERGED] test: csv import e2e tests #4889

New Issue
Closed
opened 2026-02-28 21:02:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:02:48 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3499
Author: @UnderKoen
Created: 9/24/2024
Status: ✅ Merged
Merged: 10/9/2024
Merged by: @matt-fidd

Base: master ← Head: fix/csv-import-3416

📝 Commits (10+)

  • d6db395 test: csv import e2e tests
  • f4805b2 chore: release note
  • 59fd177 chore: lint
  • 00de44d chore: remove .only
  • 979bc73 Merge remote-tracking branch 'origin/master' into fix/csv-import-3416
  • a1f2dc7 fix: csv import e2e tests
  • b79a1be chore: release note
  • f129b04 Merge branch 'master' into fix/csv-import-3416
  • 0e57b87 Merge branch 'master' into fix/csv-import-3416
  • d281696 Merge remote-tracking branch 'refs/remotes/origin/master' into fix/csv-import-3416

📊 Changes

16 files changed (+59 additions, -10 deletions)

View changed files

📝 packages/desktop-client/e2e/accounts.test.js (+40 -2)
➕ packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-6-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/data/test.csv (+9 -0)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/FieldMappings.jsx (+4 -8)
➕ upcoming-release-notes/3499.md (+6 -0)

📄 Description

Readds #3467
The problem that caused #3474 was something to do with css precedent

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3499 **Author:** [@UnderKoen](https://github.com/UnderKoen) **Created:** 9/24/2024 **Status:** ✅ Merged **Merged:** 10/9/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fix/csv-import-3416` --- ### 📝 Commits (10+) - [`d6db395`](https://github.com/actualbudget/actual/commit/d6db395f99c93f8c3e0feafaecbf151c7950add7) test: csv import e2e tests - [`f4805b2`](https://github.com/actualbudget/actual/commit/f4805b254d2184d697df1f77578cca4bd2d99b80) chore: release note - [`59fd177`](https://github.com/actualbudget/actual/commit/59fd17761ecf8da31acc3fff9318230f8d0f55cf) chore: lint - [`00de44d`](https://github.com/actualbudget/actual/commit/00de44dae1f03ea1667136dced18a416fb3cae87) chore: remove .only - [`979bc73`](https://github.com/actualbudget/actual/commit/979bc73776739ed9c2dd1e4aff719cb597210be3) Merge remote-tracking branch 'origin/master' into fix/csv-import-3416 - [`a1f2dc7`](https://github.com/actualbudget/actual/commit/a1f2dc732200324c068d0cf6a0d441f27cd04ce9) fix: csv import e2e tests - [`b79a1be`](https://github.com/actualbudget/actual/commit/b79a1be4701655f56bb05e66733e93e49eb8d0dc) chore: release note - [`f129b04`](https://github.com/actualbudget/actual/commit/f129b0449e0047413f86012fa73b1b428f6be476) Merge branch 'master' into fix/csv-import-3416 - [`0e57b87`](https://github.com/actualbudget/actual/commit/0e57b871355b4099fc70a5f6368761a52afdf01d) Merge branch 'master' into fix/csv-import-3416 - [`d281696`](https://github.com/actualbudget/actual/commit/d281696a5333c17a63320215d9749cd32d96e060) Merge remote-tracking branch 'refs/remotes/origin/master' into fix/csv-import-3416 ### 📊 Changes **16 files changed** (+59 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/accounts.test.js` (+40 -2) ➕ `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-6-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/data/test.csv` (+9 -0) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/FieldMappings.jsx` (+4 -8) ➕ `upcoming-release-notes/3499.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Readds #3467 The problem that caused #3474 was something to do with css precedent --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:02:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4889
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?