github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4255] [MERGED] fix: allow child transactions to have different transfer payees #5288

New Issue
Closed
opened 2026-02-28 21:09:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:09:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4255
Author: @jfdoming
Created: 1/29/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/fix-split-payee-bug

📝 Commits (2)

  • 1cbf4b7 fix: allow child transactions to have different transfer payees
  • e4e9c91 Add release notes

📊 Changes

5 files changed (+217 additions, -23 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/__snapshots__/transfer.test.ts.snap (+135 -0)
📝 packages/loot-core/src/server/accounts/rules.test.ts (+25 -0)
📝 packages/loot-core/src/server/accounts/transfer.test.ts (+51 -0)
📝 packages/loot-core/src/server/accounts/transfer.ts (+0 -23)
➕ upcoming-release-notes/4255.md (+6 -0)

📄 Description

Fix for an issue reported on Discord. The original issue involved rules with splits, but I found a much simpler repro:

  1. Create a transaction with a transfer payee but don't hit "Add."
  2. Set the category to "Split" and add a single child.
  3. Change the child payee to a different transfer account.
  4. Click "Add."
  5. Observe that the payee on the child in the added transaction is not set.

Looking for input from others with more context on the direction we're taking with payees on parent transactions, but I think this matches the approach we've taken in other places (child transactions are the source of truth, parents are generated based on the children).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4255 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 1/29/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/fix-split-payee-bug` --- ### 📝 Commits (2) - [`1cbf4b7`](https://github.com/actualbudget/actual/commit/1cbf4b7850fdc3bbbfa5f7be92b3772ac6d64413) fix: allow child transactions to have different transfer payees - [`e4e9c91`](https://github.com/actualbudget/actual/commit/e4e9c9180f98d3c5e9b0ede62200375e45e27f94) Add release notes ### 📊 Changes **5 files changed** (+217 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/__snapshots__/transfer.test.ts.snap` (+135 -0) 📝 `packages/loot-core/src/server/accounts/rules.test.ts` (+25 -0) 📝 `packages/loot-core/src/server/accounts/transfer.test.ts` (+51 -0) 📝 `packages/loot-core/src/server/accounts/transfer.ts` (+0 -23) ➕ `upcoming-release-notes/4255.md` (+6 -0) </details> ### 📄 Description Fix for an issue reported on Discord. The original issue involved rules with splits, but I found a much simpler repro: 1. Create a transaction with a transfer payee but don't hit "Add." 2. Set the category to "Split" and add a single child. 3. Change the child payee to a different transfer account. 4. Click "Add." 5. Observe that the payee on the child in the added transaction is not set. Looking for input from others with more context on the direction we're taking with payees on parent transactions, but I think this matches the approach we've taken in other places (child transactions are the source of truth, parents are generated based on the children). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:09:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5288
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?