github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4455] [CLOSED] Misc Cleanup #5392

New Issue
Closed
opened 2026-02-28 21:11:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:11:42 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4455
Author: @rugulous
Created: 2/26/2025
Status: ❌ Closed

Base: master ← Head: cleanup

📝 Commits (9)

  • 099a990 Allow data file index to be built on Windows too
  • 61950c6 Remove redundant upgradingAccountId check
  • cdece1c Remove duplicated upgradingId calculations
  • 9f5a594 Set token correctly when checking secret
  • 89aca30 Don't throw if response is any of the 2xx family
  • fe54177 Remove duplicated check for status === 500
  • 88c17d2 Add release notes
  • b9bb328 Fix linting issues
  • 06f35b1 Merge branch 'master' into cleanup

📊 Changes

7 files changed (+46 additions, -40 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/CreateAccountModal.tsx (+1 -5)
📝 packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx (+8 -10)
📝 packages/loot-core/bin/build-api (+1 -1)
📝 packages/loot-core/bin/build-browser (+1 -1)
📝 packages/loot-core/src/server/accounts/app.ts (+3 -1)
📝 packages/loot-core/src/server/post.ts (+26 -22)
➕ upcoming-release-notes/4455.md (+6 -0)

📄 Description

This PR addresses miscellaneous little nitpicks and fixes 2 bugs

  • The repo previously didn't run on Windows - although the rest of the bash scripts worked fine, the find command to build the index of data files was defaulting to find.exe instead of /usr/bin/find. This meant that it built and spun up, but then I was plagued by errors because the default file system wasn't being created properly!

  • secret-check always failed - the headers weren't being set correctly and so the token wasn't being passed. This PR fixes that issue, although I'm not sure it's actually used anywhere in the main codebase

The rest of the code is mostly just removing duplications and making things easier to read. There's one area of contention I can forsee though - I've updated throwIfNot200 to effectively function as throwIfNot2xx, but I wasn't sure if this is the behaviour that's desired or if we want to just use response.ok, or if it is correct to only be 200 codes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4455 **Author:** [@rugulous](https://github.com/rugulous) **Created:** 2/26/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cleanup` --- ### 📝 Commits (9) - [`099a990`](https://github.com/actualbudget/actual/commit/099a99033a42cb287a5664f8820fe9cf4351ea23) Allow data file index to be built on Windows too - [`61950c6`](https://github.com/actualbudget/actual/commit/61950c6e4a49bf7693920e0991fc23ffbca661dd) Remove redundant upgradingAccountId check - [`cdece1c`](https://github.com/actualbudget/actual/commit/cdece1cdbb8daf1738ab006357eb50a0521c5ef8) Remove duplicated upgradingId calculations - [`9f5a594`](https://github.com/actualbudget/actual/commit/9f5a594c610c0ba15435f6f1bf4121cf957b1773) Set token correctly when checking secret - [`89aca30`](https://github.com/actualbudget/actual/commit/89aca3055372789214d98746541b5d74afed0d76) Don't throw if response is any of the 2xx family - [`fe54177`](https://github.com/actualbudget/actual/commit/fe5417709b920b6aa49cca8fde91483354bfbc09) Remove duplicated check for status === 500 - [`88c17d2`](https://github.com/actualbudget/actual/commit/88c17d2eeed3d43a8e0b6640e15fa1c17c9ce364) Add release notes - [`b9bb328`](https://github.com/actualbudget/actual/commit/b9bb32836069386c454e61faa3dc99f24972593a) Fix linting issues - [`06f35b1`](https://github.com/actualbudget/actual/commit/06f35b11a4dc589a48f895e54bd6dd7cb891928d) Merge branch 'master' into cleanup ### 📊 Changes **7 files changed** (+46 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/CreateAccountModal.tsx` (+1 -5) 📝 `packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx` (+8 -10) 📝 `packages/loot-core/bin/build-api` (+1 -1) 📝 `packages/loot-core/bin/build-browser` (+1 -1) 📝 `packages/loot-core/src/server/accounts/app.ts` (+3 -1) 📝 `packages/loot-core/src/server/post.ts` (+26 -22) ➕ `upcoming-release-notes/4455.md` (+6 -0) </details> ### 📄 Description This PR addresses miscellaneous little nitpicks and fixes 2 bugs - **The repo previously didn't run on Windows** - although the rest of the bash scripts worked fine, the `find` command to build the index of data files was defaulting to `find.exe` instead of `/usr/bin/find`. This meant that it built and spun up, but then I was plagued by errors because the default file system wasn't being created properly! - **secret-check always failed** - the headers weren't being set correctly and so the token wasn't being passed. This PR fixes that issue, although I'm not sure it's actually used anywhere in the main codebase The rest of the code is mostly just removing duplications and making things easier to read. There's one area of contention I can forsee though - I've updated `throwIfNot200` to effectively function as `throwIfNot2xx`, but I wasn't sure if this is the behaviour that's desired or if we want to just use `response.ok`, or if it is correct to **only** be 200 codes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:11:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5392
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?