github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4385] [MERGED] Remove deprecated imports for several components #5355

New Issue
Closed
opened 2026-02-28 21:11:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:11:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4385
Author: @AlbertoCortina
Created: 2/15/2025
Status: ✅ Merged
Merged: 2/18/2025
Merged by: @MatissJanis

Base: master ← Head: remove-deprecated-imports

📝 Commits (10+)

  • bde4c3f ♻️ (imports) Update all View component imports to the component lib
  • b3a9aca ♻️ (imports) Update all Tooltip component imports to the component lib
  • ceced4f ♻️ (imports) Update all Toggle component imports to the component lib
  • e4a287e ♻️ (imports) Update all TextOneLine component imports to the component lib
  • 8f06e27 ♻️ (imports) Update all Text component imports to the component lib
  • 4f67cd9 ♻️ (imports) Update all Stack component imports to the component lib
  • 665a5c0 ♻️ (imports) Update all SpaceBetween component imports to the component lib
  • 0dc61f0 ♻️ (imports) Update all Popover component imports to the component lib
  • 5904da8 ♻️ (imports) Update all Menu and MenuItem component imports to the component lib
  • dc995b7 ♻️ (imports) Update all Label component imports to the component lib

📊 Changes

282 files changed (+1009 additions, -829 deletions)

View changed files

📝 packages/desktop-client/src/auth/ProtectedRoute.tsx (+2 -1)
📝 packages/desktop-client/src/components/AnimatedRefresh.tsx (+1 -2)
📝 packages/desktop-client/src/components/App.tsx (+4 -2)
📝 packages/desktop-client/src/components/BankSyncStatus.tsx (+5 -3)
📝 packages/desktop-client/src/components/DevelopmentTopBar.tsx (+2 -1)
📝 packages/desktop-client/src/components/EditablePageHeaderTitle.tsx (+4 -3)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+2 -1)
📝 packages/desktop-client/src/components/FixedSizeList.tsx (+1 -2)
📝 packages/desktop-client/src/components/HelpMenu.tsx (+4 -5)
📝 packages/desktop-client/src/components/LoggedInUser.tsx (+8 -6)
📝 packages/desktop-client/src/components/ManageRules.tsx (+5 -4)
📝 packages/desktop-client/src/components/Notes.tsx (+1 -1)
📝 packages/desktop-client/src/components/NotesButton.tsx (+5 -4)
📝 packages/desktop-client/src/components/Notifications.tsx (+6 -5)
📝 packages/desktop-client/src/components/Page.tsx (+5 -3)
📝 packages/desktop-client/src/components/PrivacyFilter.tsx (+1 -1)
📝 packages/desktop-client/src/components/ThemeSelector.tsx (+4 -3)
📝 packages/desktop-client/src/components/Titlebar.tsx (+6 -5)
📝 packages/desktop-client/src/components/UpdateNotification.tsx (+4 -3)
📝 packages/desktop-client/src/components/accounts/Account.tsx (+5 -4)

...and 80 more files

📄 Description

Hello,

I noticed that some imports were pointing to deprecated components, while the updated versions were available in the component library. I have updated the imports for the following components:

  • View
  • Tooltip
  • Toggle
  • TextOneLine
  • Text
  • Stack
  • SpaceBetween
  • Popover
  • Menu
  • MenuItem
  • Label
  • Paragraph
  • InlineField
  • InitialFocus
  • FormError
  • Card
  • Button
  • styles

Additionally, where possible, I removed the deprecated components after updating the imports.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4385 **Author:** [@AlbertoCortina](https://github.com/AlbertoCortina) **Created:** 2/15/2025 **Status:** ✅ Merged **Merged:** 2/18/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `remove-deprecated-imports` --- ### 📝 Commits (10+) - [`bde4c3f`](https://github.com/actualbudget/actual/commit/bde4c3f9a87c3119e0c4f9837d88d41d8e235655) ♻️ (imports) Update all View component imports to the component lib - [`b3a9aca`](https://github.com/actualbudget/actual/commit/b3a9aca92909791f008397aded8562cda2ba0573) ♻️ (imports) Update all Tooltip component imports to the component lib - [`ceced4f`](https://github.com/actualbudget/actual/commit/ceced4f19d42d48474edd0942c46579d518c00b1) ♻️ (imports) Update all Toggle component imports to the component lib - [`e4a287e`](https://github.com/actualbudget/actual/commit/e4a287e7d218221d646bc00482f5636e52ace075) ♻️ (imports) Update all TextOneLine component imports to the component lib - [`8f06e27`](https://github.com/actualbudget/actual/commit/8f06e275e5a41a90a66dc4790df81a659e7318a8) ♻️ (imports) Update all Text component imports to the component lib - [`4f67cd9`](https://github.com/actualbudget/actual/commit/4f67cd97669dc7aaa3be64d8b2f85ea2e34239cc) ♻️ (imports) Update all Stack component imports to the component lib - [`665a5c0`](https://github.com/actualbudget/actual/commit/665a5c0f2079f6746a5899e9222b0b95962a33f2) ♻️ (imports) Update all SpaceBetween component imports to the component lib - [`0dc61f0`](https://github.com/actualbudget/actual/commit/0dc61f0516128fb4117896020ed166ef1cc1c375) ♻️ (imports) Update all Popover component imports to the component lib - [`5904da8`](https://github.com/actualbudget/actual/commit/5904da894cf6ee52c6ad3f25a914f46e2d0d29de) ♻️ (imports) Update all Menu and MenuItem component imports to the component lib - [`dc995b7`](https://github.com/actualbudget/actual/commit/dc995b76bbf5270601b73a384bdee202b45b803b) ♻️ (imports) Update all Label component imports to the component lib ### 📊 Changes **282 files changed** (+1009 additions, -829 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/auth/ProtectedRoute.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/AnimatedRefresh.tsx` (+1 -2) 📝 `packages/desktop-client/src/components/App.tsx` (+4 -2) 📝 `packages/desktop-client/src/components/BankSyncStatus.tsx` (+5 -3) 📝 `packages/desktop-client/src/components/DevelopmentTopBar.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/EditablePageHeaderTitle.tsx` (+4 -3) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/FixedSizeList.tsx` (+1 -2) 📝 `packages/desktop-client/src/components/HelpMenu.tsx` (+4 -5) 📝 `packages/desktop-client/src/components/LoggedInUser.tsx` (+8 -6) 📝 `packages/desktop-client/src/components/ManageRules.tsx` (+5 -4) 📝 `packages/desktop-client/src/components/Notes.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/NotesButton.tsx` (+5 -4) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+6 -5) 📝 `packages/desktop-client/src/components/Page.tsx` (+5 -3) 📝 `packages/desktop-client/src/components/PrivacyFilter.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/ThemeSelector.tsx` (+4 -3) 📝 `packages/desktop-client/src/components/Titlebar.tsx` (+6 -5) 📝 `packages/desktop-client/src/components/UpdateNotification.tsx` (+4 -3) 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+5 -4) _...and 80 more files_ </details> ### 📄 Description Hello, I noticed that some imports were pointing to deprecated components, while the updated versions were available in the component library. I have updated the imports for the following components: - View - Tooltip - Toggle - TextOneLine - Text - Stack - SpaceBetween - Popover - Menu - MenuItem - Label - Paragraph - InlineField - InitialFocus - FormError - Card - Button - styles Additionally, where possible, I removed the deprecated components after updating the imports. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:11:07 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5355
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?