github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5202] [MERGED] Improve Boursobank Gocardless transaction parsing #5815

New Issue
Closed
opened 2026-02-28 21:19:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:19:08 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5202
Author: @Aerion
Created: 6/20/2025
Status: ✅ Merged
Merged: 6/20/2025
Merged by: @matt-fidd

Base: master ← Head: improve-gocardless-boursobank

📝 Commits (8)

  • 8f9576f Fix Boursobank transfer parsing
  • d834b3e Add credit note type for BoursoBank
  • 5e74fbf Improve Boursobank card transaction parsing
  • c076501 Improve Boursobank payee name backslashes handling
  • bc7e66f Set notes with date for Boursobank card transactions
  • 3201344 Add 5202 release note
  • 15f0aab [autofix.ci] apply automated fixes
  • be8e12a refactor loops and match

📊 Changes

3 files changed (+116 additions, -46 deletions)

View changed files

📝 packages/sync-server/src/app-gocardless/banks/boursobank_bousfrppxxx.js (+47 -36)
📝 packages/sync-server/src/app-gocardless/banks/tests/boursobank_bousfrppxxx.spec.js (+63 -10)
➕ upcoming-release-notes/5202.md (+6 -0)

📄 Description

This is a followup of https://github.com/actualbudget/actual/pull/4958, where the Boursobank Gocardless was introduced.

This PR addresses two comments made on the original PR:

  • The payee name for transfers wasn't read properly (caused by a non-deterministic order of the transaction details array)
  • Adding the date for card transactions in the notes

This PR also introduces enhanced transaction parsing:

  • Removing unwanted parts of the transaction name
  • Identifying a credit note / refund on the account

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5202 **Author:** [@Aerion](https://github.com/Aerion) **Created:** 6/20/2025 **Status:** ✅ Merged **Merged:** 6/20/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `improve-gocardless-boursobank` --- ### 📝 Commits (8) - [`8f9576f`](https://github.com/actualbudget/actual/commit/8f9576f24ecf1fd0dfb11a4052c6581fd4700680) Fix Boursobank transfer parsing - [`d834b3e`](https://github.com/actualbudget/actual/commit/d834b3e7c3b18479355ddfbae66f4527e7a659b2) Add credit note type for BoursoBank - [`5e74fbf`](https://github.com/actualbudget/actual/commit/5e74fbfa4a82be10b1b653824207daf74a7a0013) Improve Boursobank card transaction parsing - [`c076501`](https://github.com/actualbudget/actual/commit/c0765015640c6e78443e9902f70b4094e0f33bcd) Improve Boursobank payee name backslashes handling - [`bc7e66f`](https://github.com/actualbudget/actual/commit/bc7e66ffce91b100bcd3a06f43d5e7e2d445cea2) Set notes with date for Boursobank card transactions - [`3201344`](https://github.com/actualbudget/actual/commit/32013445018e63d133561dc299a1fd65d37ff807) Add 5202 release note - [`15f0aab`](https://github.com/actualbudget/actual/commit/15f0aabee7efc158348354db112d00417e09778c) [autofix.ci] apply automated fixes - [`be8e12a`](https://github.com/actualbudget/actual/commit/be8e12a698718475a290fa03cbb37bb1381b3983) refactor loops and match ### 📊 Changes **3 files changed** (+116 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `packages/sync-server/src/app-gocardless/banks/boursobank_bousfrppxxx.js` (+47 -36) 📝 `packages/sync-server/src/app-gocardless/banks/tests/boursobank_bousfrppxxx.spec.js` (+63 -10) ➕ `upcoming-release-notes/5202.md` (+6 -0) </details> ### 📄 Description This is a followup of https://github.com/actualbudget/actual/pull/4958, where the Boursobank Gocardless was introduced. This PR addresses two comments made on the original PR: - The payee name for transfers wasn't read properly (caused by a non-deterministic order of the transaction details array) - Adding the date for card transactions in the notes This PR also introduces enhanced transaction parsing: - Removing unwanted parts of the transaction name - Identifying a credit note / refund on the account --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:19:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5815
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?