github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5204] [MERGED] Move more .d.ts files to .ts #5817

New Issue
Closed
opened 2026-02-28 21:19:10 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:19:10 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5204
Author: @jfdoming
Created: 6/21/2025
Status: ✅ Merged
Merged: 6/21/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/move-d-ts-3

📝 Commits (4)

📊 Changes

26 files changed (+433 additions, -378 deletions)

View changed files

📝 packages/loot-core/package.json (+1 -0)
📝 packages/loot-core/src/platform/server/connection/__mocks__/index.ts (+1 -1)
📝 packages/loot-core/src/platform/server/connection/index-types.ts (+4 -4)
📝 packages/loot-core/src/platform/server/connection/index.api.ts (+1 -1)
📝 packages/loot-core/src/platform/server/connection/index.electron.ts (+1 -1)
📝 packages/loot-core/src/platform/server/connection/index.ts (+1 -1)
➖ packages/loot-core/src/platform/server/fs/index.d.ts (+0 -71)
📝 packages/loot-core/src/platform/server/fs/index.electron.ts (+3 -3)
➕ packages/loot-core/src/platform/server/fs/index.ts (+79 -0)
📝 packages/loot-core/src/platform/server/fs/index.web.test.ts (+1 -1)
📝 packages/loot-core/src/platform/server/fs/index.web.ts (+17 -5)
➖ packages/loot-core/src/platform/server/fs/path-join.d.ts (+0 -2)
➕ packages/loot-core/src/platform/server/fs/path-join.ts (+2 -0)
📝 packages/loot-core/src/platform/server/fs/shared.ts (+3 -1)
➖ packages/loot-core/src/platform/server/sqlite/index.d.ts (+0 -35)
➕ packages/loot-core/src/platform/server/sqlite/index.ts (+58 -0)
📝 packages/loot-core/src/platform/server/sqlite/index.web.ts (+5 -6)
➖ packages/loot-core/src/server/importers/ynab4-types.d.ts (+0 -165)
➕ packages/loot-core/src/server/importers/ynab4-types.ts (+163 -0)
📝 packages/loot-core/src/server/importers/ynab4.ts (+1 -1)

...and 6 more files

📄 Description

Part 3 of this migration, follow-up to https://github.com/actualbudget/actual/pull/5060.

Strongly suggest reviewing by commit and with whitespace diffs off because Git does weird things with moved files.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5204 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 6/21/2025 **Status:** ✅ Merged **Merged:** 6/21/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/move-d-ts-3` --- ### 📝 Commits (4) - [`8dbfaab`](https://github.com/actualbudget/actual/commit/8dbfaabd67ccb4f78b5531722fa4d338393b0747) Rename .d.ts files to .ts - [`2c57417`](https://github.com/actualbudget/actual/commit/2c574177fbb7e6392ffe3db2df91b73dac637671) Fix type and lint errors - [`3af621b`](https://github.com/actualbudget/actual/commit/3af621bc56590050ae18dab1f4458788aec211dd) Add release notes - [`c67e2d1`](https://github.com/actualbudget/actual/commit/c67e2d1bec7052179ba390ee5911af77ff92d021) CodeRabbit feedback ### 📊 Changes **26 files changed** (+433 additions, -378 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/package.json` (+1 -0) 📝 `packages/loot-core/src/platform/server/connection/__mocks__/index.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/connection/index-types.ts` (+4 -4) 📝 `packages/loot-core/src/platform/server/connection/index.api.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/connection/index.electron.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/connection/index.ts` (+1 -1) ➖ `packages/loot-core/src/platform/server/fs/index.d.ts` (+0 -71) 📝 `packages/loot-core/src/platform/server/fs/index.electron.ts` (+3 -3) ➕ `packages/loot-core/src/platform/server/fs/index.ts` (+79 -0) 📝 `packages/loot-core/src/platform/server/fs/index.web.test.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/fs/index.web.ts` (+17 -5) ➖ `packages/loot-core/src/platform/server/fs/path-join.d.ts` (+0 -2) ➕ `packages/loot-core/src/platform/server/fs/path-join.ts` (+2 -0) 📝 `packages/loot-core/src/platform/server/fs/shared.ts` (+3 -1) ➖ `packages/loot-core/src/platform/server/sqlite/index.d.ts` (+0 -35) ➕ `packages/loot-core/src/platform/server/sqlite/index.ts` (+58 -0) 📝 `packages/loot-core/src/platform/server/sqlite/index.web.ts` (+5 -6) ➖ `packages/loot-core/src/server/importers/ynab4-types.d.ts` (+0 -165) ➕ `packages/loot-core/src/server/importers/ynab4-types.ts` (+163 -0) 📝 `packages/loot-core/src/server/importers/ynab4.ts` (+1 -1) _...and 6 more files_ </details> ### 📄 Description Part 3 of this migration, follow-up to https://github.com/actualbudget/actual/pull/5060. Strongly suggest [reviewing by commit](https://github.com/actualbudget/actual/pull/5204/commits/b165ec89024928af220f9612c42e20e2a14a695c?diff=unified&w=1) and with whitespace diffs _off_ because Git does weird things with moved files. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:19:10 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5817
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?