github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4186] [MERGED] Fix various split transaction edits not working #5246

New Issue
Closed
opened 2026-02-28 21:08:58 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:08:58 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4186
Author: @jfdoming
Created: 1/18/2025
Status: ✅ Merged
Merged: 1/18/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/fix-distribute-splits

📝 Commits (2)

  • bc03b10 Fix various split transaction edits not working
  • ca5c2ed Add release notes

📊 Changes

2 files changed (+20 additions, -11 deletions)

View changed files

📝 packages/loot-core/src/shared/transactions.ts (+14 -11)
➕ upcoming-release-notes/4186.md (+6 -0)

📄 Description

Fixes a number of errors occurring on edge when updating split transactions. Sample repro: with an existing split, select the amount in one of the splits and hit backspace to see an error notification.

Our query engine doesn't support undefined for null values, only null; i.e., to omit a value, you either have to make it null or explicitly not pass it. To keep our types the same I opted for the latter.

To reviewer: this issue would have tripped the type checker if we enabled exactOptionalPropertyTypes in strict mode. I tried doing that though and we currently have 174 violations. How do you feel about this flag? Is it worth trying to fix the violations?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4186 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 1/18/2025 **Status:** ✅ Merged **Merged:** 1/18/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/fix-distribute-splits` --- ### 📝 Commits (2) - [`bc03b10`](https://github.com/actualbudget/actual/commit/bc03b10b9b1ac01a0383f4058e22d2688bd36ae3) Fix various split transaction edits not working - [`ca5c2ed`](https://github.com/actualbudget/actual/commit/ca5c2edb15b8841e86df80531bd7b3c20ad92776) Add release notes ### 📊 Changes **2 files changed** (+20 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/shared/transactions.ts` (+14 -11) ➕ `upcoming-release-notes/4186.md` (+6 -0) </details> ### 📄 Description Fixes a number of errors occurring on edge when updating split transactions. Sample repro: with an existing split, select the amount in one of the splits and hit backspace to see an error notification. Our query engine doesn't support `undefined` for null values, only `null`; i.e., to omit a value, you either have to make it `null` or explicitly not pass it. To keep our types the same I opted for the latter. To reviewer: this issue would have tripped the type checker if we enabled [`exactOptionalPropertyTypes`](https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes) in strict mode. I tried doing that though and we currently have 174 violations. How do you feel about this flag? Is it worth trying to fix the violations? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:08:59 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?